From nobody Sat Apr 20 11:46:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1573636860; cv=none; d=zoho.com; s=zohoarc; b=PkuZ5lCyyCRuo5Ne6d+hoEn06rXAdmyWzvO/SOKKCo1eqmCd2C6MMaBR92l+kX4AdY3CAZDpUya6MgbkOnvQG+1HEhjvz0COqWdC5Eo3mtXhtdQ2ZN62VddRjgqttxwDDLmKQB8VzLZMv/9IlDys+Keche0dOrA6kDOVF4uFwBU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1573636860; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=3pvjWV65p7QLO2nZo4Cy7x7NY19SoRlkUPSuHAuyl2U=; b=GDR56WxadQIPFIznafWr3jJplgXA2N57ZT7eD7mtb5fW5iAbfw6jGk4WCveU3x7zQNnL3HQsnbnhborLn9lH698hz+JICb665JMIafrKsTAugl/7YnbADusg7/DV/IJ3hju78GJxxyoWc2+EOfHiaN14r7X6pUyjQbXwFi5K7ec= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 157363686094374.60180117385357; Wed, 13 Nov 2019 01:21:00 -0800 (PST) Received: from localhost ([::1]:42372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUopb-0001az-24 for importer@patchew.org; Wed, 13 Nov 2019 04:20:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44232) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUoop-00013D-TF for qemu-devel@nongnu.org; Wed, 13 Nov 2019 04:20:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUook-0000H9-Mg for qemu-devel@nongnu.org; Wed, 13 Nov 2019 04:20:07 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:41262 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iUook-0000Fu-HH for qemu-devel@nongnu.org; Wed, 13 Nov 2019 04:20:02 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-382-7O3hu0o9MguO7BhMS6SfdA-1; Wed, 13 Nov 2019 04:18:31 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 41D801855564; Wed, 13 Nov 2019 09:18:30 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-69.ams2.redhat.com [10.36.116.69]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0F2BA4D9E1; Wed, 13 Nov 2019 09:18:27 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 5086116E08; Wed, 13 Nov 2019 10:18:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573636801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3pvjWV65p7QLO2nZo4Cy7x7NY19SoRlkUPSuHAuyl2U=; b=d3YvnyHjS1eI9+p7zATVAgCxA/L4A7RE6UiVbQn2iFVMFE/iIFhqQdpY9Th2YkFqGit4k6 p/NAqxuQ1AjZoztbZfGvZ2v0RCwCS0958JnXkreiMpKk/PUq9ER5BCB+g+Mu5KgHT0oujG N8QF/sdc8vzafEigQQ/5L+LpuzFIZ3Q= From: Gerd Hoffmann To: seabios@seabios.org Subject: [PATCH] ahci: zero-initialize port struct Date: Wed, 13 Nov 2019 10:18:09 +0100 Message-Id: <20191113091809.31365-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: 7O3hu0o9MguO7BhMS6SfdA-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-devel@nongnu.org, Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Specifically port->driver.lchs needs clearing, otherwise seabios will try interpret whatever random crap happens to be there as disk geometry, which may or may not break boot depending on how lucky you are. Signed-off-by: Gerd Hoffmann Reviewed-by: Laszlo Ersek --- src/hw/ahci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/hw/ahci.c b/src/hw/ahci.c index 97a072a1ca81..d45b4307ec68 100644 --- a/src/hw/ahci.c +++ b/src/hw/ahci.c @@ -345,6 +345,7 @@ ahci_port_alloc(struct ahci_ctrl_s *ctrl, u32 pnr) warn_noalloc(); return NULL; } + memset(port, 0, sizeof(*port)); port->pnr =3D pnr; port->ctrl =3D ctrl; port->list =3D memalign_tmp(1024, 1024); --=20 2.18.1