From nobody Tue Mar 10 18:23:21 2026 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) client-ip=78.46.105.101; envelope-from=seabios-bounces@seabios.org; helo=coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail(p=none dis=none) header.from=oracle.com ARC-Seal: i=1; a=rsa-sha256; t=1558196362; cv=none; d=zoho.com; s=zohoarc; b=i57+aQRdmKLT8+Q0H0NbPle5aZn2o9XVBgCKekPf9NPGGhXoEeVC3MqYMmPG2TXvbgJgilnAiSxvrnPRvvIhqfakjebr5eZrbLveS76bz8moR3EgPVYoSFUUSbpp2nEjBdYH2A84Wgv5WZLTfbD7Mmlt7ulSihzeHr3KC3GN8uk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558196362; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:To:ARC-Authentication-Results; bh=llZaZ7ieVojFCkFXLrJD90P41ssCiDo61doruIuaqfQ=; b=Kfv8oaiQSEYJIN3EhaLSAyUkdqX+qcTqgPywzU48morqDeBzfdBvinvrqkhqj3RaclwTMIG5etDO5tnxPHmez19k0Vh4Ir6O2dtaTQo6gt7Ck//DM+sQAjURV9DHEomkgucCbTXBOUWlIcMZ0kEQIpUl48tU8WL0TtZs4Kcujw0= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=none (zoho.com: 78.46.105.101 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from coreboot.org (coreboot.org [78.46.105.101]) by mx.zohomail.com with SMTPS id 1558196362791101.88880753557726; Sat, 18 May 2019 09:19:22 -0700 (PDT) Received: from [192.168.203.99] (mailu_mailman-core_1.mailu_default [192.168.203.99]) by coreboot.org (Postfix) with ESMTP id EF3C612E2E88; Sat, 18 May 2019 16:19:17 +0000 (UTC) Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by coreboot.org (Postfix) with ESMTP id 7CAC312E2E74 for ; Sat, 18 May 2019 16:19:10 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4IGIo7g106827; Sat, 18 May 2019 16:18:54 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 2sj9ft1ayk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 18 May 2019 16:18:54 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4IGGKg4020196; Sat, 18 May 2019 16:16:53 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 2sj75se7ne-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 18 May 2019 16:16:53 +0000 Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x4IGGqNU002122; Sat, 18 May 2019 16:16:52 GMT Received: from nexus.ravello.local (/213.57.127.2) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 18 May 2019 09:16:52 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=corp-2018-07-02; bh=rDYI2jnwAKL6HZCGdqNzK6t4Jdi9+lVDyXiC1TfJBzU=; b=Yhh6JGw2Ge1y04nw0vbFdJ1IGNcnd7qub4sHPpatkljiI9aAOo5T9caeWWmBeYGt6M9T 0GRmAUFEqfQrZapCZR8JnvdjBApXQDjFbDi5y4lRRUMOg4d8vzUyweNPi2/9rFI3BKPf bm5zQNvfI681EiIMQcyxKZ30Fa+mUP8hhW3QZeHcHNzNL08chi/mvC40Yl1/UTdTuybV XSdpHgRf9VDbd70DcjOx7Y/FPk9th7z5oSVilqRqoCDhokb8YkK5DfTZTI7jtOijNs3w lAtl7YBKe072g0eqfpL2HDMDvTfUGZIvPp0OSVQ0boz9Gj5XBSxd30LmhgTkSHNBQB6m Hw== From: Sam Eiderman To: seabios@seabios.org, kraxel@redhat.com, kevin@koconnor.net Date: Sat, 18 May 2019 19:15:37 +0300 Message-Id: <20190518161542.12662-2-shmuel.eiderman@oracle.com> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20190518161542.12662-1-shmuel.eiderman@oracle.com> References: <20190518161542.12662-1-shmuel.eiderman@oracle.com> X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9261 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905180117 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9261 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905180118 Message-ID-Hash: TZAOEBVLG5RQ3O3U2ROUCG5K7YHTLP6Z X-Message-ID-Hash: TZAOEBVLG5RQ3O3U2ROUCG5K7YHTLP6Z X-MailFrom: shmuel.eiderman@oracle.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: arbel.moshe@oracle.com, konrad.wilk@oracle.com X-Mailman-Version: 3.2.2 Precedence: list Subject: [SeaBIOS] [PATCH v2 1/6] bios_date: Make all dates in BIOS consistent List-Id: SeaBIOS mailing list Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ++++ X-Spam-Level: **** Authentication-Results: coreboot.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Liran Alon There are 2 places where SeaBIOS reports its release date: 1. SMBIOS Type 0 entry 2. Hard-coded address 0xFFFF5 Previous to this commit, each of these places defined it's own unique date which doesn't make sense. Therefore, define the BIOS date in a single place and make sure all relevant places in code use it. Reviewed-by: Konrad Rzeszutek Wilk Reviewed-by: Arbel Moshe Signed-off-by: Sam Eiderman Signed-off-by: Liran Alon --- src/config.h | 11 +++++++++++ src/fw/biostables.c | 1 - src/fw/smbios.c | 3 +-- src/misc.c | 2 +- 4 files changed, 13 insertions(+), 4 deletions(-) diff --git a/src/config.h b/src/config.h index 93c8dbc2..6795440c 100644 --- a/src/config.h +++ b/src/config.h @@ -29,6 +29,17 @@ #define BUILD_SUBMODEL_ID 0x00 #define BUILD_BIOS_REVISION 0x01 =20 +#define BIOS_DATE_MONTH "04" +#define BIOS_DATE_DAY "01" +#define BIOS_DATE_YEAR "14" +#define BIOS_DATE_YEAR_PREFIX "20" +#define BIOS_DATE (BIOS_DATE_MONTH "/" \ + BIOS_DATE_DAY "/" \ + BIOS_DATE_YEAR_PREFIX BIOS_DATE_YEAR) +#define BIOS_DATE_SHORT (BIOS_DATE_MONTH "/" \ + BIOS_DATE_DAY "/" \ + BIOS_DATE_YEAR) + // Various memory addresses used by the code. #define BUILD_STACK_ADDR 0x7000 #define BUILD_S3RESUME_STACK_ADDR 0x1000 diff --git a/src/fw/biostables.c b/src/fw/biostables.c index fe8626ef..b055c9b2 100644 --- a/src/fw/biostables.c +++ b/src/fw/biostables.c @@ -401,7 +401,6 @@ smbios_new_type_0(void *start, } =20 #define BIOS_NAME "SeaBIOS" -#define BIOS_DATE "04/01/2014" =20 static int smbios_romfile_setup(void) diff --git a/src/fw/smbios.c b/src/fw/smbios.c index 62a563b2..96104714 100644 --- a/src/fw/smbios.c +++ b/src/fw/smbios.c @@ -161,7 +161,6 @@ get_external(int type, char **p, unsigned *nr_structs, } while (0) =20 /* Type 0 -- BIOS Information */ -#define RELEASE_DATE_STR "01/01/2011" static void * smbios_init_type_0(void *start) { @@ -179,7 +178,7 @@ smbios_init_type_0(void *start) =20 p->bios_starting_address_segment =3D 0xe800; =20 - load_str_field_with_default(0, bios_release_date_str, RELEASE_DATE_STR= ); + load_str_field_with_default(0, bios_release_date_str, BIOS_DATE); =20 p->bios_rom_size =3D 0; /* FIXME */ =20 diff --git a/src/misc.c b/src/misc.c index b5117304..189d487b 100644 --- a/src/misc.c +++ b/src/misc.c @@ -174,7 +174,7 @@ struct descloc_s rombios32_gdt_48 VARFSEG =3D { ****************************************************************/ =20 // BIOS build date -char BiosDate[] VARFSEGFIXED(0xfff5) =3D "06/23/99"; +char BiosDate[] VARFSEGFIXED(0xfff5) =3D BIOS_DATE_SHORT; =20 u8 BiosModelId VARFSEGFIXED(0xfffe) =3D BUILD_MODEL_ID; =20 --=20 2.13.3 _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-leave@seabios.org