From nobody Wed Apr 24 06:46:14 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 80.81.252.135 is neither permitted nor denied by domain of seabios.org) client-ip=80.81.252.135; envelope-from=seabios-bounces@seabios.org; helo=mail.coreboot.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 80.81.252.135 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org Return-Path: Received: from mail.coreboot.org (mail.coreboot.org [80.81.252.135]) by mx.zohomail.com with SMTPS id 15304080738201021.4762873088533; Sat, 30 Jun 2018 18:21:13 -0700 (PDT) Received: from [127.0.0.1] (helo=ra.coreboot.org) by mail.coreboot.org with esmtp (Exim 4.86_2) (envelope-from ) id 1fZR5V-0006ab-0Y; Sun, 01 Jul 2018 03:23:37 +0200 Received: from ol.sdf.org ([205.166.94.20] helo=mx.sdf.org) by mail.coreboot.org with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_2) (envelope-from ) id 1fYWUT-00074G-EU for seabios@seabios.org; Thu, 28 Jun 2018 14:57:49 +0200 Received: from sdf.org (IDENT:coypu@otaku.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id w5SCsetS015422 (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits) verified NO) for ; Thu, 28 Jun 2018 12:54:40 GMT Received: (from coypu@localhost) by sdf.org (8.15.2/8.12.8/Submit) id w5SCseA3016077 for seabios@seabios.org; Thu, 28 Jun 2018 12:54:40 GMT Date: Thu, 28 Jun 2018 12:54:40 +0000 From: coypu@sdf.org To: seabios@seabios.org Message-ID: <20180628125440.GB7110@SDF.ORG> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.1 (2017-09-22) X-Spam-Score: -6.0 (------) X-Mailman-Approved-At: Sun, 01 Jul 2018 03:23:34 +0200 Subject: [SeaBIOS] ACPI OEM Table ID length X-BeenThere: seabios@seabios.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SeaBIOS mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Errors-To: seabios-bounces@seabios.org Sender: "SeaBIOS" X-Duff: Orig. Duff, Duff Lite, Duff Dry, Duff Dark, Raspberry Duff, Lady Duff, Red Duff, Tartar Control Duff X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Hi folks, I ran into this problem while building Xen. unfortunately, I have trouble building the same files with seabios git, and have even more limited ability to test the changes. Apparently ACPI says that the OEM Table Id must be length 8. Some of the tables in seabios use longer. newer iASL rejects this and fails to build the code. Most likely things handle it as if it was truncated, but perhaps it overran to the next field. I've used this diff, for your consideration. diff --git a/src/fw/ssdt-misc.dsl b/src/fw/ssdt-misc.dsl index acc850e..d1d2c9e 100644 --- a/src/fw/ssdt-misc.dsl +++ b/src/fw/ssdt-misc.dsl @@ -1,6 +1,6 @@ ACPI_EXTRACT_ALL_CODE ssdp_misc_aml =20 -DefinitionBlock ("ssdt-misc.aml", "SSDT", 0x01, "BXPC", "BXSSDTSUSP", 0x1) +DefinitionBlock ("ssdt-misc.aml", "SSDT", 0x01, "BXPC", "BXSSDTSU", 0x1) { =20 /**************************************************************** diff --git a/src/fw/ssdt-pcihp.dsl b/src/fw/ssdt-pcihp.dsl index cb24c11..518a5eb 100644 --- a/src/fw/ssdt-pcihp.dsl +++ b/src/fw/ssdt-pcihp.dsl @@ -1,6 +1,6 @@ ACPI_EXTRACT_ALL_CODE ssdp_pcihp_aml =20 -DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPCIHP", 0x= 1) +DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPC", 0x1) { =20 /**************************************************************** _______________________________________________ SeaBIOS mailing list SeaBIOS@seabios.org https://mail.coreboot.org/mailman/listinfo/seabios