From nobody Fri Mar 29 13:47:12 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 80.81.252.135 is neither permitted nor denied by domain of seabios.org) client-ip=80.81.252.135; envelope-from=seabios-bounces@seabios.org; helo=mail.coreboot.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 80.81.252.135 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org Return-Path: Received: from mail.coreboot.org (mail.coreboot.org [80.81.252.135]) by mx.zohomail.com with SMTPS id 1510334714573876.3974561571167; Fri, 10 Nov 2017 09:25:14 -0800 (PST) Received: from [127.0.0.1] (helo=ra.coreboot.org) by mail.coreboot.org with esmtp (Exim 4.86_2) (envelope-from ) id 1eDD31-0005XH-WF; Fri, 10 Nov 2017 18:24:56 +0100 Received: from mail-qk0-f193.google.com ([209.85.220.193]) by mail.coreboot.org with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.86_2) (envelope-from ) id 1eDD2q-0005UF-Gc for seabios@seabios.org; Fri, 10 Nov 2017 18:24:54 +0100 Received: by mail-qk0-f193.google.com with SMTP id 2so11952418qkg.13 for ; Fri, 10 Nov 2017 09:24:44 -0800 (PST) Received: from localhost ([64.9.249.2]) by smtp.gmail.com with ESMTPSA id 76sm4155306qky.56.2017.11.10.09.24.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 10 Nov 2017 09:24:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=koconnor-net.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id; bh=u7CAcCfHGwbqmiFTuVt26EHnnzpFmnqkxUWki0SbSvI=; b=QatfMjCzpasxMsV7nQOVLXFgtD/HdN/X5a0i0OZSYLSersmTCD6NK7tHCNHF3rjagS 6Yi3ZQJe62wsKbeXK50a9XCoyTR0JOdHZx9CowBPD8y/+6tmDIyhnCinW4js28FjCuL6 HfJWlns/Q5GSj9hh/dYVJsLc36AWShG7oE5BTbiKAZU0rFbB7rqlRO162ShL42bnH6FW kOJnb5WHTCDocBYI6VY9poCey//Ob/gjYF55klhaNpMT06UwGyU9eTdmz7di07/sEA2a BA38srvswHBhJKKA2xj0yIMO0kUBtxtjmhC+Na6j3TlfaRBVh7TsfozkpqVeVpkc4JhQ Ut2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=u7CAcCfHGwbqmiFTuVt26EHnnzpFmnqkxUWki0SbSvI=; b=uXorOnukcBqw1FJXjf5JfVVXVrabESPiq+EsqFRIuJSsgeoCT+tX1Q6odAg07fue/q dIG/bMh3AtfHfYLU74nMYmQs8/71xEXCmD11sVez4nK3ERheuDW+OxkhkoE1mpllB7Kq L2NtWxR4A50XMY5hrVdhFfeEynY3ZyRXRkvsp4jcQcSyiUgQkKqYS4r8nT8qhvxKdFB2 xa85hlgDsbCSKAm4Nqbkp2hvRZrUklwltRtuYqppGsgb/eoUn1qUtYChRRgEgts42yx8 Mj5OH6tOR6YI//9REJIrrCeVlhFh4vpmypk0WYKNrl494pOTjaS6XbYCP6ycqsmHIHiU zXEA== X-Gm-Message-State: AJaThX7uxjJfXM7N6psAycfAT6fOJ2KTdE95kHfzIgf1cNu8DoBHsGkP IrPCbR9caeyb21yNvNs/IJvpQHVHziM= X-Google-Smtp-Source: AGs4zMbG67JeXUpQ/PAH4Fo/WWYMI847H6vL2dQ6Jp+wUqugDobXjt1C1PDtOpwi7XjcAJYwmtk4Gw== X-Received: by 10.55.161.78 with SMTP id k75mr1734787qke.158.1510334681969; Fri, 10 Nov 2017 09:24:41 -0800 (PST) From: Kevin O'Connor To: seabios@seabios.org, Gerd Hoffmann Date: Fri, 10 Nov 2017 12:24:38 -0500 Message-Id: <20171110172438.31256-1-kevin@koconnor.net> X-Mailer: git-send-email 2.9.5 X-Spam-Score: -0.3 (/) Subject: [SeaBIOS] [RFC] paravirt: Only enable sercon in NOGRAPHIC mode if no other console specified X-BeenThere: seabios@seabios.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SeaBIOS mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: seabios-bounces@seabios.org Sender: "SeaBIOS" X-Duff: Orig. Duff, Duff Lite, Duff Dry, Duff Dark, Raspberry Duff, Lady Duff, Red Duff, Tartar Control Duff X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Kevin O'Connor --- I wonder if it would be better to only enable sercon with 0x3f8 in the nographic case if QEMU has neither specified a sercon-port and has not requested sgabios to be loaded. This is just an idea. -Kevin --- src/fw/paravirt.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/fw/paravirt.c b/src/fw/paravirt.c index 9674ab8..0770c47 100644 --- a/src/fw/paravirt.c +++ b/src/fw/paravirt.c @@ -513,12 +513,6 @@ qemu_cfg_legacy(void) qemu_romfile_add("etc/irq0-override", QEMU_CFG_IRQ0_OVERRIDE, 0, 1); qemu_romfile_add("etc/max-cpus", QEMU_CFG_MAX_CPUS, 0, 2); =20 - // serial console - u16 nogfx =3D 0; - qemu_cfg_read_entry(&nogfx, QEMU_CFG_NOGRAPHIC, sizeof(nogfx)); - if (nogfx) - const_romfile_add_int("etc/sercon-port", PORT_SERIAL1); - // NUMA data u64 numacount; qemu_cfg_read_entry(&numacount, QEMU_CFG_NUMA, sizeof(numacount)); @@ -620,4 +614,11 @@ void qemu_cfg_init(void) acpi_pm_base =3D 0x0600; dprintf(1, "Moving pm_base to 0x%x\n", acpi_pm_base); } + + // serial console + u16 nogfx =3D 0; + qemu_cfg_read_entry(&nogfx, QEMU_CFG_NOGRAPHIC, sizeof(nogfx)); + if (nogfx && !romfile_find("etc/sercon-port") + && !romfile_find("vgaroms/sgabios.bin")) + const_romfile_add_int("etc/sercon-port", PORT_SERIAL1); } --=20 2.9.5 _______________________________________________ SeaBIOS mailing list SeaBIOS@seabios.org https://mail.coreboot.org/mailman/listinfo/seabios