From nobody Thu May 2 05:01:06 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 80.81.252.135 is neither permitted nor denied by domain of seabios.org) client-ip=80.81.252.135; envelope-from=seabios-bounces@seabios.org; helo=mail.coreboot.org; Authentication-Results: mx.zoho.com; dkim=fail spf=none (zoho.com: 80.81.252.135 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org; Return-Path: Received: from mail.coreboot.org (mail.coreboot.org [80.81.252.135]) by mx.zohomail.com with SMTPS id 1496915935203694.1477603955987; Thu, 8 Jun 2017 02:58:55 -0700 (PDT) Received: from [127.0.0.1] (helo=ra.coresystems.de) by mail.coreboot.org with esmtp (Exim 4.86_2) (envelope-from ) id 1dIuCW-000163-Ap; Thu, 08 Jun 2017 11:58:00 +0200 Received: from mail-ve1eur01on0120.outbound.protection.outlook.com ([104.47.1.120] helo=EUR01-VE1-obe.outbound.protection.outlook.com) by mail.coreboot.org with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) (Exim 4.86_2) (envelope-from ) id 1dIuCN-00013Y-CY for seabios@seabios.org; Thu, 08 Jun 2017 11:57:58 +0200 Received: from rkaganb.sw.ru (195.214.232.6) by DB5PR08MB0839.eurprd08.prod.outlook.com (2a01:111:e400:599d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1157.12; Thu, 8 Jun 2017 09:58:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=KogudWJfgL+m0vUN2FedDBZnXP37WQki4LsbNCmHCe8=; b=hlBM9a40DMXy1jSpmZs/RRQYO37zq2Z154XsT2dX6JlQAgvzh6q015WKBDwjwLEQzBDhWUY7MefDYqtgbtKW3enHoHlVrSZdmvV8rsgIv3TiK7Arvr1R3xsXb4vcPGcoSaFPe+jduSWYhZrDfaSssd2+nV2AH4IStBXKiFydBgA= Authentication-Results: seabios.org; dkim=none (message not signed) header.d=none;seabios.org; dmarc=none action=none header.from=virtuozzo.com; From: Roman Kagan To: seabios@seabios.org, Kevin O'Connor , =?UTF-8?q?Maciej=20J=C3=B3zefczyk?= Date: Thu, 8 Jun 2017 12:58:07 +0300 Message-Id: <20170608095808.5656-2-rkagan@virtuozzo.com> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170608095808.5656-1-rkagan@virtuozzo.com> References: <20170608095808.5656-1-rkagan@virtuozzo.com> MIME-Version: 1.0 X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: KL1PR06CA0062.apcprd06.prod.outlook.com (2603:1096:802:14::30) To DB5PR08MB0839.eurprd08.prod.outlook.com (2a01:111:e400:599d::17) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB5PR08MB0839: X-MS-Office365-Filtering-Correlation-Id: db5f3232-d20a-4d7d-579a-08d4ae54eae7 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:DB5PR08MB0839; X-Microsoft-Exchange-Diagnostics: 1; DB5PR08MB0839; 3:5N5Q7qe0VJVr0n6Ctv1IKhyjie03Cx49SHkuPmvcoVTKfYlVhFv6Ai/s8xmQ0PDYTwd0ciT89NXuimjDKb1IdhGPaDujVkg7YVzBAztAEpS6LqKE6hMnreaZfz3hGpWCEJYFYRiHBBenKvjhEEYxgR56xslGAmRnbDecVjxFyuWVPBhifuWSAA3dULparrR2iIBtMAhrbadR4uYbwY13+CKE5GQjsxMoo3xhZVswZKbGj35UqxP8Q9a/dCnyOAdneZXMB/CdFy4djEVW0pD3ijDTqemQ3T5EJdKZ4/I6aOJgVkg/a5uQme21r47X2uxlI8qjPySeq8tmUNSoUbs2pA==; 25:UJ0RvBQ/zPejLZ0IszDXQCTGnpKVKfWX7bwoY9QKxPLIDkCAj/yHiTFES0df9stI+7PZwNvw3wq2p5K+zUyLtZW4wJeahirLKkzIHxC8QufRzS4lPxLGzHUyuBrSceFR5AzYn/cnwRgho2dlcwfkMuIIYoKam8O8zpoZ3lByeLNYXHk7TavnkOqbVPHJo7nFx1uUzZ61j9+qqrxSakYIYDinuERL1sU3dmrCMgjubA04b4DStWqBo2rWvxl1DcmW2yEKk/8L45EM4dHcH/L/oCtPRj9IC72V+P1fEJYL3/6LnQHhBgHw+oCUhQkUQsArXwSTuOjmpgDfa+hf+XjZlQeCCaFy5FNQpXMykXo39dj5kLt5X5ZmOHAvWrw09Ybp+T2kNnscmX5S6P7vbdNugatFqz0K+4i978Xp+yupReryg9OiW3Rn10edwULer91wzG7iWKSvNwgpI7mwPW2QmVXDNpfeb/fbGYPkWSfEKIg= X-Microsoft-Exchange-Diagnostics: 1; DB5PR08MB0839; 31:5iMkSAJR94V9YpsGsDrVU6BlxH1e4Lor36qoltWqAKmMbVh3DSzrLqMqMQyyj9jp4zEXCguGsnzicCfh4yAq+vE1SV15tMB7d6Z8yzIAj5fuqzy6QSRWvWMKKhZAVl7hM2N8CzSXHt5TYtXjfOhDWBhpyqDcHQgUl9/NyyQCd0SwiXa7128FPPSPSS5WRsUX77WVoeb4L3XwGoNssfHRXzOaircrFToI7yHQ8ZwXdZpq/Lqgn1KPSZMusSXCsncP; 20:2TEtG+oC4BY2Xj6HKk1JLWtiJVEYXjAY+5l2g7+/nj/hHDkAbN/Vqjn1Zo+Sw82fYQHB21DlMsO/kcXY91WNH4L+urXOWIsSOLXliFbekoKyPl1KpZp/G6a25JyL6cGZ7tqGe0Vx0QalsUxG3URrZQkobUZ2JaFfPr5TqYEe7oaS73/PE9QuecL0C/zt5PDq0w0WahC3GTwnGxZ0tScsOPs66Aqu9J7WSZS9uVht4OUY3+S+f1vgng1Jd5EEnz6247cg4gkDLdMzZSECuB7BSrhlYuxKGzi/R4Jia5HqoZhIzImsgvNqaQTacKNxaq/A67uIduXePZLcnYWeF2gfkUOLEtGakHJH4qcnDKt0qUsXFdAgIxaaRogZmUWPGCTpWwu9Pb1nK6/5cXMd8m0Wk5sCuwM3mlWThacVRQSSFus= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6041248)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123562025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB5PR08MB0839; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB5PR08MB0839; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjVQUjA4TUIwODM5OzQ6RG1oOFkwcDc0OS8waFl6OS9URFRyMTJEQVJq?= =?utf-8?B?WkhiMFVSblVWb3daSmQ1M3k5ZURtWlFwallXb2FjbVZmVllaNzNsSTRDMVB2?= =?utf-8?B?WDNaNnVyd1NtWG5ucWRjZUx1VzdrdjNnTHBKcVZnSmV4cXJLNExBcGh1RFVl?= =?utf-8?B?SlVXMzA2SDZLdUdXWTZSSXRMeHhMV2RyMWpnTVVQQXB1UzNCb1BmSi93ZWNI?= =?utf-8?B?dmxjTXNMUUFXT1BJci9rVHYvZ1d1N0xWTllrSFRlTTFra1NHKzBXdU05M0tN?= =?utf-8?B?Wkpkc3FrcHVQRTBVQ1cxcEJmUDNyZjFCYmhucWpqdjZFRnBPcUZDNDhNaUpp?= =?utf-8?B?c3hqcncrV0czV0l6RVlqaXNCN25mSG5zRHJhT1lyM1NmaDNMRHRvdmtsNTE3?= =?utf-8?B?U21YMUJXcllUc2tVNzZCRG9lUDZKQXZNd0NZd0dacnpGZElrdzNBRTNwb0th?= =?utf-8?B?d2dNS2t4YnZWS0hwdzR4VGlUWFVPVmRQSWFlc0wrUnlGTmRnNXFlT2haeVlS?= =?utf-8?B?RDFJbEJteVg4d2VJNmRTTmdRcFFIUlZtb0RlK0pKdmUyU2lYemtPWEdKeitz?= =?utf-8?B?VnEzbWxLZ1JwVkpNK041S0JNcktDeTJBUFowWnFwZjdtdGlMOVEyblhoYS9p?= =?utf-8?B?RDQxWWM2eDlIbkVpOVh1blNjR0I3SHZEMXhjMFpEZ0liVFV2MUxGTjd5cGlH?= =?utf-8?B?clR3N3NSL0xrbzd0T0VZL3NtUHd1ZkVDR0tnSklTd2NoWWkvYkcxTHdQZmxQ?= =?utf-8?B?NVZUOUw4aENpQXM3L3UzWHJUMzBOVTh3ODRHVnREcGFoUDBRNGw3b3h3SG1k?= =?utf-8?B?RkhkdkdqU0lKWEROUDNtT2xxaTlYOTRCeE4vL255L1I2ZG5vOVppL29xa3NU?= =?utf-8?B?ZlRqRDR3ZHgvZndHMi9qeUlBYXdkb3B2UnFzRzB5aGxPWjUrWXpidUc4NTVD?= =?utf-8?B?YVRCRWFwRWkySU94WHowaURFdFBHUWZ5em9PSk13aGcwdEFVTnpEWGpyMXFD?= =?utf-8?B?ek9YY1doY0tFL1JCVU1tU0p5UFlMOERuRm02bnFpSGprZ0FyODNLQ1BHS25p?= =?utf-8?B?N05IOEp0MVJSaExYdTlqdGlkaXFPK1J6bkIrdmc3ZldtdExsSDlQVkhBSi96?= =?utf-8?B?OEREUlpSbkJ5Z1dpV3hjOW1iUyswMWttZlFwQTI3akFrMndyVm1LazJPemxW?= =?utf-8?B?ZU5vN2FybzNFRVRySDNFOGVqU3pDeW9FOWUxbEZsQXZEa2VPdm94c3cxd2o1?= =?utf-8?B?elo3aUpxeHpXYWdYUFFXTUg3bnd5Vlc0eDBxdStCUnVpU2NSNWV6VjU3eERu?= =?utf-8?B?MFU1NGpaVE9JeVU4dUN6aUdMeWpFV3MreDlWcUxnRjZzc2RNa0lySnRiV1Q5?= =?utf-8?B?Z0JOYUFzaDNJeDN3UUIxdTJGODFrZ2lpVlJIcFlHZU80dWtJQmNYYTlpS3pn?= =?utf-8?B?b20xdUlQOVorUmV3R0ExRnVjNXVVbzRud0wyMUVLalBVKzh4UEdVeGhhdk9E?= =?utf-8?Q?YftpxZ4Bd+5ZUalT8caBv6WeZMnMa3BvBm0cLZbp7KDFf?= X-Forefront-PRVS: 0332AACBC3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(39410400002)(39830400002)(39400400002)(39450400003)(81166006)(478600001)(86362001)(8676002)(189998001)(53936002)(38730400002)(6512007)(1076002)(6486002)(3846002)(36756003)(6506006)(23676002)(66066001)(47776003)(7736002)(50986999)(76176999)(42186005)(2870700001)(53416004)(2906002)(305945005)(33646002)(5660300001)(50226002)(6666003)(2950100002)(25786009); DIR:OUT; SFP:1102; SCL:1; SRVR:DB5PR08MB0839; H:rkaganb.sw.ru; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; DB5PR08MB0839; 23:k5tknjxlbsLCOVf2uLpD/slrk7fEACWPrkHcm+VDcK5yYQq+76DSey3817m17RJZEpDoPqD6AJs5w20l4j+uQaaYt5m5PpaY5nFAUiIzzA1iqVUt4ZUJ8ifpRWhmzQZQZqJoN0ItkaZKni5nSI/MGYxLHro4HlmXXoqAmKyaYgWYePhhWvaI2AI0m/eGWYgmbK46BAaoLfaFE6gNjqZkvX++bpE6oBRDVyC+DID80crMSSZhOXr9vfO1H76PkAjxgjxiqL4C8t6qlWWMUcYllIuo3Us+8m+ODVwmGz7l5sTEkDoz6zPt7vuticZVahSre/jEJY3spz4JLWVD0ym4fHcvrCyxCKdKTRlLNW5o6QsQRQIKmrn54hRfVSIOQKeDuu9TqNgxq9E+KOfa0Rc/sGRvHsWvcHDpN3jB2vboolvrRg18AUMRetCZJl+LnbUic1J8G+qMFVCBv63BGbibfhgjgHJ05oPvHVB2nI6eJ9aQaGGC1PB3a8kfPQqWx6UGWzVoPihDRCs06/DLbYvuUcs5nxvhrhH7NGq4H7rbewrEv+14TecCG9UrHjP7iDMsNKJFLaUCCS3DcU4disfj+wtaUCZbbpISRJNBmH9c5yLi1h3qO31qRrYMF25uqzj9xcFXjzOYGrI8z8C1da3rO439yTxjmaqHLhP1psG91yUA1qzEFv6CwbsX7r3rtqXEv9TzL8VOkPQBgbSAy+zSStv9JG/809vaZ5kAAk6AdFVnYmOJwQZshuuR+ysokAHdtfUsub6WS7ltJHEZJiBy2AUFUTMsYJsqprkmZRe0CkK7ft+Zp9Qt2s1IQY0SXT3KFAAfHT0AWcus0ErFEbmx5BW5+GywheCs2B9+5EtKNDA3RwWcxnnDxwcCIarmvk2eA5My0qnd2iae62rrfhhqjfbt8Xb3tk/PxuQEM1VR/Ic= X-Microsoft-Exchange-Diagnostics: 1; DB5PR08MB0839; 6:MtPi2f9iXFAi67vEb7355nomJIlTBsHlSC8JmbvACaUZKuBD0iw/ZXINLGV1IwsCfm/VnwATin9c/zUpXmaA0JWpb2QDaRNnlkVAJ1VlY891Tt8DLg2LU8cMH1A1emR95DFr/sXHgUxadAefQMJUF7M5xcx+VcqOyfieCIROnYuuK2gJ+KHaPxbyuLHVjs2pZ8eEL7SE6sPqIYUrsRcJjg5BD0/dqzQFstzq2Ks2SOac+sxKp6OlpL6/0Rww8Mfg88LZ4u5w7bNwWHPKJL9sJ07FUeWVm3Z+YG2NFznRPk056o6DztQ5UOtP2UQAGnl+FshRn/ZocBV9Od4dAoYVDb0SNP9csRMKnszvLaCoik0Ao0XIB77Om/4i7IXf6FPjb96HTmPq7C7FolBfwJrjlQ1mQpKOJ+w0QYUKrHhjKFQq63pjrMEgYkexn3LzALrbs/VE9VOSMD9fDzBX1zOJ6Q6Vu1JvBLTilyGTrB44FYLv95ZPsotxQa0W+pts365sAwSs22t0xNFwFDfLm3IdiQ== X-Microsoft-Exchange-Diagnostics: 1; DB5PR08MB0839; 5:23aJQBA1NKOMDCAgpJkLL2sPv13+Nv9+w2opmC/hKN6fvfPV+o/brivWeXbPFP654os1eesjnGTE3LqUKhjgYYkmrMpaSULnCHCSxsHpSvU00iDKl5dFbgDLetm1/uDRNj8N9ExnyYfVrSsIExem6h0mvCDxW2rTrUSm5zTIZWg1Eocy7C8qkxoACDzIjbrK8m+wMFkz2ZhEiGk+NOcuEJHkae29+Xlc9qY8XcztpwFGUhLxmfhLk3ahIbNoYMf20K3fhltI8axuzIK/fjZpezf9qv4xbJ8PkjVAb/AkTnEu6Mo8M6WknaWRKq7++VPDThyVWH0XGGW1cNMFddLUD0RTPdbG4YaeCxErfCH/WysNQrIsigCexDRp+34xasfPuqjZk4P6otPhykFwIEASyrfI8M3p5RKQdVbrfDXk/OtK3lVtiUe7SP3ZyeXH3qpZDt/Q0oVHBar9szsX2zPFHWDpCpNBsCDg9HccnICm2LqD7SL4fLhS8i6JlmzKZOek; 24:Sr8B5xOumekcX0tjQjFvELdqiWfNki7TsVQmt/gvWgj9p5fPXduL0ybkXV3xNv6pnO05KBjRfiwBZWHiSShPMdYBqh3SQB+3eXMgCuteQ0o= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB5PR08MB0839; 7:TMcjmx9b40S87BmNl4qwJWmZmDQqSzo5hwg9tlasMr5uqzvefmn9emka8ANYZ19T8Evw1KHD3c38we5cri/nuK0yxeR7xZHPBSraC9J0O3JOaQVNXMwJ+tCPCMWgNl2nNTkG4Oxj625fq8EDMB+dVF/yKC+1rWmIbefvOgp7QL25+IlsHtIBzptRlA6d5ccfjJUycILZxJsCIVGivAs1nsNDLlpxT8AvpMXK+XZIzo3ZDTAdSB9OyUvmors5NecLxfPxdbKkKQUo43QrZotCCd8DawVQN7G/3nOEXdjG/UXvUxrU7j1WwFdW7pC+x/O19zYwq9tf1J0g3xj91hG/aA==; 20:D+Vw3MHlJc5H4ikSrEfSiNxapidW2QVGjyHl/n4xCM1p6l3zhIOTnYc4jXjU2wjz3BCdhir6gFJH5vWRZToykXQOX0le6FE+0pBA81b6IFpmxZ0XyclMl0ZDcWvYHY+M7Jrjyw+D9AAIOwcm5Zs5Ajg0CcQgH5ltWqxb7quH5Do= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2017 09:58:28.2750 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB0839 X-Spam-Score: -3.6 (---) Subject: [SeaBIOS] [PATCH 1/2] blockcmd: start REPORT_LUNS with the smallest buffer X-BeenThere: seabios@seabios.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SeaBIOS mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: seabios-bounces@seabios.org Sender: "SeaBIOS" X-Duff: Orig. Duff, Duff Lite, Duff Dry, Duff Dark, Raspberry Duff, Lady Duff, Red Duff, Tartar Control Duff X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_4 Z_629925259 SPT_0 A number of emulated SCSI devices in QEMU incorrectly return an error to REPORT_LUNS command when the size of the data returned is smaller than the allocation length passed in. To work it around, start with the smallest allocation length possible: for 1 entry. This is a slight pessimization because it would require another REPORT_LUNS iteration if the target has more than a single LUN, but this appears to have negligible impact on boot times, and makes REPORT_LUNS enumeration work for more QEMU devices (lsi53c895a, mptsas1068). Reported-by: Maciej J=C3=B3zefczyk Signed-off-by: Roman Kagan --- src/hw/blockcmd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/hw/blockcmd.c b/src/hw/blockcmd.c index 324188d..98c06ce 100644 --- a/src/hw/blockcmd.c +++ b/src/hw/blockcmd.c @@ -215,7 +215,9 @@ static u64 scsilun2u64(struct scsi_lun *scsi_lun) int scsi_rep_luns_scan(struct drive_s *tmp_drive, scsi_add_lun add_lun) { int ret =3D -1; - u32 maxluns =3D 511; + /* start with the smallest possible buffer, otherwise some devices in = QEMU + * may (incorrectly) error out on returning less data than fits in it = */ + u32 maxluns =3D 1; u32 nluns, i; struct cdb_report_luns cdb =3D { .command =3D CDB_CMD_REPORT_LUNS, --=20 2.9.4 _______________________________________________ SeaBIOS mailing list SeaBIOS@seabios.org https://mail.coreboot.org/mailman/listinfo/seabios From nobody Thu May 2 05:01:06 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 80.81.252.135 is neither permitted nor denied by domain of seabios.org) client-ip=80.81.252.135; envelope-from=seabios-bounces@seabios.org; helo=mail.coreboot.org; Authentication-Results: mx.zoho.com; dkim=fail spf=none (zoho.com: 80.81.252.135 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org; Return-Path: Received: from mail.coreboot.org (mail.coreboot.org [80.81.252.135]) by mx.zohomail.com with SMTPS id 149691595001948.2077689669876; Thu, 8 Jun 2017 02:59:10 -0700 (PDT) Received: from [127.0.0.1] (helo=ra.coresystems.de) by mail.coreboot.org with esmtp (Exim 4.86_2) (envelope-from ) id 1dIuCe-00017x-5L; Thu, 08 Jun 2017 11:58:08 +0200 Received: from mail-ve1eur01on0120.outbound.protection.outlook.com ([104.47.1.120] helo=EUR01-VE1-obe.outbound.protection.outlook.com) by mail.coreboot.org with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) (Exim 4.86_2) (envelope-from ) id 1dIuCV-00013Y-9o for seabios@seabios.org; Thu, 08 Jun 2017 11:58:06 +0200 Received: from rkaganb.sw.ru (195.214.232.6) by DB5PR08MB0839.eurprd08.prod.outlook.com (2a01:111:e400:599d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1157.12; Thu, 8 Jun 2017 09:58:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=a8+VzFXtBsebBv9/iWqJpaKu3frRRsU7Gy2iRMk6tmc=; b=HVK+YShSzTNMKn9qnqr6U24EnyU9DrVuVIx8rTVpo0GDxlWFcjdTsUn6JNOISvQe/1ncln43GXoEoS0OO8MViZLkUScWrfnvKfi0CxupKNGNpafGnCXiW8a7PxcSghR42NT4myTnVzvVaCiZDndP2P2C3qU3AAFtn8dZRgjWYXw= Authentication-Results: seabios.org; dkim=none (message not signed) header.d=none;seabios.org; dmarc=none action=none header.from=virtuozzo.com; From: Roman Kagan To: seabios@seabios.org, Kevin O'Connor , =?UTF-8?q?Maciej=20J=C3=B3zefczyk?= Date: Thu, 8 Jun 2017 12:58:08 +0300 Message-Id: <20170608095808.5656-3-rkagan@virtuozzo.com> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170608095808.5656-1-rkagan@virtuozzo.com> References: <20170608095808.5656-1-rkagan@virtuozzo.com> MIME-Version: 1.0 X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: KL1PR06CA0062.apcprd06.prod.outlook.com (2603:1096:802:14::30) To DB5PR08MB0839.eurprd08.prod.outlook.com (2a01:111:e400:599d::17) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB5PR08MB0839: X-MS-Office365-Filtering-Correlation-Id: 4cef951b-a166-48bc-4157-08d4ae54ed02 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:DB5PR08MB0839; X-Microsoft-Exchange-Diagnostics: 1; DB5PR08MB0839; 3:N3bD+24o8kqLtQnAkG7FnQd8fB7rZsbdN3B8dspE+FNMKmH2mAHO4Y1UpOnjsN+dFzOvLrPZ838a09PNlqQczp44Twnt60eyC9Z6mSYND9fXj2O45eYz57EH4Hld8E/pJDxDdUjbjpSJG7Qzytla0Fr3fkuBKOfBDXzWAJODrVsDj0c3WVxkR67Wgc/jxWmZpzVLC/FDXtFkT62XCjlJDvZA1yCDnPJfEU90hiAzwkksVksNfX/Zp5B5TfKBIk3AuykuyUpX+aQIFNIjhYDGwd/nje12P6aHanekd0gUKMOLCBRzacGRN9DaVPJVyJ724dKdyTM6GCfaocBj3CIyIw==; 25:iTIi2J07xw3R18JI7FVoNbjlpkd0YESRcFl9lJ90R0BMcFVJRPCP/DodwSXcHsLVK4+2BPPA6RYo6tU2/ozT970KNBvEWqOIeTZdvyPxt/LfKYBiNWvFxOtsYMXueRpLE6pUuxvohxAYuctKhULUvSQcZ01RnPEjfbZ72m6Xzs0hcem/LyDl9qTnGHrW1fDPdsWApd5myLlf434vpnt8ZV2OGcS9ESr6SVIafhsP9ivFgyvVxm8h7KBmBJVzeqDHkr6tNWLs3qmobL0k7DgkVEA7IqWDV2tkSCuUmzzDrlt6kr+qh/rQ1MQelw3eSSdxiVsYCbdUyrx67LTXfEOvv8maq+HNmfymeVGRPcy7NsAMv4mAvRxzQ+l+/bYNZo8xVPBeAbdB13NA7lTgS4LAngrHSIwpkUlgYjHsGM6W+IXpV3+JXBFSNa5m9EQtMqUywEBz9oAlqfeCicW3gJIS6cEM0JA+OzKgbgB2PP6GuS4= X-Microsoft-Exchange-Diagnostics: 1; DB5PR08MB0839; 31:Yk3nn4FM4+cshfgIYqKcVMQsJOnBA0Wjy8m53YWeXvUoavb7hz3eGdTdX92wShEEZ8E+3hr0Lqaaso1ZiFsIuXhrEzWi7U4y6T7wMlrKc4swiwCR7pxXqIpgs8PA1tkrMpL2Bx9/7Z1/QMwRpQLM0vaoTa1kvgMmMFs25XSYggGml3HX355qZNU9M26XYRM0rt/w+YLed9oAjTJrg5A+eKTJ8Dd/aYa42fjw6he97Oat48Jl28ZGA/ddODFQoCjG; 20:Brz/eTcU41bEidVQA4OiGa2dfbAZi51pvYC3PvcQfRSK2Qy/oEzfdk6e9L9OxYWGBMsn4uH0YBRs3n316+T13scqiy83gv7yL0/vU7Nj2OjGXB5m0Z6bgpgCV0BuUH9tYXZ3u7JAYkWJ0J3A3apN6IldODyswh2m57ek5mpz3u6REDDnkQLno+vY/i1lMkZaXnd7TkP4GVdQV03CLV+RLNDISKaPWfpbcW6xY8nKXG2MZT0GGgHzw/FEeJbrXT6Q5TCA+a+grwiv9IvHAzRVcgndH4RoEoQXzFLlQ39/E2c1d8tXzWrlNVzNAeAtpkOUUB0i0hKoubtNhgdNzBIQi1yx5VaM8F4Tq4SqrrN7g6eBSMOPrH1TI64TUSV6Wjtij609nIzj64Mp3G1suEa9IAC641D1FaVGfUgFyga3rzY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(176510541525296); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6041248)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123562025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB5PR08MB0839; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB5PR08MB0839; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjVQUjA4TUIwODM5OzQ6elRaeHA5NE9aWHg5UkFjSUdlYTFZQS84dUNh?= =?utf-8?B?bFBMUXkzcXh2Zm55TTluMmt5Wk44Mzh5YnlaRUhVZW5QUEVMR2VJTjVFc2RP?= =?utf-8?B?V3M5L1FaOGlJN0phRVVRdERDSlBDSHVlTGlmUElnU0luWnpDc1U5dHhMV1RB?= =?utf-8?B?TXdHT1Y4ZUdaemdQWmRPY2F4ZTJHTTYzb0huL21jVFdORkJkQURNdGFjbUFD?= =?utf-8?B?MzRNTVA5b2lucmRvRHhsMWsvMWpHWjVURjM3MThvVmJpL3hKS0h2bVFqa05H?= =?utf-8?B?TW9NdGFEaDRydnRzZUYyY09HUnhjUnVaS1piRk9OaERReDFuc3ZybHlMSHRO?= =?utf-8?B?OUtyTjl4U1A5VWNVUG9TQjVhQUFkeFoxWllrMUV0U1ZoTml5VFdmVDhNRjBS?= =?utf-8?B?K1BrYkhub1FxWS9LTlNZMGNYVzNxaThMZjZrY1VpT1FlOEJQTjgxdG1ncG5j?= =?utf-8?B?S2VzcFhxU1oyTVAxQ3pibkRENzNtOENadnBwOXFtUllCaVZQZG5raFNiSTJt?= =?utf-8?B?SmIrTmg2VFA4dmFSMXVTZUV3ek5UWElrK1BtSXpnbWNpS29UV0pTTHRPdnBO?= =?utf-8?B?OXJ2ajRTTWwwc29pYm5Qd1FuUjA5OHpxaThZUEI2M093MzNFdDI3U2s4K1hL?= =?utf-8?B?QndjdEV4REVXcFR5SUxIWXVNNEdxcjFhL0phZmRnSTNpOHo3ekhCclkwQ3pU?= =?utf-8?B?R0M5TDJrZEx3QjUvdW0yL0d3VkN1aytNeTR6RzE1V2lKcXRUdGczUW1mZGFa?= =?utf-8?B?bG1XZWlhM0NtY3JHeG9YMTdBVGZaZmI1REJKSGdkNzkwejUwTGVkQW5XajZp?= =?utf-8?B?cDRpci8vdUlMLy9hSHdYeEZYWW94NkpxclNQdmpDZVZGOStEeW0zcDM0bmUr?= =?utf-8?B?dW9zSE4xekpBaU9PZDZiWVVEYW9pQTB3bTRWTFYwSXA2WURGcE9PUU9oTjhE?= =?utf-8?B?M2xBVGFyTlNTampmUGxsMTNuQ3lGT2pIUytrWXJJaEgra29JM1hpd2J5RUNW?= =?utf-8?B?OXBsVnBDQ2ozS3lDbVU3MVFvb2ZVelJFK0hFVGtRTEU5VDdMNTJ2eUhPSW1V?= =?utf-8?B?TnNsVUZ0c2MzQk5RN2xoS3A2SGpWZG96VlhKYVdZRXhKeXBodmpmbFZrZnhY?= =?utf-8?B?cWxvVTJPR0pEdUl2R3VtSUlMcmpBQmhoMDlRWXNScVdmU0FqS1p6RkdPajN5?= =?utf-8?B?REVzVmswRVYyZ1kvVGJLZHc4c3lqc0lLNEZhNVZkOGJET3RiSUkxQWd4ZDhq?= =?utf-8?B?WjMwam9QY0c5emtHVFNzbk4wdXI5UVFzeWhjUk5Fc284RW9vV1l6QzFpU3dt?= =?utf-8?B?aUhYMGQwT0tHOWFsUU5ZRnBYTmhCOVFPNWZTbWhyVHJkYXFjTkdaSlo3UEJs?= =?utf-8?B?Z3g0bE9IZjEySjQreVpmVUcrR2Naa3lPUUtyRmJvSmFxMW5HVzJhYUdINkN5?= =?utf-8?B?Z20zWDZDTmtMd0dwRi8wM25MeUpmeTNOSkQ3Skd6bmZOV2dlUHNlL05nV2sv?= =?utf-8?B?QTZ0cms1MU9vQjd4VFpLRnJkLy9VNTdySElzQ01oUmw3VW55QTE4VGRUMmNT?= =?utf-8?Q?2wP3j9mrTq646T4qVIyZkOMj2u+1STy9smF3gCU7hRw=3D?= X-Forefront-PRVS: 0332AACBC3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(39410400002)(39830400002)(39400400002)(39450400003)(81166006)(478600001)(575784001)(86362001)(8676002)(189998001)(53936002)(38730400002)(6512007)(1076002)(6486002)(3846002)(36756003)(6506006)(23676002)(66066001)(47776003)(7736002)(50986999)(76176999)(42186005)(2870700001)(53416004)(2906002)(305945005)(33646002)(5660300001)(50226002)(6666003)(2950100002)(25786009); DIR:OUT; SFP:1102; SCL:1; SRVR:DB5PR08MB0839; H:rkaganb.sw.ru; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; DB5PR08MB0839; 23:ZteYSuM24BjhbMltOrtrWGkT/zi3F+fBRRuw25wsXTuLX1fBVrN1kdO+l9DCZwBktuA1bKZ7HGHiXyqI4xiluJcXYcxKSqkn4lmM4CacEs2z74gu1AlT9c/3SmhEdLryFYdh7lkOLBDTkndNmmOkjRlATqiFS/WLFh5yGtPjfO0hZyK9UYxtA9Ffe6o0IzLBJ6xp5kOTDu7l4wgH5nCSpvoShtEcHIxU6YPD64aMW5IkK2tMJsC24zQs/7kmsYadoxTbKjPvkQLrcvmtPvL+7KomFOtq9qMGZz4fZE996+D3XvuYR8K/iHB9nJpAOHpQ5tIoqwC49olzl+xUkoTxEGD1h6c1Mm+Lhn3XKf/eX3hJ3rINc/mKTedlZ8SWXZCBovqPDVm1H346IbLMb6MKmTyanGp+tAKooHCNFt9ERYar98aw7WtDYhNpxqYNxcXYoIMYPakFW9XhaumFFxepbXlwlNnrf4xJ8li8CuzUU7CNqJmyUeIP1y3NzO3F9gjqj287o0eVi8XHy8EEKuQkFCUILJacC0WRmD6siyMPBiVIP3qKJO1LoRO487xS1YQxEW0s67kKleJQwn0TBLcnslnFPO42AFKJm5jxyLDVrHlIPdOYenvy1FijOragyk56O17h6hEV51kBd6ypeLCFmBlwI3zuP4rTqAvdhN4/zHrKvxui6UJeUHpBsHb+AuGYrwvRAMTp3MuNKGP0BOD6CK6sAXaDW8/cD63PH001iH4xks4ntDNIbrL9EowF/E7YET1labRYMFUc8YyY80ioUTEh+tZfya29RXnoGCW0SuBTUbvjVM2zeDWK6MpcB/X03nlhYD4L3CIm6yHbJzM6VGTldCjonUukqQi8P7aItGFrsMcppmqQQM3WtN1tviw7lStrY9merKBRBHscTvSgp3tdeYDzUQkrWdGciVIepv2MNSBv1Me5z4rlJ2NqZncH X-Microsoft-Exchange-Diagnostics: 1; DB5PR08MB0839; 6:DjptSLpBM87TPDgrwGvV2sysJ7DJ4hMiX+tlVGvRJ+gIFobIEzmMCtb+SCTs0Si/rmR69T10YBUa6k0yg3MI5q/mqaqFmH5hwuGCWX77TAjjDCf33cs3Jh3ZrYlUvhJbvkbcqkXO8BObnwBYNcCl4joSMyOoVlynE0prGb1Yj1A6VCt/k4AoYplTKEK9bydi62aee4DaQL38F8WaUGNf0r75Q6T34MjCyRvL9/tr4HnwuU9osgu0kazmAogXvAEtTgh/Af28er5UNgBwJ40/dauMkKxCiSVdps7nrd8WcvM/Xf8WGmtdX63LCRuzDl0H3H8vYZFwcbzF23S6rJ2NrrLVubWw0NhWJcnjFNNIcO8Ge/+yZXxm5VqWff17hf4N/5RGvL9/CRSV1/B2HfrDIAEVOdL+tp1V9LTghZd0k50b/roOXwRuR+XQtCq1Mjpi6+WV7AuYoCRnmN3LRmWQWFuK1Kza/tDILxb8YLSF0iOqRJkxgQrkPFg1RBP674tazJbg0fDydQGzAfagAfVXmA== X-Microsoft-Exchange-Diagnostics: 1; DB5PR08MB0839; 5:f0xG9MhWMQ3fOJkWO3FBaEqC9Uw0dWD+J2/6BpLJpIagRbEl4eDOezwwqR/IMuNlSOTP5hucrGlqwMlsqtuU+DY0YKDlWPi4pu2gBNnBJibtrREC+/Aj+OJac6bN6uCy753vgcq1E5DmbeeW5TV1wbF7wUN5KnDg3QCvJ/ll/afd4dEEVv6iy7bH5ATCN8QbrsGJ3+oUHUGYmSyeEHCjtgtCNz43NyxDpykv228JKSpBVk/dzQb9eQ8pWGVfAaxsJqMMR5s2MAOcbF1B0u/SoaODO2t5QnEIjGBd5VDzTkvBks5cxyiNJXsiB9sTmGwVJs6zHuOzVHNFnapIOqJ3tWv+2qF5zJXzM2OB81DMrrvMYpj7koK+lDT2QYkUSuyC5Egj+1j8fFbQgS5u8fmU8HvDeXd47F1SSC5HF9L0vXrvMG+34aDcDwe7StadBFsaSAwl2Z33UC+zOn89lAQZmU9FOYS6sn8zyKPr/3Lnvp1X9xVySp1wlvEgVn/UH70p; 24:T7f2jJquJoy5MNB6L2dr5YFioucp51see93lfihTt8sFDdiW4Sv8tI0g1Fl2eu2SHhZvAfKV8z/ErWY6AofDq5elZB2wFYvIWFtAD1Gsvk4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB5PR08MB0839; 7:4IcysjHw8WdjhWXhnffadNS8dqt7rP/tMPtnqVujTG72GdNepPrtqrc/yuP0+/tKd21b54Nr+C19sfI0pCNX+W3jOOK5CooQt2nuTmZHZFwGNfN9dAYTn1wyH5unPxAcoHvxuwvdQMBwFLivT4VmM506p6NjvG0lS/d5AWdu9XKtLq1V24CmVyneXCeveEUwcP/QvipqwE2Wx3CbGnBDOVYfiSurp4LHi6N0pXu0znwSOzycvnvMUFGaIlW8VRUjQJ4Gum68KKjME2RU6QXCpj+vJbUe6w+KtFWA4ZP0LZMmmFx/FIZWPZ0Hl7I/hZejk3WFcV8tFegyjc3oVit+vg==; 20:pMvRB5U893go7fjH/3KWLOwukjIfaQ3lmVj7/dei9irr3UtGq9U+2Cdb+VLz/vJiTbfmO/H450XEqESk6QZKFq2sZf+VWVXSJWKvC5RowgpdIk8Kx6WkZ/0DK/vDSy+AYsF3IPGX7YkGNwumUFoxbJQcGYnwj//85a4UvJFJmhA= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2017 09:58:31.8224 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB0839 X-Spam-Score: -3.1 (---) Subject: [SeaBIOS] [PATCH 2/2] Revert "lsi-scsi: reset in case of a serious problem" X-BeenThere: seabios@seabios.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SeaBIOS mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: seabios-bounces@seabios.org Sender: "SeaBIOS" X-Duff: Orig. Duff, Duff Lite, Duff Dry, Duff Dark, Raspberry Duff, Lady Duff, Red Duff, Tartar Control Duff X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_4 Z_629925259 SPT_0 This reverts commit 11277846e819b9eef3db5ac833a6a47f95f5ef15. It was originally introduced to deal with the case when REPORT_LUNS caused an error in QEMU implementation of lsi53c895a and left it in a "confused" state making further interaction impossible. However the remedy was worse than the disease: the reset was controller-wide causing all luns to reset, losing all in-flight requests; upon that all luns lit up unit_attention condition, so that any non-informational request would fail with check_condition status. As a result, the lun enumeration succeeded and I saw the respective entries in the boot menu during my testing, but the read from those luns ended with an error and booting failed, which I didn't bother to test. So this reverts to the original error handling behavior. The problem with the failing REPORT_LUNS is addressed in the preceding patch, by making it unlikely to fail. Reported-by: Maciej J=C3=B3zefczyk Signed-off-by: Roman Kagan --- src/hw/lsi-scsi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/hw/lsi-scsi.c b/src/hw/lsi-scsi.c index 846bb0b..5233251 100644 --- a/src/hw/lsi-scsi.c +++ b/src/hw/lsi-scsi.c @@ -116,8 +116,6 @@ lsi_scsi_process_op(struct disk_op_s *op) u8 sist0 =3D inb(iobase + LSI_REG_SIST0); u8 sist1 =3D inb(iobase + LSI_REG_SIST1); if (sist0 || sist1) { - /* serious problem, can't continue w/o reset */ - outb(LSI_ISTAT0_SRST, iobase + LSI_REG_ISTAT0); goto fail; } if (dstat & 0x04) { --=20 2.9.4 _______________________________________________ SeaBIOS mailing list SeaBIOS@seabios.org https://mail.coreboot.org/mailman/listinfo/seabios