From nobody Sun Feb 8 03:57:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1680098164; cv=none; d=zohomail.com; s=zohoarc; b=h5q2S/+H8HsAemglazoaAJjYiWnld4RUu0QNJqgzUpyB22b63nJFkAQ30nHB8aEIKDKXD51aBJrk70ycEWUmsYqGFg77tC3Q8+wU2b2gcApo06qKM6jbs1BmPBG6UrlQMFRagBKHf7Aj+siSvfTYbZqY1T4S+mKyzt1TV3xx23I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680098164; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=Ne8hidr9sGfns9P9adlpv5Zz/cqof1nqsaMwstyy1Ks=; b=CKCA2M3IrFN4f2ssdfUH1zP4KMFUyfrZvpplT56WNId1M41fjBMaTYJjQGUnp4LMCAkNCU1zMXqCqFf1pzX4sVEsadllKk+uEcgvYGdJTkW9uVy68Y5gAVq4ZtUTD5WFWmHQGLzetHjpNEEa3qU7eGbDhBasZr2ZH+LAzEV/J1s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1680098164626422.5662618324649; Wed, 29 Mar 2023 06:56:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1phWGk-0002hp-EY; Wed, 29 Mar 2023 09:55:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phWGi-0002gd-P0 for qemu-devel@nongnu.org; Wed, 29 Mar 2023 09:55:16 -0400 Received: from smtp-out1.suse.de ([2001:67c:2178:6::1c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1phWGh-0000Zp-C0 for qemu-devel@nongnu.org; Wed, 29 Mar 2023 09:55:16 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id DA042219EC; Wed, 29 Mar 2023 13:55:13 +0000 (UTC) Received: from hawking.suse.de (unknown [10.168.4.11]) by relay2.suse.de (Postfix) with ESMTP id C83DA2C165; Wed, 29 Mar 2023 13:55:13 +0000 (UTC) Received: by hawking.suse.de (Postfix, from userid 17005) id 9191C4A0378; Wed, 29 Mar 2023 15:55:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1680098113; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=Ne8hidr9sGfns9P9adlpv5Zz/cqof1nqsaMwstyy1Ks=; b=zpjgSpYALhSoagh4JTfS0FFEYNcqmZ8xdws3xoGeGz7T+wlmqzleWKwhOTrFl4eHOV4Ngf eI0EWZQsN3z6t+uIIKHkpJSjZL6lyD7JPGgkipbMZCnxG/U6S99rWIFXaiagoicaWJsRcv XtwQoXZh5f50azub7B4APh/6KQizWXg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1680098113; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=Ne8hidr9sGfns9P9adlpv5Zz/cqof1nqsaMwstyy1Ks=; b=sfwiNr07t6+HkW6wEAPYQkwMX7lbhIXGlU5a2+MeFvHRqVy0AqPixlHjloz1VQ7qnKnZDL yBpveWbatXRhVHBw== From: Andreas Schwab To: Laurent Vivier Subject: [PATCH v2] linux-user: preserve incoming order of environment variables in the target CC: qemu-devel@nongnu.org X-Yow: Concentrate on th'cute, li'l CARTOON GUYS! Remember the SERIAL NUMBERS!! Follow the WHIPPLE AVE EXIT!! Have a FREE PEPSI!! Turn LEFT at th'HOLIDAY INN!! JOIN the CREDIT WORLD!! MAKE me an OFFER!!! Date: Wed, 29 Mar 2023 15:55:13 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:67c:2178:6::1c; envelope-from=schwab@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1680098166116100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Do not reverse the order of environment variables in the target environ array relative to the incoming environ order. Some testsuites depend on a specific order, even though it is not defined by any standard. Signed-off-by: Andreas Schwab --- linux-user/main.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/linux-user/main.c b/linux-user/main.c index 4b18461969..dbfd3ee8f1 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -691,7 +691,13 @@ int main(int argc, char **argv, char **envp) envlist =3D envlist_create(); =20 /* add current environment into the list */ + /* envlist_setenv adds to the front of the list; to preserve environ + order add from back to front */ for (wrk =3D environ; *wrk !=3D NULL; wrk++) { + continue; + } + while (wrk !=3D environ) { + wrk--; (void) envlist_setenv(envlist, *wrk); } =20 --=20 2.40.0 --=20 Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint =3D 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."