From nobody Tue Oct 22 23:26:23 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nimmagadda.net ARC-Seal: i=1; a=rsa-sha256; t=1729257473; cv=none; d=zohomail.com; s=zohoarc; b=IKgJ1jMGmsFrepYdM4DWFXaXpSk/1MsuI0ok8bFH32JWdf9MNsa5Cu2LZ+IaPYcdPK8CkbOXtHDY0gHyewrm9KrozkD+vhVxz3DNQwC04DMCbbtvhZoje+8tFFMJHxoAbV7nChlGJL0Xz2ITpZmuLj6lSJxiId3LiA2mf+LbfgY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1729257473; h=Content-Type:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=VPMohmg/IBbUKjF8C3FRS2j8DwTUyBfaUfASW1zteLQ=; b=PeaC/Eeu1ptOkXIEagCCIhwbagazFSeI9WE0NUPW+J3MuOVxxddZQWNvt3KvTsxQoEcqmH2vzwZiVeqyW1TMLpWSFew8kCq3Kg6RO9FfxNg1yLA6wqnJ6iKyLy1Msx/nFBpZfAn7AVCRTLKwY2m59jmY03zBPEqLch/1cgYC72s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1729257472789576.3870729660515; Fri, 18 Oct 2024 06:17:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t1mqt-0007GX-95; Fri, 18 Oct 2024 09:17:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1jqs-0007w2-TJ for qemu-devel@nongnu.org; Fri, 18 Oct 2024 06:04:58 -0400 Received: from pri.nimmagadda.net ([2400:8904::f03c:92ff:feb4:8213]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1jqq-00046f-HC for qemu-devel@nongnu.org; Fri, 18 Oct 2024 06:04:58 -0400 Received: from IN-CW5TXJ4C2G (localhost [IPv6:::1]) by pri.nimmagadda.net (Postfix) with ESMTPS id BD5A74369E; Fri, 18 Oct 2024 10:04:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nimmagadda.net; s=skn; t=1729245874; bh=LgD81EjwdySXLo2mrynOyQn6DQoeJgXo7pBx6pJbXbY=; h=From:To:Cc:Subject:Date; b=GbzWRJsl8c/7ZAVwaVMHpG23bRbLqOfVyLH6DEoegD1VGQY+MZ6/RvadMaOtDY2O5 OtbFDnuI5mLz7jro2JbwMlCMi+BLCQFaZxxHrBb0NL7dE5b43GOIcdaLobp/JyVtbT X2hl5mpT6JtL7PmcgAjpzp3/Zg1s399z8XLUDb0I= From: Sunil Nimmagadda To: qemu-devel@nongnu.org Cc: michael.roth@amd.com, kkostiuk@redhat.com Subject: [PATCH] qemu-ga: Fix a SIGSEGV on guest-set-time command Date: Fri, 18 Oct 2024 15:34:39 +0530 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2400:8904::f03c:92ff:feb4:8213; envelope-from=sunil@nimmagadda.net; helo=pri.nimmagadda.net X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_XBL=0.375, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 18 Oct 2024 09:17:09 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nimmagadda.net) X-ZM-MESSAGEID: 1729257476710116600 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" qemu-ga on a NetBSD -current VM terminates with a SIGSEGV upon receiving 'guest-set-time' command... Core was generated by `qemu-ga'. Program terminated with signal SIGSEGV, Segmentation fault. #0 0x000000000cd37a40 in ga_pipe_read_str (fd=3Dfd@entry=3D0xffffff922a20,= str=3Dstr@entry=3D0xffffff922a18) at ../qga/commands-posix.c:88 88 *str[len] =3D '\0'; [Current thread is 1 (process 1112)] (gdb) bt #0 0x000000000cd37a40 in ga_pipe_read_str (fd=3Dfd@entry=3D0xffffff922a20,= str=3Dstr@entry=3D0xffffff922a18) at ../qga/commands-posix.c:88 #1 0x000000000cd37b60 in ga_run_command (argv=3Dargv@entry=3D0xffffff922a9= 0,=20 action=3Daction@entry=3D0xcda34b8 "set hardware clock to system time", = errp=3Derrp@entry=3D0xffffff922a70, in_str=3D0x0) at ../qga/commands-posix.c:164 #2 0x000000000cd380c4 in qmp_guest_set_time (has_time=3D, t= ime_ns=3D,=20 errp=3Derrp@entry=3D0xffffff922ad0) at ../qga/commands-posix.c:304 #3 0x000000000cd253d8 in qmp_marshal_guest_set_time (args=3D, ret=3D, errp=3D0xffffff922b48) at qga/qga-qapi-commands.c:193 #4 0x000000000cd4e71c in qmp_dispatch (cmds=3Dcmds@entry=3D0xcdf5b18 , request=3Drequest@entry=3D0xf3c711a4b000,=20 allow_oob=3Dallow_oob@entry=3Dfalse, cur_mon=3Dcur_mon@entry=3D0x0) at = ../qapi/qmp-dispatch.c:220 #5 0x000000000cd36524 in process_event (opaque=3D0xf3c711a79000, obj=3D0xf= 3c711a4b000, err=3D0x0) at ../qga/main.c:677 #6 0x000000000cd526f0 in json_message_process_token (lexer=3Dlexer@entry= =3D0xf3c711a79018, input=3D0xf3c712072480,=20 type=3Dtype@entry=3DJSON_RCURLY, x=3D28, y=3D1) at ../qobject/json-stre= amer.c:99 #7 0x000000000cd93860 in json_lexer_feed_char (lexer=3Dlexer@entry=3D0xf3c= 711a79018, ch=3D125 '}', flush=3Dflush@entry=3Dfalse) at ../qobject/json-lexer.c:313 #8 0x000000000cd93a00 in json_lexer_feed (lexer=3Dlexer@entry=3D0xf3c711a7= 9018,=20 buffer=3Dbuffer@entry=3D0xffffff922d10 "{\"execute\":\"guest-set-time\"= }\n", size=3D) at ../qobject/json-lexer.c:350 #9 0x000000000cd5290c in json_message_parser_feed (parser=3Dparser@entry= =3D0xf3c711a79000,=20 buffer=3Dbuffer@entry=3D0xffffff922d10 "{\"execute\":\"guest-set-time\"= }\n", size=3D) at ../qobject/json-streamer.c:121 #10 0x000000000cd361fc in channel_event_cb (condition=3D, da= ta=3D0xf3c711a79000) at ../qga/main.c:703 #11 0x000000000cd3710c in ga_channel_client_event (channel=3D, condition=3D, data=3D0xf3c711b2d300) at ../qga/channel-posix.c:94 #12 0x0000f3c7120d9bec in g_main_dispatch () from /usr/pkg/lib/libglib-2.0.= so.0 #13 0x0000f3c7120dd25c in g_main_context_iterate_unlocked.constprop () from= /usr/pkg/lib/libglib-2.0.so.0 #14 0x0000f3c7120ddbf0 in g_main_loop_run () from /usr/pkg/lib/libglib-2.0.= so.0 #15 0x000000000cda00d8 in run_agent_once (s=3D0xf3c711a79000) at ../qga/mai= n.c:1522 #16 run_agent (s=3D0xf3c711a79000) at ../qga/main.c:1559 #17 main (argc=3D, argv=3D) at ../qga/main.c:= 1671 (gdb)=20 The commandline options used on the host machine... qemu-system-aarch64 \ -machine type=3Dvirt,pflash0=3Drom \ -m 8G \ -cpu host \ -smp 8 \ -accel hvf \ -device virtio-net-pci,netdev=3Dunet \ -device virtio-blk-pci,drive=3Dhd \ -drive file=3Dnetbsd.qcow2,if=3Dnone,id=3Dhd \ -netdev user,id=3Dunet,hostfwd=3Dtcp::2223-:22 \ -object rng-random,filename=3D/dev/urandom,id=3Dviornd0 \ -device virtio-rng-pci,rng=3Dviornd0 \ -serial mon:stdio \ -display none \ -blockdev node-name=3Drom,driver=3Dfile,filename=3D/opt/homebrew/Cellar/= qemu/9.0.2/share/qemu/edk2-aarch64-code.fd,read-only=3Dtrue \ -chardev socket,path=3D/tmp/qga_netbsd.sock,server=3Don,wait=3Doff,id=3D= qga0 \ -device virtio-serial \ -device virtconsole,chardev=3Dqga0,name=3Dorg.qemu.guest_agent.0 This patch rectifies the operator precedence while assigning the NUL terminator. Signed-off-by: Sunil Nimmagadda diff --git a/qga/commands-posix.c b/qga/commands-posix.c index c2bd0b4..bb41fa9 100644 Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Konstantin Kostiuk --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -85,7 +85,7 @@ static ssize_t ga_pipe_read_str(int fd[2], char **str) *str =3D g_realloc(*str, len + n + 1); memcpy(*str + len, buf, n); len +=3D n; - *str[len] =3D '\0'; + (*str)[len] =3D '\0'; } close(fd[0]); fd[0] =3D -1;