From nobody Mon Feb 9 10:57:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1527816849642739.2050366061497; Thu, 31 May 2018 18:34:09 -0700 (PDT) Received: from localhost ([::1]:46912 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fOYxE-0007N6-Ms for importer@patchew.org; Thu, 31 May 2018 21:34:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fOYqu-0002xW-2B for qemu-devel@nongnu.org; Thu, 31 May 2018 21:27:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fOYqt-0002vY-9C for qemu-devel@nongnu.org; Thu, 31 May 2018 21:27:36 -0400 Received: from mail-qt0-x230.google.com ([2607:f8b0:400d:c0d::230]:34667) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fOYqt-0002v8-4X for qemu-devel@nongnu.org; Thu, 31 May 2018 21:27:35 -0400 Received: by mail-qt0-x230.google.com with SMTP id m5-v6so30317154qti.1 for ; Thu, 31 May 2018 18:27:35 -0700 (PDT) Received: from localhost.localdomain (96-86-104-61-static.hfc.comcastbusiness.net. [96.86.104.61]) by smtp.gmail.com with ESMTPSA id o68-v6sm2003842qkc.19.2018.05.31.18.27.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 31 May 2018 18:27:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juliacomputing-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=p8zPs4iWTBqjU8a4XjcsjIL6xqMmB1ONcP18/0NsEPI=; b=haEROXKepbNQ0/kPX20txeZz0n8kNfdWRo1TSM925Hz+UGXrZ5im7JFecePqxdilUd PvTBsq8OXop6/e1rUBMyRmzVufIiupHeOa5BAj8LKu3ulOV4IxiwsEo4M4Jq33UXqkJw GtGSVlCR5+mJqrHj1bP05hcMegT+7YuJTMf4Z7C9JyPx+U4LIg+kuMcdZBa/vkxPm6dK BhBYuGAQyFzmIXsdCi4SkhNLN4EZI9421xMCzj7uasG+H7R0uH0wZC5ZAaMu5Xe06Kp6 5jC4qaWIwhIwOxgla1tdDPciNQNN/5i6xqE4JV3asZT0CyCwPkBGhMFWDyqR6bAgGH3J OqjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=p8zPs4iWTBqjU8a4XjcsjIL6xqMmB1ONcP18/0NsEPI=; b=XrONBQJ0Yk83aNKbY/65BvFJskSBTlQbqWoG4TSN3T5mf7XwxJBhYRq7Tm1PYGW8Tq x2rmsHXqrpdp6GW8jcwQ462pJ5MqYwhKXiPaoRU0TKS4Vodm2I1FuQFqYOF/GITo80yX l6QVH0eBzWBfN/OK0+J5ClTb7FoadvW4QhglBFvTTfcmZxD2unwmeXbK8WkzNc7xSsTM EOt8g7n0p+XAhUClE7vpvnRRz1FJpnKzDWns3YJVrhW639Jl6fPmId8jSDSZWrz+wB2o UB6gu8wlK0NNiWYYyXmU/XFvElTeLzebdMdK5yHd0g3VP+pDlzVQjnxVF0Tjzj3jiUw0 ExGw== X-Gm-Message-State: APt69E1rp/s3ZRpOhet8eZ6ap4TB0sVM4h450WeWSE/eRmuOJjvuL8lR E62/jNmnF8LBj0IPL8DEDL5pbXeP5gE= X-Google-Smtp-Source: ADUXVKJYvRkuSUicAa8EZ67L86ZsgqP+eHt7EhRSO48IgSulmgzQDHRw0WwOGClk8RKSp+jVP5cTNA== X-Received: by 2002:aed:3d92:: with SMTP id i18-v6mr9169763qtf.149.1527816454226; Thu, 31 May 2018 18:27:34 -0700 (PDT) From: Keno Fischer To: qemu-devel@nongnu.org Date: Thu, 31 May 2018 21:26:00 -0400 Message-Id: X-Mailer: git-send-email 2.8.1 In-Reply-To: References: In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::230 Subject: [Qemu-devel] [PATCH v2 05/20] 9p: Properly set errp in fstatfs error path X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keno Fischer , groug@kaod.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" In the review of 9p: Avoid warning if FS_IOC_GETVERSION is not defined Grep Kurz noted this error path was failing to set errp. Fix that. Signed-off-by: Keno Fischer --- Changes since v1: New patch hw/9pfs/9p-local.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c index adc169a..576c8e3 100644 --- a/hw/9pfs/9p-local.c +++ b/hw/9pfs/9p-local.c @@ -1420,6 +1420,8 @@ static int local_init(FsContext *ctx, Error **errp) */ if (fstatfs(data->mountfd, &stbuf) < 0) { close_preserve_errno(data->mountfd); + error_setg_errno(errp, errno, + "failed to stat file system at '%s'", ctx->fs_root); goto err; } switch (stbuf.f_type) { --=20 2.8.1