From nobody Mon Feb 9 22:37:56 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@gnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1506731208377485.3808632338971; Fri, 29 Sep 2017 17:26:48 -0700 (PDT) Received: from localhost ([::1]:37515 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dy5cC-0001Si-F8 for importer@patchew.org; Fri, 29 Sep 2017 20:26:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dy5V5-0003nS-7h for qemu-devel@nongnu.org; Fri, 29 Sep 2017 20:19:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dy5V1-0004J4-Ss for qemu-devel@nongnu.org; Fri, 29 Sep 2017 20:19:23 -0400 Received: from mail-by2nam03on0079.outbound.protection.outlook.com ([104.47.42.79]:31088 helo=NAM03-BY2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dy5V1-0004IA-H0 for qemu-devel@nongnu.org; Fri, 29 Sep 2017 20:19:19 -0400 Received: from BN6PR02CA0036.namprd02.prod.outlook.com (10.173.146.150) by BLUPR0201MB1924.namprd02.prod.outlook.com (10.162.239.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Sat, 30 Sep 2017 00:19:17 +0000 Received: from CY1NAM02FT026.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::200) by BN6PR02CA0036.outlook.office365.com (2603:10b6:404:5f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.9 via Frontend Transport; Sat, 30 Sep 2017 00:19:17 +0000 Received: from xsj-pvapsmtpgw01 (149.199.60.83) by CY1NAM02FT026.mail.protection.outlook.com (10.152.75.157) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.56.11 via Frontend Transport; Sat, 30 Sep 2017 00:19:15 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1dy5Uw-00082H-SN; Fri, 29 Sep 2017 17:19:14 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1dy5Uw-0006u8-Nn; Fri, 29 Sep 2017 17:19:14 -0700 Received: from xsj-pvapsmtp01 (smtp.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id v8U0JC3g000367; Fri, 29 Sep 2017 17:19:12 -0700 Received: from [172.19.2.220] (helo=localhost.localdomain) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1dy5Uu-0006tt-3f; Fri, 29 Sep 2017 17:19:12 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=jW8XOD1xMUm4KXh7sr+Lal3Xr0JBadFOotfT74psJbA=; b=RJBicvW+VuqWBMkJQP/HEwH3MF6u9lIlg3rvJSxZIjtIoY56AArRE13LoTavPBOYSfCFq1KTApO/zJxqB/0FQqvK7pu+HHjIbnQtt5561WzYl1NJ2J3Fne8KgRPPXRGQhXilpxP+RxI5u2R3oZbPjdAhPnhOxqdYC5AYbJvWEkM= Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@gnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; From: Alistair Francis To: Date: Fri, 29 Sep 2017 17:15:25 -0700 Message-ID: X-Mailer: git-send-email 2.11.0 In-Reply-To: References: X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23358.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(376002)(346002)(2980300002)(438002)(199003)(189002)(81166006)(97736004)(50226002)(316002)(77096006)(356003)(33646002)(36386004)(36756003)(81156014)(53936002)(8676002)(16586007)(478600001)(47776003)(189998001)(106002)(5003940100001)(9786002)(54906003)(118296001)(50986999)(6666003)(2906002)(76176999)(305945005)(39060400002)(4326008)(106466001)(50466002)(2351001)(2950100002)(5660300001)(48376002)(63266004)(8936002)(6916009)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0201MB1924; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; PTR:ErrorRetry; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; CY1NAM02FT026; 1:u6hLnuqnvqAUKLKaW2Hi73jiJRHIUphcAE2441iNgkm/Grc/X8UPJAn4a3gk6V9s09cUk3xsPIH+OWGdYqcliIv7itKWX1uJYpO5GgLqmlnpuTezBQrMtvMaBVqMurO7 MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7cbfc4cc-d672-4b05-a7a7-08d50798e269 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(8251501002)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:BLUPR0201MB1924; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0201MB1924; 3:RWqrKgxHiwefo+hMwfKqyehGUBFStTYQEbAazIXWGVbZPBcR9hzZUrZzDmj/NbQ0Glz4YFdu1HkGd98LmdHe3QUqUqqmTTELGm77sYCfEPz3qFMGj0wFccHwFUawbn0RgIzaxgIgcBe/q8uZn0CynmNr85+wfKpnG/f6n09W64LrQbBgQ/WJBZx8lQSu7M11onOYfZFgQdWe6MgXZ+o+C6KHQFs/13qVi6Vb+FHyLKKlvMiCu1mvfB7DHZyJ2U2CKEo9XnisXo4+eV2F2CpFZ9D3fc1qUJtUYSLE1M6iTDsHkAeUSRSMHzNxYqluVeChvpqaEZ4QbKT3gfBu/5pf8Ca1jgMVMqx9UycGdpTlgYI=; 25:oWLhE6S8aNl0pVLL/qZ5i5Ubsss2lvSSte7K4xai9rKQ7OsAbf4TBEGTUZA3Et07o1dPrhBWIHIYz1rjHZ3SKTQzgDMPn8hewShxD4swRdr46dnME4vnS+U2RSKKbLKTEXxkEQ39sUss5h9m7S+qBmrsm2MOqJTTIpTNd5h0dwZBzk6rZ6FWmeAuqyFiT4OqFhLpFslCC1aLohLqh3hIqqQw5Ta/wH5BfRmFhAVZ8VIO9HlnGxQWPCZrTR2iKDHXNXWQ6Yp+iNfFiRBoYNXRKuI2TRrdNtvliTJDRfFwtuBXKoOcRuDjTHQOecLvU29lvaKNv8Lyf13H8q6/jdfcxA== X-MS-TrafficTypeDiagnostic: BLUPR0201MB1924: X-Microsoft-Exchange-Diagnostics: 1; BLUPR0201MB1924; 31:aQeYgZbP/jXZWi47xUWciVkRZyQHPrVnAA2NKJDFkDuftegiRiXEgWT9chdr1yA2kecUYuXvBDLZCIARjOxKVbslJ1pKakLwscubIp6YK2+XAg1FA9KodZ+QeT5biSWQkAlvzBXQILd5jrId+gXYoqPLen5gyBKw7VbLRw2y8pgIUYXbnsNYYOhZmwjnucFl9ZdaH2pBXAzN00IfNykKOzMCNpxfgyV2tu1MtG8q7Ig=; 20:WwttJdR6MnxNe7j1vJOkM8DfZQ7ULHqFlA29EZTWhOnZ79axMpxNnhIUe9tfzJlcIKVG7qnH2Q4Hi8ypMCHmljGXJ6FLueumJQMXjW6u0N/KTsJqJE4hZan8RN1UrZTrRG4R0T76bcLvTFgKGmiLpgJNmloy9XrIs7flVnqI7DLegEHQQxsXjTPQevk6tLbDczZj+zI02iofGWIFChGQiPmLLYejMpuqbIvs3sGR8Om31LhHYBLjUorwRaE44ahccWDKUTL0+XzmdVrKgCWaRkP33U46aZLQx4+7rbcK3BuHKig3jXECHCA/plNuftk13OPvNApjckuFRDon57nbjRd/5EYVHJz/2aK3mxUIGh3cS+xEk06GtN95/IaHJmQmTliF75n1OW2fcWdUeavLcHkxXqo1Esit9SuRFZ+ZRpu7GH5iP4Fwj/KdM8k3LqHIaDb9oLxjuM98Bo+7geiY56qhN50jekdSb9M2QVJpPCrB4TmOyGmVcqHRkFdr1Pd4 X-Exchange-Antispam-Report-Test: UriScan:(788757137089)(192813158149592); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93004095)(6055026)(6041248)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BLUPR0201MB1924; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BLUPR0201MB1924; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0201MB1924; 4:NBgefL9FMwxlRXj9BZJYvX7xKJLuT0StJ4r/iu16mT8pGR4cE3N1OvPQ0FRO82APoKZXzMXekCaY2VEJYgYVaiuRmoRzfDPUOR3+jeTkzg6Zi6aXnMR/S4ifSeMBCs0brkUf9GH0rmzcd/K5G+e8UbH9w8mC6IxlMYruVkDx5b4pmwpmERCkehXU7pSTqGS8eIAc90gUAP1IUcSNnqizifN2bXs2XhxyAIv0nWhb4bXuu/8pv5GKtNGuIeeN2UELIHlCzCuybhwc7u9F4z3Y52WruUvVofQBro4opEvcTfG5Odupeclg85JLNAxl7j+r+2HLStOMRqqbjbDuArraUA== X-Forefront-PRVS: 0446F0FCE1 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0201MB1924; 23:7ziPB/vQDplW56MAbv9jgGzHboSt1fEim4QP7SM?= =?us-ascii?Q?L182IErajbTwqvZN1td8hLkH93O3aVJRjK9F38owYh0+qRswY6//kQZQlyPp?= =?us-ascii?Q?CWuubrhc4mcgQom1HXhrlQh9XrPmnlRpSOZXWPPHG02BGKE8Ncjn0BhdCIGX?= =?us-ascii?Q?cUJvhfZIVRVlmZmD7GeUcSO7/xUoCiqDu1r/8rxoAq5BjXxFaQ5Hd2lij4h0?= =?us-ascii?Q?CHHzz5No9g2KTw8Qf9R8BatZo9/I7BrNh8UYcjdVt9Sc3/KxtSneVaJEsrUR?= =?us-ascii?Q?nkw1GDUT24UrRw/yWkvFgi9eCxxL5dm36bosX/aLb/XvXgpSivWMmfYWXu/U?= =?us-ascii?Q?eIk0DYCoiERtjT1BOWU/WqLYAsyVB494TbbRuiH5xPmE0E4XtxgoCYFqTer8?= =?us-ascii?Q?xT4EXY1RUckK4GHKQ3sjvWpU8v7M1fbZIiZX7Ne8hMbyzCfy1TkwegwaS1qP?= =?us-ascii?Q?fH3z5S7YhAlzieJQHa/wpMOkn0PQUGJ8ElM4gnUux+L2TqKijfCWfskyW0GR?= =?us-ascii?Q?8nM5uEkWbl8OMfBxupt1soRVgc57wDpw3bZG9pNJFRI//vIoBUiRIsopiZb9?= =?us-ascii?Q?7vAxYZSqN4UYhgxK007+z7KhhSunRVANkgIrUPHa+8wlGXO9gFR5kRxQP4BD?= =?us-ascii?Q?oVDLdl1LekciXE3X1z7SljI6erBxOvqc46HaTJ0zeTUPZIq1v0O6kwZELIrj?= =?us-ascii?Q?EUqFDUHfdbpUu/4a18kndXVnajpNqqJY1vIGkXj+vKQeU+eTJebu1qQxG0xp?= =?us-ascii?Q?iH4IBbUH0m42OY20l+LcjurNyHEPkOu+wHXHOxpnsn1Q9s9DkxM/Bf8XenlF?= =?us-ascii?Q?plWC6yBRPKvm3JyqWxJMfCWxznSP7hSedNwvqocNojZtb6F+C09t3W0FCv/u?= =?us-ascii?Q?HobOOucZZwufjXhkSejTc7Lcin4IqA1xgpQs3n+d0s9ZZvjceZn9ZsrFUbk7?= =?us-ascii?Q?iYot/yrsMncHLICAdgRQKVQlArgOOkW49r7IX/BmgqJCaqxpMHI7ZA0be/me?= =?us-ascii?Q?i07vXDBV1KcGg/aXQMkjgME5EaCuk0jBDXNzTtq0wsUGxNcGVMSWGUEHSJyS?= =?us-ascii?Q?sXAwjQWTVR1qJa5DoPbAhkfo0jkTMnRFP48uUOA9p65WbKdfoqQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0201MB1924; 6:+75wpW2l91EEORh1zr2S9EX2+cddfZd9CxBMzLAaikG42j1NVpCG09HcAOiOTn8Q+fG6SNAMQ2pS2bYl6qHFdAXnFXNK+NUnI8rbsb8OZ/zGpAV/AE1mOghY84p8HfHNarm0b2WO0FDpoa1+yrM8OMEoATqwDwsgRajym8MNO4oh6WyuETyVEhdVJ/Sw52igTjVIlEVfZ9EGnQj3AmLOfcHFH4AhEQWf4+VHgsQHmALMWT3FymhIhpOAlT58JznVCp5QaMV0NByVFf98Li82TBYRYwupExnPe9HjkZvpd3puA4FCUViYwz2vdko2tJ2XBIfo6ZHCgBJmDi9SKSAYsg==; 5:Y7za+Ew08fef0eO0QBKCNWYOT1iyEp82Wt3SOa5ecStL/tWDUf6idg61tXO1WQ5JemRrS3/9jkTBaS1Txno60mTweopY1atn6i3vhiuuKsP9wH2jIed9JrjlFMXTEvN71tIZfTZegWuQ3JQ5saSQ/A699/TE+Od0AVecS3r6NwM=; 24:kYW/+z5V4opsLnxT7u8y2G1FQjMcHlHI0fSf75ge9VG2uavYJ3KLGTUfLTFR6v9bWr70lmRMiIeJRwoyDv8lZlF4Sgswz2Env823du/udpo=; 7:g5hpUzkN2z4vTboaHp1W3BHLoke5SEVs5wAQNTApHekUatRvK3qGW47A4HRUvWIz3aigCv208XKFZzgx5agx8BXSzEbVekxt9rbh8JXMt/tIfS/Yfn49/hc71/CmepPOd5tmgsvOCUPiRbTJLdRC4COkZNeqy6IFBvJlUz0Gf9s3jE/LEvAUJpmfatsfj25k52X8iLVsGqUdvYZTm6bN5h+uFBkGdAHe5naBi1IkBkM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2017 00:19:15.4197 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0201MB1924 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.42.79 Subject: [Qemu-devel] [PATCH v2 08/47] hw/char: Replace fprintf(stderr, "*\n" with error_report() X-BeenThere: qemu-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair23@gmail.com, Paolo Bonzini , armbru@redhat.com, alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@gnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_= report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_re= port("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report= ("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("= \1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1= "\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\= 2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2)= ;|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|= Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig= }' \ {} + find ./* -type f -exec sed -i \ 'N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}'= \ {} + find ./* -type f -exec sed -i \ 'N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + Some lines where then manually tweaked to pass checkpatch. Signed-off-by: Alistair Francis Cc: Paolo Bonzini --- V2: - Split hw patch into individual directories hw/char/exynos4210_uart.c | 6 +++--- hw/char/mcf_uart.c | 5 +++-- hw/char/sh_serial.c | 9 +++++---- 3 files changed, 11 insertions(+), 9 deletions(-) diff --git a/hw/char/exynos4210_uart.c b/hw/char/exynos4210_uart.c index 3957e78abf..a388f01a23 100644 --- a/hw/char/exynos4210_uart.c +++ b/hw/char/exynos4210_uart.c @@ -296,7 +296,7 @@ static void exynos4210_uart_update_irq(Exynos4210UartSt= ate *s) qemu_irq_raise(s->irq); =20 #if DEBUG_IRQ - fprintf(stderr, "UART%d: IRQ has been raised: %08x\n", + error_report("UART%d: IRQ has been raised: %08x", s->channel, s->reg[I_(UINTP)]); #endif =20 @@ -388,7 +388,7 @@ static void exynos4210_uart_write(void *opaque, hwaddr = offset, * qemu_chr_fe_write and background I/O callbacks */ qemu_chr_fe_write_all(&s->chr, &ch, 1); #if DEBUG_Tx_DATA - fprintf(stderr, "%c", ch); + error_report("%c", ch); #endif s->reg[I_(UTRSTAT)] |=3D UTRSTAT_TRANSMITTER_EMPTY | UTRSTAT_Tx_BUFFER_EMPTY; @@ -400,7 +400,7 @@ static void exynos4210_uart_write(void *opaque, hwaddr = offset, case UINTP: s->reg[I_(UINTP)] &=3D ~val; s->reg[I_(UINTSP)] &=3D ~val; - PRINT_DEBUG("UART%d: UINTP [%04x] have been cleared: %08x\n", + PRINT_DEBUG("UART%d: UINTP [%04x] have been cleared: %08x", s->channel, offset, s->reg[I_(UINTP)]); exynos4210_uart_update_irq(s); break; diff --git a/hw/char/mcf_uart.c b/hw/char/mcf_uart.c index 56fa402b58..14cb051be9 100644 --- a/hw/char/mcf_uart.c +++ b/hw/char/mcf_uart.c @@ -6,6 +6,7 @@ * This code is licensed under the GPL */ #include "qemu/osdep.h" +#include "qemu/error-report.h" #include "hw/hw.h" #include "hw/sysbus.h" #include "hw/m68k/mcf.h" @@ -174,7 +175,7 @@ static void mcf_do_command(mcf_uart_state *s, uint8_t c= md) mcf_uart_do_tx(s); break; case 3: /* Reserved. */ - fprintf(stderr, "mcf_uart: Bad TX command\n"); + error_report("mcf_uart: Bad TX command"); break; } =20 @@ -189,7 +190,7 @@ static void mcf_do_command(mcf_uart_state *s, uint8_t c= md) s->rx_enabled =3D 0; break; case 3: /* Reserved. */ - fprintf(stderr, "mcf_uart: Bad RX command\n"); + error_report("mcf_uart: Bad RX command"); break; } } diff --git a/hw/char/sh_serial.c b/hw/char/sh_serial.c index 835b5378a0..7bb3f3c70b 100644 --- a/hw/char/sh_serial.c +++ b/hw/char/sh_serial.c @@ -25,6 +25,7 @@ * THE SOFTWARE. */ #include "qemu/osdep.h" +#include "qemu/error-report.h" #include "hw/hw.h" #include "hw/sh4/sh.h" #include "chardev/char-fe.h" @@ -190,8 +191,8 @@ static void sh_serial_write(void *opaque, hwaddr offs, } } =20 - fprintf(stderr, "sh_serial: unsupported write to 0x%02" - HWADDR_PRIx "\n", offs); + error_report("sh_serial: unsupported write to 0x%02" + HWADDR_PRIx "", offs); abort(); } =20 @@ -290,8 +291,8 @@ static uint64_t sh_serial_read(void *opaque, hwaddr off= s, #endif =20 if (ret & ~((1 << 16) - 1)) { - fprintf(stderr, "sh_serial: unsupported read from 0x%02" - HWADDR_PRIx "\n", offs); + error_report("sh_serial: unsupported read from 0x%02" + HWADDR_PRIx "", offs); abort(); } =20 --=20 2.11.0