From nobody Wed Nov 19 00:16:26 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1613442039; cv=none; d=zohomail.com; s=zohoarc; b=exUailcFRADiG6fe1FEinu2lMP4FZj5oJgXX6SkC2XFnfoBYZErjUTdECfYvR8e9qXVZ1AXpbvN7kJkXfLxUZupiIhMw0iwMzNc+pmVezYvAxVwCM9Ho30WQv95TIw0aiGn8vhuLWFDJwYHKT8egTxqyeaf0ZQqx7W5F35xCuuU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613442039; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=l2smH8LbyGI/i6R6RAa78VM1Dua9VOEMmu0wn60S3XA=; b=VdeoFHVUOIfUSHCeC5/p1Vvfm7hJGFmoWrQ3ncBU2uwMKB6edIYQN1HRvttOK7qBBfJPfoyblkV6m/5a+n9Ursh2Yk/UuPwY0sLXPzNzuxSt5Y7g0aNJQdbDE/wXjP3HM09IhC6V4Wv+ynr0IHmiUE0656hGu1QZWLBJ0H6AAlA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1613442039758236.4266763881152; Mon, 15 Feb 2021 18:20:39 -0800 (PST) Received: from localhost ([::1]:41188 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBpyg-0002x5-Iv for importer@patchew.org; Mon, 15 Feb 2021 21:20:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBptE-0005vo-DY for qemu-devel@nongnu.org; Mon, 15 Feb 2021 21:15:00 -0500 Received: from mga17.intel.com ([192.55.52.151]:25635) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBptC-0001ZH-QC for qemu-devel@nongnu.org; Mon, 15 Feb 2021 21:15:00 -0500 Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2021 18:14:51 -0800 Received: from ls.sc.intel.com (HELO localhost) ([143.183.96.54]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2021 18:14:51 -0800 IronPort-SDR: f2yqq0ViZHTh2sQVKmmexwhgoPuUe1fJ1rT1ezpUHpzkTWrhgpHJE2w4sxaAuWjm2Dg8jrQcAe /Kb9uQ3oR/ng== X-IronPort-AV: E=McAfee;i="6000,8403,9896"; a="162558756" X-IronPort-AV: E=Sophos;i="5.81,182,1610438400"; d="scan'208";a="162558756" IronPort-SDR: x998+QN+qsZQSDZtQ8EZL80B4rh+IhI/vkQfEaN30yn/Zy6zy6KpWrvRvxdKIOr71I+VRwFkyF rBBFk+x65wpQ== X-IronPort-AV: E=Sophos;i="5.81,182,1610438400"; d="scan'208";a="591705401" From: Isaku Yamahata To: qemu-devel@nongnu.org, pbonzini@redhat.com, alistair@alistair23.me, ehabkost@redhat.com, marcel.apfelbaum@gmail.com, mst@redhat.com, cohuck@redhat.com, mtosatti@redhat.com, xiaoyao.li@intel.com, seanjc@google.com Subject: [RFC PATCH 07/23] i386/kvm: Squash getting/putting guest state for TDX VMs Date: Mon, 15 Feb 2021 18:13:03 -0800 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.55.52.151; envelope-from=isaku.yamahata@intel.com; helo=mga17.intel.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: isaku.yamahata@intel.com, Sean Christopherson , isaku.yamahata@gmail.com, kvm@vger.kernel.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Sean Christopherson Ignore get/put state of TDX VMs as accessing/mutating guest state of producation TDs is not supported. Allow kvm_arch_get_registers() to run as normal, except for MSRs, for debug TDs, and silently ignores attempts to read guest state for non-debug TDs. Signed-off-by: Sean Christopherson --- target/i386/kvm/kvm.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index ab7a896bd2..9c5f669b7c 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -2565,6 +2565,11 @@ void kvm_put_apicbase(X86CPU *cpu, uint64_t value) { int ret; =20 + /* TODO: Allow accessing guest state for debug TDs. */ + if (vm_type =3D=3D KVM_X86_TDX_VM) { + return; + } + ret =3D kvm_put_one_msr(cpu, MSR_IA32_APICBASE, value); assert(ret =3D=3D 1); } @@ -4019,6 +4024,11 @@ int kvm_arch_put_registers(CPUState *cpu, int level) =20 assert(cpu_is_stopped(cpu) || qemu_cpu_is_self(cpu)); =20 + /* TODO: Allow accessing guest state for debug TDs. */ + if (vm_type =3D=3D KVM_X86_TDX_VM) { + return 0; + } + /* must be before kvm_put_nested_state so that EFER.SVME is set */ ret =3D kvm_put_sregs(x86_cpu); if (ret < 0) { @@ -4129,9 +4139,11 @@ int kvm_arch_get_registers(CPUState *cs) if (ret < 0) { goto out; } - ret =3D kvm_get_msrs(cpu); - if (ret < 0) { - goto out; + if (vm_type !=3D KVM_X86_TDX_VM) { + ret =3D kvm_get_msrs(cpu); + if (ret < 0) { + goto out; + } } ret =3D kvm_get_apic(cpu); if (ret < 0) { --=20 2.17.1