From nobody Fri Dec 19 20:16:40 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1508431948408521.7653412050972; Thu, 19 Oct 2017 09:52:28 -0700 (PDT) Received: from localhost ([::1]:50229 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e5E3I-00069Q-K8 for importer@patchew.org; Thu, 19 Oct 2017 12:52:12 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e5Da3-0005pp-Ow for qemu-devel@nongnu.org; Thu, 19 Oct 2017 12:22:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e5Da0-00024g-I0 for qemu-devel@nongnu.org; Thu, 19 Oct 2017 12:21:59 -0400 Received: from mail-dm3nam03on0069.outbound.protection.outlook.com ([104.47.41.69]:51760 helo=NAM03-DM3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e5Da0-00024O-AY for qemu-devel@nongnu.org; Thu, 19 Oct 2017 12:21:56 -0400 Received: from MWHPR02CA0015.namprd02.prod.outlook.com (10.168.209.153) by DM5PR02MB3385.namprd02.prod.outlook.com (10.164.152.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Thu, 19 Oct 2017 16:21:54 +0000 Received: from CY1NAM02FT031.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::208) by MWHPR02CA0015.outlook.office365.com (2603:10b6:300:4b::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7 via Frontend Transport; Thu, 19 Oct 2017 16:21:53 +0000 Received: from xsj-pvapsmtpgw02 (149.199.60.100) by CY1NAM02FT031.mail.protection.outlook.com (10.152.75.180) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Thu, 19 Oct 2017 16:21:53 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:38875 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1e5DZw-0007xy-Lt; Thu, 19 Oct 2017 09:21:52 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1e5DZw-0003B2-II; Thu, 19 Oct 2017 09:21:52 -0700 Received: from xsj-pvapsmtp01 (mailhub.xilinx.com [149.199.38.66]) by xsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id v9JGLks9018132; Thu, 19 Oct 2017 09:21:46 -0700 Received: from [172.19.2.220] (helo=localhost.localdomain) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1e5DZq-0003AC-8w; Thu, 19 Oct 2017 09:21:46 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=m9eVTZWUyII8KpWXEkcWTmrRnh/jAXyIB/CglQP+I3k=; b=l3VBug4oWzpV0uC6gXtN6LbB1UaVduLbObNI6pwQ2LSYO+aYrvhiSBRS+MXRYZNZ0/YZ8Hm+LI3T30sSTKooq3IQ1gTBkogYC8kgszqyRWPEVpBihDk4Zbj9+wvUbe466qyoAmhDn7FgoqGAzYFQf0i9FaC/lIFVuUTfHPsj/j0= Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; From: Alistair Francis To: Date: Thu, 19 Oct 2017 09:17:43 -0700 Message-ID: X-Mailer: git-send-email 2.11.0 In-Reply-To: References: X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23404.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(346002)(39860400002)(376002)(2980300002)(438002)(189002)(199003)(8936002)(33646002)(106466001)(36756003)(5003940100001)(36386004)(5660300001)(189998001)(4326008)(118296001)(81166006)(47776003)(8676002)(81156014)(63266004)(16586007)(9786002)(2351001)(356003)(106002)(316002)(6916009)(77096006)(575784001)(50226002)(50986999)(2950100002)(48376002)(76176999)(54906003)(2906002)(478600001)(6666003)(305945005)(39060400002)(50466002)(107986001)(5001870100001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR02MB3385; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; CY1NAM02FT031; 1:7OYs5N+jCrfeb/9Qgx3V/9iUoNpvoCwV1pWBcx6RL3oTW4jw//U0u9IkBfi+yoG027/O/A/ZgIXZG/5C7/6v5mSx3zVUA1EnZDA4Uo3/I/BQ+BMdHuMoGwQsXWswVr6/ MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 36c3b2df-031b-48e8-a1af-08d5170d829b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(8251501002)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:DM5PR02MB3385; X-Microsoft-Exchange-Diagnostics: 1; DM5PR02MB3385; 3:vLxmZcSl/dO+CsnM0z5+R2Dfdo1+BLWe93cINLrU3ow+53l1Oz0wyEL20xHZzdBA32oExkE7mzTYKV9q/oB3ZyPNIMGss51H7Nwkcd26Lk7Cm5zQxukfKlMUA8L+u8hTYeA1A2BcVjp5sW9uEsCYoigu7+AW00zV9uvhQcwcseW0QkrIwudAu18PXdADhcra07lPbsxTP9dXbzMHP73I9nc2872+PIP+8roW85k2Sw9OQwx12/1Wrh/lPKjfA+kEUEuSuBXYja1yaPGL5TpxK0c7lADkE79Ob0QuPZEz6stOzChAM4D3L7bT24/ntJkqcmDilbBrPzknTJa+r27JU6PTNgxXmzLdGKoAds1igGE=; 25:sfqgIDlaa9R0WEi0mE2xMhCnevyePH55ynoioSlCYGc89npVtwO4fLpCcpH9ZzGJ4PYESOh57p9BHiKAReFrGtf6mCfGduWkR+Dmc+b0Jpu692GFC57IxdIpgxBRomJxG4bYLCcmzO8UB8EVJgsBp8NThN7ptcoIcIrIEOJtpTMJ1eiF8BS/m2S4OkRmbLqG1YhanuuSnkt2Yey/mZTfo8xp91eErHTY5E6LyXxEAMV3uhvIAq9Cpaz0zOkrfukuj99235puJVUniTG/C8lpfYS7Jq+pOledMNZSbTY0Dtxg6amIsN2tZzoANAD4QaV6FzrQBDlvJp49jLTavXo1CQ== X-MS-TrafficTypeDiagnostic: DM5PR02MB3385: X-Microsoft-Exchange-Diagnostics: 1; DM5PR02MB3385; 31:jEv2bUF4/L4vJtfXW+pLlXP/7IPIZNfUjKJvkieRjk8uDeN6gI/j3++rR7eagvsuW68oMiUAkXdIkRz1zd0xq/qjvCyLzcgrRaw1oqWOMP455vLOFW9CWE2GIf/0Faekm1/wP4KffXBHcPGp8ZGisQV9jlTvAvDWzgjAP8hAJImp5Jdbfg8tZR1OIk5kVKQprb4pyhOFFYz6Vnz6XLhs3BcaoWZhLohatgBB5Ov0hRM=; 20:WmVn8GKUbg+KFtMOVNze0CznumNnTLU5a3yb3eKIauMyjVN4TwXHdAcCtKAfsVaIMoDG5pC0cv/PrCS7OhbdC+sMZyGl8P/OjPwFvOhVAgb6BXy8HoGFBbQzXBSRAEuPQBPB3UXEFtxWHzc5b/pkjzoxkdmt5nXyZ/H5b8Q04WB9+1Z+l4WlTbtTxLKvtrSEFSy3UO5zpiGLMS9uotTNZVnE2kSdvyw7G0TqpLoOntAm20SW02Km3MD+fRZvQEVcs3/aUa240q7Qef764sFe489dGDZ1DjAQCY5MtrjEXLvjx7dLfJtf9ZvwDcRWCKcYrnVofqDQcQCnGIrV8ZPSgZ9I3zTSvPYF7iR0KA8ZN/ofb6AvUoo9HRD6EsDWSGJ7rDhpg3UCaOfSmdPJVWFO7BZgonvKDGyr17Qr2NktvmAoA06v/dkna0p6s27wBkL6/Fn47XqLpVZ/enYgTejZoidfqhl/oxsuj6UYLCZzYueHrdVnnHCNcA2Fg28AA0pz X-Exchange-Antispam-Report-Test: UriScan:(788757137089)(192813158149592); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(93006095)(93004095)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123558100)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR02MB3385; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR02MB3385; X-Microsoft-Exchange-Diagnostics: 1; DM5PR02MB3385; 4:5NSuddcRys/rWbETFeTJBG6XGDp4Y1r1P+U+Jb2+6go+wEg/8JuciT0a1xgSttl3KAYFGXaKGW9kH5YrHKyKK7wpzaCnAcYDLQxWKnnOvfn4kXsbceqp2uPgopFz7U0HvzRuwniPYYxapETpDH3P/56dv6AaWu3KzdOfOjMV7dK+bY2bcoAkTh0kPc8YO3Vj6uTOUkFbSNEOQU+B5nEIi0bf3KHRfkXLRBciYxW/NGoSLMNrsphyMEfQMuspdzbqkOiqLGY7/vM7l6dms56y9Gs1ooKD12IMUjXyjIObcLmUhLSAFdAFVO1EDaq/64rIT2W3yLPeYJfJgXC8CjTlYA== X-Forefront-PRVS: 0465429B7F X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR02MB3385; 23:iZ3pI9wiyJOBlI+/E9yZbEuA3ZnY0gzOAb2pvHrD6?= =?us-ascii?Q?KcaOudMf6Mzdpg2JyZrArVnqkklnwNlRh+T7lJYs5JuaU/D/IxFXkADxzKSt?= =?us-ascii?Q?5lcig9VCfrpDHs8DkRcJ+ZmwcF/fvHKtJ4OLLBsj8f+sWJuLXfWXeQhuyuy7?= =?us-ascii?Q?D9R5QDgGmjnDTn2KDEsVG6jxGnn2nkan/lEpvna/722rgudCNKp1Krv39ZyE?= =?us-ascii?Q?vdlfb7weJjrJgk3UFKPKFQ6r5WppFhwFpZmVAeN1/RM5/0rrxfIOFkUPiCjH?= =?us-ascii?Q?XMY3jxz2c5u6wjeB0mox3J5JSW4b9q4z+ZkXPwS7Rv5b+OqUKLL6V7msUZP4?= =?us-ascii?Q?5NjBGeyLsfQaPmxq8MketgjwnjPgrj8yzYkP/lWtHS92A0yQmm7r53Yv8oE/?= =?us-ascii?Q?C05pTzY2r4sQIffPW4Br2eRGpYCsBTrnYKdo0pNP3CqpQUzGO6kRDJYQyvjs?= =?us-ascii?Q?kbfow6yhujwC7mGJtGV2fAvMhxHVZiArsZCoJzdDUUWtnOAEJdY8spCshVVZ?= =?us-ascii?Q?ot3jwMku+JJH55Xp2BKclZrzj8tSnXM+mxQO4yJC35pG2qkVvpfgSXyaFEUe?= =?us-ascii?Q?KU7rFyx0Hmxr9UzY4VqAmYwm1DGY2mgPpJ21saVyvIn5hyupQSyP5JSBPMTc?= =?us-ascii?Q?YQPojANhehlpOcmx5KtaRV6pZgQzLah4QZL/NtAlZezjQRORy8SphFCXmPPh?= =?us-ascii?Q?am3bGl6dy16a7gwXG52pI5oXxa6UZAbtR1iENLG8wbz+Cj4aq6gLxF2jQTo6?= =?us-ascii?Q?4b8njlEVgwEp9ihJC5qUN9q8jiKAF97Xgu0NGQFKWW4hFin+wq7LQfVKN8av?= =?us-ascii?Q?FKZmzS0HkYcLYmHnrRdskKBzuZV9X6I36PsjeflcZFN0qYTu8Bn5CPZc0YYc?= =?us-ascii?Q?kpDcbqn822GTNoopnvH+NDf7q8jGj8xR/SE5RTUGdAZAmin3wFz3pTuhk4dS?= =?us-ascii?Q?HGv5T7ULvlMS83/LD6QbnB4Z9cBLLTlasyUXL/hHQk6MqfsAQn61wCsKYIA8?= =?us-ascii?Q?10Cs9Xbw6vYWejkgKm5zDOmbw6rUHNm62f7hzso4Tji1yoXBjtgU+eRozpLq?= =?us-ascii?Q?5Q7tF5vELKealhRXRPLWLCJn6gtGe8adKoU3rICB/UO8o79vg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR02MB3385; 6:XqhmHr5cxFRH2LtE2qTl47/8HbO2nCerEQ/VkLz5tre4kvOi/UxzB75sxS8ghVkBhmX1bK4YxR3GtjwmdgaUzMvQ3rqbilPVR5pcl+LDEOBFLcqQ26tmM74u430FgaAdqSiaoKAy1Yr2rmGO7zfRhNtmT/jYW6cGsN2iKwemSz3UmDJ6/+T3w8roAoCI3jPci030wLCtWbzwHhfaG6nOrgWjsetHwtU744m61geBo2rGnoVEqMh7gHw+/Ph4eWY0m4+nEpZGLlSmKlWeE2WR5Apq8y2Scw3hut0mtAX9BZ22ffxq4SH2dXyBO63X70swVFqRc9vFGsXnEvqy92xJbQ==; 5:Fq5nsJD+Y28UOrlvj5PXnpiN5rc7JnfqrcD/SxkXI7wlkN/5YcFUrOffG6XiAGyzT50kMTo6tSW8ryup30xfKiN7gUc3UfXDYxvRjBF904chGBG3YixWev63VnIuNmQe0OJmRyBlywUhmM8eAEyiOA==; 24:Sgqo5v5yIpN57hrzPBpT+ptOzuojOgqUy9Lbt2sHjysRHHeTXX/CHUf/g+/EvyP7GTDPIAXmMeThqmCCO9FHLBJxbR+9DmKCiPGXmUWH/6Q=; 7:8ghRH54AHR7iNEBqPd5fHGqkJSC9Wq+J5xzzK44bETa7mAm3I2yCoXzIugcYevUwTv3GYx3AIuqsWquBw1c+sBgm6yfxO9Qxxtq8deijhk9vl+QxPMPeiEHU/2BgHfQO3mmHLjNsGL4U8NvTikxf0aMKP4YVD6YoQcEtpRJC523MF2FfIJ5T4sWgH8NAM927vWs6x8JqhLRboQTuGNMyr8FSKOMHb2cZJxD/iAQ40Ww= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2017 16:21:53.3075 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR02MB3385 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.41.69 Subject: [Qemu-devel] [PATCH v3 34/46] hw/sd: Replace fprintf(stderr, "*\n" with error_report() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair23@gmail.com, armbru@redhat.com, alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_6 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_= report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_re= port("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report= ("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("= \1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1= "\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\= 2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2)= ;|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|= Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig= }' \ {} + find ./* -type f -exec sed -i \ 'N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}'= \ {} + find ./* -type f -exec sed -i \ 'N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + Some lines where then manually tweaked to pass checkpatch. Some of the prints in hw/sd/sd.c were manually converted to using DPRINTF() instead. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- V3: - Fixup some DPRINTF() prints being wrong V2: - Split hw patch into individual directories hw/sd/pl181.c | 5 +++-- hw/sd/sd.c | 15 ++++++++------- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/hw/sd/pl181.c b/hw/sd/pl181.c index 55c8098ecd..2b878a0c5e 100644 --- a/hw/sd/pl181.c +++ b/hw/sd/pl181.c @@ -8,6 +8,7 @@ */ =20 #include "qemu/osdep.h" +#include "qemu/error-report.h" #include "sysemu/block-backend.h" #include "sysemu/blockdev.h" #include "hw/sysbus.h" @@ -146,7 +147,7 @@ static void pl181_fifo_push(PL181State *s, uint32_t val= ue) int n; =20 if (s->fifo_len =3D=3D PL181_FIFO_LEN) { - fprintf(stderr, "pl181: FIFO overflow\n"); + error_report("pl181: FIFO overflow"); return; } n =3D (s->fifo_pos + s->fifo_len) & (PL181_FIFO_LEN - 1); @@ -160,7 +161,7 @@ static uint32_t pl181_fifo_pop(PL181State *s) uint32_t value; =20 if (s->fifo_len =3D=3D 0) { - fprintf(stderr, "pl181: FIFO underflow\n"); + error_report("pl181: FIFO underflow"); return 0; } value =3D s->fifo[s->fifo_pos]; diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 35347a5bbc..5d7fa3e418 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -700,7 +700,7 @@ static void sd_lock_command(SDState *sd) sd->card_status &=3D ~CARD_IS_LOCKED; sd->pwd_len =3D 0; /* Erasing the entire card here! */ - fprintf(stderr, "SD: Card force-erased by CMD42\n"); + error_report("SD: Card force-erased by CMD42"); return; } =20 @@ -1282,7 +1282,7 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, return sd_r1; =20 case 56: /* CMD56: GEN_CMD */ - fprintf(stderr, "SD: GEN_CMD 0x%08x\n", req.arg); + error_report("SD: GEN_CMD 0x%08x", req.arg); =20 switch (sd->state) { case sd_transfer_state: @@ -1564,9 +1564,10 @@ send_response: if (rsplen) { int i; DPRINTF("Response:"); - for (i =3D 0; i < rsplen; i++) - fprintf(stderr, " %02x", response[i]); - fprintf(stderr, " state %d\n", sd->state); + for (i =3D 0; i < rsplen; i++) { + DPRINTF(" %02x", response[i]); + } + DPRINTF(" state %d\n", sd->state); } else { DPRINTF("No response %d\n", sd->state); } @@ -1580,14 +1581,14 @@ static void sd_blk_read(SDState *sd, uint64_t addr,= uint32_t len) DPRINTF("sd_blk_read: addr =3D 0x%08llx, len =3D %d\n", (unsigned long long) addr, len); if (!sd->blk || blk_pread(sd->blk, addr, sd->data, len) < 0) { - fprintf(stderr, "sd_blk_read: read error on host side\n"); + error_report("sd_blk_read: read error on host side"); } } =20 static void sd_blk_write(SDState *sd, uint64_t addr, uint32_t len) { if (!sd->blk || blk_pwrite(sd->blk, addr, sd->data, len, 0) < 0) { - fprintf(stderr, "sd_blk_write: write error on host side\n"); + error_report("sd_blk_write: write error on host side"); } } =20 --=20 2.11.0