From nobody Wed Nov 19 13:56:54 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=eik.bme.hu ARC-Seal: i=1; a=rsa-sha256; t=1615945169; cv=none; d=zohomail.com; s=zohoarc; b=TlLYJhOyPOf+7f0wFgCrNQy2RQy7ANEFOBhbtUlCVuiNDbi8MWcolcQA8E0W7z796t+nq8D0d8xrtVI/BQb3tO6M77/C7ULcu2zW31Of2Nqc3XLi8mHrwy65ULgBPd3MBUn/5cs1UmtW9EIrksyi0BV725OtB9Cj01cA5E1L/vE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615945169; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6S5jqHw/Ni3Crqvh5bKjJrUsZkPee+DZO2qjVjateEo=; b=L1FAWnk3eX3c7gESXvcctGLH8V1wkax0JbK3/qzrOaeDrgUNOFtY0GR8+OKzkbjRvRBgdzC/QhSzDsvJEGHUcWWfmFokf/F0psxLsUCoWTuvh0ZdGkAVkp1fw1KHLIJrv9a/pygSs0SCBWc4YfkjgH+ECCPqiwcngqvclxaagiY= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615945169327610.4288845916699; Tue, 16 Mar 2021 18:39:29 -0700 (PDT) Received: from localhost ([::1]:58114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lML9j-0002Da-C8 for importer@patchew.org; Tue, 16 Mar 2021 21:39:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMKyi-0008SB-MP; Tue, 16 Mar 2021 21:28:07 -0400 Received: from zero.eik.bme.hu ([152.66.115.2]:59612) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMKye-0000W6-Rq; Tue, 16 Mar 2021 21:28:04 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 2E74174642A; Wed, 17 Mar 2021 02:27:59 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 86E2B7463B7; Wed, 17 Mar 2021 02:27:51 +0100 (CET) Message-Id: In-Reply-To: References: From: BALATON Zoltan Subject: [PATCH v10 3/7] vt82c686: Introduce abstract TYPE_VIA_ISA and base vt82c686b_isa on it Date: Wed, 17 Mar 2021 02:17:51 +0100 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org X-Spam-Probability: 10% Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=152.66.115.2; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Paolo Bonzini , f4bug@amsat.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" To allow reusing ISA bridge emulation for vt8231_isa move the device state of vt82c686b_isa emulation in an abstract via_isa class. This change breaks migration back compatibility but this is not an issue for Fuloong2E machine which is not versioned or migration supported. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/isa/vt82c686.c | 70 ++++++++++++++++++++++------------------ include/hw/pci/pci_ids.h | 2 +- 2 files changed, 40 insertions(+), 32 deletions(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index b3048fd37e..69f073ec9e 100644 --- a/hw/isa/vt82c686.c +++ b/hw/isa/vt82c686.c @@ -518,24 +518,48 @@ static const TypeInfo vt8231_superio_info =3D { }; =20 =20 -OBJECT_DECLARE_SIMPLE_TYPE(VT82C686BISAState, VT82C686B_ISA) +#define TYPE_VIA_ISA "via-isa" +OBJECT_DECLARE_SIMPLE_TYPE(ViaISAState, VIA_ISA) =20 -struct VT82C686BISAState { +struct ViaISAState { PCIDevice dev; qemu_irq cpu_intr; ViaSuperIOState *via_sio; }; =20 +static const VMStateDescription vmstate_via =3D { + .name =3D "via-isa", + .version_id =3D 1, + .minimum_version_id =3D 1, + .fields =3D (VMStateField[]) { + VMSTATE_PCI_DEVICE(dev, ViaISAState), + VMSTATE_END_OF_LIST() + } +}; + +static const TypeInfo via_isa_info =3D { + .name =3D TYPE_VIA_ISA, + .parent =3D TYPE_PCI_DEVICE, + .instance_size =3D sizeof(ViaISAState), + .abstract =3D true, + .interfaces =3D (InterfaceInfo[]) { + { INTERFACE_CONVENTIONAL_PCI_DEVICE }, + { }, + }, +}; + static void via_isa_request_i8259_irq(void *opaque, int irq, int level) { - VT82C686BISAState *s =3D opaque; + ViaISAState *s =3D opaque; qemu_set_irq(s->cpu_intr, level); } =20 +/* TYPE_VT82C686B_ISA */ + static void vt82c686b_write_config(PCIDevice *d, uint32_t addr, uint32_t val, int len) { - VT82C686BISAState *s =3D VT82C686B_ISA(d); + ViaISAState *s =3D VIA_ISA(d); =20 trace_via_isa_write(addr, val, len); pci_default_write_config(d, addr, val, len); @@ -545,19 +569,9 @@ static void vt82c686b_write_config(PCIDevice *d, uint3= 2_t addr, } } =20 -static const VMStateDescription vmstate_via =3D { - .name =3D "vt82c686b", - .version_id =3D 1, - .minimum_version_id =3D 1, - .fields =3D (VMStateField[]) { - VMSTATE_PCI_DEVICE(dev, VT82C686BISAState), - VMSTATE_END_OF_LIST() - } -}; - static void vt82c686b_isa_reset(DeviceState *dev) { - VT82C686BISAState *s =3D VT82C686B_ISA(dev); + ViaISAState *s =3D VIA_ISA(dev); uint8_t *pci_conf =3D s->dev.config; =20 pci_set_long(pci_conf + PCI_CAPABILITY_LIST, 0x000000c0); @@ -577,7 +591,7 @@ static void vt82c686b_isa_reset(DeviceState *dev) =20 static void vt82c686b_realize(PCIDevice *d, Error **errp) { - VT82C686BISAState *s =3D VT82C686B_ISA(d); + ViaISAState *s =3D VIA_ISA(d); DeviceState *dev =3D DEVICE(d); ISABus *isa_bus; qemu_irq *isa_irq; @@ -601,7 +615,7 @@ static void vt82c686b_realize(PCIDevice *d, Error **err= p) } } =20 -static void via_class_init(ObjectClass *klass, void *data) +static void vt82c686b_class_init(ObjectClass *klass, void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); PCIDeviceClass *k =3D PCI_DEVICE_CLASS(klass); @@ -609,28 +623,21 @@ static void via_class_init(ObjectClass *klass, void *= data) k->realize =3D vt82c686b_realize; k->config_write =3D vt82c686b_write_config; k->vendor_id =3D PCI_VENDOR_ID_VIA; - k->device_id =3D PCI_DEVICE_ID_VIA_ISA_BRIDGE; + k->device_id =3D PCI_DEVICE_ID_VIA_82C686B_ISA; k->class_id =3D PCI_CLASS_BRIDGE_ISA; k->revision =3D 0x40; dc->reset =3D vt82c686b_isa_reset; dc->desc =3D "ISA bridge"; dc->vmsd =3D &vmstate_via; - /* - * Reason: part of VIA VT82C686 southbridge, needs to be wired up, - * e.g. by mips_fuloong2e_init() - */ + /* Reason: part of VIA VT82C686 southbridge, needs to be wired up */ dc->user_creatable =3D false; } =20 -static const TypeInfo via_info =3D { +static const TypeInfo vt82c686b_isa_info =3D { .name =3D TYPE_VT82C686B_ISA, - .parent =3D TYPE_PCI_DEVICE, - .instance_size =3D sizeof(VT82C686BISAState), - .class_init =3D via_class_init, - .interfaces =3D (InterfaceInfo[]) { - { INTERFACE_CONVENTIONAL_PCI_DEVICE }, - { }, - }, + .parent =3D TYPE_VIA_ISA, + .instance_size =3D sizeof(ViaISAState), + .class_init =3D vt82c686b_class_init, }; =20 =20 @@ -642,7 +649,8 @@ static void vt82c686b_register_types(void) type_register_static(&via_superio_info); type_register_static(&vt82c686b_superio_info); type_register_static(&vt8231_superio_info); - type_register_static(&via_info); + type_register_static(&via_isa_info); + type_register_static(&vt82c686b_isa_info); } =20 type_init(vt82c686b_register_types) diff --git a/include/hw/pci/pci_ids.h b/include/hw/pci/pci_ids.h index ea28dcc850..aa3f67eaa4 100644 --- a/include/hw/pci/pci_ids.h +++ b/include/hw/pci/pci_ids.h @@ -204,7 +204,7 @@ #define PCI_VENDOR_ID_XILINX 0x10ee =20 #define PCI_VENDOR_ID_VIA 0x1106 -#define PCI_DEVICE_ID_VIA_ISA_BRIDGE 0x0686 +#define PCI_DEVICE_ID_VIA_82C686B_ISA 0x0686 #define PCI_DEVICE_ID_VIA_IDE 0x0571 #define PCI_DEVICE_ID_VIA_UHCI 0x3038 #define PCI_DEVICE_ID_VIA_82C686B_PM 0x3057 --=20 2.21.4