From nobody Sat Nov 15 10:52:11 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1752560442; cv=none; d=zohomail.com; s=zohoarc; b=CqY8VX6oyc0UMjMa5gBijVb2OLKOTFqW+QvVZcUMdO75iST8vX4IdVsdfmUWN0Alu+pRHWTMmj+Hd7+wn1P5SwQPIf9mYuuJZ0VMmBS4Cf54XDvdVw3SUhntgqqilzHRms2mglvwGscQpvWIyg6ytMxbwMsRBo/oUme3fZaMXV8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752560442; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=uh429H/7Fd0JqSjaTv4ix/gvZDdMnAIxIzaDOJCmbvQ=; b=dSdk4Gca6d300MEBSo8SaDtif3S4K5/j7oB4agulhHX8YT3csrJZKck6OemfnvDPpe4cE3/Ly1RkBK+Qobj6ZIR6j6eu/0m23l+7qNTbDJ0Jbry2q77cfxBRiC+fot0sJIjXFcZyyTp4YO2JNe3LPVulvCdk3dPwMxj0cob68oQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752560442445759.4514927703548; Mon, 14 Jul 2025 23:20:42 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ubZ11-0002Et-PF; Tue, 15 Jul 2025 02:19:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ubYxH-0007ti-Bz for qemu-devel@nongnu.org; Tue, 15 Jul 2025 02:16:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ubYxF-0006Q1-0y for qemu-devel@nongnu.org; Tue, 15 Jul 2025 02:15:54 -0400 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-212-nplSoFjsPUijz8H--n0QPA-1; Tue, 15 Jul 2025 02:15:50 -0400 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4e9252ba0so2978672f8f.0 for ; Mon, 14 Jul 2025 23:15:50 -0700 (PDT) Received: from redhat.com ([2a0d:6fc0:150d:fc00:de3:4725:47c6:6809]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8e269a0sm14045211f8f.86.2025.07.14.23.15.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jul 2025 23:15:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752560152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uh429H/7Fd0JqSjaTv4ix/gvZDdMnAIxIzaDOJCmbvQ=; b=hwURKt0FtSPmbu7RHJs/flD5bH+Ixxk1Zell+3gCkeq5ZDImCQGDUBYSYa4VFXB018VyU5 XCJEov77vAdAmbRL7gI1g4qIiNCN30UmUZfIB5AtjCxdegEaA8gnSvTa++Wtv9srizHbzf axYsX7WB7ezImckWC96zcCZlRhgk/LE= X-MC-Unique: nplSoFjsPUijz8H--n0QPA-1 X-Mimecast-MFC-AGG-ID: nplSoFjsPUijz8H--n0QPA_1752560149 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752560149; x=1753164949; h=content-transfer-encoding:content-disposition:mime-version :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uh429H/7Fd0JqSjaTv4ix/gvZDdMnAIxIzaDOJCmbvQ=; b=XdSzoMc+4zu5naTXNS2DT6aCHBavNRvOGTM/WkDys2FSJ15Uwni8SeSL8+ymD8J/IQ /9rWJg+j0sS+LVY0upvCQsR8TAeB/zNwuOtQxuSr/sW0333kJ+KLswy0Co+FZ9et8krB nxuhbft1qLRL8CmcmC1oS/Kf4lk9GEredqUrCk+i9Ya9QbN2eiSQF/afgoOcPYijdASw XS1Yp+H74yHd2HPASwq0PPXP0hRR07+kr58N0v8K10tIRfCw26yn8UrvsQ4wTYThFCTO f0UXSzTYz6h4QVkWb4qKxStZsB0+ar4xUeulb/305PDA31kj4ymczBr+E6fuFOIam/sN E9Og== X-Gm-Message-State: AOJu0YxrwdJ0Swkzy9kT5BPb68Ecz2VJ1AV8+8xfX7F9wCt1hOWLjaXm Buoy8lUZB+cJEoOg5hD32/3j3l9E2I50Pb8r1BI+Sw3NPLEcN78cwCwIRT8wvsyoisiQZlIei9G 78Z4T79eUbbmAp8QARfirG/p8ZwcxB71T4pZrZI9SWf+zUVVqCyr8khN9dGdG/LtxbDgWM+eNff DdAQmLtOqKRwqI60x1rOv20rmpXWPnUV2ngQ== X-Gm-Gg: ASbGncvtNLav70m5ruV3Jy7m3dv1cB74tvEOXwDRylkjU+aWkxS64HeIrxJoFmA0aak ZnMy2gOad+CRZZ8H6ubyp4BnIDOuzdjGtau2cOeaiUHzJpxhnk/vrFNXOTzUWj5JFrYz2Yks58N tQ5ovA8vlo4WlSqpuZy6Fp/sTMFmzaPqZyumL+sG6ruF7/34a7e4q1q7T8X0FofnlsKQF5YuMgu XCOvWuphrYI7f35+nlMjzUlho2RB1q/OdN99xsy6TYGbpUMLEXEjraS4TIJW2oCbwnB7uHiJHc2 JJk/9dVywS5BcGsV3li86wmUU7TLsreW X-Received: by 2002:a05:6000:43d5:b0:3a5:2ec5:35a3 with SMTP id ffacd0b85a97d-3b5f18e82d8mr9966104f8f.45.1752560149036; Mon, 14 Jul 2025 23:15:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFT7GVM6dTzSOuN6/p9UJaJmmDrydVcqite4GPEEar6R+66sVnawTLQMMxaVABg+N3sQ/W1vA== X-Received: by 2002:a05:6000:43d5:b0:3a5:2ec5:35a3 with SMTP id ffacd0b85a97d-3b5f18e82d8mr9966084f8f.45.1752560148565; Mon, 14 Jul 2025 23:15:48 -0700 (PDT) Date: Tue, 15 Jul 2025 02:15:46 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , qemu-rust@nongnu.org Subject: [PATCH v2] rust: bindings: allow any number of params Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1752560444841116600 We are going to be adding more parameters, and this makes rust unhappy: Functions with lots of parameters are considered bad style and reduce readability (=E2=80=9Cwhat does the 5th parameter mean?=E2=80=9D). Cons= ider grouping some parameters into a new type. Specifically: error: this function has too many arguments (8/7) --> /builds/mstredhat/qemu/build/rust/qemu-api/rust-qemu-api-tests.p/st= ructured/bindings.inc.rs:3840:5 | 3840 | / pub fn new_bitfield_1( 3841 | | secure: std::os::raw::c_uint, 3842 | | space: std::os::raw::c_uint, 3843 | | user: std::os::raw::c_uint, ... | 3848 | | address_type: std::os::raw::c_uint, 3849 | | ) -> __BindgenBitfieldUnit<[u8; 4usize]> { | |____________________________________________^ | =3D help: for further information visit https://rust-lang.github.io/ru= st-clippy/master/index.html#too_many_arguments =3D note: `-D clippy::too-many-arguments` implied by `-D warnings` =3D help: to override `-D warnings` add `#[allow(clippy::too_many_argu= ments)]` Signed-off-by: Michael S. Tsirkin Acked-by: Paolo Bonzini Reviewed-by: Manos Pitsidianakis Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- rust/qemu-api/src/bindings.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rust/qemu-api/src/bindings.rs b/rust/qemu-api/src/bindings.rs index 057de4b646..c4f1f755ce 100644 --- a/rust/qemu-api/src/bindings.rs +++ b/rust/qemu-api/src/bindings.rs @@ -13,7 +13,8 @@ clippy::missing_const_for_fn, clippy::ptr_offset_with_cast, clippy::useless_transmute, - clippy::missing_safety_doc + clippy::missing_safety_doc, + clippy::too_many_arguments )] =20 //! `bindgen`-generated declarations. --=20 MST