From nobody Mon Feb 9 10:33:11 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1701451064; cv=none; d=zohomail.com; s=zohoarc; b=Ih1PFEXKgev97+o3U/tK8t6hLTaPvcF9bXu7E9xJBjNfoovQxl/XgsPbZ5oM1/ZSAy3CzGWHe1l0Fo/0Wvsroa/uqtXS0RNCJeMycLDjmadu6YZPnVQNmMxulZ7e3VSq9QXCrNU9On2nKCejsTq1MCX/mrgksqklAGhZdTEFdr0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1701451064; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=mIm/ZZ+AtEMMvxQLcKFz+qdaAOEyPQ7KcKiLyzLcQQQ=; b=nO7bK17a5PbTbi345d2bfdQX56kXdi8AHZ5tltAeI+f+zWuUThBHFT45Jd+6iAnmwzg7POyINyPnsT25RLSxtrYaOe4Y3VWL3zrL4p/Cpr2tJJmAuMRm5EyjqXBSrsGOHl09a6lZ4G0xpE4T1CzNDGx3mvBYSDENRhER7tRR6K4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1701451064813894.3919715354824; Fri, 1 Dec 2023 09:17:44 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r977P-00030F-3j; Fri, 01 Dec 2023 12:15:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9773-0002uG-LB for qemu-devel@nongnu.org; Fri, 01 Dec 2023 12:15:38 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9771-0007iq-9j for qemu-devel@nongnu.org; Fri, 01 Dec 2023 12:15:36 -0500 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-383-JFujUxdjOUq66T9cpcxk-A-1; Fri, 01 Dec 2023 12:15:30 -0500 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40b297925ccso17137615e9.2 for ; Fri, 01 Dec 2023 09:15:30 -0800 (PST) Received: from redhat.com ([2a06:c701:73e1:6f00:c7ce:b553:4096:d504]) by smtp.gmail.com with ESMTPSA id d4-20020a05600c3ac400b0040b538047b4sm9494751wms.3.2023.12.01.09.15.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 09:15:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701450934; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mIm/ZZ+AtEMMvxQLcKFz+qdaAOEyPQ7KcKiLyzLcQQQ=; b=J0WdiMDiJeyGZq6kb6iG/XA8y2/lBH6qhtQq1BXQ4alNeW4pC6gztNc6YRzciw94z3mf68 lYGx+cFm7MiSEpGCw+f6qtUdRpTIaq4D9wypyEU9Ei6huBIZ2tNw7S3X6Aho5AZWhHUGD4 rlLg/vRqvxwcF0Eai7KbuHppgeDMB4c= X-MC-Unique: JFujUxdjOUq66T9cpcxk-A-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701450928; x=1702055728; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mIm/ZZ+AtEMMvxQLcKFz+qdaAOEyPQ7KcKiLyzLcQQQ=; b=pArXJnyTZriFeCKpElXSMY9+cvLAUQI00rWucXnwCDRxMZsXzK9n7LKMDM6YhZt9as elaO0tDrTsA38NNF8VkEDOxYYkQNnIxZfvTxFVFJKhgpI0f0db+Zp/sP5i2b1V/d455P zGbOeufdp01hv1cQjWIHVk7rwude1AShRnucC1hYeq5sMzv7gwP28WASfgT5vIlXaVT/ ThhE2CtxO89Z3H7FY3/FhoWq/AtJeDJ6o2dxusHKeK5N1GBScdjZZp4w4yG32JZNZ6Hr GHqAgMJXqn6cQOLLdEtodHdfP0OjHoRwXawx5V1tBg6eG1pwv6MqZj4wLg3NMgUrt2By 8P7g== X-Gm-Message-State: AOJu0YyrPeXc7yn8N3qqKSMDdaW+5YJYULvMoEBaKUOggLj9J+572wJz QouKwG8opkVP5k47neVYK1VdA8l1UC6Tmowbpd/B8aigRXBt3yDzCilhng/39eNg6HJKtlEibIA BihJnFvmIfont3hDKOf8bQ+RC0GGlHy80eJ4i1lXKL6ykh7wwkQsSGIvZWptu95fD0pRR X-Received: by 2002:a05:600c:6003:b0:40b:5e22:974 with SMTP id az3-20020a05600c600300b0040b5e220974mr797983wmb.99.1701450928392; Fri, 01 Dec 2023 09:15:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IGQ3WlOhsWzu1uBXzuftI+71IX/uk6qlLfHxlliu7daUVG7SIcVu0iGmSptjR45Oe54zj5iYg== X-Received: by 2002:a05:600c:6003:b0:40b:5e22:974 with SMTP id az3-20020a05600c600300b0040b5e220974mr797971wmb.99.1701450928059; Fri, 01 Dec 2023 09:15:28 -0800 (PST) Date: Fri, 1 Dec 2023 12:15:25 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Cc: Peter Maydell , Manos Pitsidianakis , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Gerd Hoffmann Subject: [PULL 07/15] virtio-snd: check AUD_register_card return value Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1701451065147000001 From: Manos Pitsidianakis AUD_register_card might fail. Even though errp was passed as an argument, the call's return value was not checked for failure. Fixes: Coverity CID 1523899 Signed-off-by: Manos Pitsidianakis Message-Id: <20231109162034.2108018-1-manos.pitsidianakis@linaro.org> Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/audio/virtio-snd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c index 2fe966e311..83e97858e0 100644 --- a/hw/audio/virtio-snd.c +++ b/hw/audio/virtio-snd.c @@ -1102,7 +1102,9 @@ static void virtio_snd_realize(DeviceState *dev, Erro= r **errp) return; } =20 - AUD_register_card("virtio-sound", &vsnd->card, errp); + if (!AUD_register_card("virtio-sound", &vsnd->card, errp)) { + return; + } =20 /* set default params for all streams */ default_params.features =3D 0; --=20 MST