From nobody Tue Nov 18 04:32:09 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=oracle.com ARC-Seal: i=1; a=rsa-sha256; t=1607923949; cv=none; d=zohomail.com; s=zohoarc; b=cBqJCH8nLCfQ1Wo+4euoJVcVssS0JAZHo2E3jfDccXBNF2TmfeSb9VzSYwrP7dbgS0JWdE1vKx0n9yTUvHKSMyQxIybloKdldRzesSFzB9T4KMTzWv9x5r29jejtWwmOdIoHW5dTL+L0rs1tg4RD9j3dXi71k8wAEpYWAnzbae8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607923949; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vBwb/56sNqW0f5osyPsmo/XlpSJ7MuwTR5dLsqlNFAc=; b=SojzCVtMhGt6OV6ECKkIF8LaNeMNuc1uyEOaXSnYUZsAppzFdtIj5Gogo0+Pq/gkoTRrYCkslC5vgBqrjiVuCFn4Ha3vMnDujNR5LjXCEP9YXQrLU9xCVnYnBgkVty98j8OuEVWS8kgvu53kiEGsCFAdkXzIk2LUksVmietIR78= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607923949891388.0843711228016; Sun, 13 Dec 2020 21:32:29 -0800 (PST) Received: from localhost ([::1]:38686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kogTE-0002CR-O9 for importer@patchew.org; Mon, 14 Dec 2020 00:32:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kogCz-000589-H1 for qemu-devel@nongnu.org; Mon, 14 Dec 2020 00:15:45 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:37358) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kogCw-0007CI-42 for qemu-devel@nongnu.org; Mon, 14 Dec 2020 00:15:41 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BE5F5om007591; Mon, 14 Dec 2020 05:15:29 GMT Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 35cn9r3ce7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 14 Dec 2020 05:15:29 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BE5Anp5184227; Mon, 14 Dec 2020 05:15:28 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 35d7rw1nq9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Dec 2020 05:15:28 +0000 Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0BE5FQEd019113; Mon, 14 Dec 2020 05:15:26 GMT Received: from jaraman-bur-1.us.oracle.com (/10.152.33.39) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 13 Dec 2020 21:15:24 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=vBwb/56sNqW0f5osyPsmo/XlpSJ7MuwTR5dLsqlNFAc=; b=jMOuSp4l04msfo8UTvg8qWZdZx3fBkDqjr2dCKLlx7f4wJTjFFcUIOiauKLY+IG6Z5OZ QqNLEAQEGhW9Yj1LAbem84fvp38OdhdD/q6Mb39HJ8MtPjv/gTsmPlkcMYwJZ2P9uAiY Gs2rQ0TWCyU18judoN6zNbltttes4ZFhXBiPoDSXraI4Y2osqhpHuuKgx2/JHOM6WXNc 8mkpbCxNNhjuR5A27k67vYJnNUL7/ch1bOV28TVLmN6GvSCVX4lJT6jHGq31iZrpmWpi sTWLQnxJxUH8TTJob5pKa5JUSQxSrjSnHU+peaCoiztfn8yF9cvaAsXib16MHj8hr8Dg CA== From: Jagannathan Raman To: qemu-devel@nongnu.org Subject: [PATCH v13 10/19] multi-process: Associate fd of a PCIDevice with its object Date: Mon, 14 Dec 2020 00:14:50 -0500 Message-Id: X-Mailer: git-send-email 1.8.3.1 In-Reply-To: References: In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9834 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0 adultscore=0 spamscore=0 suspectscore=0 bulkscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012140040 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9834 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=999 impostorscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 malwarescore=0 priorityscore=1501 phishscore=0 mlxscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012140040 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=156.151.31.86; envelope-from=jag.raman@oracle.com; helo=userp2130.oracle.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: elena.ufimtseva@oracle.com, fam@euphon.net, swapnil.ingle@nutanix.com, john.g.johnson@oracle.com, kraxel@redhat.com, jag.raman@oracle.com, quintela@redhat.com, mst@redhat.com, armbru@redhat.com, kanth.ghatraju@oracle.com, felipe@nutanix.com, thuth@redhat.com, ehabkost@redhat.com, konrad.wilk@oracle.com, dgilbert@redhat.com, alex.williamson@redhat.com, stefanha@redhat.com, thanos.makatos@nutanix.com, kwolf@redhat.com, berrange@redhat.com, mreitz@redhat.com, ross.lagerwall@citrix.com, marcandre.lureau@gmail.com, pbonzini@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Associate the file descriptor for a PCIDevice in remote process with DeviceState object. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi --- hw/remote/remote-obj.c | 206 +++++++++++++++++++++++++++++++++++++++++++++= ++++ MAINTAINERS | 1 + hw/remote/meson.build | 1 + 3 files changed, 208 insertions(+) create mode 100644 hw/remote/remote-obj.c diff --git a/hw/remote/remote-obj.c b/hw/remote/remote-obj.c new file mode 100644 index 0000000..b5573b7 --- /dev/null +++ b/hw/remote/remote-obj.c @@ -0,0 +1,206 @@ +/* + * Copyright =C2=A9 2020 Oracle and/or its affiliates. + * + * This work is licensed under the terms of the GNU GPL-v2, version 2 or l= ater. + * + * See the COPYING file in the top-level directory. + * + */ + +#include "qemu/osdep.h" +#include "qemu-common.h" + +#include "qemu/error-report.h" +#include "qemu/notify.h" +#include "qom/object_interfaces.h" +#include "hw/qdev-core.h" +#include "io/channel.h" +#include "hw/qdev-core.h" +#include "hw/remote/machine.h" +#include "io/channel-util.h" +#include "qapi/error.h" +#include "sysemu/sysemu.h" +#include "hw/pci/pci.h" +#include "qemu/sockets.h" + +#define TYPE_REMOTE_OBJECT "x-remote-object" +#define REMOTE_OBJECT(obj) \ + OBJECT_CHECK(RemoteObject, (obj), TYPE_REMOTE_OBJECT) +#define REMOTE_OBJECT_GET_CLASS(obj) \ + OBJECT_GET_CLASS(RemoteObjectClass, (obj), TYPE_REMOTE_OBJECT) +#define REMOTE_OBJECT_CLASS(klass) \ + OBJECT_CLASS_CHECK(RemoteObjectClass, (klass), TYPE_REMOTE_OBJECT) + +typedef struct { + ObjectClass parent_class; + + unsigned int nr_devs; + unsigned int max_devs; +} RemoteObjectClass; + +typedef struct { + /* private */ + Object parent; + + Notifier machine_done; + + int32_t fd; + char *devid; + + QIOChannel *ioc; + + DeviceState *dev; + DeviceListener listener; +} RemoteObject; + +static void remote_object_set_fd(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) +{ + RemoteObject *o =3D REMOTE_OBJECT(obj); + int32_t value; + + if (!visit_type_int32(v, name, &value, errp)) { + return; + } + + if (!fd_is_socket(value)) { + o->fd =3D -1; + error_setg(errp, "File descriptor %d is not a socket", value); + return; + } + + o->fd =3D value; +} + +static void remote_object_set_devid(Object *obj, const char *str, Error **= errp) +{ + RemoteObject *o =3D REMOTE_OBJECT(obj); + + g_free(o->devid); + + o->devid =3D g_strdup(str); +} + +static void remote_object_release(DeviceListener *listener, DeviceState *d= ev) +{ + RemoteObject *o =3D container_of(listener, RemoteObject, listener); + + if (o->dev =3D=3D dev) { + object_unref(OBJECT(o)); + } +} + +static void remote_object_machine_done(Notifier *notifier, void *data) +{ + RemoteObject *o =3D container_of(notifier, RemoteObject, machine_done); + DeviceState *dev =3D NULL; + QIOChannel *ioc =3D NULL; + Coroutine *co =3D NULL; + RemoteCommDev *comdev =3D NULL; + Error *err =3D NULL; + + dev =3D qdev_find_recursive(sysbus_get_default(), o->devid); + if (!dev || !object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) { + error_report("%s is not a PCI device", o->devid); + return; + } + + ioc =3D qio_channel_new_fd(o->fd, &err); + if (!ioc) { + error_report_err(err); + return; + } + qio_channel_set_blocking(ioc, false, NULL); + + o->dev =3D dev; + + o->listener.unrealize =3D remote_object_release; + device_listener_register(&o->listener); + + /* co-routine should free this. */ + comdev =3D g_new0(RemoteCommDev, 1); + *comdev =3D (RemoteCommDev) { + .ioc =3D ioc, + .dev =3D PCI_DEVICE(dev), + }; + + co =3D qemu_coroutine_create(mpqemu_remote_msg_loop_co, comdev); + qemu_coroutine_enter(co); +} + +static void remote_object_init(Object *obj) +{ + RemoteObjectClass *k =3D REMOTE_OBJECT_GET_CLASS(obj); + RemoteObject *o =3D REMOTE_OBJECT(obj); + + if (k->nr_devs >=3D k->max_devs) { + error_report("Reached maximum number of devices: %u", k->max_devs); + return; + } + + o->ioc =3D NULL; + o->fd =3D -1; + o->devid =3D NULL; + + k->nr_devs++; + + o->machine_done.notify =3D remote_object_machine_done; + qemu_add_machine_init_done_notifier(&o->machine_done); +} + +static void remote_object_finalize(Object *obj) +{ + RemoteObjectClass *k =3D REMOTE_OBJECT_GET_CLASS(obj); + RemoteObject *o =3D REMOTE_OBJECT(obj); + + device_listener_unregister(&o->listener); + + if (o->ioc) { + qio_channel_shutdown(o->ioc, QIO_CHANNEL_SHUTDOWN_BOTH, NULL); + qio_channel_close(o->ioc, NULL); + } + + object_unref(OBJECT(o->ioc)); + + k->nr_devs--; + g_free(o->devid); +} + +static void remote_object_class_init(ObjectClass *klass, void *data) +{ + RemoteObjectClass *k =3D REMOTE_OBJECT_CLASS(klass); + + /* + * Limit number of supported devices to 1. This is done to avoid devic= es + * from one VM accessing the RAM of another VM. This is done until we + * start using separate address spaces for individual devices. + */ + k->max_devs =3D 1; + k->nr_devs =3D 0; + + object_class_property_add(klass, "fd", "int32_t", NULL, + remote_object_set_fd, NULL, NULL); + object_class_property_add_str(klass, "devid", NULL, + remote_object_set_devid); +} + +static const TypeInfo remote_object_info =3D { + .name =3D TYPE_REMOTE_OBJECT, + .parent =3D TYPE_OBJECT, + .instance_size =3D sizeof(RemoteObject), + .instance_init =3D remote_object_init, + .instance_finalize =3D remote_object_finalize, + .class_size =3D sizeof(RemoteObjectClass), + .class_init =3D remote_object_class_init, + .interfaces =3D (InterfaceInfo[]) { + { TYPE_USER_CREATABLE }, + { } + } +}; + +static void register_types(void) +{ + type_register_static(&remote_object_info); +} + +type_init(register_types); diff --git a/MAINTAINERS b/MAINTAINERS index 4f2cd91..f049059 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3160,6 +3160,7 @@ F: include/hw/remote/machine.h F: hw/remote/mpqemu-link.c F: include/hw/remote/mpqemu-link.h F: hw/remote/message.c +F: hw/remote/remote-obj.c =20 Build and test automation ------------------------- diff --git a/hw/remote/meson.build b/hw/remote/meson.build index 9f5c57f..71d0a56 100644 --- a/hw/remote/meson.build +++ b/hw/remote/meson.build @@ -3,5 +3,6 @@ remote_ss =3D ss.source_set() remote_ss.add(when: 'CONFIG_MULTIPROCESS', if_true: files('machine.c')) remote_ss.add(when: 'CONFIG_MULTIPROCESS', if_true: files('mpqemu-link.c')) remote_ss.add(when: 'CONFIG_MULTIPROCESS', if_true: files('message.c')) +remote_ss.add(when: 'CONFIG_MULTIPROCESS', if_true: files('remote-obj.c')) =20 softmmu_ss.add_all(when: 'CONFIG_MULTIPROCESS', if_true: remote_ss) --=20 1.8.3.1