From nobody Tue May 13 08:01:53 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass(p=none dis=none) header.from=gmail.com
ARC-Seal: i=1; a=rsa-sha256; t=1739784559; cv=none;
d=zohomail.com; s=zohoarc;
b=eXm3J0HnlH04uzRC511Rs30X5o1Hs/07xRJN+o4mZ0hQ6qLmMAnr4177Ca5VC2BtdcZ23uO1YG8a4G2cg2E7yL+/yM43UsTd8ZNu9mhsPU4gSL1XcKh5U5t4mRXLASDFFxuV2clB4Sv+mSeOc7DZ19CoHCk9Px37t0uFcZNNh8s=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1739784559;
h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To;
bh=EbMv2dkOrEFHvUHvF6ZzowdWf/tdcr77orU+Pt2H9R0=;
b=At8gW3TYbwegEUFJxCiUl4KxJgaKUPEaSC2mhI2vNPcqXYcvYGhNWmHcGvwMa0udPm64+6j5r65Efi4L7vjWrHGR32FXGZdXqOYKvl42AUwgLPYxTtSf+St1p0acTGxQ4PyS1w9NmyKj/PuhlGXiOZFHPOS9xKyRnQB8JQp8bhQ=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass header.from=<jeuk20.kim@gmail.com> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1739784559571660.5495909774056;
Mon, 17 Feb 2025 01:29:19 -0800 (PST)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1tjxQU-0001oF-QA; Mon, 17 Feb 2025 04:28:31 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <jeuk20.kim@gmail.com>)
id 1tjxQM-0001nP-Fc; Mon, 17 Feb 2025 04:28:22 -0500
Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <jeuk20.kim@gmail.com>)
id 1tjxQK-0000uC-Pg; Mon, 17 Feb 2025 04:28:22 -0500
Received: by mail-pj1-x1030.google.com with SMTP id
98e67ed59e1d1-2fc20e0f0ceso5018539a91.3;
Mon, 17 Feb 2025 01:28:20 -0800 (PST)
Received: from jeuk-MS-7D42.. ([175.119.5.143])
by smtp.gmail.com with ESMTPSA id
d2e1a72fcca58-73265f98e18sm4152940b3a.106.2025.02.17.01.28.15
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 17 Feb 2025 01:28:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1739784498; x=1740389298; darn=nongnu.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=EbMv2dkOrEFHvUHvF6ZzowdWf/tdcr77orU+Pt2H9R0=;
b=gg3XBAm0gguH2T71XcVHe7BymgL/7AT2cGeEvnXoaGUGBHfw2o3nn23/1MWHU4AGo0
TmT8f10sq41IHkkGkDR0a/uyO+1Hgji+vlfIguOD8kxejGzVT3POsba30a6bS+MaTnyQ
aWct/BR91ARmkILzPz0LuXpicCRR7JtcvhVEp3+bxDNw615OYCBe8KyciJHl0gsxrqAv
bFOBLfFQmYiMouu7BA58X8UusdlqBoCKIplnzGvl3z9msmbluNUj7MbeUhyoaUiWdWIm
UjSUEmAUVF9LMW8X7cNoU0W8LZx3SfNk7ywwFD5QMbZi/ftCQTGo5RIXEEwZ0XCMmT+8
Guhg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1739784498; x=1740389298;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=EbMv2dkOrEFHvUHvF6ZzowdWf/tdcr77orU+Pt2H9R0=;
b=ebXvHk/6NhMU4lxCUSdQA/ss+r2AcOavoPcM5Lv2ECVmhZ1P6E2dgB+8NbgnktgPHH
SDy1vkHs97r/ujHDurBA3aYqLGTXHR7WNagb/AxnB/oF9En/O22jTCTpBxdpYF0byhed
ysOjXMhW5gLxwd5qW3MVIiJHhTg+WNy0MXVuJFzPmZ/oS6aRglazRBs+1zQibO/qgL2Q
p2UqqKvrnCTC5deoFmJdrUK+2PHANY9D3T4hXxJ/7NyqNDsQbeLDpcuidp2Exmkj7KmX
yAguMjGwND0a7LqOb2U+oPVfuHmB25FpA8Stci4p4+avW23FtH/kP6qIm75JNa8pc59N
At4Q==
X-Forwarded-Encrypted: i=1;
AJvYcCX0+e0PVZeUBRfbxwUp4aX7Ty5IFFdDBeQXARDh0k12IxGqayDVAeqpsu/mgSMha/bJK758slUV14c2@nongnu.org
X-Gm-Message-State: AOJu0Yz7di1pEofVXK6q710NMZB0LDhIjn1Qr2lQshHSs1HrSKobBLAC
PrNGi+PsH8zxcFByYgJKMCO3vNRHdDoIh4NrSgW044plq+ylIyCrQEWcNg==
X-Gm-Gg: ASbGncsM5m5EpQ4BSa93bO6iteS9ZRCCl3sI/jlosJo5RXy/7amqQIQC+6Rh1pqkN26
jAk4g105i9Mh/5f3fcAylqJFKxishKp0ZyfNYrDmjHNzv19SkdpDYJOsSjSq9Yne48Id1/6jlV0
xsCSn9CjjrRg2NVjSRSWhECgnXPMrtGvlUGZ1CBe/G+D37XuhrOMON8TjVR7RWmvVpfRXTrjS/0
NjuB5gEJjSpIIekOP0LTPuR6bVjPWuW2AM9YxXWVpsLg0SeBXB7JV3O1yf/9E203SvHwtUD1dRd
4WvJSn+BiUaNhGw6V+M=
X-Google-Smtp-Source:
AGHT+IG/iLiZ27v0EMN/usFhr2lCDl/2yQPI3uQuLAclIOU0xMB0q4wtoJbX+6j3vbaV3fdVsMR+Zg==
X-Received: by 2002:a05:6a00:1403:b0:730:87cf:a7cd with SMTP id
d2e1a72fcca58-732617a1b47mr16247520b3a.8.1739784498256;
Mon, 17 Feb 2025 01:28:18 -0800 (PST)
From: Jeuk Kim <jeuk20.kim@gmail.com>
To: qemu-devel@nongnu.org,
stefanha@redhat.com
Cc: pbonzini@redhat.com, qemu-block@nongnu.org, jeuk20.kim@samsung.com,
j-young.choi@samsung.com, farosas@suse.de, lvivier@redhat.com,
Jeuk Kim <jeuk20.kim@gmail.com>
Subject: [PULL 2/4] tests/qtest/ufs-test: Cleanup unused code
Date: Mon, 17 Feb 2025 18:27:53 +0900
Message-ID:
<e041d3d2165994311a6ee4bee6d1c7864ff81916.1739784105.git.jeuk20.kim@samsung.com>
X-Mailer: git-send-email 2.43.0
In-Reply-To: <cover.1739784105.git.jeuk20.kim@samsung.com>
References: <cover.1739784105.git.jeuk20.kim@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=2607:f8b0:4864:20::1030;
envelope-from=jeuk20.kim@gmail.com; helo=mail-pj1-x1030.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: pass (identity @gmail.com)
X-ZM-MESSAGEID: 1739784561594019000
Content-Type: text/plain; charset="utf-8"
Removed dead code related to the unimplemented task
management request.
Acked-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Jeuk Kim <jeuk20.kim@samsung.com>
---
tests/qtest/ufs-test.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/tests/qtest/ufs-test.c b/tests/qtest/ufs-test.c
index 1f860b41c0..ce8b398c6b 100644
--- a/tests/qtest/ufs-test.c
+++ b/tests/qtest/ufs-test.c
@@ -8,7 +8,6 @@
=20
#include "qemu/osdep.h"
#include "qemu/module.h"
-#include "qemu/units.h"
#include "libqtest.h"
#include "libqos/qgraph.h"
#include "libqos/pci.h"
@@ -35,7 +34,6 @@ struct QUfs {
QPCIBar bar;
=20
uint64_t utrlba;
- uint64_t utmrlba;
uint64_t cmd_desc_addr;
uint64_t data_buffer_addr;
=20
@@ -257,7 +255,7 @@ static void ufs_send_scsi_command(QUfs *ufs, uint8_t sl=
ot, uint8_t lun,
static void ufs_init(QUfs *ufs, QGuestAllocator *alloc)
{
uint64_t end_time;
- uint32_t nutrs, nutmrs;
+ uint32_t nutrs;
uint32_t hcs, is, ucmdarg2, cap;
uint32_t hce =3D 0, ie =3D 0;
UtpTransferReqDesc utrd;
@@ -305,7 +303,6 @@ static void ufs_init(QUfs *ufs, QGuestAllocator *alloc)
hcs =3D ufs_rreg(ufs, A_HCS);
g_assert_true(FIELD_EX32(hcs, HCS, DP));
g_assert_true(FIELD_EX32(hcs, HCS, UTRLRDY));
- g_assert_true(FIELD_EX32(hcs, HCS, UTMRLRDY));
g_assert_true(FIELD_EX32(hcs, HCS, UCRDY));
=20
/* Enable all interrupt functions */
@@ -326,20 +323,15 @@ static void ufs_init(QUfs *ufs, QGuestAllocator *allo=
c)
/* Enable transfer request and task management request */
cap =3D ufs_rreg(ufs, A_CAP);
nutrs =3D FIELD_EX32(cap, CAP, NUTRS) + 1;
- nutmrs =3D FIELD_EX32(cap, CAP, NUTMRS) + 1;
ufs->cmd_desc_addr =3D
guest_alloc(alloc, nutrs * UTP_COMMAND_DESCRIPTOR_SIZE);
ufs->data_buffer_addr =3D
guest_alloc(alloc, MAX_PRD_ENTRY_COUNT * PRD_ENTRY_DATA_SIZE);
ufs->utrlba =3D guest_alloc(alloc, nutrs * sizeof(UtpTransferReqDesc));
- ufs->utmrlba =3D guest_alloc(alloc, nutmrs * sizeof(UtpTaskReqDesc));
=20
ufs_wreg(ufs, A_UTRLBA, ufs->utrlba & 0xffffffff);
ufs_wreg(ufs, A_UTRLBAU, ufs->utrlba >> 32);
- ufs_wreg(ufs, A_UTMRLBA, ufs->utmrlba & 0xffffffff);
- ufs_wreg(ufs, A_UTMRLBAU, ufs->utmrlba >> 32);
ufs_wreg(ufs, A_UTRLRSR, 1);
- ufs_wreg(ufs, A_UTMRLRSR, 1);
=20
/* Send nop out to test transfer request */
ufs_send_nop_out(ufs, 0, &utrd, &rsp_upiu);
@@ -370,7 +362,6 @@ static void ufs_exit(QUfs *ufs, QGuestAllocator *alloc)
{
if (ufs->enabled) {
guest_free(alloc, ufs->utrlba);
- guest_free(alloc, ufs->utmrlba);
guest_free(alloc, ufs->cmd_desc_addr);
guest_free(alloc, ufs->data_buffer_addr);
}
--=20
2.43.0