From nobody Mon Feb 9 14:00:26 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=siemens.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1581057888388658.7848731268132; Thu, 6 Feb 2020 22:44:48 -0800 (PST) Received: from localhost ([::1]:50680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izxNf-0001TY-2v for importer@patchew.org; Fri, 07 Feb 2020 01:44:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46884) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izxMi-00012X-J4 for qemu-devel@nongnu.org; Fri, 07 Feb 2020 01:43:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1izxMh-0004cx-60 for qemu-devel@nongnu.org; Fri, 07 Feb 2020 01:43:48 -0500 Received: from lizzard.sbs.de ([194.138.37.39]:45964) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1izxMg-0004Zb-Sp for qemu-devel@nongnu.org; Fri, 07 Feb 2020 01:43:47 -0500 Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id 0176hjgm010597 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 7 Feb 2020 07:43:45 +0100 Received: from [167.87.42.193] ([167.87.42.193]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 0176hiQh029354; Fri, 7 Feb 2020 07:43:44 +0100 From: Jan Kiszka Subject: [PATCH v2] apic: Report current_count via 'info lapic' To: qemu-devel Message-ID: Date: Fri, 7 Feb 2020 07:43:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by lizzard.sbs.de id 0176hjgm010597 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 194.138.37.39 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Jan Kiszka This is helpful when debugging stuck guest timers. As we need apic_get_current_count for that, and it is really not emulation specific, move it to apic_common.c and export it. Fix its style at this chance as well. Signed-off-by: Jan Kiszka Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- Changes in v2: - fix style of apic_get_current_count hw/intc/apic.c | 18 ------------------ hw/intc/apic_common.c | 19 +++++++++++++++++++ include/hw/i386/apic_internal.h | 1 + target/i386/helper.c | 5 +++-- 4 files changed, 23 insertions(+), 20 deletions(-) diff --git a/hw/intc/apic.c b/hw/intc/apic.c index bd40467965..f2207d0ace 100644 --- a/hw/intc/apic.c +++ b/hw/intc/apic.c @@ -615,24 +615,6 @@ int apic_accept_pic_intr(DeviceState *dev) return 0; } =20 -static uint32_t apic_get_current_count(APICCommonState *s) -{ - int64_t d; - uint32_t val; - d =3D (qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) - s->initial_count_load_t= ime) >> - s->count_shift; - if (s->lvt[APIC_LVT_TIMER] & APIC_LVT_TIMER_PERIODIC) { - /* periodic */ - val =3D s->initial_count - (d % ((uint64_t)s->initial_count + 1)); - } else { - if (d >=3D s->initial_count) - val =3D 0; - else - val =3D s->initial_count - d; - } - return val; -} - static void apic_timer_update(APICCommonState *s, int64_t current_time) { if (apic_next_timer(s, current_time)) { diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c index 9ec0f2deb2..fb432e83f2 100644 --- a/hw/intc/apic_common.c +++ b/hw/intc/apic_common.c @@ -189,6 +189,25 @@ bool apic_next_timer(APICCommonState *s, int64_t curre= nt_time) return true; } =20 +uint32_t apic_get_current_count(APICCommonState *s) +{ + int64_t d; + uint32_t val; + d =3D (qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) - s->initial_count_load_t= ime) >> + s->count_shift; + if (s->lvt[APIC_LVT_TIMER] & APIC_LVT_TIMER_PERIODIC) { + /* periodic */ + val =3D s->initial_count - (d % ((uint64_t)s->initial_count + 1)); + } else { + if (d >=3D s->initial_count) { + val =3D 0; + } else { + val =3D s->initial_count - d; + } + } + return val; +} + void apic_init_reset(DeviceState *dev) { APICCommonState *s; diff --git a/include/hw/i386/apic_internal.h b/include/hw/i386/apic_interna= l.h index b04bdd947f..2597000e03 100644 --- a/include/hw/i386/apic_internal.h +++ b/include/hw/i386/apic_internal.h @@ -211,6 +211,7 @@ void vapic_report_tpr_access(DeviceState *dev, CPUState= *cpu, target_ulong ip, TPRAccess access); =20 int apic_get_ppr(APICCommonState *s); +uint32_t apic_get_current_count(APICCommonState *s); =20 static inline void apic_set_bit(uint32_t *tab, int index) { diff --git a/target/i386/helper.c b/target/i386/helper.c index c3a6e4fabe..e3c3726c29 100644 --- a/target/i386/helper.c +++ b/target/i386/helper.c @@ -370,10 +370,11 @@ void x86_cpu_dump_local_apic_state(CPUState *cs, int = flags) dump_apic_lvt("LVTTHMR", lvt[APIC_LVT_THERMAL], false); dump_apic_lvt("LVTT", lvt[APIC_LVT_TIMER], true); =20 - qemu_printf("Timer\t DCR=3D0x%x (divide by %u) initial_count =3D %u\n", + qemu_printf("Timer\t DCR=3D0x%x (divide by %u) initial_count =3D %u" + " current_count =3D %u\n", s->divide_conf & APIC_DCR_MASK, divider_conf(s->divide_conf), - s->initial_count); + s->initial_count, apic_get_current_count(s)); =20 qemu_printf("SPIV\t 0x%08x APIC %s, focus=3D%s, spurious vec %u\n", s->spurious_vec, --=20 2.16.4