From nobody Mon Feb 9 08:30:18 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1527817286186207.74686006942522; Thu, 31 May 2018 18:41:26 -0700 (PDT) Received: from localhost ([::1]:46963 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fOZ4E-0004f5-5J for importer@patchew.org; Thu, 31 May 2018 21:41:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fOYr4-00035d-Lk for qemu-devel@nongnu.org; Thu, 31 May 2018 21:27:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fOYr3-00037r-SG for qemu-devel@nongnu.org; Thu, 31 May 2018 21:27:46 -0400 Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:46918) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fOYr3-00037N-NF for qemu-devel@nongnu.org; Thu, 31 May 2018 21:27:45 -0400 Received: by mail-qt0-x242.google.com with SMTP id h5-v6so22286473qtm.13 for ; Thu, 31 May 2018 18:27:45 -0700 (PDT) Received: from localhost.localdomain (96-86-104-61-static.hfc.comcastbusiness.net. [96.86.104.61]) by smtp.gmail.com with ESMTPSA id o68-v6sm2003842qkc.19.2018.05.31.18.27.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 31 May 2018 18:27:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juliacomputing-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=vLHkSALVaGK1wFXtf9DTVfvI4Clr8oZ6T8vCp8aCeG0=; b=unpAdG23/L0bymkaBOWWV72lDkimMy25GndNmWxaELYGE+laTyjkgRnxj9cMPRsKgf KowqXHdtzECie/p07IitqTWhYr1+S/eP096/2aqQPak/8Y5to5VwOmASvJ3moNE/ral8 1EqPQHVKDZmGvsmv5SoT9CIrXGcoI0pxiFulqdT6Wg9Qd7vsrkKlSKWtqEKxSquXdBQP /4gh9hTysmqBLQI5fW4mcFhRFB8RLVnBqsKGS5VvYhYgv++CvG2L9/0HZMf4pwAo3Atm 6K73fIMLQNHrnxJFwYix3lHH4wXejh/7kRivgJthnRmcy01k67oHOetds7oGycMwz9Eg dHmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=vLHkSALVaGK1wFXtf9DTVfvI4Clr8oZ6T8vCp8aCeG0=; b=JBDbilEsyOZkyYyK9oIKVq6AGqLAODediMJ+i67V/y85IwjkbMa3DX/9J+cu0GSa3d xRGYJbPjHpz6FxgwBcUGTTgBEn/eB8hOmaYwAPJGdfGYjLJZjbKvKGsb0C6qeukDwLJi Zb585L1zfA+PlEJKN+pwzL1qH5OEFivcLBYrLME40Q0R/+/qv2gzLMP3U9ruVxVLpvmR lALyngOqItsB2GaPaLjcvwYeRlNMekz6A5UzGN9toeBv9MD2RocvDXuea2qd2+NUJnv5 eceNmH3Q/g40xn8NtHsdY6VLWlaE4wXPaTl9zCbTELdMFa/S9CoN69Ax73DYx0mqImu6 t3eQ== X-Gm-Message-State: APt69E3GCINEtTwV8lOinO8PFukPzyq7kq0T4BxO7oi//izlgkE9nOxR pQkpifZsjcvR6fLbq4WK8ngCQelJAno= X-Google-Smtp-Source: ADUXVKKb+KT68lu8OfV2fBG/hRes2v28Ooj33PoQgIJGqHrjfjI2M92JJycwjv/nLKscZTW5xL2Rlg== X-Received: by 2002:a0c:c602:: with SMTP id v2-v6mr8689212qvi.11.1527816464836; Thu, 31 May 2018 18:27:44 -0700 (PDT) From: Keno Fischer To: qemu-devel@nongnu.org Date: Thu, 31 May 2018 21:26:07 -0400 Message-Id: X-Mailer: git-send-email 2.8.1 In-Reply-To: References: In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::242 Subject: [Qemu-devel] [PATCH v2 12/20] 9p: darwin: Explicitly cast comparisons of mode_t with -1 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keno Fischer , groug@kaod.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Comparisons of mode_t with -1 require an explicit cast, since mode_t is unsigned on Darwin. Signed-off-by: Keno Fischer --- Changes from v1: Split from strchrnul change hw/9pfs/9p-local.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c index 6222891..1f0b1b0 100644 --- a/hw/9pfs/9p-local.c +++ b/hw/9pfs/9p-local.c @@ -310,7 +310,7 @@ update_map_file: if (credp->fc_gid !=3D -1) { gid =3D credp->fc_gid; } - if (credp->fc_mode !=3D -1) { + if (credp->fc_mode !=3D (mode_t)-1) { mode =3D credp->fc_mode; } if (credp->fc_rdev !=3D -1) { @@ -416,7 +416,7 @@ static int local_set_xattrat(int dirfd, const char *pat= h, FsCred *credp) return err; } } - if (credp->fc_mode !=3D -1) { + if (credp->fc_mode !=3D (mode_t)-1) { uint32_t tmp_mode =3D cpu_to_le32(credp->fc_mode); err =3D fsetxattrat_nofollow(dirfd, path, "user.virtfs.mode", &tmp= _mode, sizeof(mode_t), 0); --=20 2.8.1