From nobody Mon Feb 9 03:48:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1687783267; cv=none; d=zohomail.com; s=zohoarc; b=XlCmjDXGZG4NEifVHNzkGvT5rZgc6hz/AZqgRTmDHXx589q+jsQtHCqoWCfEjAf8ZdZPKD05HOTm8ntVo/Nrhd31Ig37DFsyWN4B41/gFyNJk18z9OnMSAn1PUbBLePvV3StBoeBoLEjkpXFBnJ9bg9HjDFsFS2T917d4mhZrDc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1687783267; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MJ9botFGkaoWh8PWyeQFOSjPZov2yyt/c15HeORAvds=; b=Yk2ITB2B2nYgoFUGDpBeH/+dH/qdTIdMXqzgdELubIt2sxxKYhZLsyOporlzvDweg21OczvaSK4lUKnjdj+s8FKQfboMpNLqzHopZuTKOQfJrJhPc3SIFVGFnor72yVRy/sZOK2UZow9Ep7gVVdhzHoU/X3smzHiF+B7tgup6z0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1687783267696591.1182555509289; Mon, 26 Jun 2023 05:41:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDlO2-0007fe-Ne; Mon, 26 Jun 2023 08:32:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDlMQ-0005Q7-MM for qemu-devel@nongnu.org; Mon, 26 Jun 2023 08:30:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDlMO-0003Zm-Tf for qemu-devel@nongnu.org; Mon, 26 Jun 2023 08:30:26 -0400 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-360-Vi8nS49hN3aND3Xma93hGA-1; Mon, 26 Jun 2023 08:30:22 -0400 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f9bd5c7fdfso18612115e9.1 for ; Mon, 26 Jun 2023 05:30:22 -0700 (PDT) Received: from redhat.com ([2.52.156.102]) by smtp.gmail.com with ESMTPSA id z24-20020a05600c221800b003fa96fe2bd9sm2651949wml.22.2023.06.26.05.30.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 05:30:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687782624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MJ9botFGkaoWh8PWyeQFOSjPZov2yyt/c15HeORAvds=; b=Kwve6T+S1R6WzEHsdLpleiZrokJVVAXLWfFcPuU1PDLvDTTy1+jBG2MUSWUrj2mZU9xYq0 FU6CBV/Zk+066JWKgIIdxle9+jf/n80U0Uqe7Rdyjz66u04BMB1YFaaTJI6GA/JN8QxX+G 0X6a4JZHCJ+FdbDRRzBsdFQ+8PUFMMg= X-MC-Unique: Vi8nS49hN3aND3Xma93hGA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687782621; x=1690374621; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MJ9botFGkaoWh8PWyeQFOSjPZov2yyt/c15HeORAvds=; b=GyHSBJDHUqpH3BxFbKoYIZbV9MdZcyP8FMWeNuP/ec3bV+XPGZMYmU7MvQt48k+l4D NYDPxqdneklBUpsAb1K9kgdciov7Dod2741NFzFdNvzbfJ2Wr/pdjRQequlb8BGxQ+js 7T1K58dFnEQPHPj4cVbXPg8SALn/nklIC2F9R6zVasuFp/TM8KNhGnBvFfZpeXPcAel0 4YgqtQiCiJGf80j+0OapltDpy/oUkkJunv7bhyFyP8cAU3rTsQioXJzw7H0BmdGGd6K0 rquHsPn+JoyMSB9ZYrBqOhVl5GG/GTLfEetS1a6E3ng9GQ3Oq8IyLuwOqhfHWMglbI0o kg3w== X-Gm-Message-State: AC+VfDwjZKrcAKVophRFCvKLwBdni9fKcQlT0OLz4hpbKIpfZc2ZTAM/ ZLSwTNXMynoba7KWiYxg6oQgzWKT/L8xRyuYC2XytqDK7NpIgQB59tkxOk93XaP1/8E+BRbLdQT nngfOe8dZ+wj3Coy4jfKD/EQMa/4YRls4tOavZvBmJRpb/SqIf5hZqsfemkFOwwz6cunL X-Received: by 2002:a1c:f603:0:b0:3f8:f80e:7b45 with SMTP id w3-20020a1cf603000000b003f8f80e7b45mr22022474wmc.7.1687782621097; Mon, 26 Jun 2023 05:30:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Ih30cCXNPPKlyYgSpGkv31POYM5uIHSsSNrKGP28p6SmlJkRLS+XRCypx/4oLiDIYhQl2CQ== X-Received: by 2002:a1c:f603:0:b0:3f8:f80e:7b45 with SMTP id w3-20020a1cf603000000b003f8f80e7b45mr22022447wmc.7.1687782620756; Mon, 26 Jun 2023 05:30:20 -0700 (PDT) Date: Mon, 26 Jun 2023 08:30:17 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Cc: Peter Maydell , Zhenzhong Duan , Peter Xu , Jason Wang , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum Subject: [PULL 50/53] intel_iommu: Fix flag check in replay Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1687783269423100009 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Zhenzhong Duan Replay doesn't notify registered notifiers but the one passed to it. So it's meaningless to check the registered notifier's synthetic flag. There is no issue currently as all replay use cases have MAP flag set, but let's be robust. Signed-off-by: Zhenzhong Duan Reviewed-by: Peter Xu Message-Id: <20230615032626.314476-3-zhenzhong.duan@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/intel_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 34af12f392..f046f85913 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -3837,7 +3837,7 @@ static void vtd_iommu_replay(IOMMUMemoryRegion *iommu= _mr, IOMMUNotifier *n) PCI_FUNC(vtd_as->devfn), vtd_get_domain_id(s, &ce, vtd_as->pasid), ce.hi, ce.lo); - if (vtd_as_has_map_notifier(vtd_as)) { + if (n->notifier_flags & IOMMU_NOTIFIER_MAP) { /* This is required only for MAP typed notifiers */ vtd_page_walk_info info =3D { .hook_fn =3D vtd_replay_hook, --=20 MST