From nobody Wed Feb 11 07:49:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=eik.bme.hu Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770753827560955.810697825456; Tue, 10 Feb 2026 12:03:47 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vptwZ-0000uC-13; Tue, 10 Feb 2026 15:02:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vptwG-0000p0-AZ for qemu-devel@nongnu.org; Tue, 10 Feb 2026 15:02:25 -0500 Received: from zero.eik.bme.hu ([2001:738:2001:2001::2001]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vptwE-00052F-3H for qemu-devel@nongnu.org; Tue, 10 Feb 2026 15:02:23 -0500 Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id 8526E596E9E; Tue, 10 Feb 2026 21:02:16 +0100 (CET) Received: from zero.eik.bme.hu ([127.0.0.1]) by localhost (zero.eik.bme.hu [127.0.0.1]) (amavis, port 10028) with ESMTP id RXhpb9tbmoVs; Tue, 10 Feb 2026 21:02:14 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 82FEC596E91; Tue, 10 Feb 2026 21:02:14 +0100 (CET) X-Virus-Scanned: amavis at eik.bme.hu Message-ID: In-Reply-To: References: From: BALATON Zoltan Subject: [PATCH v3 6/6] hw/xtensa/xtfpga: Fix leaking memory region MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: qemu-devel@nongnu.org Cc: Peter Xu , Akihiko Odaki , Paolo Bonzini , Mark Cave-Ayland , Gerd Hoffmann , Max Filippov , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Date: Tue, 10 Feb 2026 21:02:14 +0100 (CET) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:738:2001:2001::2001; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1770753830586154100 Content-Type: text/plain; charset="utf-8" Use memory_region_new_ram to avoid leaking memory region. This would be a migration break but the machines using this don't seem to support migration and even if they did we make no compatibility guarantee for these machines. Signed-off-by: BALATON Zoltan --- hw/xtensa/xtfpga.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/xtensa/xtfpga.c b/hw/xtensa/xtfpga.c index b025cc53a8..b8ae1994d8 100644 --- a/hw/xtensa/xtfpga.c +++ b/hw/xtensa/xtfpga.c @@ -50,7 +50,6 @@ #include "xtensa_memory.h" #include "hw/xtensa/mx_pic.h" #include "exec/cpu-common.h" -#include "migration/vmstate.h" =20 typedef struct XtfpgaFlashDesc { hwaddr base; @@ -162,10 +161,8 @@ static void xtfpga_net_init(MemoryRegion *address_spac= e, memory_region_add_subregion(address_space, descriptors, sysbus_mmio_get_region(s, 1)); =20 - ram =3D g_malloc(sizeof(*ram)); - memory_region_init_ram_flags_nomigrate(ram, OBJECT(s), "open_eth.ram", - 16 * KiB, 0, &error_fatal); - vmstate_register_ram_global(ram); + ram =3D memory_region_new_ram(OBJECT(s), "open_eth.ram", 16 * KiB, + &error_fatal); memory_region_add_subregion(address_space, buffers, ram); } =20 --=20 2.41.3