From nobody Mon Apr 29 14:04:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=listsout.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from listsout.gnu.org (listsout.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 15468127184661013.7779599033107; Sun, 6 Jan 2019 14:11:58 -0800 (PST) Received: from localhost ([127.0.0.1]:38888 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggGe9-0001GP-7y for importer@patchew.org; Sun, 06 Jan 2019 17:11:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggGd9-0000jA-DT for qemu-devel@nongnu.org; Sun, 06 Jan 2019 17:10:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggGd8-0004cn-Ce for qemu-devel@nongnu.org; Sun, 06 Jan 2019 17:10:51 -0500 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:37668) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ggGd5-0004cH-IB; Sun, 06 Jan 2019 17:10:47 -0500 Received: by mail-wr1-x442.google.com with SMTP id s12so41351125wrt.4; Sun, 06 Jan 2019 14:10:46 -0800 (PST) Received: from ?IPv6:2a02:c7d:8625:5a01:7503:9d7c:2958:5e7d? ([2a02:c7d:8625:5a01:7503:9d7c:2958:5e7d]) by smtp.gmail.com with ESMTPSA id o4sm46464221wrq.66.2019.01.06.14.10.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Jan 2019 14:10:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=iQ9T46e91ARm6CPDv9Tgj7uRRERtmnvfaVaRPTfnb5I=; b=YE/IA38LdxCp4plbYBP7dzXkxgmMIWvQXWjOZSHdM5uESzXcCwuHviJcyC9rhVBMfv x0MzNiMGfz9RhQ6bRenBR5vm+o7kvM3vI5HcuF9nZodLJAAL3Fi2jjwDIXlhanQ0Iu4c WELJsveIVudpYG35US8Jc1I3BLBJv4LZc0y2G1Dat0xr39Zjtq4jLRYeRZ+ajVpjtdu0 ieLna8cnrH/p1PdcYR78go5MfBytWLalFqLbByPMPKeLEfwYxSnXYzPkCx9V08rvhfcm Bc+IDfATBKPMh3kTkKkxfA3VKFirYB0YhsQ88DNd7OKbmUw4qcuIyUszLg5u6dER0J+8 D7XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=iQ9T46e91ARm6CPDv9Tgj7uRRERtmnvfaVaRPTfnb5I=; b=hOSi2QJhtb/kwlkf2RCN6B/6+3Bpumwn1KzloySG5xUFiLzlREYcP7Jhg01MXvmaQL 74gt5H4SKWCgG2VmLRpnEy/E+xMFb9FPtcrelvUaUgBvz5m0i+oAIvvNgUCDrug5o1m7 5F3WD7AxD7uf81UBBEkrVuP+xlrqLV9agV2y5mq+OiQBz+256FaEm6rl2zLQThTr/CD/ FyMvd35+YC4jTv/9Cx/wFE9/15lbxpIncEh0cw6YFwR46RfacJbEY3GmQkxoJEeIXFit HiZCUE2GkwLSdC+/dciqkp2DDIP7MHCXhOZtHpH92tuNP6s0pYhOhSYPyYzAdZFNxrXp 6bng== X-Gm-Message-State: AJcUukcNxd27EBmJ652bgcXFIyOV8bTlZo9hTVxRft7W4QaoyoBn/fqW Sh/nXX5fYEqKzUfCotyyRKQ= X-Google-Smtp-Source: ALg8bN4yS+PZ/Va8RtzeXHrp+ADavW4UfqDPHo+KrBV16I5zfu4j+eEtKdBoLRMwGltz20Q75TcAJw== X-Received: by 2002:adf:90e5:: with SMTP id i92mr47281657wri.210.1546812645601; Sun, 06 Jan 2019 14:10:45 -0800 (PST) To: QEMU Developers From: Nick Hudson Message-ID: Date: Sun, 6 Jan 2019 22:10:42 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 Subject: [Qemu-devel] [PATCH v4] Support u-boot noload images for arm as used by, NetBSD/evbarm GENERIC kernel. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-arm Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" noload kernels are loaded with the u-boot image header and as a result the header size needs adding to the entry point. Fake up a hdr so the kernel image is loaded at the right address and the entry point is adjusted appropriately. The default location for the uboot file is 32MiB above bottom of DRAM. This matches the recommendation in Documentation/arm/Booting. Clarify the load_uimage API to state the passing of a load address when an image doesn't specify one, or when loading a ramdisk is expected. Adjust callers of load_uimage, etc. --- hw/arm/boot.c | 8 +++++--- hw/core/loader.c | 19 ++++++++++++++++--- hw/core/uboot_image.h | 1 + hw/microblaze/boot.c | 2 +- hw/nios2/boot.c | 2 +- hw/ppc/e500.c | 1 + hw/ppc/ppc440_bamboo.c | 2 +- hw/ppc/sam460ex.c | 2 +- include/hw/loader.h | 7 ++++++- 9 files changed, 33 insertions(+), 11 deletions(-) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index 94fce12802..c7a67af7a9 100644 --- a/hw/arm/boot.c +++ b/hw/arm/boot.c @@ -30,8 +30,9 @@ * Documentation/arm/Booting and Documentation/arm64/booting.txt * They have different preferred image load offsets from system RAM base. */ -#define KERNEL_ARGS_ADDR 0x100 -#define KERNEL_LOAD_ADDR 0x00010000 +#define KERNEL_ARGS_ADDR 0x100 +#define KERNEL_NOLOAD_ADDR 0x02000000 +#define KERNEL_LOAD_ADDR 0x00010000 #define KERNEL64_LOAD_ADDR 0x00080000 =20 #define ARM64_TEXT_OFFSET_OFFSET 8 @@ -1082,7 +1083,8 @@ void arm_load_kernel(ARMCPU *cpu, struct arm_boot_inf= o *info) } entry =3D elf_entry; if (kernel_size < 0) { - kernel_size =3D load_uimage_as(info->kernel_filename, &entry, NULL, + uint64_t loadaddr =3D info->loader_start + KERNEL_NOLOAD_ADDR; + kernel_size =3D load_uimage_as(info->kernel_filename, &entry, &loa= daddr, &is_linux, NULL, NULL, as); } if (arm_feature(&cpu->env, ARM_FEATURE_AARCH64) && kernel_size < 0) { diff --git a/hw/core/loader.c b/hw/core/loader.c index fa41842280..c7182dfa64 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -613,13 +613,26 @@ static int load_uboot_image(const char *filename, hwa= ddr *ep, hwaddr *loadaddr, goto out; =20 if (hdr->ih_type !=3D image_type) { - fprintf(stderr, "Wrong image type %d, expected %d\n", hdr->ih_type, - image_type); - goto out; + if (!(image_type =3D=3D IH_TYPE_KERNEL && + hdr->ih_type =3D=3D IH_TYPE_KERNEL_NOLOAD)) { + fprintf(stderr, "Wrong image type %d, expected %d\n", hdr->ih_= type, + image_type); + goto out; + } } =20 /* TODO: Implement other image types. */ switch (hdr->ih_type) { + case IH_TYPE_KERNEL_NOLOAD: + if (!loadaddr || *loadaddr =3D=3D LOAD_UIMAGE_LOADADDR_INVALID) { + fprintf(stderr, "this image format (kernel_noload) cannot be " + "loaded on this machine type"); + goto out; + } + + hdr->ih_load =3D *loadaddr + sizeof(*hdr); + hdr->ih_ep +=3D hdr->ih_load; + /* fall through */ case IH_TYPE_KERNEL: address =3D hdr->ih_load; if (translate_fn) { diff --git a/hw/core/uboot_image.h b/hw/core/uboot_image.h index 34c11a70a6..608022de6e 100644 --- a/hw/core/uboot_image.h +++ b/hw/core/uboot_image.h @@ -124,6 +124,7 @@ #define IH_TYPE_SCRIPT 6 /* Script file */ #define IH_TYPE_FILESYSTEM 7 /* Filesystem Image (any type) */ #define IH_TYPE_FLATDT 8 /* Binary Flat Device Tree Blob */ +#define IH_TYPE_KERNEL_NOLOAD 14 /* OS Kernel Image (noload) */ =20 /* * Compression Types diff --git a/hw/microblaze/boot.c b/hw/microblaze/boot.c index 35bfeda7aa..489ab839b7 100644 --- a/hw/microblaze/boot.c +++ b/hw/microblaze/boot.c @@ -156,7 +156,7 @@ void microblaze_load_kernel(MicroBlazeCPU *cpu, hwaddr = ddr_base, =20 /* If it wasn't an ELF image, try an u-boot image. */ if (kernel_size < 0) { - hwaddr uentry, loadaddr; + hwaddr uentry, loadaddr =3D LOAD_UIMAGE_LOADADDR_INVALID; =20 kernel_size =3D load_uimage(kernel_filename, &uentry, &loadadd= r, 0, NULL, NULL); diff --git a/hw/nios2/boot.c b/hw/nios2/boot.c index 4bb5b601d3..ed5cb28e94 100644 --- a/hw/nios2/boot.c +++ b/hw/nios2/boot.c @@ -161,7 +161,7 @@ void nios2_load_kernel(Nios2CPU *cpu, hwaddr ddr_base, =20 /* If it wasn't an ELF image, try an u-boot image. */ if (kernel_size < 0) { - hwaddr uentry, loadaddr; + hwaddr uentry, loadaddr =3D LOAD_UIMAGE_LOADADDR_INVALID; =20 kernel_size =3D load_uimage(kernel_filename, &uentry, &loadadd= r, 0, NULL, NULL); diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index b20fea0dfc..0581e9e3d4 100644 --- a/hw/ppc/e500.c +++ b/hw/ppc/e500.c @@ -995,6 +995,7 @@ void ppce500_init(MachineState *machine) * Hrm. No ELF image? Try a uImage, maybe someone is giving us an * ePAPR compliant kernel */ + loadaddr =3D LOAD_UIMAGE_LOADADDR_INVALID; payload_size =3D load_uimage(filename, &bios_entry, &loadaddr, NUL= L, NULL, NULL); if (payload_size < 0) { diff --git a/hw/ppc/ppc440_bamboo.c b/hw/ppc/ppc440_bamboo.c index b8aa55d526..fc06191588 100644 --- a/hw/ppc/ppc440_bamboo.c +++ b/hw/ppc/ppc440_bamboo.c @@ -179,7 +179,7 @@ static void bamboo_init(MachineState *machine) CPUPPCState *env; uint64_t elf_entry; uint64_t elf_lowaddr; - hwaddr loadaddr =3D 0; + hwaddr loadaddr =3D LOAD_UIMAGE_LOADADDR_INVALID; target_long initrd_size =3D 0; DeviceState *dev; int success; diff --git a/hw/ppc/sam460ex.c b/hw/ppc/sam460ex.c index 4b051c0950..84ea592749 100644 --- a/hw/ppc/sam460ex.c +++ b/hw/ppc/sam460ex.c @@ -402,7 +402,7 @@ static void sam460ex_init(MachineState *machine) CPUPPCState *env; PPC4xxI2CState *i2c[2]; hwaddr entry =3D UBOOT_ENTRY; - hwaddr loadaddr =3D 0; + hwaddr loadaddr =3D LOAD_UIMAGE_LOADADDR_INVALID; target_long initrd_size =3D 0; DeviceState *dev; SysBusDevice *sbdev; diff --git a/include/hw/loader.h b/include/hw/loader.h index 0a0ad808ea..84d6bb44b7 100644 --- a/include/hw/loader.h +++ b/include/hw/loader.h @@ -175,10 +175,15 @@ void load_elf_hdr(const char *filename, void *hdr, bo= ol *is64, Error **errp); int load_aout(const char *filename, hwaddr addr, int max_sz, int bswap_needed, hwaddr target_page_size); =20 +#define LOAD_UIMAGE_LOADADDR_INVALID (-1) + /** load_uimage_as: * @filename: Path of uimage file * @ep: Populated with program entry point. Ignored if NULL. - * @loadaddr: Populated with the load address. Ignored if NULL. + * @loadaddr: load address if none specified in the image or when loading = a ramdisk. + * Populated with the the load address. Ignored if NULL or + * LOAD_UIMAGE_LOADADDR_INVALID (images which do not specify a = load address + * will not be loadable). * @is_linux: Is set to true if the image loaded is Linux. Ignored if NULL. * @translate_fn: optional function to translate load addresses * @translate_opaque: opaque data passed to @translate_fn --=20 2.17.1