From nobody Fri Nov 7 12:03:14 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1547739762324555.047803194324; Thu, 17 Jan 2019 07:42:42 -0800 (PST) Received: from localhost ([127.0.0.1]:46807 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gk9oX-0008LH-Aq for importer@patchew.org; Thu, 17 Jan 2019 10:42:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gk9gl-0001q2-4u for qemu-devel@nongnu.org; Thu, 17 Jan 2019 10:34:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gk9gh-0007bo-KV for qemu-devel@nongnu.org; Thu, 17 Jan 2019 10:34:37 -0500 Received: from fanzine.igalia.com ([91.117.99.155]:59820) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gk9gf-0007Iv-OG; Thu, 17 Jan 2019 10:34:35 -0500 Received: from [194.100.51.2] (helo=perseus.local) by fanzine.igalia.com with esmtpsa (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim) id 1gk9gY-0003bW-II; Thu, 17 Jan 2019 16:34:26 +0100 Received: from berto by perseus.local with local (Exim 4.89) (envelope-from ) id 1gk9gI-0007R9-S5; Thu, 17 Jan 2019 17:34:10 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=References:In-Reply-To:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=8mqTp2fl48arWAh+3SJcUCy7rJ4fNzNV3IPwyPxfHpM=; b=fGYO2x6E2nFFlEKCE/J/IX11LH24asBRff2627/re/l+HK5Yi2xWJv20fsrTMQlk+vJapaMh2Q36criTyiljVq++CgUyJNSgGJn42RRqiI5PwCTG4BC5d5u9eOT7V4d85S/aRueEEJHxzn33rmmetfGegncVfLEsAiBHAgm2lqasSkifXVoiV0UDM1NI0rfsovEUbiIK4TfSVBZ+UJjKA5rRnwl7Imn4RvkHVGK8CSGpZ1En4t2wcBrSius12pq2Bb/B/ZS72GSSXBey9QokM3+raoZdy2/ylgol14J27Qact4qgVdDMLKbyIirBgAvF1f9DpmfxOEw6knVh+IetVA==; From: Alberto Garcia To: qemu-devel@nongnu.org Date: Thu, 17 Jan 2019 17:33:54 +0200 Message-Id: X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 91.117.99.155 Subject: [Qemu-devel] [PATCH 03/13] block: Freeze the backing chain for the duration of the mirror job X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Alberto Garcia , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Alberto Garcia --- block/mirror.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/block/mirror.c b/block/mirror.c index 22bef9f7e9..afbc30da61 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -630,6 +630,10 @@ static int mirror_exit_common(Job *job) } s->prepared =3D true; =20 + if (bdrv_chain_contains(src, target_bs)) { + bdrv_unfreeze_backing_chain(mirror_top_bs, target_bs); + } + bdrv_release_dirty_bitmap(src, s->dirty_bitmap); =20 /* Make sure that the source BDS doesn't go away during bdrv_replace_n= ode, @@ -1641,6 +1645,10 @@ static void mirror_start_job(const char *job_id, Blo= ckDriverState *bs, goto fail; } } + + if (bdrv_freeze_backing_chain(mirror_top_bs, target, errp) < 0) { + goto fail; + } } =20 QTAILQ_INIT(&s->ops_in_flight); --=20 2.11.0