From nobody Wed Nov 5 11:01:09 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1540294264981363.5150810504955; Tue, 23 Oct 2018 04:31:04 -0700 (PDT) Received: from localhost ([::1]:40310 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gEutn-00084E-3K for importer@patchew.org; Tue, 23 Oct 2018 07:30:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42803) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gEumk-0001qm-IB for qemu-devel@nongnu.org; Tue, 23 Oct 2018 07:23:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gEumi-0007jz-1x for qemu-devel@nongnu.org; Tue, 23 Oct 2018 07:23:42 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:39132) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gEumg-0007ex-1Q for qemu-devel@nongnu.org; Tue, 23 Oct 2018 07:23:38 -0400 Received: by mail-wr1-f68.google.com with SMTP id r10-v6so363036wrv.6 for ; Tue, 23 Oct 2018 04:23:35 -0700 (PDT) Received: from localhost.localdomain (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id g8-v6sm1498990wmf.45.2018.10.23.04.23.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Oct 2018 04:23:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s2YgaCnLP12cyII7rhvQCvotFBtfpUv1EX4w2HDrZb0=; b=MzRTeAs0bPZZgJtXsON6Ur0hFfh/+YNkYxMsOJmo8Io3KNDUgVkD0VFGLAN40gQ9oa C97LvbhGhQm8k3dTN0IHXLS0OdL9BDfC5XJuV7N5VkJO9TSs9QqsAPJfHIkGOjvqw8ue Kx1PFTUSmtFOJ2EcqsgY+Tz+UWhu7Sw/9vZtKM8DQXb7S54rycwrZNGuFVS7bL8+8ypH MbNx1a/7gwN2WeASC4f6zGCP4rKgyBI5ZwZtSpnonlaWf6KvkpnzwBlNnotmHcEExL/8 UH5wtfjYuMz5U7Xrh2oZBnHINTnstfQMTVAtlowUWWoG4BYs89ksTE+SdWtGRwBHGtSB UplA== X-Gm-Message-State: AGRZ1gKxQcJPVn9f/VWgY//mXGq++85SGfZq8oqVikkxEdxdrX1uSm/q kYad5OzjM+RAsNiW0SGfGoXBn5MeNpo= X-Google-Smtp-Source: AJdET5erShF2yNwOCNhzj1SgME+afOg+QE8sNqEnoxok0My2I4qTsiMzzKhb9+TtNVkuLUJG12Sz0w== X-Received: by 2002:a5d:4406:: with SMTP id z6-v6mr8765028wrq.308.1540293814731; Tue, 23 Oct 2018 04:23:34 -0700 (PDT) From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Golembiovsk=C3=BD?= To: qemu-devel@nongnu.org Date: Tue, 23 Oct 2018 13:23:16 +0200 Message-Id: X-Mailer: git-send-email 2.19.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.221.68 Subject: [Qemu-devel] [PATCH v5 07/14] build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSI X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roth , Olga Krishtal , =?UTF-8?q?Tom=C3=A1=C5=A1=20Golembiovsk=C3=BD?= , Sameeh Jubran , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RDMRC_1 RSF_0 Z_629925259 SPT_0 There was inconsistency between commits: 50cbebb9a3 configure: add configure check for ntdddisk.h a3ef3b2272 qga: added bus type and disk location path The first commit added #define CONFIG_QGA_NTDDDISK but the second commit expected the name to be CONFIG_QGA_NTDDSCSI. As a result the code in second patch was never used. Renaming the option to CONFIG_QGA_NTDDSCSI to match the name of header file that is being checked for. Signed-off-by: Tom=C3=A1=C5=A1 Golembiovsk=C3=BD Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Sameeh Jubran --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 26e8605bbc..491e6e85c4 100755 --- a/configure +++ b/configure @@ -6204,7 +6204,7 @@ if test "$mingw32" =3D "yes" ; then echo "WIN_SDK=3D\"$win_sdk\"" >> $config_host_mak fi if test "$guest_agent_ntddscsi" =3D "yes" ; then - echo "CONFIG_QGA_NTDDDISK=3Dy" >> $config_host_mak + echo "CONFIG_QGA_NTDDSCSI=3Dy" >> $config_host_mak fi if test "$guest_agent_msi" =3D "yes"; then echo "QEMU_GA_MSI_ENABLED=3Dyes" >> $config_host_mak --=20 2.19.0