From nobody Sun Apr 5 16:27:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=163.com ARC-Seal: i=1; a=rsa-sha256; t=1774284687; cv=none; d=zohomail.com; s=zohoarc; b=DuA4ODP9jflEKYNebm7fLipVxzm4Q0K8tn4cMVJw7nHPcVhZ0TNtdXZ3JSXmiGga7LZE6eTAetO5Vb0yvFnH5xx/tZc4RIvyAxgJz4m3htYkBCiHf5b++TWOZsm0997klidFrI2VmqtrqVOyIJ+BIL60r735VS9eZKrImpvf0Co= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774284687; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=aeDjjVRMT/dIuNCZwQoXRf0bQC8+WgxwfQJexXCLxHE=; b=dJXkC2GkfChGckdznMN1gklA6xdTzQ0+GXI1vQKkeI1iLJtHndP/bEUPnVRsb6dqPmcQDOZ0SHcIBTVA2O7YnIYicu8vOsxuCyoOdK47CekYoL22cyKaQ/cdPxXzu3XQKzjuREfuZOdj28XCarM6FRoduc0br9FhHFXUYLgfArM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1774284687586166.96788843340198; Mon, 23 Mar 2026 09:51:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w4iUX-0000Bj-Jv; Mon, 23 Mar 2026 12:51:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w4iUO-00005s-FY; Mon, 23 Mar 2026 12:50:52 -0400 Received: from m16.mail.163.com ([220.197.31.2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w4iUH-0000H3-UE; Mon, 23 Mar 2026 12:50:52 -0400 Received: from dt-VM.localdomain (unknown []) by gzsmtp4 (Coremail) with SMTP id PygvCgAH5qxAb8FpwWGXTQ--.954S3; Tue, 24 Mar 2026 00:50:12 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=ae DjjVRMT/dIuNCZwQoXRf0bQC8+WgxwfQJexXCLxHE=; b=Ya6Ad3GELVId9eMuvW +sKJttZUHp0lajCVtZwkhd7EIc/wseI63XLYb+vatrNVjBta0djKaRGlXuN4N08f cW6Ob3qqZVpJsFB+kZJZGuVW9Wz/0C93N7X//M0w+mtbzQCPsy9bxMRU9JwCf9dB JYataFhx40dPNGExe5E38OKHU= From: Tao Ding To: Peter Maydell , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Tao Ding Subject: [PATCH v2 1/1] Fix transfer size register decrement in pl080 Date: Tue, 24 Mar 2026 00:50:07 +0800 Message-ID: <5856c66fd4e495b874815adba9dcfeddc1f47e65.1774282897.git.dingtao0430@163.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: PygvCgAH5qxAb8FpwWGXTQ--.954S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7Ww15XF4kZrWruF4xXF13Jwb_yoW8tw4UpF yDKFySkr4Fq34rZ3Z0qr40gr15Xa1Iy3ZxK3y2gr1DCr1kuFy3Gr1rGrWxJFWYvwn7Zr1r ta4DWr4Y9r1qqw7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07U75rxUUUUU= X-Originating-IP: [119.4.67.184] X-CM-SenderInfo: pglqw3tdrqkjqq6rljoofrz/xtbC4QS39WnBb0SKqAAA3G Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=220.197.31.2; envelope-from=dingtao0430@163.com; helo=m16.mail.163.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @163.com) X-ZM-MESSAGEID: 1774284688147158500 Content-Type: text/plain; charset="utf-8" Configure swidth to 1 byte, width to 4 bytes, and transfer size to 4. Configuration ../configure --target-list=3Darm-softmmu --enable-debug Reproducer ./qemu-system-arm -M versatilepb -m 128M -nographic -S \ -device loader,addr=3D0x00000000,data=3D0x44332211,data-len=3D4 \ -device loader,addr=3D0x00001000,data=3D0x00000000,data-len=3D4 \ -device loader,addr=3D0x10130030,data=3D0x00000001,data-len=3D4 \ -device loader,addr=3D0x10130100,data=3D0x00000000,data-len=3D4 \ -device loader,addr=3D0x10130104,data=3D0x00001000,data-len=3D4 \ -device loader,addr=3D0x10130108,data=3D0x00000000,data-len=3D4 \ -device loader,addr=3D0x1013010C,data=3D0x9e47f004,data-len=3D4 \ -device loader,addr=3D0x10130110,data=3D0x0000c001,data-len=3D4=20 Qemu monitor (qemu) xp /1wx 0x00001000 00001000: 0x00002211 The result correctly after fixed (qemu) xp /1wx 0x00001000 00001000: 0x44332211 Suggested-by: Peter Maydell Signed-off-by: Tao Ding --- hw/dma/pl080.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/dma/pl080.c b/hw/dma/pl080.c index 627ccbbd81..4a90c7bb27 100644 --- a/hw/dma/pl080.c +++ b/hw/dma/pl080.c @@ -179,23 +179,28 @@ again: c, extract32(ch->ctrl, 21, 3)); continue; } - - for (n =3D 0; n < dwidth; n+=3D swidth) { + if ((size * swidth) % dwidth) { + qemu_log_mask(LOG_GUEST_ERROR, + "pl080: channel %d: transfer size mismatch: size=3D%d = swidth=3D%d dwidth=3D%d\n", + c, size, swidth, dwidth); + continue; + } + xsize =3D MAX(swidth, dwidth); + for (n =3D 0; n < xsize; n +=3D swidth) { address_space_read(&s->downstream_as, ch->src, MEMTXATTRS_UNSPECIFIED, buff + n, swidt= h); if (ch->ctrl & PL080_CCTRL_SI) ch->src +=3D swidth; } - xsize =3D (dwidth < swidth) ? swidth : dwidth; /* ??? This may pad the value incorrectly for dwidth < 32. */ for (n =3D 0; n < xsize; n +=3D dwidth) { - address_space_write(&s->downstream_as, ch->dest + n, + address_space_write(&s->downstream_as, ch->dest, MEMTXATTRS_UNSPECIFIED, buff + n, dwid= th); if (ch->ctrl & PL080_CCTRL_DI) - ch->dest +=3D swidth; + ch->dest +=3D dwidth; } =20 - size--; + size -=3D xsize / swidth; ch->ctrl =3D (ch->ctrl & 0xfffff000) | size; if (size =3D=3D 0) { /* Transfer complete. */ --=20 2.43.0