From nobody Sat Feb 7 06:13:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1668009498; cv=none; d=zohomail.com; s=zohoarc; b=U3ZzilRK46B6FfMVVRaTV0Z2rBJcHUrFXfNKgB085141bF3CBXDAnEYO6KZZD5htTs1sKQWvl/8/kIkdgNaTTn9LNtO+VCOSh7vI1Y8kKX8LhIDmT4dzaMiSWZ9Rr7yAHz0ocyPusyhfgwpBy0yYRt3xGa0VYsCQ+BQTeoPVv2w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668009498; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yj5ZLy7UgEu+A/BDjFAC6gOaDRncxqI9pvQtJekPyVY=; b=Uclh60q3whYjlg+2laVmAWFQlEVve5Trj94OGNoWc2uBtYTmpQdf1G8SCip0aLy8tFlT1TKaIbj6ePRLrath1RqCjnpPXjXlDjiXnpOudKyhGoXNLjGop6bUQXDS5g2xakyR7SZlkJXGC5qdSufcOcvYStNiNbopcSx45wwu2Os= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1668009498575177.59875136322717; Wed, 9 Nov 2022 07:58:18 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osnST-0001rg-0T; Wed, 09 Nov 2022 10:57:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osnSQ-0001pE-6p for qemu-devel@nongnu.org; Wed, 09 Nov 2022 10:57:43 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osnS9-0005ha-Ez for qemu-devel@nongnu.org; Wed, 09 Nov 2022 10:57:41 -0500 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-654-23CFuIQLMnmnNlMeGIxl7Q-1; Wed, 09 Nov 2022 10:57:17 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 232A93C32985 for ; Wed, 9 Nov 2022 15:57:17 +0000 (UTC) Received: from wi2021.rezanina.moe.rezanina.moe (ovpn-193-213.brq.redhat.com [10.40.193.213]) by smtp.corp.redhat.com (Postfix) with ESMTP id 64AB940C2087; Wed, 9 Nov 2022 15:57:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668009440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yj5ZLy7UgEu+A/BDjFAC6gOaDRncxqI9pvQtJekPyVY=; b=MO2xjKv5JPAEE3ESDanLMocbSOSJs01anlbMTsAImxKCozdFN0UreOs4MoHJI+/VMrPOiO VSnYIf58yKaOej/n/uvpz7eel0t/WlcGcmTzRG579+yiBYe5lakILCYy0fQRFbC66KRQb7 aXJHAGBBmsOGrDJZN1QZLZ57CMPSJls= X-MC-Unique: 23CFuIQLMnmnNlMeGIxl7Q-1 From: mrezanin@redhat.com To: qemu-devel@nongnu.org Cc: Miroslav Rezanina Subject: [PATCH 1/4] rtl8139: Remove unused variable Date: Wed, 9 Nov 2022 10:57:11 -0500 Message-Id: <15a32dd06c492216cbf27cd3ddcbe1e9afb8d8f5.1668009030.git.mrezanin@redhat.com> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=mrezanin@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1668009499496100003 Content-Type: text/plain; charset="utf-8" From: Miroslav Rezanina Variable send_count used in rtl8139_cplus_transmit_one function is only incremented but never read. This causes 'Unused but set variable' warning on Clang 15.0.1 compiler. Removing the variable to prevent the warning. Signed-off-by: Miroslav Rezanina Reviewed-by: Thomas Huth --- hw/net/rtl8139.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c index 6b65823b4b..e6643e3c9d 100644 --- a/hw/net/rtl8139.c +++ b/hw/net/rtl8139.c @@ -2156,7 +2156,6 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s) ip_data_len, saved_size - ETH_HLEN, large_send_mss); =20 int tcp_send_offset =3D 0; - int send_count =3D 0; =20 /* maximum IP header length is 60 bytes */ uint8_t saved_ip_header[60]; @@ -2261,7 +2260,6 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s) /* add transferred count to TCP sequence number */ stl_be_p(&p_tcp_hdr->th_seq, chunk_size + ldl_be_p(&p_tcp_hdr->th_seq)); - ++send_count; } =20 /* Stop sending this frame */ --=20 2.31.1 From nobody Sat Feb 7 06:13:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1668009518; cv=none; d=zohomail.com; s=zohoarc; b=h68RTLrQ26LYONWbOVbO5GStuZUPqsIeq6zcFbyjbgim7EJIrRJLkZ17KtjFfZuH9yX6SpUsRCQVhojlpVzsScE4tSqfA7mPVQa4pGf7I0OhFtXX3Tr8lh5Y/jugjcMlpOchO5WwHYEmpJdr4Oa29WdZ/nx+90EF2nA88al3L5E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668009518; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=LyiN0TBFB/Dby1NbZclwz2V/BozZkXfFitgGbnIb02I=; b=NJTvS/dLeO4QHM7X9qDtv7yAOFiJg75R6fAyKj4LAYPZQpm7Fq2FUbu4+n4BryNRdwYlXj2hlUrabNK/IHN4z+2N2I5v1fV3erS2uLeqj725l9ieLtQZnHydEE/9SEgyBTRmuUTL+rBi7To6bOaERpj8JoAidfn8/lmy6awR1bI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1668009518601228.92455610288198; Wed, 9 Nov 2022 07:58:38 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osnSI-0001fP-K0; Wed, 09 Nov 2022 10:57:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osnS9-0001cr-6h for qemu-devel@nongnu.org; Wed, 09 Nov 2022 10:57:27 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osnS4-0005cL-F7 for qemu-devel@nongnu.org; Wed, 09 Nov 2022 10:57:22 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-185-oZ9nH_2NOUqMLzxHHVIa7g-1; Wed, 09 Nov 2022 10:57:18 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3284F101E15A for ; Wed, 9 Nov 2022 15:57:18 +0000 (UTC) Received: from wi2021.rezanina.moe.rezanina.moe (ovpn-193-213.brq.redhat.com [10.40.193.213]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6A69A40C2087; Wed, 9 Nov 2022 15:57:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668009439; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LyiN0TBFB/Dby1NbZclwz2V/BozZkXfFitgGbnIb02I=; b=YTtI2UAOO8KZqfCM/PBVVlajoEp+bFIGuyBbQwfHbZwjSTo86uGSJJzU8LLX+QEiNpJhOV P0sPXmihcbvRSh/ZSisI8KMpkUJjCioIVYAHoDZLLMGVYpdhhXg605cAU5UJVNTSjckvPs u/qypGmp7aaKG9bZhhn/EG0kg1nUG9U= X-MC-Unique: oZ9nH_2NOUqMLzxHHVIa7g-1 From: mrezanin@redhat.com To: qemu-devel@nongnu.org Cc: Miroslav Rezanina Subject: [PATCH 2/4] tulip: Remove unused variable Date: Wed, 9 Nov 2022 10:57:12 -0500 Message-Id: <02e1560d115c208df32236df8916fed98429fda1.1668009030.git.mrezanin@redhat.com> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=mrezanin@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1668009519465100003 Content-Type: text/plain; charset="utf-8" From: Miroslav Rezanina Variable n used in tulip_idblock_crc function is only incremented but never= read. This causes 'Unused but set variable' warning on Clang 15.0.1 compiler. Removing the variable to prevent the warning. Signed-off-by: Miroslav Rezanina Reviewed-by: Thomas Huth --- hw/net/tulip.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/net/tulip.c b/hw/net/tulip.c index b9e42c322a..c2b3b1bdfa 100644 --- a/hw/net/tulip.c +++ b/hw/net/tulip.c @@ -870,11 +870,10 @@ static const MemoryRegionOps tulip_ops =3D { =20 static void tulip_idblock_crc(TULIPState *s, uint16_t *srom) { - int word, n; + int word; int bit; unsigned char bitval, crc; const int len =3D 9; - n =3D 0; crc =3D -1; =20 for (word =3D 0; word < len; word++) { @@ -887,7 +886,6 @@ static void tulip_idblock_crc(TULIPState *s, uint16_t *= srom) srom[len - 1] =3D (srom[len - 1] & 0xff00) | (unsigned sho= rt)crc; break; } - n++; bitval =3D ((srom[word] >> bit) & 1) ^ ((crc >> 7) & 1); crc =3D crc << 1; if (bitval =3D=3D 1) { --=20 2.31.1 From nobody Sat Feb 7 06:13:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1668009512; cv=none; d=zohomail.com; s=zohoarc; b=fi+97HcN2n7uBbnGu83dwfdSjcO2bxSHlndVqw5jaW7h2VtfSn5G2ujkNRfkUc6r3l75t+vHad8+N1gi7mfI7QIYoRtYFLnSfuyWw0KNEQZeiyp3SdWak9I1wImrNlQXiEPKnExZwBYQRmzR4Mw04mYkG6e+szMXG/N9K7eoooo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668009512; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OBA3OTIbSIue2sNhbGgq/ZfVBLgLT7sNawdYdjMymsI=; b=HGjJ90UB+rD8/ktlyou0Mj8gY2Bi7AlVi1bih0UvoW49JI/B18G02YtmopB0BcGLaCK28wpozyCDa/kIEHE4hjEqfvo/tfdms8TFU8N795F2dF0TISDv9Y200fjEpe6GkHb3VJa64bZYQZqZkMQpEuWxHHSGXai+atIz6Qtu8CY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1668009512827257.8641887862391; Wed, 9 Nov 2022 07:58:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osnSR-0001oo-0Q; Wed, 09 Nov 2022 10:57:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osnSB-0001dB-UU for qemu-devel@nongnu.org; Wed, 09 Nov 2022 10:57:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osnS8-0005i7-Fm for qemu-devel@nongnu.org; Wed, 09 Nov 2022 10:57:27 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-341-cYwd1En7NJSHBLwFcZeBfQ-1; Wed, 09 Nov 2022 10:57:19 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 19448833AEC for ; Wed, 9 Nov 2022 15:57:19 +0000 (UTC) Received: from wi2021.rezanina.moe.rezanina.moe (ovpn-193-213.brq.redhat.com [10.40.193.213]) by smtp.corp.redhat.com (Postfix) with ESMTP id 74A2140C2086; Wed, 9 Nov 2022 15:57:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668009440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OBA3OTIbSIue2sNhbGgq/ZfVBLgLT7sNawdYdjMymsI=; b=ZebqwtOg5e6l5S3Tf6k/4+r7+ZwRcWnRJlC0/XoCfCv8oriQs9CfcFYIYhMGqIqbG+goTh X8SoqyZ0Sh1Q5MSidxJOJi+9l/4TzPwOUc5eVGoLfRmMMGl/6lSPVB2fMXeVzZ/3xyF/bz RJwJv1qVzOpxcM10fS3yd6zI1W30daM= X-MC-Unique: cYwd1En7NJSHBLwFcZeBfQ-1 From: mrezanin@redhat.com To: qemu-devel@nongnu.org Cc: Miroslav Rezanina Subject: [PATCH 3/4] qemu-img: remove unused variable Date: Wed, 9 Nov 2022 10:57:13 -0500 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=mrezanin@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1668009513425100003 Content-Type: text/plain; charset="utf-8" From: Miroslav Rezanina Variable block_count used in img_dd function is only incremented but never = read. This causes 'Unused but set variable' warning on Clang 15.0.1 compiler. Removing the variable to prevent the warning. Signed-off-by: Miroslav Rezanina Reviewed-by: Thomas Huth --- qemu-img.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index a3b64c88af..a9b3a8103c 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -4922,7 +4922,7 @@ static int img_dd(int argc, char **argv) const char *out_fmt =3D "raw"; const char *fmt =3D NULL; int64_t size =3D 0; - int64_t block_count =3D 0, out_pos, in_pos; + int64_t out_pos, in_pos; bool force_share =3D false; struct DdInfo dd =3D { .flags =3D 0, @@ -5122,7 +5122,7 @@ static int img_dd(int argc, char **argv) =20 in.buf =3D g_new(uint8_t, in.bsz); =20 - for (out_pos =3D 0; in_pos < size; block_count++) { + for (out_pos =3D 0; in_pos < size; ) { int bytes =3D (in_pos + in.bsz > size) ? size - in_pos : in.bsz; =20 ret =3D blk_pread(blk1, in_pos, bytes, in.buf, 0); --=20 2.31.1 From nobody Sat Feb 7 06:13:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1668009493; cv=none; d=zohomail.com; s=zohoarc; b=StKUcxucsqOTyWphCqCXl4sTEYvGcVr716qZ/T+c+4MaZ+3prSLiV0AOcW+A7TvqNGsaj2Vy8VXLK/NO/l3vE9cKn80RMerG3oOQc3jHVBnQSe58jLImuOm/ZSOnAcM0JqLC7LTEeKfk6U+PplnFJjMpyoWY4rActSraNxV4IWA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668009493; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=kdqvurnWAXVDsjl6mVesUOVqmPHheeOSHJAfsJCbOyU=; b=UlOnVQHnkycMpQGbQqBBZJvM9EeSYnJx1vGCycTCZHTQUriaoqm6MTG7/Rtjknq6sDQLEt602VSW0gsqOehIoCAd4fBGLLWGEJLhN4mFE8ZfU9ir10y1wSxWcniOjE+UYG6dV39AzI9z1hCVB9cOz9dsRoMWZw9CukXT3xq1z78= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1668009493637639.4304709755925; Wed, 9 Nov 2022 07:58:13 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osnSR-0001qM-Sg; Wed, 09 Nov 2022 10:57:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osnSA-0001cv-Uf for qemu-devel@nongnu.org; Wed, 09 Nov 2022 10:57:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osnS8-0005ob-EC for qemu-devel@nongnu.org; Wed, 09 Nov 2022 10:57:26 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-553-qt9jf7c4PImCsh-VGGsTlw-1; Wed, 09 Nov 2022 10:57:20 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1B640101E157 for ; Wed, 9 Nov 2022 15:57:20 +0000 (UTC) Received: from wi2021.rezanina.moe.rezanina.moe (ovpn-193-213.brq.redhat.com [10.40.193.213]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6635440C83BA; Wed, 9 Nov 2022 15:57:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668009442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kdqvurnWAXVDsjl6mVesUOVqmPHheeOSHJAfsJCbOyU=; b=fmfsFSSVjpkgTXepv1rLE/dKIxyD0SJxq4BPPio+rFse4lGAcL/p5fOkZA5kdy7ngCB17s rn83ejcq7JuEYv9nX3QLImasJHji34xf9p7VQBIOKuLBv2IB0khd/JrhjqzHQIADgaQyxI Zo34vfrQpU8X5p5M6F0qzCzMkI0zt6o= X-MC-Unique: qt9jf7c4PImCsh-VGGsTlw-1 From: mrezanin@redhat.com To: qemu-devel@nongnu.org Cc: Miroslav Rezanina Subject: [PATCH 4/4] host-libusb: Remove unused variable Date: Wed, 9 Nov 2022 10:57:14 -0500 Message-Id: <00df0db69ff9167d38bac81f6d03281955bd861a.1668009030.git.mrezanin@redhat.com> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=mrezanin@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1668009495436100001 Content-Type: text/plain; charset="utf-8" From: Miroslav Rezanina Variable unconnected used in usb_host_auto_check function is only increment= ed but never read as line where it is read was disabled since introducing the = code. This causes 'Unused but set variable' warning on Clang 15.0.1 compiler. Removing the variable and disabled code to prevent the warning. Signed-off-by: Miroslav Rezanina Reviewed-by: Thomas Huth --- hw/usb/host-libusb.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index 28f8af8941..176868d345 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -1837,7 +1837,6 @@ static void usb_host_auto_check(void *unused) struct USBAutoFilter *f; libusb_device **devs =3D NULL; struct libusb_device_descriptor ddesc; - int unconnected =3D 0; int i, n; =20 if (usb_host_init() !=3D 0) { @@ -1897,9 +1896,6 @@ static void usb_host_auto_check(void *unused) libusb_free_device_list(devs, 1); =20 QTAILQ_FOREACH(s, &hostdevs, next) { - if (s->dh =3D=3D NULL) { - unconnected++; - } if (s->seen =3D=3D 0) { if (s->dh) { usb_host_close(s); @@ -1908,17 +1904,6 @@ static void usb_host_auto_check(void *unused) } s->seen =3D 0; } - -#if 0 - if (unconnected =3D=3D 0) { - /* nothing to watch */ - if (usb_auto_timer) { - timer_del(usb_auto_timer); - trace_usb_host_auto_scan_disabled(); - } - return; - } -#endif } =20 if (!usb_vmstate) { --=20 2.31.1