[PATCH v6 0/4] yank: Add chardev tests and fixes

Lukas Straub posted 4 patches 2 years, 12 months ago
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1617035720.git.lukasstraub2@web.de
Maintainers: "Marc-André Lureau" <marcandre.lureau@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
There is a newer version of this series
MAINTAINERS            |   1 +
chardev/char-socket.c  |  20 ++++-
chardev/char.c         |  77 ++++++++++------
include/chardev/char.h |   3 +
tests/unit/meson.build |   3 +-
tests/unit/test-yank.c | 200 +++++++++++++++++++++++++++++++++++++++++
6 files changed, 275 insertions(+), 29 deletions(-)
create mode 100644 tests/unit/test-yank.c
[PATCH v6 0/4] yank: Add chardev tests and fixes
Posted by Lukas Straub 2 years, 12 months ago
Hello Everyone,
These patches increase test coverage for yank, add tests and fix bugs and
crashes in yank in combination with chardev-change.
Please Review.

Regards,
Lukas Straub

Changes:
-v6:
 -test: (hopefully) fix test on OSX by using qio_net_listener on the dummy
  server socket so new clients get accept()'ed properly

-v5:
 -test: fix memory leak

-v4:
 -test: fix CharChangeTestConfig structs on stack going out of scope
 -test: move after bugfixes

-v3:
 -Base on <cover.1616521341.git.lukasstraub2@web.de>
  ([PATCH 0/2] yank: Always link full yank code)
 -Drop patch 1 (tests: Use the normal yank code instead of stubs in relevant tests)

-v2:
 -test: add license
 -test: factorize testcases to a single function
 -test: test chardev_change with initialization of new chardev failing
 -fix chardev_change with initialization of new chardev failing
 -add reviewed-by and tested-by tags

Based-on: <cover.1616521341.git.lukasstraub2@web.de>
([PATCH 0/2] yank: Always link full yank code)


Lukas Straub (4):
  chardev/char.c: Move object_property_try_add_child out of chardev_new
  chardev/char.c: Always pass id to chardev_new
  chardev: Fix yank with the chardev-change case
  tests: Add tests for yank with the chardev-change case

 MAINTAINERS            |   1 +
 chardev/char-socket.c  |  20 ++++-
 chardev/char.c         |  77 ++++++++++------
 include/chardev/char.h |   3 +
 tests/unit/meson.build |   3 +-
 tests/unit/test-yank.c | 200 +++++++++++++++++++++++++++++++++++++++++
 6 files changed, 275 insertions(+), 29 deletions(-)
 create mode 100644 tests/unit/test-yank.c

--
2.30.2
Re: [PATCH v6 0/4] yank: Add chardev tests and fixes
Posted by Marc-André Lureau 2 years, 12 months ago
Hi Lukas

On Mon, Mar 29, 2021 at 8:38 PM Lukas Straub <lukasstraub2@web.de> wrote:

> Hello Everyone,
> These patches increase test coverage for yank, add tests and fix bugs and
> crashes in yank in combination with chardev-change.
> Please Review.
>
> Regards,
> Lukas Straub
>
> Changes:
> -v6:
>  -test: (hopefully) fix test on OSX by using qio_net_listener on the dummy
>   server socket so new clients get accept()'ed properly
>

I can't see the change, patchew neither:
https://patchew.org/QEMU/cover.1616794852.git.lukasstraub2@web.de/diff/cover.1617035720.git.lukasstraub2@web.de/

btw, could you also fix the checkpatch style issue?

thanks

>
> -v5:
>  -test: fix memory leak
>
> -v4:
>  -test: fix CharChangeTestConfig structs on stack going out of scope
>  -test: move after bugfixes
>
> -v3:
>  -Base on <cover.1616521341.git.lukasstraub2@web.de>
>   ([PATCH 0/2] yank: Always link full yank code)
>  -Drop patch 1 (tests: Use the normal yank code instead of stubs in
> relevant tests)
>
> -v2:
>  -test: add license
>  -test: factorize testcases to a single function
>  -test: test chardev_change with initialization of new chardev failing
>  -fix chardev_change with initialization of new chardev failing
>  -add reviewed-by and tested-by tags
>
> Based-on: <cover.1616521341.git.lukasstraub2@web.de>
> ([PATCH 0/2] yank: Always link full yank code)
>
>
> Lukas Straub (4):
>   chardev/char.c: Move object_property_try_add_child out of chardev_new
>   chardev/char.c: Always pass id to chardev_new
>   chardev: Fix yank with the chardev-change case
>   tests: Add tests for yank with the chardev-change case
>
>  MAINTAINERS            |   1 +
>  chardev/char-socket.c  |  20 ++++-
>  chardev/char.c         |  77 ++++++++++------
>  include/chardev/char.h |   3 +
>  tests/unit/meson.build |   3 +-
>  tests/unit/test-yank.c | 200 +++++++++++++++++++++++++++++++++++++++++
>  6 files changed, 275 insertions(+), 29 deletions(-)
>  create mode 100644 tests/unit/test-yank.c
>
> --
> 2.30.2
>


-- 
Marc-André Lureau
Re: [PATCH v6 0/4] yank: Add chardev tests and fixes
Posted by Lukas Straub 2 years, 12 months ago
On Mon, 29 Mar 2021 22:19:17 +0400
Marc-André Lureau <marcandre.lureau@gmail.com> wrote:

> Hi Lukas
> 
> On Mon, Mar 29, 2021 at 8:38 PM Lukas Straub <lukasstraub2@web.de> wrote:
> 
> > Hello Everyone,
> > These patches increase test coverage for yank, add tests and fix bugs and
> > crashes in yank in combination with chardev-change.
> > Please Review.
> >
> > Regards,
> > Lukas Straub
> >
> > Changes:
> > -v6:
> >  -test: (hopefully) fix test on OSX by using qio_net_listener on the dummy
> >   server socket so new clients get accept()'ed properly
> >  
> 
> I can't see the change, patchew neither:
> https://patchew.org/QEMU/cover.1616794852.git.lukasstraub2@web.de/diff/cover.1617035720.git.lukasstraub2@web.de/

Oh, I forgot to git add.

> btw, could you also fix the checkpatch style issue?

Okay.

Regards,
Lukas Straub

> thanks
> 
> >
> > -v5:
> >  -test: fix memory leak
> >
> > -v4:
> >  -test: fix CharChangeTestConfig structs on stack going out of scope
> >  -test: move after bugfixes
> >
> > -v3:
> >  -Base on <cover.1616521341.git.lukasstraub2@web.de>
> >   ([PATCH 0/2] yank: Always link full yank code)
> >  -Drop patch 1 (tests: Use the normal yank code instead of stubs in
> > relevant tests)
> >
> > -v2:
> >  -test: add license
> >  -test: factorize testcases to a single function
> >  -test: test chardev_change with initialization of new chardev failing
> >  -fix chardev_change with initialization of new chardev failing
> >  -add reviewed-by and tested-by tags
> >
> > Based-on: <cover.1616521341.git.lukasstraub2@web.de>
> > ([PATCH 0/2] yank: Always link full yank code)
> >
> >
> > Lukas Straub (4):
> >   chardev/char.c: Move object_property_try_add_child out of chardev_new
> >   chardev/char.c: Always pass id to chardev_new
> >   chardev: Fix yank with the chardev-change case
> >   tests: Add tests for yank with the chardev-change case
> >
> >  MAINTAINERS            |   1 +
> >  chardev/char-socket.c  |  20 ++++-
> >  chardev/char.c         |  77 ++++++++++------
> >  include/chardev/char.h |   3 +
> >  tests/unit/meson.build |   3 +-
> >  tests/unit/test-yank.c | 200 +++++++++++++++++++++++++++++++++++++++++
> >  6 files changed, 275 insertions(+), 29 deletions(-)
> >  create mode 100644 tests/unit/test-yank.c
> >
> > --
> > 2.30.2
> >  
> 
> 



-- 

Re: [PATCH v6 0/4] yank: Add chardev tests and fixes
Posted by no-reply@patchew.org 2 years, 12 months ago
Patchew URL: https://patchew.org/QEMU/cover.1617035720.git.lukasstraub2@web.de/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: cover.1617035720.git.lukasstraub2@web.de
Subject: [PATCH v6 0/4] yank: Add chardev tests and fixes

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210329132632.68901-1-mreitz@redhat.com -> patchew/20210329132632.68901-1-mreitz@redhat.com
 - [tag update]      patchew/cover.1616570702.git.viresh.kumar@linaro.org -> patchew/cover.1616570702.git.viresh.kumar@linaro.org
 * [new tag]         patchew/cover.1617035720.git.lukasstraub2@web.de -> patchew/cover.1617035720.git.lukasstraub2@web.de
Switched to a new branch 'test'
2f8555b tests: Add tests for yank with the chardev-change case
df55f5e chardev: Fix yank with the chardev-change case
ac94aea chardev/char.c: Always pass id to chardev_new
545c6dc chardev/char.c: Move object_property_try_add_child out of chardev_new

=== OUTPUT BEGIN ===
1/4 Checking commit 545c6dcdbf05 (chardev/char.c: Move object_property_try_add_child out of chardev_new)
2/4 Checking commit ac94aea1496c (chardev/char.c: Always pass id to chardev_new)
3/4 Checking commit df55f5e93c68 (chardev: Fix yank with the chardev-change case)
4/4 Checking commit 2f8555b5dc94 (tests: Add tests for yank with the chardev-change case)
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#231: FILE: tests/unit/test-yank.c:180:
+#define CHAR_CHANGE_TEST(name, _old_yank, _new_yank)                           \
+        g_test_add_data_func("/yank/char_change/success/" # name,              \
+                             &(CharChangeTestConfig) { .addr = &tcpaddr,       \
+                                                       .old_yank = (_old_yank),\
+                                                       .new_yank = (_new_yank),\
+                                                       .fail = false },        \
+                             char_change_test);                                \
+        g_test_add_data_func("/yank/char_change/fail/" # name,                 \
+                             &(CharChangeTestConfig) { .addr = &tcpaddr,       \
+                                                       .old_yank = (_old_yank),\
+                                                       .new_yank = (_new_yank),\
+                                                       .fail = true },         \
+                             char_change_test);

total: 1 errors, 0 warnings, 216 lines checked

Patch 4/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/cover.1617035720.git.lukasstraub2@web.de/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com