Patchew URL: https://patchew.org/QEMU/cover.1616794852.git.lukasstraub2@web.de/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: cover.1616794852.git.lukasstraub2@web.de
Subject: [PATCH v5 0/4] yank: Add chardev tests and fixes
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/cover.1616794852.git.lukasstraub2@web.de -> patchew/cover.1616794852.git.lukasstraub2@web.de
Switched to a new branch 'test'
6e47978 tests: Add tests for yank with the chardev-change case
012405b chardev: Fix yank with the chardev-change case
88fb5e8 chardev/char.c: Always pass id to chardev_new
eea7cc3 chardev/char.c: Move object_property_try_add_child out of chardev_new
=== OUTPUT BEGIN ===
1/4 Checking commit eea7cc39202d (chardev/char.c: Move object_property_try_add_child out of chardev_new)
2/4 Checking commit 88fb5e8d4735 (chardev/char.c: Always pass id to chardev_new)
3/4 Checking commit 012405b37770 (chardev: Fix yank with the chardev-change case)
4/4 Checking commit 6e479781b605 (tests: Add tests for yank with the chardev-change case)
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#231: FILE: tests/unit/test-yank.c:180:
+#define CHAR_CHANGE_TEST(name, _old_yank, _new_yank) \
+ g_test_add_data_func("/yank/char_change/success/" # name, \
+ &(CharChangeTestConfig) { .addr = &tcpaddr, \
+ .old_yank = (_old_yank),\
+ .new_yank = (_new_yank),\
+ .fail = false }, \
+ char_change_test); \
+ g_test_add_data_func("/yank/char_change/fail/" # name, \
+ &(CharChangeTestConfig) { .addr = &tcpaddr, \
+ .old_yank = (_old_yank),\
+ .new_yank = (_new_yank),\
+ .fail = true }, \
+ char_change_test);
total: 1 errors, 0 warnings, 216 lines checked
Patch 4/4 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/cover.1616794852.git.lukasstraub2@web.de/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com