From nobody Thu Nov 13 14:53:12 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.alibaba.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158134892135154.35795097970038; Mon, 10 Feb 2020 07:35:21 -0800 (PST) Received: from localhost ([::1]:35114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1B5k-0003gb-1T for importer@patchew.org; Mon, 10 Feb 2020 10:35:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41635) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j150s-00078z-Sa for qemu-devel@nongnu.org; Mon, 10 Feb 2020 04:05:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j150o-0004Ih-6D for qemu-devel@nongnu.org; Mon, 10 Feb 2020 04:05:51 -0500 Received: from out4436.biz.mail.alibaba.com ([47.88.44.36]:53923) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j150n-0004Ep-Su for qemu-devel@nongnu.org; Mon, 10 Feb 2020 04:05:50 -0500 Received: from localhost(mailfrom:zhabin@linux.alibaba.com fp:SMTPD_---0Tpb7N0C_1581325531) by smtp.aliyun-inc.com(127.0.0.1); Mon, 10 Feb 2020 17:05:31 +0800 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R111e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e07417; MF=zhabin@linux.alibaba.com; NM=1; PH=DS; RN=10; SR=0; TI=SMTPD_---0Tpb7N0C_1581325531; From: Zha Bin To: linux-kernel@vger.kernel.org Subject: [PATCH v2 1/5] virtio-mmio: add notify feature for per-queue Date: Mon, 10 Feb 2020 17:05:17 +0800 Message-Id: <8a4ea95d6d77a2814aaf6897b5517353289a098e.1581305609.git.zhabin@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: References: In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 47.88.44.36 X-Mailman-Approved-At: Mon, 10 Feb 2020 10:31:31 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: virtio-dev@lists.oasis-open.org, zhabin@linux.alibaba.com, slp@redhat.com, mst@redhat.com, jasowang@redhat.com, jing2.liu@linux.intel.com, qemu-devel@nongnu.org, chao.p.peng@linux.intel.com, gerry@linux.alibaba.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Liu Jiang The standard virtio-mmio devices use notification register to signal backend. This will cause vmexits and slow down the performance when we passthrough the virtio-mmio devices to guest virtual machines. We proposed to update virtio over MMIO spec to add the per-queue notify feature VIRTIO_F_MMIO_NOTIFICATION[1]. It can allow the VMM to configure notify location for each queue. [1] https://lkml.org/lkml/2020/1/21/31 Signed-off-by: Liu Jiang Co-developed-by: Zha Bin Signed-off-by: Zha Bin Co-developed-by: Jing Liu Signed-off-by: Jing Liu Co-developed-by: Chao Peng Signed-off-by: Chao Peng --- drivers/virtio/virtio_mmio.c | 37 ++++++++++++++++++++++++++++++++++= +-- include/uapi/linux/virtio_config.h | 8 +++++++- 2 files changed, 42 insertions(+), 3 deletions(-) diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index 97d5725..1733ab97 100644 --- a/drivers/virtio/virtio_mmio.c +++ b/drivers/virtio/virtio_mmio.c @@ -90,6 +90,9 @@ struct virtio_mmio_device { /* a list of queues so we can dispatch IRQs */ spinlock_t lock; struct list_head virtqueues; + + unsigned short notify_base; + unsigned short notify_multiplier; }; =20 struct virtio_mmio_vq_info { @@ -98,6 +101,9 @@ struct virtio_mmio_vq_info { =20 /* the list node for the virtqueues list */ struct list_head node; + + /* Notify Address*/ + unsigned int notify_addr; }; =20 =20 @@ -119,13 +125,23 @@ static u64 vm_get_features(struct virtio_device *vdev) return features; } =20 +static void vm_transport_features(struct virtio_device *vdev, u64 features) +{ + if (features & BIT_ULL(VIRTIO_F_MMIO_NOTIFICATION)) + __virtio_set_bit(vdev, VIRTIO_F_MMIO_NOTIFICATION); +} + static int vm_finalize_features(struct virtio_device *vdev) { struct virtio_mmio_device *vm_dev =3D to_virtio_mmio_device(vdev); + u64 features =3D vdev->features; =20 /* Give virtio_ring a chance to accept features. */ vring_transport_features(vdev); =20 + /* Give virtio_mmio a chance to accept features. */ + vm_transport_features(vdev, features); + /* Make sure there is are no mixed devices */ if (vm_dev->version =3D=3D 2 && !__virtio_test_bit(vdev, VIRTIO_F_VERSION_1)) { @@ -272,10 +288,13 @@ static void vm_reset(struct virtio_device *vdev) static bool vm_notify(struct virtqueue *vq) { struct virtio_mmio_device *vm_dev =3D to_virtio_mmio_device(vq->vdev); + struct virtio_mmio_vq_info *info =3D vq->priv; =20 - /* We write the queue's selector into the notification register to + /* We write the queue's selector into the Notify Address to * signal the other end */ - writel(vq->index, vm_dev->base + VIRTIO_MMIO_QUEUE_NOTIFY); + if (info) + writel(vq->index, vm_dev->base + info->notify_addr); + return true; } =20 @@ -434,6 +453,12 @@ static struct virtqueue *vm_setup_vq(struct virtio_dev= ice *vdev, unsigned index, vq->priv =3D info; info->vq =3D vq; =20 + if (__virtio_test_bit(vdev, VIRTIO_F_MMIO_NOTIFICATION)) + info->notify_addr =3D vm_dev->notify_base + + vm_dev->notify_multiplier * vq->index; + else + info->notify_addr =3D VIRTIO_MMIO_QUEUE_NOTIFY; + spin_lock_irqsave(&vm_dev->lock, flags); list_add(&info->node, &vm_dev->virtqueues); spin_unlock_irqrestore(&vm_dev->lock, flags); @@ -471,6 +496,14 @@ static int vm_find_vqs(struct virtio_device *vdev, uns= igned nvqs, return irq; } =20 + if (__virtio_test_bit(vdev, VIRTIO_F_MMIO_NOTIFICATION)) { + unsigned int notify =3D readl(vm_dev->base + + VIRTIO_MMIO_QUEUE_NOTIFY); + + vm_dev->notify_base =3D notify & 0xffff; + vm_dev->notify_multiplier =3D (notify >> 16) & 0xffff; + } + err =3D request_irq(irq, vm_interrupt, IRQF_SHARED, dev_name(&vdev->dev), vm_dev); if (err) diff --git a/include/uapi/linux/virtio_config.h b/include/uapi/linux/virtio= _config.h index ff8e7dc..5d93c01 100644 --- a/include/uapi/linux/virtio_config.h +++ b/include/uapi/linux/virtio_config.h @@ -52,7 +52,7 @@ * rest are per-device feature bits. */ #define VIRTIO_TRANSPORT_F_START 28 -#define VIRTIO_TRANSPORT_F_END 38 +#define VIRTIO_TRANSPORT_F_END 40 =20 #ifndef VIRTIO_CONFIG_NO_LEGACY /* Do we get callbacks when the ring is completely used, even if we've @@ -88,4 +88,10 @@ * Does the device support Single Root I/O Virtualization? */ #define VIRTIO_F_SR_IOV 37 + +/* + * This feature indicates the enhanced notification support on MMIO transp= ort + * layer. + */ +#define VIRTIO_F_MMIO_NOTIFICATION 39 #endif /* _UAPI_LINUX_VIRTIO_CONFIG_H */ --=20 1.8.3.1 From nobody Thu Nov 13 14:53:12 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.alibaba.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1581348825587791.0405475171731; Mon, 10 Feb 2020 07:33:45 -0800 (PST) Received: from localhost ([::1]:35084 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1B4C-0000sm-4n for importer@patchew.org; Mon, 10 Feb 2020 10:33:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41649) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j150t-000799-0M for qemu-devel@nongnu.org; Mon, 10 Feb 2020 04:05:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j150r-0004La-Pj for qemu-devel@nongnu.org; Mon, 10 Feb 2020 04:05:54 -0500 Received: from out4436.biz.mail.alibaba.com ([47.88.44.36]:11714) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j150r-0004Ja-Fp for qemu-devel@nongnu.org; Mon, 10 Feb 2020 04:05:53 -0500 Received: from localhost(mailfrom:zhabin@linux.alibaba.com fp:SMTPD_---0Tpb9F9i_1581325531) by smtp.aliyun-inc.com(127.0.0.1); Mon, 10 Feb 2020 17:05:32 +0800 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R101e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e04426; MF=zhabin@linux.alibaba.com; NM=1; PH=DS; RN=10; SR=0; TI=SMTPD_---0Tpb9F9i_1581325531; From: Zha Bin To: linux-kernel@vger.kernel.org Subject: [PATCH v2 2/5] virtio-mmio: refactor common functionality Date: Mon, 10 Feb 2020 17:05:18 +0800 Message-Id: <0268807dc26ecdf5620de9000758d05ca0b21f3f.1581305609.git.zhabin@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: References: In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 47.88.44.36 X-Mailman-Approved-At: Mon, 10 Feb 2020 10:31:31 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: virtio-dev@lists.oasis-open.org, zhabin@linux.alibaba.com, slp@redhat.com, mst@redhat.com, jasowang@redhat.com, jing2.liu@linux.intel.com, qemu-devel@nongnu.org, chao.p.peng@linux.intel.com, gerry@linux.alibaba.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Liu Jiang Common functionality is refactored into virtio_mmio_common.h in order to MSI support in later patch set. Signed-off-by: Liu Jiang Co-developed-by: Zha Bin Signed-off-by: Zha Bin Co-developed-by: Jing Liu Signed-off-by: Jing Liu Co-developed-by: Chao Peng Signed-off-by: Chao Peng --- drivers/virtio/virtio_mmio.c | 21 +-------------------- drivers/virtio/virtio_mmio_common.h | 31 +++++++++++++++++++++++++++++++ 2 files changed, 32 insertions(+), 20 deletions(-) create mode 100644 drivers/virtio/virtio_mmio_common.h diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index 1733ab97..41e1c93 100644 --- a/drivers/virtio/virtio_mmio.c +++ b/drivers/virtio/virtio_mmio.c @@ -61,13 +61,12 @@ #include #include #include -#include #include #include -#include #include #include #include +#include "virtio_mmio_common.h" =20 =20 =20 @@ -77,24 +76,6 @@ =20 =20 =20 -#define to_virtio_mmio_device(_plat_dev) \ - container_of(_plat_dev, struct virtio_mmio_device, vdev) - -struct virtio_mmio_device { - struct virtio_device vdev; - struct platform_device *pdev; - - void __iomem *base; - unsigned long version; - - /* a list of queues so we can dispatch IRQs */ - spinlock_t lock; - struct list_head virtqueues; - - unsigned short notify_base; - unsigned short notify_multiplier; -}; - struct virtio_mmio_vq_info { /* the actual virtqueue */ struct virtqueue *vq; diff --git a/drivers/virtio/virtio_mmio_common.h b/drivers/virtio/virtio_mm= io_common.h new file mode 100644 index 0000000..90cb304 --- /dev/null +++ b/drivers/virtio/virtio_mmio_common.h @@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +#ifndef _DRIVERS_VIRTIO_VIRTIO_MMIO_COMMON_H +#define _DRIVERS_VIRTIO_VIRTIO_MMIO_COMMON_H +/* + * Virtio MMIO driver - common functionality for all device versions + * + * This module allows virtio devices to be used over a memory-mapped devic= e. + */ + +#include +#include + +#define to_virtio_mmio_device(_plat_dev) \ + container_of(_plat_dev, struct virtio_mmio_device, vdev) + +struct virtio_mmio_device { + struct virtio_device vdev; + struct platform_device *pdev; + + void __iomem *base; + unsigned long version; + + /* a list of queues so we can dispatch IRQs */ + spinlock_t lock; + struct list_head virtqueues; + + unsigned short notify_base; + unsigned short notify_multiplier; +}; + +#endif --=20 1.8.3.1 From nobody Thu Nov 13 14:53:12 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.alibaba.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1581349016433687.2412740716791; Mon, 10 Feb 2020 07:36:56 -0800 (PST) Received: from localhost ([::1]:35164 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1B7H-0006BZ-2w for importer@patchew.org; Mon, 10 Feb 2020 10:36:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41678) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j150z-0007Ae-1o for qemu-devel@nongnu.org; Mon, 10 Feb 2020 04:06:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j150x-0004Pb-NF for qemu-devel@nongnu.org; Mon, 10 Feb 2020 04:06:00 -0500 Received: from out4436.biz.mail.alibaba.com ([47.88.44.36]:11638) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j150x-0004O3-BL for qemu-devel@nongnu.org; Mon, 10 Feb 2020 04:05:59 -0500 Received: from localhost(mailfrom:zhabin@linux.alibaba.com fp:SMTPD_---0TpayjRN_1581325532) by smtp.aliyun-inc.com(127.0.0.1); Mon, 10 Feb 2020 17:05:32 +0800 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R671e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01f04396; MF=zhabin@linux.alibaba.com; NM=1; PH=DS; RN=10; SR=0; TI=SMTPD_---0TpayjRN_1581325532; From: Zha Bin To: linux-kernel@vger.kernel.org Subject: [PATCH v2 3/5] virtio-mmio: create a generic MSI irq domain Date: Mon, 10 Feb 2020 17:05:19 +0800 Message-Id: <4c52548758eefe1fe7078d3b6f10492a001c0636.1581305609.git.zhabin@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: References: In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 47.88.44.36 X-Mailman-Approved-At: Mon, 10 Feb 2020 10:31:31 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: virtio-dev@lists.oasis-open.org, zhabin@linux.alibaba.com, slp@redhat.com, mst@redhat.com, jasowang@redhat.com, jing2.liu@linux.intel.com, qemu-devel@nongnu.org, chao.p.peng@linux.intel.com, gerry@linux.alibaba.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Liu Jiang Create a generic irq domain for all architectures which supports virtio-mmio. The device offering VIRTIO_F_MMIO_MSI feature bit can use this irq domain. Signed-off-by: Liu Jiang Co-developed-by: Zha Bin Signed-off-by: Zha Bin Co-developed-by: Jing Liu Signed-off-by: Jing Liu Co-developed-by: Chao Peng Signed-off-by: Chao Peng --- drivers/base/platform-msi.c | 4 +- drivers/virtio/Kconfig | 9 ++++ drivers/virtio/virtio_mmio_msi.h | 93 ++++++++++++++++++++++++++++++++++++= ++++ include/linux/msi.h | 1 + 4 files changed, 105 insertions(+), 2 deletions(-) create mode 100644 drivers/virtio/virtio_mmio_msi.h diff --git a/drivers/base/platform-msi.c b/drivers/base/platform-msi.c index 8da314b..45752f1 100644 --- a/drivers/base/platform-msi.c +++ b/drivers/base/platform-msi.c @@ -31,12 +31,11 @@ struct platform_msi_priv_data { /* The devid allocator */ static DEFINE_IDA(platform_msi_devid_ida); =20 -#ifdef GENERIC_MSI_DOMAIN_OPS /* * Convert an msi_desc to a globaly unique identifier (per-device * devid + msi_desc position in the msi_list). */ -static irq_hw_number_t platform_msi_calc_hwirq(struct msi_desc *desc) +irq_hw_number_t platform_msi_calc_hwirq(struct msi_desc *desc) { u32 devid; =20 @@ -45,6 +44,7 @@ static irq_hw_number_t platform_msi_calc_hwirq(struct msi= _desc *desc) return (devid << (32 - DEV_ID_SHIFT)) | desc->platform.msi_index; } =20 +#ifdef GENERIC_MSI_DOMAIN_OPS static void platform_msi_set_desc(msi_alloc_info_t *arg, struct msi_desc *= desc) { arg->desc =3D desc; diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig index 078615c..551a9f7 100644 --- a/drivers/virtio/Kconfig +++ b/drivers/virtio/Kconfig @@ -84,6 +84,15 @@ config VIRTIO_MMIO =20 If unsure, say N. =20 +config VIRTIO_MMIO_MSI + bool "Memory-mapped virtio device MSI" + depends on VIRTIO_MMIO && GENERIC_MSI_IRQ_DOMAIN && GENERIC_MSI_IRQ + help + This allows device drivers to support msi interrupt handling for + virtio-mmio devices. It can improve performance greatly. + + If unsure, say N. + config VIRTIO_MMIO_CMDLINE_DEVICES bool "Memory mapped virtio devices parameter parsing" depends on VIRTIO_MMIO diff --git a/drivers/virtio/virtio_mmio_msi.h b/drivers/virtio/virtio_mmio_= msi.h new file mode 100644 index 0000000..27cb2af --- /dev/null +++ b/drivers/virtio/virtio_mmio_msi.h @@ -0,0 +1,93 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +#ifndef _DRIVERS_VIRTIO_VIRTIO_MMIO_MSI_H +#define _DRIVERS_VIRTIO_VIRTIO_MMIO_MSI_H + +#ifdef CONFIG_VIRTIO_MMIO_MSI + +#include +#include +#include +#include + +static irq_hw_number_t mmio_msi_hwirq; +static struct irq_domain *mmio_msi_domain; + +struct irq_domain *__weak arch_msi_root_irq_domain(void) +{ + return NULL; +} + +void __weak irq_msi_compose_msg(struct irq_data *data, struct msi_msg *msg) +{ +} + +static void mmio_msi_mask_irq(struct irq_data *data) +{ +} + +static void mmio_msi_unmask_irq(struct irq_data *data) +{ +} + +static struct irq_chip mmio_msi_controller =3D { + .name =3D "VIRTIO-MMIO-MSI", + .irq_mask =3D mmio_msi_mask_irq, + .irq_unmask =3D mmio_msi_unmask_irq, + .irq_ack =3D irq_chip_ack_parent, + .irq_retrigger =3D irq_chip_retrigger_hierarchy, + .irq_compose_msi_msg =3D irq_msi_compose_msg, + .flags =3D IRQCHIP_SKIP_SET_WAKE, +}; + +static int mmio_msi_prepare(struct irq_domain *domain, struct device *dev, + int nvec, msi_alloc_info_t *arg) +{ + memset(arg, 0, sizeof(*arg)); + return 0; +} + +static void mmio_msi_set_desc(msi_alloc_info_t *arg, struct msi_desc *desc) +{ + mmio_msi_hwirq =3D platform_msi_calc_hwirq(desc); +} + +static irq_hw_number_t mmio_msi_get_hwirq(struct msi_domain_info *info, + msi_alloc_info_t *arg) +{ + return mmio_msi_hwirq; +} + +static struct msi_domain_ops mmio_msi_domain_ops =3D { + .msi_prepare =3D mmio_msi_prepare, + .set_desc =3D mmio_msi_set_desc, + .get_hwirq =3D mmio_msi_get_hwirq, +}; + +static struct msi_domain_info mmio_msi_domain_info =3D { + .flags =3D MSI_FLAG_USE_DEF_DOM_OPS | + MSI_FLAG_USE_DEF_CHIP_OPS | + MSI_FLAG_ACTIVATE_EARLY, + .ops =3D &mmio_msi_domain_ops, + .chip =3D &mmio_msi_controller, + .handler =3D handle_edge_irq, + .handler_name =3D "edge", +}; + +static inline void mmio_msi_create_irq_domain(void) +{ + struct fwnode_handle *fn; + struct irq_domain *parent =3D arch_msi_root_irq_domain(); + + fn =3D irq_domain_alloc_named_fwnode("VIRTIO-MMIO-MSI"); + if (fn && parent) { + mmio_msi_domain =3D + platform_msi_create_irq_domain(fn, + &mmio_msi_domain_info, parent); + irq_domain_free_fwnode(fn); + } +} +#else +static inline void mmio_msi_create_irq_domain(void) {} +#endif + +#endif diff --git a/include/linux/msi.h b/include/linux/msi.h index 8ad679e..ee5f566 100644 --- a/include/linux/msi.h +++ b/include/linux/msi.h @@ -362,6 +362,7 @@ int platform_msi_domain_alloc(struct irq_domain *domain= , unsigned int virq, void platform_msi_domain_free(struct irq_domain *domain, unsigned int virq, unsigned int nvec); void *platform_msi_get_host_data(struct irq_domain *domain); +irq_hw_number_t platform_msi_calc_hwirq(struct msi_desc *desc); #endif /* CONFIG_GENERIC_MSI_IRQ_DOMAIN */ =20 #ifdef CONFIG_PCI_MSI_IRQ_DOMAIN --=20 1.8.3.1 From nobody Thu Nov 13 14:53:12 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.alibaba.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1581348801014193.07883205474604; Mon, 10 Feb 2020 07:33:21 -0800 (PST) Received: from localhost ([::1]:35078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1B3m-000832-SJ for importer@patchew.org; Mon, 10 Feb 2020 10:33:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41780) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j151U-0007JX-VJ for qemu-devel@nongnu.org; Mon, 10 Feb 2020 04:06:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j151O-0004jW-HF for qemu-devel@nongnu.org; Mon, 10 Feb 2020 04:06:32 -0500 Received: from out4436.biz.mail.alibaba.com ([47.88.44.36]:44225) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j151O-0004hT-1y for qemu-devel@nongnu.org; Mon, 10 Feb 2020 04:06:26 -0500 Received: from localhost(mailfrom:zhabin@linux.alibaba.com fp:SMTPD_---0TpZzdpy_1581325533) by smtp.aliyun-inc.com(127.0.0.1); Mon, 10 Feb 2020 17:05:33 +0800 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R181e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e07488; MF=zhabin@linux.alibaba.com; NM=1; PH=DS; RN=10; SR=0; TI=SMTPD_---0TpZzdpy_1581325533; From: Zha Bin To: linux-kernel@vger.kernel.org Subject: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support Date: Mon, 10 Feb 2020 17:05:20 +0800 Message-Id: <4c3d13be5a391b1fc50416838de57d903cbf8038.1581305609.git.zhabin@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: References: In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 47.88.44.36 X-Mailman-Approved-At: Mon, 10 Feb 2020 10:31:31 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: virtio-dev@lists.oasis-open.org, zhabin@linux.alibaba.com, slp@redhat.com, mst@redhat.com, jasowang@redhat.com, jing2.liu@linux.intel.com, qemu-devel@nongnu.org, chao.p.peng@linux.intel.com, gerry@linux.alibaba.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Liu Jiang Userspace VMMs (e.g. Qemu microvm, Firecracker) take advantage of using virtio over mmio devices as a lightweight machine model for modern cloud. The standard virtio over MMIO transport layer only supports one legacy interrupt, which is much heavier than virtio over PCI transport layer using MSI. Legacy interrupt has long work path and causes specific VMExits in following cases, which would considerably slow down the performance: 1) read interrupt status register 2) update interrupt status register 3) write IOAPIC EOI register We proposed to add MSI support for virtio over MMIO via new feature bit VIRTIO_F_MMIO_MSI[1] which increases the interrupt performance. With the VIRTIO_F_MMIO_MSI feature bit supported, the virtio-mmio MSI uses msi_sharing[1] to indicate the event and vector mapping. Bit 1 is 0: device uses non-sharing and fixed vector per event mapping. Bit 1 is 1: device uses sharing mode and dynamic mapping. [1] https://lkml.org/lkml/2020/1/21/31 Signed-off-by: Liu Jiang Co-developed-by: Zha Bin Signed-off-by: Zha Bin Co-developed-by: Jing Liu Signed-off-by: Jing Liu Co-developed-by: Chao Peng Signed-off-by: Chao Peng --- drivers/virtio/virtio_mmio.c | 299 ++++++++++++++++++++++++++++++++= ++-- drivers/virtio/virtio_mmio_common.h | 8 + drivers/virtio/virtio_mmio_msi.h | 82 ++++++++++ include/uapi/linux/virtio_config.h | 7 +- include/uapi/linux/virtio_mmio.h | 31 ++++ 5 files changed, 411 insertions(+), 16 deletions(-) diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index 41e1c93..b24ce21 100644 --- a/drivers/virtio/virtio_mmio.c +++ b/drivers/virtio/virtio_mmio.c @@ -67,8 +67,7 @@ #include #include #include "virtio_mmio_common.h" - - +#include "virtio_mmio_msi.h" =20 /* The alignment to use between consumer and producer parts of vring. * Currently hardcoded to the page size. */ @@ -85,9 +84,13 @@ struct virtio_mmio_vq_info { =20 /* Notify Address*/ unsigned int notify_addr; -}; =20 + /* MSI vector (or none) */ + unsigned int msi_vector; +}; =20 +static void vm_free_msi_irqs(struct virtio_device *vdev); +static int vm_request_msi_vectors(struct virtio_device *vdev, int nirqs); =20 /* Configuration interface */ =20 @@ -110,6 +113,9 @@ static void vm_transport_features(struct virtio_device = *vdev, u64 features) { if (features & BIT_ULL(VIRTIO_F_MMIO_NOTIFICATION)) __virtio_set_bit(vdev, VIRTIO_F_MMIO_NOTIFICATION); + + if (features & BIT_ULL(VIRTIO_F_MMIO_MSI)) + __virtio_set_bit(vdev, VIRTIO_F_MMIO_MSI); } =20 static int vm_finalize_features(struct virtio_device *vdev) @@ -307,7 +313,33 @@ static irqreturn_t vm_interrupt(int irq, void *opaque) return ret; } =20 +static irqreturn_t vm_vring_interrupt(int irq, void *opaque) +{ + struct virtio_mmio_device *vm_dev =3D opaque; + struct virtio_mmio_vq_info *info; + irqreturn_t ret =3D IRQ_NONE; + unsigned long flags; + + spin_lock_irqsave(&vm_dev->lock, flags); + list_for_each_entry(info, &vm_dev->virtqueues, node) { + if (vring_interrupt(irq, info->vq) =3D=3D IRQ_HANDLED) + ret =3D IRQ_HANDLED; + } + spin_unlock_irqrestore(&vm_dev->lock, flags); + + return ret; +} + + +/* Handle a configuration change */ +static irqreturn_t vm_config_changed(int irq, void *opaque) +{ + struct virtio_mmio_device *vm_dev =3D opaque; + + virtio_config_changed(&vm_dev->vdev); =20 + return IRQ_HANDLED; +} =20 static void vm_del_vq(struct virtqueue *vq) { @@ -316,6 +348,15 @@ static void vm_del_vq(struct virtqueue *vq) unsigned long flags; unsigned int index =3D vq->index; =20 + if (vm_dev->msi_enabled && !vm_dev->msi_share) { + if (info->msi_vector !=3D VIRTIO_MMIO_MSI_NO_VECTOR) { + int irq =3D mmio_msi_irq_vector(&vq->vdev->dev, + info->msi_vector); + + free_irq(irq, vq); + } + } + spin_lock_irqsave(&vm_dev->lock, flags); list_del(&info->node); spin_unlock_irqrestore(&vm_dev->lock, flags); @@ -334,20 +375,56 @@ static void vm_del_vq(struct virtqueue *vq) kfree(info); } =20 -static void vm_del_vqs(struct virtio_device *vdev) +static void vm_free_irqs(struct virtio_device *vdev) { struct virtio_mmio_device *vm_dev =3D to_virtio_mmio_device(vdev); + + if (vm_dev->msi_enabled) + vm_free_msi_irqs(vdev); + else + free_irq(platform_get_irq(vm_dev->pdev, 0), vm_dev); +} + +static void vm_del_vqs(struct virtio_device *vdev) +{ struct virtqueue *vq, *n; =20 list_for_each_entry_safe(vq, n, &vdev->vqs, list) vm_del_vq(vq); =20 - free_irq(platform_get_irq(vm_dev->pdev, 0), vm_dev); + vm_free_irqs(vdev); +} + +static inline void mmio_msi_set_enable(struct virtio_mmio_device *vm_dev, + int enable) +{ + u32 state; + + state =3D readl(vm_dev->base + VIRTIO_MMIO_MSI_STATE); + if (enable && (state & VIRTIO_MMIO_MSI_ENABLED_MASK)) + return; + + writel(VIRTIO_MMIO_MSI_CMD_ENABLE, + vm_dev->base + VIRTIO_MMIO_MSI_COMMAND); +} + +static void mmio_msi_config_vector(struct virtio_mmio_device *vm_dev, u32 = vec) +{ + writel(vec, vm_dev->base + VIRTIO_MMIO_MSI_VEC_SEL); + writel(VIRTIO_MMIO_MSI_CMD_MAP_CONFIG, vm_dev->base + + VIRTIO_MMIO_MSI_COMMAND); +} + +static void mmio_msi_queue_vector(struct virtio_mmio_device *vm_dev, u32 v= ec) +{ + writel(vec, vm_dev->base + VIRTIO_MMIO_MSI_VEC_SEL); + writel(VIRTIO_MMIO_MSI_CMD_MAP_QUEUE, vm_dev->base + + VIRTIO_MMIO_MSI_COMMAND); } =20 static struct virtqueue *vm_setup_vq(struct virtio_device *vdev, unsigned = index, void (*callback)(struct virtqueue *vq), - const char *name, bool ctx) + const char *name, bool ctx, u32 msi_vector) { struct virtio_mmio_device *vm_dev =3D to_virtio_mmio_device(vdev); struct virtio_mmio_vq_info *info; @@ -440,6 +517,11 @@ static struct virtqueue *vm_setup_vq(struct virtio_dev= ice *vdev, unsigned index, else info->notify_addr =3D VIRTIO_MMIO_QUEUE_NOTIFY; =20 + info->msi_vector =3D msi_vector; + /* Set queue event and vector mapping for MSI share mode. */ + if (vm_dev->msi_share && msi_vector !=3D VIRTIO_MMIO_MSI_NO_VECTOR) + mmio_msi_queue_vector(vm_dev, msi_vector); + spin_lock_irqsave(&vm_dev->lock, flags); list_add(&info->node, &vm_dev->virtqueues); spin_unlock_irqrestore(&vm_dev->lock, flags); @@ -461,12 +543,11 @@ static struct virtqueue *vm_setup_vq(struct virtio_de= vice *vdev, unsigned index, return ERR_PTR(err); } =20 -static int vm_find_vqs(struct virtio_device *vdev, unsigned nvqs, - struct virtqueue *vqs[], - vq_callback_t *callbacks[], - const char * const names[], - const bool *ctx, - struct irq_affinity *desc) +static int vm_find_vqs_intx(struct virtio_device *vdev, unsigned int nvqs, + struct virtqueue *vqs[], + vq_callback_t *callbacks[], + const char * const names[], + const bool *ctx) { struct virtio_mmio_device *vm_dev =3D to_virtio_mmio_device(vdev); int irq =3D platform_get_irq(vm_dev->pdev, 0); @@ -487,8 +568,6 @@ static int vm_find_vqs(struct virtio_device *vdev, unsi= gned nvqs, =20 err =3D request_irq(irq, vm_interrupt, IRQF_SHARED, dev_name(&vdev->dev), vm_dev); - if (err) - return err; =20 for (i =3D 0; i < nvqs; ++i) { if (!names[i]) { @@ -497,14 +576,202 @@ static int vm_find_vqs(struct virtio_device *vdev, u= nsigned nvqs, } =20 vqs[i] =3D vm_setup_vq(vdev, queue_idx++, callbacks[i], names[i], - ctx ? ctx[i] : false); + ctx ? ctx[i] : false, + VIRTIO_MMIO_MSI_NO_VECTOR); if (IS_ERR(vqs[i])) { vm_del_vqs(vdev); return PTR_ERR(vqs[i]); } } =20 + return err; +} + +static int vm_find_vqs_msi(struct virtio_device *vdev, unsigned int nvqs, + struct virtqueue *vqs[], vq_callback_t *callbacks[], + const char * const names[], bool per_vq_vectors, + const bool *ctx, struct irq_affinity *desc) +{ + struct virtio_mmio_device *vm_dev =3D to_virtio_mmio_device(vdev); + int i, err, allocated_vectors, nvectors; + u32 msi_vec; + u32 max_vec_num =3D readl(vm_dev->base + VIRTIO_MMIO_MSI_VEC_NUM); + + /* For MSI non-sharing, the max vector number MUST greater than nvqs. + * Otherwise, go back to legacy interrupt. + */ + if (per_vq_vectors && max_vec_num < (nvqs + 1)) + return -EINVAL; + + if (per_vq_vectors) { + nvectors =3D 1; + for (i =3D 0; i < nvqs; ++i) + if (callbacks[i]) + ++nvectors; + } else { + nvectors =3D 2; + } + + vm_dev->msi_share =3D !per_vq_vectors; + + /* Allocate nvqs irqs for queues and one irq for configuration */ + err =3D vm_request_msi_vectors(vdev, nvectors); + if (err !=3D 0) + return err; + + allocated_vectors =3D vm_dev->msi_used_vectors; + for (i =3D 0; i < nvqs; i++) { + if (!names[i]) { + vqs[i] =3D NULL; + continue; + } + if (!callbacks[i]) + msi_vec =3D VIRTIO_MMIO_MSI_NO_VECTOR; + else if (per_vq_vectors) + msi_vec =3D allocated_vectors++; + else + msi_vec =3D 1; + vqs[i] =3D vm_setup_vq(vdev, i, callbacks[i], names[i], + ctx ? ctx[i] : false, msi_vec); + if (IS_ERR(vqs[i])) { + err =3D PTR_ERR(vqs[i]); + goto error_find; + } + + if (!per_vq_vectors || + msi_vec =3D=3D VIRTIO_MMIO_MSI_NO_VECTOR) + continue; + + /* allocate per-vq irq if available and necessary */ + snprintf(vm_dev->vm_vq_names[msi_vec], + sizeof(*vm_dev->vm_vq_names), + "%s-%s", + dev_name(&vm_dev->vdev.dev), names[i]); + err =3D request_irq(mmio_msi_irq_vector(&vqs[i]->vdev->dev, + msi_vec), + vring_interrupt, 0, + vm_dev->vm_vq_names[msi_vec], vqs[i]); + + if (err) + goto error_find; + } + return 0; + +error_find: + vm_del_vqs(vdev); + return err; +} + +static int vm_find_vqs(struct virtio_device *vdev, unsigned int nvqs, + struct virtqueue *vqs[], + vq_callback_t *callbacks[], + const char * const names[], + const bool *ctx, + struct irq_affinity *desc) +{ + struct virtio_mmio_device *vm_dev =3D to_virtio_mmio_device(vdev); + int err; + + if (__virtio_test_bit(vdev, VIRTIO_F_MMIO_NOTIFICATION)) { + unsigned int notify =3D readl(vm_dev->base + + VIRTIO_MMIO_QUEUE_NOTIFY); + + vm_dev->notify_base =3D notify & 0xffff; + vm_dev->notify_multiplier =3D (notify >> 16) & 0xffff; + } + + if (__virtio_test_bit(vdev, VIRTIO_F_MMIO_MSI)) { + bool dyn_mapping =3D !!(readl(vm_dev->base + + VIRTIO_MMIO_MSI_STATE) & + VIRTIO_MMIO_MSI_SHARING_MASK); + if (!dyn_mapping) + err =3D vm_find_vqs_msi(vdev, nvqs, vqs, callbacks, + names, true, ctx, desc); + else + err =3D vm_find_vqs_msi(vdev, nvqs, vqs, callbacks, + names, false, ctx, desc); + if (!err) + return 0; + } + + return vm_find_vqs_intx(vdev, nvqs, vqs, callbacks, names, ctx); +} + +static int vm_request_msi_vectors(struct virtio_device *vdev, int nirqs) +{ + struct virtio_mmio_device *vm_dev =3D to_virtio_mmio_device(vdev); + unsigned int v; + int irq, err; + + if (vm_dev->msi_enabled) + return -EINVAL; + + vm_dev->vm_vq_names =3D kmalloc_array(nirqs, sizeof(*vm_dev->vm_vq_names), + GFP_KERNEL); + if (!vm_dev->vm_vq_names) + return -ENOMEM; + + mmio_get_msi_domain(vdev); + err =3D mmio_msi_domain_alloc_irqs(&vdev->dev, nirqs); + if (err) { + kfree(vm_dev->vm_vq_names); + vm_dev->vm_vq_names =3D NULL; + return err; + } + + mmio_msi_set_enable(vm_dev, 1); + vm_dev->msi_enabled =3D true; + + v =3D vm_dev->msi_used_vectors; + /* The first MSI vector is used for configuration change event. */ + snprintf(vm_dev->vm_vq_names[v], sizeof(*vm_dev->vm_vq_names), + "%s-config", dev_name(&vdev->dev)); + irq =3D mmio_msi_irq_vector(&vdev->dev, v); + err =3D request_irq(irq, vm_config_changed, 0, vm_dev->vm_vq_names[v], + vm_dev); + if (err) + goto error_request_irq; + + /* Set the configuration event mapping. */ + if (vm_dev->msi_share) + mmio_msi_config_vector(vm_dev, v); + + ++vm_dev->msi_used_vectors; + + if (vm_dev->msi_share) { + v =3D vm_dev->msi_used_vectors; + snprintf(vm_dev->vm_vq_names[v], sizeof(*vm_dev->vm_vq_names), + "%s-virtqueues", dev_name(&vm_dev->vdev.dev)); + err =3D request_irq(mmio_msi_irq_vector(&vdev->dev, v), + vm_vring_interrupt, 0, vm_dev->vm_vq_names[v], + vm_dev); + if (err) + goto error_request_irq; + ++vm_dev->msi_used_vectors; + } + + return 0; + +error_request_irq: + vm_free_msi_irqs(vdev); + + return err; +} + +static void vm_free_msi_irqs(struct virtio_device *vdev) +{ + int i; + struct virtio_mmio_device *vm_dev =3D to_virtio_mmio_device(vdev); + + mmio_msi_set_enable(vm_dev, 0); + for (i =3D 0; i < vm_dev->msi_used_vectors; i++) + free_irq(mmio_msi_irq_vector(&vdev->dev, i), vm_dev); + mmio_msi_domain_free_irqs(&vdev->dev); + kfree(vm_dev->vm_vq_names); + vm_dev->vm_vq_names =3D NULL; + vm_dev->msi_enabled =3D false; + vm_dev->msi_used_vectors =3D 0; } =20 static const char *vm_bus_name(struct virtio_device *vdev) @@ -609,6 +876,8 @@ static int virtio_mmio_probe(struct platform_device *pd= ev) =20 platform_set_drvdata(pdev, vm_dev); =20 + mmio_msi_create_irq_domain(); + rc =3D register_virtio_device(&vm_dev->vdev); if (rc) put_device(&vm_dev->vdev.dev); diff --git a/drivers/virtio/virtio_mmio_common.h b/drivers/virtio/virtio_mm= io_common.h index 90cb304..ccf6320 100644 --- a/drivers/virtio/virtio_mmio_common.h +++ b/drivers/virtio/virtio_mmio_common.h @@ -26,6 +26,14 @@ struct virtio_mmio_device { =20 unsigned short notify_base; unsigned short notify_multiplier; + + /* Name strings for interrupts. This size should be enough. */ + char (*vm_vq_names)[256]; + + /* used vectors */ + unsigned int msi_used_vectors; + bool msi_share; + bool msi_enabled; }; =20 #endif diff --git a/drivers/virtio/virtio_mmio_msi.h b/drivers/virtio/virtio_mmio_= msi.h index 27cb2af..10038cb 100644 --- a/drivers/virtio/virtio_mmio_msi.h +++ b/drivers/virtio/virtio_mmio_msi.h @@ -8,6 +8,7 @@ #include #include #include +#include "virtio_mmio_common.h" =20 static irq_hw_number_t mmio_msi_hwirq; static struct irq_domain *mmio_msi_domain; @@ -21,12 +22,41 @@ void __weak irq_msi_compose_msg(struct irq_data *data, = struct msi_msg *msg) { } =20 +static void __iomem *vm_dev_base(struct msi_desc *desc) +{ + if (desc) { + struct device *dev =3D desc->dev; + struct virtio_device *vdev =3D dev_to_virtio(dev); + struct virtio_mmio_device *vm_dev =3D to_virtio_mmio_device(vdev); + + return vm_dev->base; + } + + return NULL; +} + +static void mmio_msi_set_mask_bit(struct irq_data *data, u32 flag) +{ + struct msi_desc *desc =3D irq_data_get_msi_desc(data); + void __iomem *base =3D vm_dev_base(desc); + unsigned int offset =3D data->irq - desc->irq; + + if (base) { + u32 op =3D flag ? VIRTIO_MMIO_MSI_CMD_MASK : + VIRTIO_MMIO_MSI_CMD_UNMASK; + writel(offset, base + VIRTIO_MMIO_MSI_VEC_SEL); + writel(op, base + VIRTIO_MMIO_MSI_COMMAND); + } +} + static void mmio_msi_mask_irq(struct irq_data *data) { + mmio_msi_set_mask_bit(data, 1); } =20 static void mmio_msi_unmask_irq(struct irq_data *data) { + mmio_msi_set_mask_bit(data, 0); } =20 static struct irq_chip mmio_msi_controller =3D { @@ -86,8 +116,60 @@ static inline void mmio_msi_create_irq_domain(void) irq_domain_free_fwnode(fn); } } + +static void mmio_write_msi_msg(struct msi_desc *desc, struct msi_msg *msg) +{ + void __iomem *base =3D vm_dev_base(desc); + + if (base) { + writel(desc->platform.msi_index, base + + VIRTIO_MMIO_MSI_VEC_SEL); + writel(msg->address_lo, base + VIRTIO_MMIO_MSI_ADDRESS_LOW); + writel(msg->address_hi, base + VIRTIO_MMIO_MSI_ADDRESS_HIGH); + writel(msg->data, base + VIRTIO_MMIO_MSI_DATA); + writel(VIRTIO_MMIO_MSI_CMD_CONFIGURE, + base + VIRTIO_MMIO_MSI_COMMAND); + } +} + +static inline int mmio_msi_domain_alloc_irqs(struct device *dev, + unsigned int nvec) +{ + return platform_msi_domain_alloc_irqs(dev, nvec, + mmio_write_msi_msg); +} + +static inline void mmio_msi_domain_free_irqs(struct device *dev) +{ + return platform_msi_domain_free_irqs(dev); +} + +static inline void mmio_get_msi_domain(struct virtio_device *vdev) +{ + if (!vdev->dev.msi_domain) + vdev->dev.msi_domain =3D mmio_msi_domain; +} + +static inline int mmio_msi_irq_vector(struct device *dev, unsigned int nr) +{ + struct msi_desc *entry =3D first_msi_entry(dev); + + return entry->irq + nr; +} + #else static inline void mmio_msi_create_irq_domain(void) {} +static inline int mmio_msi_irq_vector(struct device *dev, unsigned int nr) +{ + return -EINVAL; +} +static inline void mmio_get_msi_domain(struct virtio_device *vdev) {} +static inline int mmio_msi_domain_alloc_irqs(struct device *dev, + unsigned int nvec) +{ + return -EINVAL; +} +static inline void mmio_msi_domain_free_irqs(struct device *dev) {} #endif =20 #endif diff --git a/include/uapi/linux/virtio_config.h b/include/uapi/linux/virtio= _config.h index 5d93c01..5eb3900 100644 --- a/include/uapi/linux/virtio_config.h +++ b/include/uapi/linux/virtio_config.h @@ -52,7 +52,7 @@ * rest are per-device feature bits. */ #define VIRTIO_TRANSPORT_F_START 28 -#define VIRTIO_TRANSPORT_F_END 40 +#define VIRTIO_TRANSPORT_F_END 41 =20 #ifndef VIRTIO_CONFIG_NO_LEGACY /* Do we get callbacks when the ring is completely used, even if we've @@ -94,4 +94,9 @@ * layer. */ #define VIRTIO_F_MMIO_NOTIFICATION 39 + +/* + * This feature indicates the MSI support on MMIO layer. + */ +#define VIRTIO_F_MMIO_MSI 40 #endif /* _UAPI_LINUX_VIRTIO_CONFIG_H */ diff --git a/include/uapi/linux/virtio_mmio.h b/include/uapi/linux/virtio_m= mio.h index c4b0968..777cb0e 100644 --- a/include/uapi/linux/virtio_mmio.h +++ b/include/uapi/linux/virtio_mmio.h @@ -122,6 +122,21 @@ #define VIRTIO_MMIO_QUEUE_USED_LOW 0x0a0 #define VIRTIO_MMIO_QUEUE_USED_HIGH 0x0a4 =20 +/* MSI max vector number that device supports - Read Only */ +#define VIRTIO_MMIO_MSI_VEC_NUM 0x0c0 +/* MSI state register - Read Only */ +#define VIRTIO_MMIO_MSI_STATE 0x0c4 +/* MSI command register - Write Only */ +#define VIRTIO_MMIO_MSI_COMMAND 0x0c8 +/* MSI vector selector - Write Only */ +#define VIRTIO_MMIO_MSI_VEC_SEL 0x0d0 +/* MSI low 32 bit address, 64 bits in two halves */ +#define VIRTIO_MMIO_MSI_ADDRESS_LOW 0x0d4 +/* MSI high 32 bit address, 64 bits in two halves */ +#define VIRTIO_MMIO_MSI_ADDRESS_HIGH 0x0d8 +/* MSI 32 bit data */ +#define VIRTIO_MMIO_MSI_DATA 0x0dc + /* Configuration atomicity value */ #define VIRTIO_MMIO_CONFIG_GENERATION 0x0fc =20 @@ -130,6 +145,22 @@ #define VIRTIO_MMIO_CONFIG 0x100 =20 =20 +/* MSI commands */ +#define VIRTIO_MMIO_MSI_CMD_ENABLE 0x1 +#define VIRTIO_MMIO_MSI_CMD_DISABLE 0x2 +#define VIRTIO_MMIO_MSI_CMD_CONFIGURE 0x3 +#define VIRTIO_MMIO_MSI_CMD_MASK 0x4 +#define VIRTIO_MMIO_MSI_CMD_UNMASK 0x5 +#define VIRTIO_MMIO_MSI_CMD_MAP_CONFIG 0x6 +#define VIRTIO_MMIO_MSI_CMD_MAP_QUEUE 0x7 + +/* MSI NO_VECTOR */ +#define VIRTIO_MMIO_MSI_NO_VECTOR 0xffffffff + +/* MSI state enabled state mask */ +#define VIRTIO_MMIO_MSI_ENABLED_MASK (1 << 31) +/* MSI state MSI sharing mask */ +#define VIRTIO_MMIO_MSI_SHARING_MASK (1 << 30) =20 /* * Interrupt flags (re: interrupt status & acknowledge registers) --=20 1.8.3.1 From nobody Thu Nov 13 14:53:12 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.alibaba.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1581348897740710.8261374618942; Mon, 10 Feb 2020 07:34:57 -0800 (PST) Received: from localhost ([::1]:35112 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1B5M-00032y-F2 for importer@patchew.org; Mon, 10 Feb 2020 10:34:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41629) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j150s-00078x-Qm for qemu-devel@nongnu.org; Mon, 10 Feb 2020 04:05:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j150n-0004IP-Pq for qemu-devel@nongnu.org; Mon, 10 Feb 2020 04:05:50 -0500 Received: from out4436.biz.mail.alibaba.com ([47.88.44.36]:33718) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j150n-0004BN-GT for qemu-devel@nongnu.org; Mon, 10 Feb 2020 04:05:49 -0500 Received: from localhost(mailfrom:zhabin@linux.alibaba.com fp:SMTPD_---0TpbD1jB_1581325533) by smtp.aliyun-inc.com(127.0.0.1); Mon, 10 Feb 2020 17:05:33 +0800 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R181e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01f04397; MF=zhabin@linux.alibaba.com; NM=1; PH=DS; RN=10; SR=0; TI=SMTPD_---0TpbD1jB_1581325533; From: Zha Bin To: linux-kernel@vger.kernel.org Subject: [PATCH v2 5/5] x86: virtio-mmio: support virtio-mmio with MSI for x86 Date: Mon, 10 Feb 2020 17:05:21 +0800 Message-Id: <946b71e77a34666a9b8c419c5a467d1628b50fa0.1581305609.git.zhabin@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: References: In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 47.88.44.36 X-Mailman-Approved-At: Mon, 10 Feb 2020 10:31:30 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: virtio-dev@lists.oasis-open.org, zhabin@linux.alibaba.com, slp@redhat.com, mst@redhat.com, jasowang@redhat.com, jing2.liu@linux.intel.com, qemu-devel@nongnu.org, chao.p.peng@linux.intel.com, gerry@linux.alibaba.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Liu Jiang virtio-mmio supports a generic MSI irq domain for all archs. This patch adds the x86 architecture support. Signed-off-by: Liu Jiang Co-developed-by: Zha Bin Signed-off-by: Zha Bin Co-developed-by: Jing Liu Signed-off-by: Jing Liu Co-developed-by: Chao Peng Signed-off-by: Chao Peng --- arch/x86/kernel/apic/msi.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/apic/msi.c b/arch/x86/kernel/apic/msi.c index 159bd0c..2fcd602 100644 --- a/arch/x86/kernel/apic/msi.c +++ b/arch/x86/kernel/apic/msi.c @@ -45,7 +45,11 @@ static void __irq_msi_compose_msg(struct irq_cfg *cfg, s= truct msi_msg *msg) MSI_DATA_VECTOR(cfg->vector); } =20 -static void irq_msi_compose_msg(struct irq_data *data, struct msi_msg *msg) +/* + * x86 PCI-MSI/HPET/DMAR related method. + * Also can be used as arch specific method for virtio-mmio MSI. + */ +void irq_msi_compose_msg(struct irq_data *data, struct msi_msg *msg) { __irq_msi_compose_msg(irqd_cfg(data), msg); } @@ -166,6 +170,11 @@ static void irq_msi_update_msg(struct irq_data *irqd, = struct irq_cfg *cfg) return ret; } =20 +struct irq_domain *arch_msi_root_irq_domain(void) +{ + return x86_vector_domain; +} + /* * IRQ Chip for MSI PCI/PCI-X/PCI-Express Devices, * which implement the MSI or MSI-X Capability Structure. --=20 1.8.3.1