[Qemu-devel] [PATCH 0/5] Refactor common PCI IDE functions from CMD646

BALATON Zoltan posted 5 patches 10 weeks ago
Test asan passed
Test checkpatch passed
Test docker-clang@ubuntu passed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1547166960.git.balaton@eik.bme.hu
hw/ide/cmd646.c      | 102 ++++++++-------------------------------------------
hw/ide/pci.c         |  65 ++++++++++++++++++++++++++++++++
hw/ide/sii3112.c     |  52 ++++----------------------
include/hw/ide/pci.h |  14 ++-----
4 files changed, 93 insertions(+), 140 deletions(-)

[Qemu-devel] [PATCH 0/5] Refactor common PCI IDE functions from CMD646

Posted by BALATON Zoltan 10 weeks ago
Hello,

This series is a small refactoring that moves some common PCI IDE io
mem ops functions from the CMD646 model to the PCI IDE model so a
CMD646 specific type can be dropped from PCIIDEState, removes code
duplication from SiI3112 model (also fixing a bug) and allows these
functions to be used by future PCI IDE implementations.

Also cc'd Mark and Richard because the CMD646 seems to be used by
Sparc, HPPA and Alpha machines.

Regards,
BALATON Zoltan

BALATON Zoltan (5):
  cmd646: Remove unused variable
  cmd646: Remove IDEBus from CMD646BAR
  cmd646: Move PCI IDE specific functions to ide/pci.c
  ide: Get rid of CMD646BAR struct
  sii3112: Remove duplicated code and use PCI IDE ops instead

 hw/ide/cmd646.c      | 102 ++++++++-------------------------------------------
 hw/ide/pci.c         |  65 ++++++++++++++++++++++++++++++++
 hw/ide/sii3112.c     |  52 ++++----------------------
 include/hw/ide/pci.h |  14 ++-----
 4 files changed, 93 insertions(+), 140 deletions(-)

-- 
2.13.7


Re: [Qemu-devel] [PATCH 0/5] Refactor common PCI IDE functions from CMD646

Posted by John Snow 8 weeks ago

On 1/10/19 7:36 PM, BALATON Zoltan wrote:
> Hello,
> 
> This series is a small refactoring that moves some common PCI IDE io
> mem ops functions from the CMD646 model to the PCI IDE model so a
> CMD646 specific type can be dropped from PCIIDEState, removes code
> duplication from SiI3112 model (also fixing a bug) and allows these
> functions to be used by future PCI IDE implementations.
> 
> Also cc'd Mark and Richard because the CMD646 seems to be used by
> Sparc, HPPA and Alpha machines.
> 
> Regards,
> BALATON Zoltan
> 
> BALATON Zoltan (5):
>   cmd646: Remove unused variable
>   cmd646: Remove IDEBus from CMD646BAR
>   cmd646: Move PCI IDE specific functions to ide/pci.c
>   ide: Get rid of CMD646BAR struct
>   sii3112: Remove duplicated code and use PCI IDE ops instead
> 
>  hw/ide/cmd646.c      | 102 ++++++++-------------------------------------------
>  hw/ide/pci.c         |  65 ++++++++++++++++++++++++++++++++
>  hw/ide/sii3112.c     |  52 ++++----------------------
>  include/hw/ide/pci.h |  14 ++-----
>  4 files changed, 93 insertions(+), 140 deletions(-)
> 

Pushed to my staging branch, thanks.

Re: [Qemu-devel] [PATCH 0/5] Refactor common PCI IDE functions from CMD646

Posted by John Snow 8 weeks ago

On 1/10/19 7:36 PM, BALATON Zoltan wrote:
> Hello,
> 
> This series is a small refactoring that moves some common PCI IDE io
> mem ops functions from the CMD646 model to the PCI IDE model so a
> CMD646 specific type can be dropped from PCIIDEState, removes code
> duplication from SiI3112 model (also fixing a bug) and allows these
> functions to be used by future PCI IDE implementations.
> 
> Also cc'd Mark and Richard because the CMD646 seems to be used by
> Sparc, HPPA and Alpha machines.
> 
> Regards,
> BALATON Zoltan
> 
> BALATON Zoltan (5):
>   cmd646: Remove unused variable
>   cmd646: Remove IDEBus from CMD646BAR
>   cmd646: Move PCI IDE specific functions to ide/pci.c
>   ide: Get rid of CMD646BAR struct
>   sii3112: Remove duplicated code and use PCI IDE ops instead
> 
>  hw/ide/cmd646.c      | 102 ++++++++-------------------------------------------
>  hw/ide/pci.c         |  65 ++++++++++++++++++++++++++++++++
>  hw/ide/sii3112.c     |  52 ++++----------------------
>  include/hw/ide/pci.h |  14 ++-----
>  4 files changed, 93 insertions(+), 140 deletions(-)
> 

Richard, any strong feelings on this? I'm inclined to pull it this weekend.

--js

Re: [Qemu-devel] [PATCH 0/5] Refactor common PCI IDE functions from CMD646

Posted by Richard Henderson 8 weeks ago
On 1/21/19 5:44 PM, John Snow wrote:
>> BALATON Zoltan (5):
>>   cmd646: Remove unused variable
>>   cmd646: Remove IDEBus from CMD646BAR
>>   cmd646: Move PCI IDE specific functions to ide/pci.c
>>   ide: Get rid of CMD646BAR struct
>>   sii3112: Remove duplicated code and use PCI IDE ops instead
>>
>>  hw/ide/cmd646.c      | 102 ++++++++-------------------------------------------
>>  hw/ide/pci.c         |  65 ++++++++++++++++++++++++++++++++
>>  hw/ide/sii3112.c     |  52 ++++----------------------
>>  include/hw/ide/pci.h |  14 ++-----
>>  4 files changed, 93 insertions(+), 140 deletions(-)
>>
> 
> Richard, any strong feelings on this? I'm inclined to pull it this weekend.

Please do.


r~

Re: [Qemu-devel] [PATCH 0/5] Refactor common PCI IDE functions from CMD646

Posted by Mark Cave-Ayland 9 weeks ago
On 11/01/2019 00:36, BALATON Zoltan wrote:

> Hello,
> 
> This series is a small refactoring that moves some common PCI IDE io
> mem ops functions from the CMD646 model to the PCI IDE model so a
> CMD646 specific type can be dropped from PCIIDEState, removes code
> duplication from SiI3112 model (also fixing a bug) and allows these
> functions to be used by future PCI IDE implementations.
> 
> Also cc'd Mark and Richard because the CMD646 seems to be used by
> Sparc, HPPA and Alpha machines.
> 
> Regards,
> BALATON Zoltan
> 
> BALATON Zoltan (5):
>   cmd646: Remove unused variable
>   cmd646: Remove IDEBus from CMD646BAR
>   cmd646: Move PCI IDE specific functions to ide/pci.c
>   ide: Get rid of CMD646BAR struct
>   sii3112: Remove duplicated code and use PCI IDE ops instead
> 
>  hw/ide/cmd646.c      | 102 ++++++++-------------------------------------------
>  hw/ide/pci.c         |  65 ++++++++++++++++++++++++++++++++
>  hw/ide/sii3112.c     |  52 ++++----------------------
>  include/hw/ide/pci.h |  14 ++-----
>  4 files changed, 93 insertions(+), 140 deletions(-)

This looks like a good tidy-up to me. I've applied these patches locally and tried a
quick boot test under qemu-system-sparc64 and it seems to work, so:

Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.

Re: [Qemu-devel] [PATCH 0/5] Refactor common PCI IDE functions from CMD646

Posted by John Snow 9 weeks ago

On 1/10/19 7:36 PM, BALATON Zoltan wrote:
> Hello,
> 
> This series is a small refactoring that moves some common PCI IDE io
> mem ops functions from the CMD646 model to the PCI IDE model so a
> CMD646 specific type can be dropped from PCIIDEState, removes code
> duplication from SiI3112 model (also fixing a bug) and allows these
> functions to be used by future PCI IDE implementations.
> 
> Also cc'd Mark and Richard because the CMD646 seems to be used by
> Sparc, HPPA and Alpha machines.
> 
> Regards,
> BALATON Zoltan
> 
> BALATON Zoltan (5):
>   cmd646: Remove unused variable
>   cmd646: Remove IDEBus from CMD646BAR
>   cmd646: Move PCI IDE specific functions to ide/pci.c
>   ide: Get rid of CMD646BAR struct
>   sii3112: Remove duplicated code and use PCI IDE ops instead
> 
>  hw/ide/cmd646.c      | 102 ++++++++-------------------------------------------
>  hw/ide/pci.c         |  65 ++++++++++++++++++++++++++++++++
>  hw/ide/sii3112.c     |  52 ++++----------------------
>  include/hw/ide/pci.h |  14 ++-----
>  4 files changed, 93 insertions(+), 140 deletions(-)
> 

Hi, just a note to let you know I just got back from vacation and I will
take a little while to get to this as I unbury.

--js