From nobody Wed Nov 5 00:11:33 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail header.i=@wdc.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1531859814108452.96126486449054; Tue, 17 Jul 2018 13:36:54 -0700 (PDT) Received: from localhost ([::1]:33147 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffWbX-0000dC-VL for importer@patchew.org; Tue, 17 Jul 2018 16:29:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffWZq-0008Dk-8Y for qemu-devel@nongnu.org; Tue, 17 Jul 2018 16:28:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffWZn-0005VV-31 for qemu-devel@nongnu.org; Tue, 17 Jul 2018 16:28:06 -0400 Received: from esa3.hgst.iphmx.com ([216.71.153.141]:30202) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1ffWZm-0005Ua-M0 for qemu-devel@nongnu.org; Tue, 17 Jul 2018 16:28:03 -0400 Received: from mail-sn1nam04lp0086.outbound.protection.outlook.com (HELO NAM04-SN1-obe.outbound.protection.outlook.com) ([216.32.180.86]) by ob1.hgst.iphmx.com with ESMTP; 18 Jul 2018 04:28:01 +0800 Received: from risc6-mainframe.int.fusionio.com (199.255.44.171) by DM5PR04MB0394.namprd04.prod.outlook.com (2603:10b6:3:9d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.952.18; Tue, 17 Jul 2018 20:27:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1531859283; x=1563395283; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=3Hmi1bZjrsnxpK9XcYDC5g9rrP0pkPoWuqooHMb2t+k=; b=EX9+y/nJsnlCVDrP0/5GpiHLqoDjth9JFj6mWkQFxn8drYWVl3bPc26i lliVWwxA4WC76of7Qgoswkq8pWjYhP149MWIq/EakLw6AB0OTGw1MH+rk fRrSg8Uk53OSjHsUnVHr3YRv08+rZZUxOHcRC+7CVDQbVdlU4I/FJEOSG ZpZ/t5aaoIZbw84Vu0pvrbQlGZDX0JLceIUv04Zst6op5bAtuUR4pOllh nQ3p6+1twAOyysV1Eyz62SP3xqYtnY5BfPxqBfBpxqVTIQ3keBlAtVVeN 89Kh5UXzCiwzG4YKQtldLWMlektDAW41e19uAtbEHWVbJ6zzeG/ff099C g==; X-IronPort-AV: E=Sophos;i="5.51,366,1526313600"; d="scan'208";a="87467558" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SR/LrtcBLOo1Q1DC6zJeOTecOuWoi7wM4Vi3Q/UgGlA=; b=aM8oUwy6fO0lbYQOFJE8MCwLsARdv2nVCZISk2cAIIHm62SYlhIt2VgVGSIJicYdjLufq/I3g4B+y3nBMVJUVylyTBlhpudR/RiShx2hcRzEZvNqk/J3vvXeFmEhkUbSDUMOdMk/HmZrXyLPK+goQzZ/PKAxkbA8gKuLozCFzP0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alistair.Francis@wdc.com; From: Alistair Francis To: qemu-devel@nongnu.org Date: Tue, 17 Jul 2018 13:27:50 -0700 Message-Id: <7b4596fd90e5576e7caafc0f34ecb06c786c4a7c.1531859179.git.alistair.francis@wdc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [199.255.44.171] X-ClientProxiedBy: CO1PR15CA0065.namprd15.prod.outlook.com (2603:10b6:101:1f::33) To DM5PR04MB0394.namprd04.prod.outlook.com (2603:10b6:3:9d::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bac28d5c-5105-4a1d-445f-08d5ec23c9d7 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DM5PR04MB0394; X-Microsoft-Exchange-Diagnostics: 1; DM5PR04MB0394; 3:YhrKGAKYrL2PLUOAElUer1bCyKco5Qhq60xlo7yr68lDCiVWzKg52MQn9YtWCdHB9MbdHUA4Xn0lAohvFKuV9LTo9d2U2FyHzt71kk4dXmdcaCDhTtqnjFjebJXSIbs1+9e7+voKKShGgarRmzvQagxLlAfKNTR5O6onZYMgN+GztY7u6pfTC4TT5aJ+t1hVhQ/L57tUFSjh/gApZsHCjLOG3NdrClhJ2z5iz3yTjiTQ0HNvemuIO6g0Go3f5sPf; 25:9q2NjW5KRp4y57jOMsaEWpudkE7q61ILpB3yjlvBJWJvcOy8V3DnXL3ldxqALPEPDv9IwMqNZkUrxvPUDBWP0AOav0x9j6JQa13W/Sga/gW0CzNhO0t5q0EF1Ksppp35NR3zAReRUO/vg5gS6aMhvvLoPDeQiYLLloboym+0M911TNPIjHqxvj8odH5ObS4bQgYJG+dC2cmtfUcvq65HCagA1kdhsEQ94qu3zoDqgR+kQQK4prAk9IAgwo+rdfI7HQEiMs84muBHAF58JKclqLcihb4LEe6BYhAd/OWUL4lV0q3Lsi9sZ2KW1m2sVtw/2AS4CprVBilskGwvHcOb3g==; 31:ZhPkFtaie1cF/KhcHSpucAmSA/9A1DxpUYDiRCV6+5bxEYd5eW6rphM40OmiVVlG/sKKCA5Im+QxsqSPbKVRY4SbbloL7o/9G/TCPQx27dL2Qp5+QaP6BObIg9cWCN3UwmkMufHR8797mxaxbOz79MsNGlUGoCSVc2Jy5btSdV4eUSoyK/Z1E4nvpsnJ8u8gN/Z3OndvqoFMKrO2gUnSQa+wsB6ZV0/3TIBMmUkseNU= X-MS-TrafficTypeDiagnostic: DM5PR04MB0394: WDCIPOUTBOUND: EOP-TRUE X-Microsoft-Exchange-Diagnostics: 1; DM5PR04MB0394; 20:B4nphwycI+Al9EE9QiHxsEs1iHIideT/TDfo+bpyESW0qLtTq+/TEIgFWq3VfNLwTmbcwrd2RVQZEPV89huA+31m+0ClRV7ZED7e5GoRdYCLHL13zDttpnGa+AQqmbYhokzNVRI8m9HmuHOdhjBYQoMjIe6ySPJnh/dLIMO2Iv5mX/px6V64HLwiweiHDa1jtpMWrjS11FutV92dX15ML36BQ9GIQNMdxYvIue3WvxoMiqjjGv7iaZazfoPJ0BDG12ZBYMu5FOatA7eBaSaRfENhIznKW7hdwegzSkSvYsOGKQpHwmjvJgVflFWxDp1ZdVNF4eyR9PVhorRu9qZ5GkZ3sNVdfCZkLo9ixQalbHmGZCelEaiAXKUJf1oqte4RbuEdLQ0eEGXWssWCGfH6w6Gp58NbileMjoWg1W1vdru0uu2NxFs3VM1tBPlgJ6wiAm2Oo9wJbTMZPLxP/fwPUDJxtt4la1uposzCkiuepSADbN2iq6WV9lEprp4OkcfQ; 4:iJN56A/1hb0oa+N9WXraLR5GI9QvY+u+59qKBsBPirCoLji2xAPw6Q/lsIHX02SudS4L0velzL6ytWZn40hIurwZyuq+QPOVLVh24tkBb0uSpaJnnz07sx7p/XFNNlMZ3rh8VJCg1MNUI079JqZhgiSJjSzjmljXQAs/S0GXgX5DqXRME7F7CUWXiHh4UlXfzufZmMzh9LaG9qgCoreKvGolH1x0eC1+1SeaI4vi5D+ltv1nyHJ/PFLAF6gXOn6rCVkWkZrqz1BleJwX8vLvUA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(3002001)(3231311)(944501410)(52105095)(10201501046)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:DM5PR04MB0394; BCL:0; PCL:0; RULEID:; SRVR:DM5PR04MB0394; X-Forefront-PRVS: 073631BD3D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(346002)(136003)(39860400002)(376002)(366004)(396003)(199004)(189003)(47776003)(66066001)(6116002)(186003)(97736004)(44832011)(53936002)(26005)(86362001)(3846002)(16526019)(4326008)(6916009)(76176011)(386003)(6506007)(446003)(486006)(476003)(2616005)(5660300001)(11346002)(956004)(51416003)(52116002)(7736002)(36756003)(8676002)(81166006)(105586002)(50226002)(81156014)(72206003)(16586007)(48376002)(8936002)(305945005)(118296001)(316002)(6666003)(2361001)(25786009)(2351001)(6512007)(50466002)(68736007)(106356001)(2906002)(6486002)(478600001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR04MB0394; H:risc6-mainframe.int.fusionio.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR04MB0394; 23:VEgzxyzSfXxkJBps6Ul98/ADM29h2iZIE8uJ6rxpD?= =?us-ascii?Q?nxcE+ls7kdVgIohu6PB89nHsb5xc8/Pmym65r/Qc6ms2IdTeoygL95dxI7E8?= =?us-ascii?Q?gKZU9GidkWlhc09pWKm4q8JyRT22MpAI/+8DVd/v161xtuDeRgMS3O3DVAqc?= =?us-ascii?Q?rAE1nGB5EbujmHIllUcnlLCJSAuIlFg2uhzvbZsxaOH1MCyu5iJTdvr9VW1A?= =?us-ascii?Q?Il5WXOm/hoAymOLpjeNvMgCIDK53E9izP/HnWF4tPIKPfF+3MOwlC218fP0u?= =?us-ascii?Q?m8t42dcWHcoeru8RgJJ8dWlOcc9/jKGD4FlgpXE3ycLj/cN27Ubzs0qX9kYq?= =?us-ascii?Q?epU7g9CIGsMqdzGhnyp9WT+TIn0IE5jMqhQWdgqGyf/lpmKNt0Tc2y0zVl8c?= =?us-ascii?Q?kalUeIHOiXExlyiUCfL+oqkBSypuXnp1J7TPV0/Yiw27vE6CjoL6GBDnwPyo?= =?us-ascii?Q?AuGYdMQLb23BaHzZRBR+OkhKntfA3xuMVL1jCtcuiOvx9MOc1Mv9WeerNW/e?= =?us-ascii?Q?PzQxmxlBqJEu2+Xc+12pYbI7U2Cu7nGeO/cXvYfUzl9vAODZSsMWUtU6WQj5?= =?us-ascii?Q?wbMUCu7e5kNtyUgBaaRLqlj7dZ+cmG2GQbGvSG70htbPbKaYeK6idB7adqk8?= =?us-ascii?Q?3rk7upO3ERn+BWwPXNN87U+IjM4b9iseBxxE+EVJ1/sOFOBtUpODE6m6NBze?= =?us-ascii?Q?ipHO5j3DIzRVFLmgm+aEqY7pnzlsuPxN31Qr7M4SrbxuXtSg1c7G1w3ov4O8?= =?us-ascii?Q?4r4BfUTCmOkOaTrwgu3oXO+uQukHLcYSvCQzTlyfEzxEaCn9OqimBtdWAIOj?= =?us-ascii?Q?qR5qwADR2WVkppq5iHIHy1VLU3+PVxgpccc3CiiuHMgEawRLwOAXHoJgXI5x?= =?us-ascii?Q?Pzl5r40jKSuibCkx73oRZyBAZkaghDjTLd9LqCGdDEh1fEnteQPJBYSLQZvo?= =?us-ascii?Q?RwcNStvploqFPjcJA2lmJP0aqE+PkF24Pe9D3KwsybjMbw2CwwcYWAZyVT7u?= =?us-ascii?Q?j3PpXfs+dymmpuMok/Y+fs6hnqlie/Kh8Vo6JtSD4SgJ0qqJxOfEF5K21khe?= =?us-ascii?Q?4axX4sQFkSGeavWWh+Pex5RnRKynwUrXnVrkBfJ+ktszo+I+gskxy9SrQE3s?= =?us-ascii?Q?e6QxldbVQ/OUA3UwbqvV1x3eaelLro43IiNqYYudQAyPJHiypXHU8uXuRP2U?= =?us-ascii?Q?alKRDRjpvGObL2YCX11BvBSMz1RK+1fZOD+DoeaVwJq+120nX1FpBRlpesrj?= =?us-ascii?Q?LY6n6fMHV95cVRUZP6AmQq22jdPJ2kxaai1ysCa?= X-Microsoft-Antispam-Message-Info: yLLApMi/fgRGlVqg2akD/SXcNAp71H4nqqzE88V9VWDIfHM+2tOsSmbps+ikUkvU79l+xRm9ePzEuKKwYUtMg5/dqTSg2QXpi/+y+T69emcfCh6p1N6zuRRrY/64VUjJ0UreC2W9CJfXghyXyyLLKhMYGXYgpSnh9ipa33x3cjByEgO7wi+PVbZi0V6XSlcsJkxd2DH1yQpeG5aIjMazM3S27aaPKc9TbxU1GUlWHCaJWMOtX27RHWuBVaJGYqjXIopKiTzk8HOIlvL5q2iWKHHIh1jbmhkYyc8qKCcPob3pgBHojmktylB0wH0I6+NdsmgNeBDkjLkhferw8ambsULZ9rOkNHbKI2e99ddJO1Y= X-Microsoft-Exchange-Diagnostics: 1; DM5PR04MB0394; 6:s181Cn552ABZ461DfuePMa2jNQh4TEdhzLtEtkfjqfS2rvtYzXsWne6IXpZtel0evf4QHCGyk682D7RlstnEpK9+Y5vfN3FZTi4fykrdxfcPxOJgTT/B1fvHprrXR5h77gDu+FtYJQk90703A7k0H9UrFzDmsFP0oTndyK4SfZXVfw5ZiH9p3JfJzHkv1omYW5rZpw7gMZHn6Mvv1a3u5sMz/+Kl3tNOmG1bYKHQkFKCX34KPnkweFKq5kLKt94/5bLcHfho+q5IjYU9AdvhXyFMqiMGQdSxHPHKA2/39To+bnnIayeX/F9KUhRi3ftPYPoB/m/hZzspEstopXQMP4EIdhmzC5/r0iOp5+IJfAUbPuwGD9uhz0u5OHrabFG+l7TR8DpcmN1/8/7rGmJfat5GyKqhiRvFL0oImB6qTcrQQxm6WAE+S/yGrv2t4hLNeh0WlijOXHwHIf/5qNSZnw==; 5:CS5eVkRP4Pvfy/dRSnriatw8j/e3XN1igLzf0IBrh9GeL+TIbTK3APJzVVl9IQnY5+or1cbfzFaicqy7HJoNLivaPfB0WL9DeRiRLpwQbhmyQNfHQW04tAX27ta5Rb2i+qR10je7IBFIyKnAr8gTqRjmgEdxeOYBNNrenlZ269s=; 24:qalg6B2gu8o7qyVoYNcU6GaVSvJXoJvfOkb8a2B3Kp0G50y719JlDFVsMRIjwCGzCbUlJShhIU9ANV5+myt1LVnqRyh4BwmH4nuoHqu1S/w= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR04MB0394; 7:H+FXG9rrBcncY0P2gqQGUDrHLoJmrIvZZDW0wOVRKNZ26ouUHRuUve/NlhamAQj2Bh+NqOmRdxfV+uguPa7WPh+e4eM9GhCvGkfXUNleMjDkhfcJAGSzHOnHlVtQygiE8Pvs0DW6Uq2gm36ONcdw5jGgRt46omjp0xbLshrmqZBXrt1UncIvoIrqjWr/x2wmoaRdDITIXZTDEOlgVghyQySbQd94iNJBrL2jL1XfqgZ8lWuku6uw/K+GDzKO+HZK; 20:qhLcLwB33YRTWfhwR+5XJ2I/pfAEy4H7udWZrrk8PqjBGcPuF9EifXm6R+BwH4LeLCKfRgOSr+HYLM52xnQdWaX0vuhD+vyoGaq+qrq4mu6q8fJZHS8CRRCQpZm8RUwU0zdRqpwtgmCBa1Zzguk4MmG72kZqDDNPJAZvaPa3uj8= X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2018 20:27:59.3448 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bac28d5c-5105-4a1d-445f-08d5ec23c9d7 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB0394 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 216.71.153.141 Subject: [Qemu-devel] [PATCH v1 1/5] sifive_e: Fix crash when introspecting the device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, mjc@sifive.com, alistair.francis@wdc.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the new object_initialize_child() and sysbus_init_child_obj() to fix the issue. Signed-off-by: Alistair Francis Reviewed-by: Michael Clark Reviewed-by: Thomas Huth --- hw/riscv/sifive_e.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/riscv/sifive_e.c b/hw/riscv/sifive_e.c index 8a8dbe1c00..4577d72037 100644 --- a/hw/riscv/sifive_e.c +++ b/hw/riscv/sifive_e.c @@ -105,9 +105,9 @@ static void riscv_sifive_e_init(MachineState *machine) int i; =20 /* Initialize SoC */ - object_initialize(&s->soc, sizeof(s->soc), TYPE_RISCV_E_SOC); - object_property_add_child(OBJECT(machine), "soc", OBJECT(&s->soc), - &error_abort); + object_initialize_child(OBJECT(machine), "soc", &s->soc, + sizeof(s->soc), TYPE_RISCV_E_SOC, + &error_abort, NULL); object_property_set_bool(OBJECT(&s->soc), true, "realized", &error_abort); =20 @@ -139,9 +139,9 @@ static void riscv_sifive_e_soc_init(Object *obj) { SiFiveESoCState *s =3D RISCV_E_SOC(obj); =20 - object_initialize(&s->cpus, sizeof(s->cpus), TYPE_RISCV_HART_ARRAY); - object_property_add_child(obj, "cpus", OBJECT(&s->cpus), - &error_abort); + object_initialize_child(obj, "cpus", &s->cpus, + sizeof(s->cpus), TYPE_RISCV_HART_ARRAY, + &error_abort, NULL); object_property_set_str(OBJECT(&s->cpus), SIFIVE_E_CPU, "cpu-type", &error_abort); object_property_set_int(OBJECT(&s->cpus), smp_cpus, "num-harts", --=20 2.17.1 From nobody Wed Nov 5 00:11:33 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail header.i=@wdc.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1531859577610271.4646929141925; Tue, 17 Jul 2018 13:32:57 -0700 (PDT) Received: from localhost ([::1]:33167 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffWeW-0003Ml-Io for importer@patchew.org; Tue, 17 Jul 2018 16:32:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffWa3-0008Kh-Bi for qemu-devel@nongnu.org; Tue, 17 Jul 2018 16:28:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffWa0-0005Zu-5b for qemu-devel@nongnu.org; Tue, 17 Jul 2018 16:28:19 -0400 Received: from esa5.hgst.iphmx.com ([216.71.153.144]:30194) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1ffWZz-0005Za-QB for qemu-devel@nongnu.org; Tue, 17 Jul 2018 16:28:16 -0400 Received: from mail-co1nam03lp0016.outbound.protection.outlook.com (HELO NAM03-CO1-obe.outbound.protection.outlook.com) ([216.32.181.16]) by ob1.hgst.iphmx.com with ESMTP; 18 Jul 2018 04:28:14 +0800 Received: from risc6-mainframe.int.fusionio.com (199.255.44.171) by BN6PR04MB0386.namprd04.prod.outlook.com (2603:10b6:404:91::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.952.18; Tue, 17 Jul 2018 20:28:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1531859295; x=1563395295; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=jDJLdIUeOKD7i7iiFffCsR0e5J3dHUow6GiKmrp7GHg=; b=g3QRpNOOGbsgZU0LY4tmHtYgbG2RPYdU8UfDDssasOmb9G+ygRXr9QJC eJ7BMbMZSYzbDtZCTvqes1jcnZZQPnoLUsZHFmWVHRM7raoRfg/lOkFeM ThKjCbpsFsNb8ew7q63e71RlwFoxJuFst7BqncXqSZCmApQfT/RRZUdql p7T4PKCCwupesbdwCFhQoZxycloiew7xWAuRvgfz3oAptcIVW6AjvleY1 PHe3pLTH5CtZ5nuRuFVVY2kGbRPxfJdGUrVtIlEpNofYq4turPBSLv+qx b8BQp8kf2jHXBUKpkEMX+gVV8TRpXHyiUwYrpsowE/gVs9qM0kPA3Trfj w==; X-IronPort-AV: E=Sophos;i="5.51,366,1526313600"; d="scan'208";a="84985451" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pAQ5Ydm+BosiGpJbnAegorjRE5xxs9V5E+KUOpHoTJE=; b=KYqJVrKZggXsBnlvqjhLnSepj+q/bEu5clVdxMVsI4dMXW0epVVqplFG/6y9RBWz9pPnkbD/8LdhLlgEwQW3TOCEQTps95IsBMiAeg0Z5iLiu53nbpwtm9GXnnroiTVD2muUbHlV/BT0Pf4vmp1K31FJtyAz/BYfNDfDlDx8UVI= From: Alistair Francis To: qemu-devel@nongnu.org Date: Tue, 17 Jul 2018 13:28:02 -0700 Message-Id: <0f2b0a7a0b3565525a8683ac8fe65f44f734ab19.1531859179.git.alistair.francis@wdc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [199.255.44.171] X-ClientProxiedBy: BYAPR01CA0021.prod.exchangelabs.com (2603:10b6:a02:80::34) To BN6PR04MB0386.namprd04.prod.outlook.com (2603:10b6:404:91::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0b231f19-3642-4541-2053-08d5ec23d177 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(48565401081)(2017052603328)(7153060)(7193020); SRVR:BN6PR04MB0386; X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0386; 3:DSOEDTs5o4Tm82zUQHjPJHujE4ovlQmTGNMCGVzuoqP1vNSp70Ivvy/gAPqCpTpfOPuoeLrgyN7FNFl8fvvzVw/V2WI5H5GeSD5sTJASfA8q81kc9G1unPmClwsu+VEix0K2aYxsPDgTMkK57IRoty0E7j9E/hxE00O3T2HFJMVoZM4MY3MYvPrlnfu8EC2VpXKRCPN4nM9zvUAjmKPaVqqbT3EO48FyRUnI4foNDDssLn3Vd6mygPV3o5Ft8OQC; 25:7nRT96nwaYpp0sCaivYr8K3l80m3yWlaEc1kwzbpo40GBkSU5fLAD7tmsbWyU9IDH///nJuVLszC5NcV56gd95Ld689qqFAyAHryt/H/mflI61YotMXf4ano5Q1w4WcAJQrw0sZKtFxlEqbIcK0gflURnAPKuFNjUia+3wlWMeSuocy8mmgxuY1Mip3W0lPTt4TQNZd9u/sws4X9TWkr7Zcni2QMU3K5fTdmOdKeQpXFZKWeGurnZi+sQJK1Rf2kx1VRAhH+IS3XbLo0rs2EX6PASLDI0axe9DaGmRquHBp9V3iH1fn1O4CefAY2cQ+PYBLuzab3REfwMm9HDYYQzA==; 31:/ECFwMQj/MepO8UTCl9v697SkwBiyPEsz6r8gYzlhy9dxJ9sej9ZPuMJkyQfbwcaElcnswLrgIr06YorrOq+Y4pxReC7t5sR6lxs2Mhp3onTi3iXIx/HJotDvPm4BmX530kL+h0yw7zHYXMsxP+6JGXpzfXOlCqEzRBLyu7+fX8Vda11T5GV7KQYQ60yIzS84UKKvbqRqPVAidxQ/6XWOpdOepCF9MIMHXFSdXT+SRA= X-MS-TrafficTypeDiagnostic: BN6PR04MB0386: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alistair.Francis@wdc.com; WDCIPOUTBOUND: EOP-TRUE X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0386; 20:fnUUkH61nqFYdhe5sQ1fJgR/2nMOPco9AfAYaDvZoNc/Q9toDKybeiGZmDiZ2kI+7cIlPOfUyH563C26ja1HEtK0H+BC/0jj53izhWhUqNwOgJccie3cNbyVgVz9MV38oTN6Y6mYntc+fu9TaXCK5cBh+yiu6ivbDDZTN8N7USa5bgKym//LoqxyCyYRm9IiFT/2jFXrlUT7cLIw5yjWgr6eOKd7MxrfwUaQcld6HZ57zhFSc5wCOyggWCFURi4En43y98fSVZti5hMGELHH4ErP+PRzmpB5584Wr4ls5Z6zSjcvGG/hlNDsKJmykvwVTBhqgASxH0R6gKLjko0NUascNKyuihPQbsY7YLf7shCvlptRe5a8WJWrF1YjoIwPa2gODSzlk7s68TnH1hE7gOD3J2A7U8eHp3Ot/wzR69//WX3EaqrgwJCjuzXGdn33JwE4rmLtKaXi/D/khmuAounGLjq5f6OU/mlJQwUBX6yFP0njpFFxTncJEHOVTIEH; 4:ttxGgEszfUKaO5IEvko41zI6ehMT7m+svtS1MQGkRf/kdxM1LNizfmqHzwNYLPzAYcFIe+6SE7dBZopd7Y6MVLAPxHISYIXi+mym4KU9sYq04TZF12oLSCZtRFIfD4269nn7db8CHWEtfsLcKg010augpkah7kBXi0KV136w3c8ijElqkJA8MBrYnRYyIGLcA9j6cNmTXW6l3t/wnR745weRUVhEF3AfusNtChqFt6qZ9oCTglkYdZOTAGSooSvvFwM6d4FgqrdQc+G/z1wc7w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231311)(944501410)(52105095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:BN6PR04MB0386; BCL:0; PCL:0; RULEID:; SRVR:BN6PR04MB0386; X-Forefront-PRVS: 073631BD3D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(39860400002)(136003)(396003)(376002)(366004)(346002)(189003)(199004)(8936002)(11346002)(8676002)(478600001)(66066001)(2361001)(486006)(446003)(48376002)(186003)(81156014)(97736004)(72206003)(50466002)(26005)(956004)(6486002)(25786009)(2616005)(476003)(47776003)(386003)(6506007)(4326008)(16526019)(81166006)(6512007)(6116002)(105586002)(50226002)(86362001)(51416003)(6916009)(106356001)(76176011)(36756003)(3846002)(7736002)(305945005)(44832011)(68736007)(5660300001)(52116002)(118296001)(2351001)(53936002)(2906002)(16586007)(316002)(6666003); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR04MB0386; H:risc6-mainframe.int.fusionio.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR04MB0386; 23:3BkbzJtaQqQipNB/VGcnux95XrM0hF/GajDkBz38u?= =?us-ascii?Q?7jEuk8rQZNwEdJD9VzyK6zwN6u+HRmdPWyjQfVVm4rIN+gJtElBscB5NzDz0?= =?us-ascii?Q?zqs13DriOZfRhQ6UAVjdDYXlCQzw9PndycFnGW/I7haTNdQgKPKi0kGeZ0tT?= =?us-ascii?Q?C3fsUOx2senH02BTOex892VuWrm4fsit2e+xkM0p6MQTXQGGaY3OK9JnfPNp?= =?us-ascii?Q?sRTRrbp/WJihqjMWofzNt5cENd96nzUyTL3zzpa4AlqBzYyajbrVv0p1fg9N?= =?us-ascii?Q?moAr4xajRPoZ4gRkQ7wVEldSloTwHZ3QBQ/Hlog7w+KYRNZx3oYoVQDkh9pH?= =?us-ascii?Q?MPyf04Rls/tGrQ88tQ9RZR26sWkj/kIgHHCXBXSq32fOuNaIRR2nXY1+Y6Mt?= =?us-ascii?Q?DwQQM90f3Et2ldR3urevOA4L9zxJ8SExL/H8xDaLDjFL249XvOUKG3Vkk7qS?= =?us-ascii?Q?n67gbz1thHr0PSkvDeNqCi0NEI5YF8bdIuZZg2xmminPJSvI8OxHp9pUs9sH?= =?us-ascii?Q?unjKA2RQNRo9UOo5C9kMYmYeL3PuVbrkluiFpdfYg46HI1ZhY9eh5BrvVsuH?= =?us-ascii?Q?qCv3cHjVa7WW85zppAFdHZUKi4AB0utG30liAiaQeK0ANB23VJbOaazOuDoT?= =?us-ascii?Q?9B13NQ0oc0A7FzeUoGEIEexQy6kXIr6gdWui4GWbNKvoq90EttxTrOU+wyNL?= =?us-ascii?Q?FlfzW3uO63/pWlTGOh83F+7ah/vhxZ6KCxkyLmc6y5tHKxEqiiVi1edqLZxb?= =?us-ascii?Q?262Ths7pRm+nuZSzHBG7lgawS9nGtsk2D1kyfUKxJ6fZ2I5Lx7XRhAFBiFAL?= =?us-ascii?Q?bqSAzEuo53WOGHQHdIoodCZTxIYI///57jrDWKq3FSmdOfXcKNyJF2HfHWt4?= =?us-ascii?Q?rb2ae4d7NNyu21wWjyQ4kR4qffV7YZR6VrfgB+NbE+ihcOa7vGw+O3zFuyPc?= =?us-ascii?Q?+U97n2vFpmXxx8mw32PO7oOeG5SyHlD7kF30ZkcAk40YKPj30vAnwCunVYF1?= =?us-ascii?Q?Qc076cVEbpZcrjbxJtKv1ztB9XONXAnK4tAbJS84FqkxnBVqWcL6cko7l764?= =?us-ascii?Q?zlixhUBvS40yIJ4JC7BgCbkbomgVZpvxgc355JUJHiL3PNmujUVuqzQOj6s3?= =?us-ascii?Q?wEd2ZpmNGl50p3UotwdfX3utBW+GBL9iJpEO27uO+kZStatUHxbiCGUbhRVZ?= =?us-ascii?Q?xLKat3AqqYrA8c0QnOPjka6zQeoHeJOX6CqEO47DpxOOr9HyfcwByETi5zKo?= =?us-ascii?Q?BTFQ/qVtt49LGdss2wQkZGEMyMAMedFP/ZkLxCX?= X-Microsoft-Antispam-Message-Info: fuN436gZXn/6nAwRDBuMQwHRG0CjqV0+DHIzZTWqCYUzI+AorjEXMM/NF6cWcRQqpcJxJqIdf9HeJs14UDZKFAdZ/H4DF8xATEtJJErbMATQ7rKO3CnhTzNueLwYHWcukVQmnEOp4l2M+jjDgTPBSZLZqndZf27SVSlaNO3CgfcGQpSG/eAOIlNUHofF7qr6EWXzJ1s5kjPwcL+WuNgvi7nr+7ZAKT4nlWzWoT6PLhQvrtB5wgy0/S0Bdl2Do+pmVyNwSyvRQi09eYzxb9VYjRL++jNWizeKKI/6Mw+pAg9XD93syhBYOYsvxSZky5VxQl09u1fmaH0e9iwhrMKOs4osHy65b69tZKvIQN4eccM= X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0386; 6:IGn2/tFsRrxGkPWBYT7B0TlL3g+mYYonZpye7isngSXjPnnBzNMTvPtkfKyM4fXUKtucyoob8zRarlRlP4Wg3GKIZY2vsGCpu+EEmKZWUUfgEH6jOSKXsvPEBEf5+5QZT36wGWyPedFxs3kTSpE6N4XHz9T0i8oIy9m4UuU0DTR44N8b0oIHUscUrrbrIkf8BppLRGJcKjk8gQQ6TZlepX+m3bh1dFvkarH3gj8WwSYFJoBaw5op3F/qk+GFfQcUPNqsjLLtOlVsgqlATl9BMWj/tkXn8KQiJLG8rHQT80o1Io6xixR7MEYeHoC+e+mIzB0fGwQ+b/rhEEpPQnB7E7z3DVU3hBonwZwVoij6iuzGA5VW4sQMIAQQnkR2U+Sj0dAU9TAJGZ1S6p7EU3t9gTLEifHwM45hEfc3Q9dUHNJey+2rj5F0MM0gj5POBviU42mWBGUkM3QLR3pQh1M/GQ==; 5:vHahx/xbtUT0IYCIULd45T2EJG5YK/4k2i+Dv/dTKjLBwKaL+/EgL4kYb4I/BCLt0+I8X6iog2vHQAVddr8z6oyzsylM8W9HOr0v7wA0Z1hpWjSudG9qXiNxLQQjVojoNYZ0tyeHK58qHgeWw9V5nPjBDI2Igam6jCvtBh9SvfY=; 24:tqGenCxTflxuUa5WENOxgRtNPDRyH6kkSlY2CouU5Xknn12SoxNTmdU0PSd1TwWhDnQvSYq6d108C4fplPQjoE+70OwtAkdR7W4L9wpH1aE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0386; 7:gA/AtPgF8g2TT9mSYxaTHsy4fPK30m3VCr7nySH3Is0NdDfCFxlOqQRzfJOEwQknf/q4xnhUyODNdctgSJrI/r5puaP5lEbU+oL8tBuK77vwhyVo5FauNO9BcCWCHNlNWB+M9aU5Q37oDmCGYRF1AsFHtoK35dSjEuV+3nXvhCu6MJaDKKhRGNwDABXl7SvYzuREMIMgdxyZfK/d0k1/c/V2qvkxtLNQv0kbhAXFRreEeppSmYrCxCvMDijDEoZ5; 20:6KOmnbJgT7oKpUadX32JTJReqbuaR9kQ+dlaEytCDQvk9GjYMo3A9vttB/bmvD7Q0Y9aJW71d9QZT6dEKXmogjiqqT4o3NSZNcc/daq7SbswPzCPDn0y9J1p6G0rHTBLv+lvyEUlDXvgB9waHesKXgQ/T5OX04AImuJ2HW1Xv1A= X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2018 20:28:12.1175 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0b231f19-3642-4541-2053-08d5ec23d177 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR04MB0386 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 216.71.153.144 Subject: [Qemu-devel] [PATCH v1 2/5] sifive_u: Fix crash when introspecting the device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, mjc@sifive.com, alistair.francis@wdc.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the new object_initialize_child() and sysbus_init_child_obj() to fix the issue. Signed-off-by: Alistair Francis Reviewed-by: Michael Clark Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Suggested-by: Thomas Huth Tested-by: Philippe Mathieu-Daud=C3=A9 --- hw/riscv/sifive_u.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c index 3a6ffeb437..59ae1ce24a 100644 --- a/hw/riscv/sifive_u.c +++ b/hw/riscv/sifive_u.c @@ -244,9 +244,9 @@ static void riscv_sifive_u_init(MachineState *machine) int i; =20 /* Initialize SoC */ - object_initialize(&s->soc, sizeof(s->soc), TYPE_RISCV_U_SOC); - object_property_add_child(OBJECT(machine), "soc", OBJECT(&s->soc), - &error_abort); + object_initialize_child(OBJECT(machine), "soc", &s->soc, + sizeof(s->soc), TYPE_RISCV_U_SOC, + &error_abort, NULL); object_property_set_bool(OBJECT(&s->soc), true, "realized", &error_abort); =20 @@ -303,16 +303,15 @@ static void riscv_sifive_u_soc_init(Object *obj) { SiFiveUSoCState *s =3D RISCV_U_SOC(obj); =20 - object_initialize(&s->cpus, sizeof(s->cpus), TYPE_RISCV_HART_ARRAY); - object_property_add_child(obj, "cpus", OBJECT(&s->cpus), - &error_abort); + object_initialize_child(obj, "cpus", &s->cpus, sizeof(s->cpus), + TYPE_RISCV_HART_ARRAY, &error_abort, NULL); object_property_set_str(OBJECT(&s->cpus), SIFIVE_U_CPU, "cpu-type", &error_abort); object_property_set_int(OBJECT(&s->cpus), smp_cpus, "num-harts", &error_abort); =20 - object_initialize(&s->gem, sizeof(s->gem), TYPE_CADENCE_GEM); - qdev_set_parent_bus(DEVICE(&s->gem), sysbus_get_default()); + sysbus_init_child_obj(obj, "gem", &s->gem, sizeof(s->gem), + TYPE_CADENCE_GEM); } =20 static void riscv_sifive_u_soc_realize(DeviceState *dev, Error **errp) --=20 2.17.1 From nobody Wed Nov 5 00:11:33 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail header.i=@wdc.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1531859443598968.9586728804113; Tue, 17 Jul 2018 13:30:43 -0700 (PDT) Received: from localhost ([::1]:33148 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffWcE-0001dK-7z for importer@patchew.org; Tue, 17 Jul 2018 16:30:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49421) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffWaH-0008VR-6g for qemu-devel@nongnu.org; Tue, 17 Jul 2018 16:28:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffWaE-0005h3-1i for qemu-devel@nongnu.org; Tue, 17 Jul 2018 16:28:33 -0400 Received: from esa3.hgst.iphmx.com ([216.71.153.141]:20646) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1ffWaD-0005gc-KD for qemu-devel@nongnu.org; Tue, 17 Jul 2018 16:28:29 -0400 Received: from mail-cys01nam02lp0052.outbound.protection.outlook.com (HELO NAM02-CY1-obe.outbound.protection.outlook.com) ([207.46.163.52]) by ob1.hgst.iphmx.com with ESMTP; 18 Jul 2018 04:28:29 +0800 Received: from risc6-mainframe.int.fusionio.com (199.255.44.250) by BN6PR04MB0389.namprd04.prod.outlook.com (2603:10b6:404:91::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.952.17; Tue, 17 Jul 2018 20:28:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1531859310; x=1563395310; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=Z/sogBiN0ay1POHuPGblX40zyyO2mF0oW+LCGZoiE+I=; b=mmTdXXfRBzD7VZduu8b6hXuFJiyl4MRQwkYx58+dE3WYZ31b+sw3bL3D V1qEcebKqNOrC9TqtW44MvKRGvlixQ8QFnHDvywqPahN0YJOnAgocopXm EKvEQ8VHiyKtF1W7P66YvA4fVTqNqZRos22zRO2PaqfTlRY2vozyX2MT5 NvYbmwtk9o8Ns4BJRMDxpjuovR6bBvmFznlizTxGxxdCkhtnGy6yXizIN brBzYUefQx4qK4+0/0mfmiLB0vALp94jRERCIESXlBqhZFm54zmbg8UZn HJuASaz53BxcMI0LEBQK69RbL+abdfc38CuZ5NzNtxLz1j1NtEaWsdGy4 A==; X-IronPort-AV: E=Sophos;i="5.51,366,1526313600"; d="scan'208";a="87467638" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qQ7P+oU+jXRgyif9+EFsk5+IU5pxNWhdwoP3eCbwOTw=; b=QcCk+guxfRy54ydma7QUfUB80OZuXkyTmHovNty6xBuqaV4cPMJcWSYB5GSg6qgqaeQh71Qy2RbwItjz+MC7hHuHnx8Dm0/2611q6Soj2czMa0IBFPTlUUkKg9qoWxGBJMzOB3nrVhfMZnWLRreTXdWDmH378OcswQBWfU6y8lU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alistair.Francis@wdc.com; From: Alistair Francis To: qemu-devel@nongnu.org Date: Tue, 17 Jul 2018 13:28:15 -0700 Message-Id: <8a6a1a1a1056023dc79179399c11e059fbdcde1a.1531859179.git.alistair.francis@wdc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [199.255.44.250] X-ClientProxiedBy: BYAPR04CA0023.namprd04.prod.outlook.com (2603:10b6:a03:40::36) To BN6PR04MB0389.namprd04.prod.outlook.com (2603:10b6:404:91::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7f5591b2-d749-494b-45b2-08d5ec23d933 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(48565401081)(2017052603328)(7153060)(7193020); SRVR:BN6PR04MB0389; X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0389; 3:cO+TAApIrbaCShjBdwCXGzNQ3ANvatawi1z6nlE41c9vfLAxNurjbhYT/45dl5LLaHQM83pOxO2mhIT5cWXseQk8+vehCUkGrSB+XSaZ/j5lpJSyaYCXjhthgw+K4Tkr58luIrbW1/31kPBYgiKYC4bqc3cEnX3gdZzNlw8TU3irt1MkmplFOXKwNfSXUHbPT6pphHafi8wdBVrIHGaeq7I5zKM6T8aYkTaUe/5GQrI0aPeBgMneKDLeeTntVDhZ; 25:dO2i5aHP5URVNQ0eH4GAWIPsFrTqPnnznLcb1BlUYwpRkDAOpWYRK4/ZgLzNX940Sg3vOU3dKk/aH9kGobKHuknca9+3wcKtumT7/Y8ZbqoKbS9/zB5OV7AbTnB7l3pFzEUJ1mUKu3iklg3F5z8OR7xTmzOE1oHboGaAmbKC/JSWRp3qCIxgTa+UXKOdB3itM/IxniIQbrwHyso12ofWuhyzF2qrZxvLdejSRjSt/nrVIb+A8WP2ZbRzvUL1KQ+29zUj6V3Zrjk6SIkzv3GUR4hdWajXf1aT9On6Zm8q4+X2L9IPS3cQQ02goDgCy6v3w/KxYXusE5k9XJzl94al8w==; 31:cYOqTYhPndwxh4FBje/RBWQMDEDuKXgYdRi7S5RqLaWMaem6Ia1qifQhW/CpADBQgjUaCn3tLzN+kVK7cL+iS3Jv2mWlALN7zSfmoOzai3u/LaIH/WJOGM0S2qS7FyAhXrG6Y1xxz7bojz1Dvv5+1e8N//wpRO7GPFfeRQkCJt6aUVDCBz+YRTmCO5hyUAPVjs2nUNoTUzN0t42q5EqEIuS+1s70hz9UZteCAQki9p4= X-MS-TrafficTypeDiagnostic: BN6PR04MB0389: WDCIPOUTBOUND: EOP-TRUE X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0389; 20:jMNbNWtVU3Krfd5okYT03uwcMtJeME7wUWBpqBX9x+Xflf7Yg0zqr/c1DDtaiDrjsqQo7ROQsqrVtp2Vqdy0vVD0NibI5XG675jQyyGo63bbwG02qWQn6boZ2UmKlwaYZt+ulTWqx6GcbAK2D0CYyI6rB1Agmt3b716cCAa/LuTpdD7v3rFnSml0HiGwjP4ir+NZW/d8M5YW4r2W0NGxWaM8iGBXVaAcZupIw3vCUbT+Uq7vmh9fWoJcSLTzQ3bGFPXZTslqFuaSY/Ef7Lw9gGvKHhhqsp6VVSzhMt7mI4x5JywD/dCdOce5pUebPaSDG56KDC7JxSVcP0/AdzofFv10Whf6Q2IfwMA/H1pxxBA9/QB8zsK9pvy9pa7NLVTCPU6iolTjk6Mr6v7bX47/1KjGh59OHGAxapn9GHbkKlokaXzYqTVNv926/I9x6NGaI+STi087FMCQejBTMfoz8f5aJMbrAYBtmIu97hLmiQP5SiiugZHTQzA6HuHnQmcB; 4:jLZt/WQocvCrjEhuKne7sLJZr2/YznLz4+yxJlaeYAOeYCW4topcJ4RLBzz3cq04+HmFW+SlRMmJcq/N4A77p6s2PPBk7o+R2JasDJoYv+WERdS7gP2bGYt6x47SH1SSh9J8XMl0XVnqw5VkTMZL27niTRXDeOxvE3sFMZTc0VnuNPf/1zj1UqRIN9ed6otJ+Aje5PeA9UBqEhsn5YTld8Uy/JNpu0BM01LpQvx2nGV1UrSszYd0YpPaMMlmubltCBykwwszj86AkhdpEhcIiA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:BN6PR04MB0389; BCL:0; PCL:0; RULEID:; SRVR:BN6PR04MB0389; X-Forefront-PRVS: 073631BD3D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(346002)(376002)(136003)(366004)(396003)(39860400002)(199004)(189003)(106356001)(8936002)(6916009)(47776003)(66066001)(16586007)(105586002)(305945005)(2351001)(316002)(97736004)(7736002)(53936002)(86362001)(6666003)(2906002)(6116002)(3846002)(25786009)(36756003)(72206003)(4326008)(478600001)(44832011)(486006)(2616005)(68736007)(118296001)(956004)(11346002)(52116002)(51416003)(16526019)(26005)(476003)(76176011)(6512007)(186003)(386003)(6506007)(81166006)(8676002)(446003)(81156014)(2361001)(5660300001)(50226002)(6486002)(48376002)(50466002); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR04MB0389; H:risc6-mainframe.int.fusionio.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR04MB0389; 23:cnSLkBET/Kcmum9o+StOiN7gYt3HwfVKB0vQ/+z8r?= =?us-ascii?Q?9+J+2VP/3CfoHNjC/6Z9BBCmuwrwk3hRG0t0+7e3GZgUECWpEtmo5/NsIb88?= =?us-ascii?Q?s+PdmMzQqGuCJrnUCcfAvS7qK+xemxu0+/MTdY99lj4JkPtaoRyAtojoHsHF?= =?us-ascii?Q?ljUt3ABmgINt51zHOecpXeyOeA51s2tClJh8ArSQ8z+HyZgdpCwkzyKcnh4L?= =?us-ascii?Q?54Np6GfZqdXK0Wv/1pBQxVwtbI/+3efoOgUJPSlMNSzVwspvoWfxYRMORZS3?= =?us-ascii?Q?KUHP6BA3Lzeq7MSg8E3iOKOO7dBdwnjfCpLRKoj26xtRS61VTDQvOYrVzoEl?= =?us-ascii?Q?2cwrLZrXs99anNpbajWqdgq9d1OT189ltj56LxGt/9pvVedNSRVqnQqVIQ6f?= =?us-ascii?Q?NJCuzsdBS/tsdKIqZ3I5jiWTZL90hPRJFi6TQpZZsGmAeNkualA+msV932mr?= =?us-ascii?Q?3QZuw9IcK69NQCxHPPbpBeAkJtsB7MvqgUQJRFuGS3sNsFpVvLP4N0HzZoso?= =?us-ascii?Q?7ONVQ0w6EPPJNltYR0bEB9yqTl9WulujDsHQrL75N6xgZZRq9RjhDu+5cS+B?= =?us-ascii?Q?Mv4CPFtUqilSmvDTBdB75e+3+oF2Amleo9VTChz/flC+J3VuK4Hw//O5nCrs?= =?us-ascii?Q?bhInq6xv3PZ4go/sjj67xLghYt69EXksch0iv47fFSXP3A0Zcu07NheYSTXX?= =?us-ascii?Q?2iAnrQsGH+6hqy3/TjA2SjGw/gbKTX1Q4Qq3HMo0TCYJS9XRvdd+YeswcfY6?= =?us-ascii?Q?EUXqcx+dFgHDHhtpF+LrCTCKvueHBBMOKjlathTqFI4bHvQondenTlWiLXzY?= =?us-ascii?Q?PPXbRzHZVx983F38SoOSUEIljkMAMyqq6LZmPnniNh1+Kk+LhvR/+3Lhu3zI?= =?us-ascii?Q?KHcoogOY/TsBVqjf7odzT6vOW8OTYC3FuY9klT13mTSe3OlwwmXnWmC3NKfN?= =?us-ascii?Q?0VMrO9nYnHgNBHFG0oMsSpEThtpMPSWzuZlpvSfpbvhSAn8ijvWobWypoUzR?= =?us-ascii?Q?46TBbZlZV9iAMQiIH2Xy1rhE3uj69onRLqoC0sH6zv8llO1HglxV0NnuXZ91?= =?us-ascii?Q?63sDRCl7NkZk9Pl5/aiRU/LVVv7u7s9Ujrj76jG6lcqHlhR3LDYeI0j88xvW?= =?us-ascii?Q?Yg62jjATdG8nXT4cw+4MKtIuSLryszQUMhiZ0aVcI8O5eAHAecPIKxnpsu0O?= =?us-ascii?Q?dQj5SLYOMtp+EPeASvKBinVJBOj4C3TDURyHD7UFwBpj1nsfm1wq0FuVSAxm?= =?us-ascii?Q?Xhf9VEgsbvqYWoHl75LDPtYVNg2eIjg03AmPHnd?= X-Microsoft-Antispam-Message-Info: TIOKUQXtDX3GO3/F28pVsJklzlZTj6YkIB2FhsTaX+M4ui1r13q4D/d5wY5KM2y8yFMBWfxyQzdR46rzzIKVQBhDFpLHNBn+3Xd2VGvaofpRUBnIGS5eWUJr+X1KFIUq+rJWxx15bSi8ySJt4MyP43xrdIVFFdtwPRy5jLl7f4ccuyZ9dHF4fUGO47L8OudnV/yHB9JyJ7ELkmtlcqhuQwQhwQeOrnQ8rfZa5vMdFHI14KdXwO/lpTANOlIAd0XZaEqQqgdQj6wc+fr8MHIUVf1e16DN7OmltgsOCu6WSagt5YCN5sgagtIyxIUgrJqhVADD5mrisW0g+GFq6WVe0hSKZLsL40VyQbcFohtXmLw= X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0389; 6:Vrgc+71+STMpEKEV7icDO7Nh8ABNTysJlpdCHz2bROxpsahylizkhbYP1+5bYi+I/mW7dgAkmR03B2b/lmDv3bDEv4Iig/5G/JEHb6c3GhBD3r8Ya3Betw7xLAQzl6hqss0jgDGxw1xrqq4M05ikSfc6AymzjZ2B3dpH+R4pmHjf45ibZggmFAGJlcUxmvScsNvZq7SramaZLCVPLDMK4yQMERn8TCfnVzSHL2UVOxn3OXytEjK1UkDglHeVJ+xYPxC3S5AG1+9wK7aKMHGntLR0Huz7JTAL+XucU7NNKX5FsQAW2JQQyoVzAFCtM0Xp72/6BBOKJvdOwKaMhRF9a2hSYuhP235AFIbzZnYpjBYa8jgu4torLFtV91OCW8MiCusZiYxTItuvjFHTYRfL3wpqcm3IKWMB0WVJXBXY3PuQ8BtXXQ7VnLG/U4ES4U/r/nXJhtDaZzq2EqreUm9Ndg==; 5:ngpej60sNfJWtvyV0HcxQCzwoT6c7bLVhCE7qmIsLZ7Upb0xEmEgfvavxKP7Ze+GpkIT/3uSTzIj8V+sNbu+E7dGL4fuBul13TVCUcqoS33Kk9/FtEN3UOt8iT0L1I1i69x41zJxhs//tnXgvvCSmcWVmljb7+Pgb0dHdmNsdwg=; 24:is5urysm33xPdJtFWDwzRur2ZONnKFTPkLVc1TXnht/POJkiAZPw71xqrx4Wg60Bu+NekVebHkTCygOMX27DPr/V+t4C4bX3W+uk3DBO55I= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0389; 7:ruGHscmKevYCOn2f8RaRZkx0LJU3cpYPgKLEBFuSprEupIC9ZohdrIlWAFBMiXzfHug+kaT2heDAnofhegzlF804hUmQuuQQ3blr/7/LhiFttiAozo9m9C/N1BDstqvHIvG2O9W967jqgRmS2HB2cwgaVOPNEyA9syzDMV83aCH7masxryFrihBH4b04FVYC0+Qar5rPyny5iB2AceThoE11CgKK4zjLlxZ78lK4ScQTBC4jHJ+DZ54DqUTa1ZkT; 20:tlV7T2pHTKbD/osWYnum+Tpjn5TIeKWJ7a4Lo3lehwISNhHjxVdQpO9lm7iY9Vw+PalznSlFYMyzGYVP3ldFFN1txdub5K3OnVl0bZE1P1yA7bcKSL/doXnQTZclJJpvF0yg2CWBknX/SJ1sR9oFpn0Nlstgr5Ur8Am/0CcB/GA= X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2018 20:28:25.0936 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7f5591b2-d749-494b-45b2-08d5ec23d933 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR04MB0389 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 216.71.153.141 Subject: [Qemu-devel] [PATCH v1 3/5] virt: Fix crash when introspecting the device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, mjc@sifive.com, alistair.francis@wdc.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the new object_initialize_child() and sysbus_init_child_obj() to fix the issue. Signed-off-by: Alistair Francis Reviewed-by: Michael Clark Reviewed-by: Thomas Huth --- hw/riscv/virt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index aeada2498d..248bbdffd3 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -274,9 +274,8 @@ static void riscv_virt_board_init(MachineState *machine) void *fdt; =20 /* Initialize SOC */ - object_initialize(&s->soc, sizeof(s->soc), TYPE_RISCV_HART_ARRAY); - object_property_add_child(OBJECT(machine), "soc", OBJECT(&s->soc), - &error_abort); + object_initialize_child(OBJECT(machine), "soc", &s->soc, sizeof(s->soc= ), + TYPE_RISCV_HART_ARRAY, &error_abort, NULL); object_property_set_str(OBJECT(&s->soc), VIRT_CPU, "cpu-type", &error_abort); object_property_set_int(OBJECT(&s->soc), smp_cpus, "num-harts", --=20 2.17.1 From nobody Wed Nov 5 00:11:33 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail header.i=@wdc.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1531859461739209.1170979759347; Tue, 17 Jul 2018 13:31:01 -0700 (PDT) Received: from localhost ([::1]:33152 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffWcV-0001pv-6j for importer@patchew.org; Tue, 17 Jul 2018 16:30:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffWaV-0000EX-W6 for qemu-devel@nongnu.org; Tue, 17 Jul 2018 16:28:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffWaQ-0005l3-37 for qemu-devel@nongnu.org; Tue, 17 Jul 2018 16:28:46 -0400 Received: from esa1.hgst.iphmx.com ([68.232.141.245]:51356) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1ffWaP-0005kc-Lf for qemu-devel@nongnu.org; Tue, 17 Jul 2018 16:28:42 -0400 Received: from mail-by2nam03lp0049.outbound.protection.outlook.com (HELO NAM03-BY2-obe.outbound.protection.outlook.com) ([216.32.180.49]) by ob1.hgst.iphmx.com with ESMTP; 18 Jul 2018 04:28:39 +0800 Received: from risc6-mainframe.int.fusionio.com (199.255.44.250) by MWHPR04MB0401.namprd04.prod.outlook.com (2603:10b6:300:70::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.952.18; Tue, 17 Jul 2018 20:28:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1531859321; x=1563395321; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=OW7GsMaJB6yFpZ1sldwnHhyBeLJlBxlGvLILmf9CnD8=; b=iX3ba++Slg9ujPoEJ/TDlKyXI/lZkUUIY0/D96mwijFW0IUA2rmrPgEK 8uyOpb0rMeiyhfWldxxWQ+7UCtN6EjWGTW8THQueEI0F7OjyDzEi4zesV xdRQmYRXUWcSxV4Jgo6WXDTzT7qFo9IAEsLv3hwb1SktIhECkQ/MqnUyi qjwJjVusODoVTmO40GispklZipZNMi4Whvp+msPIAJe4oi3cT/u00KIn7 cm0UAsHGlpSXdY9HhDz30VooStdf6Wk5EDrJmqCi4i8RvZjZHPR2jFgYW NotGQx9+fxVx3zQPiWDtUNVuDIf63XSSK/HulCegPZcwbANj3MbApJ3p6 A==; X-IronPort-AV: E=Sophos;i="5.51,366,1526313600"; d="scan'208";a="187792148" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w3Jj27jptKthdvXHGV3XdDgiThigVPVpO7ZzCgmWsG8=; b=XVW/qQMVFMOENUMJpgYzO0K/13l+BXS6f5dAaqywhE2vDTlyc2GhErH1dmN4gYVgv5o2goh90P79KB4bQa+P+4BRnSG32M85KMuf6fT8mTOsgqMp5D3hz5mTkUFSg9WHcA0OaXM0+67c4j9FIBJPBaqXe4UhUql4b1D88pDNd0I= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alistair.Francis@wdc.com; From: Alistair Francis To: qemu-devel@nongnu.org Date: Tue, 17 Jul 2018 13:28:28 -0700 Message-Id: <6c60f18b1b26088dbbb54538caeaa0121e94a52d.1531859179.git.alistair.francis@wdc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [199.255.44.250] X-ClientProxiedBy: BYAPR04CA0027.namprd04.prod.outlook.com (2603:10b6:a03:40::40) To MWHPR04MB0401.namprd04.prod.outlook.com (2603:10b6:300:70::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ff0b3a86-4832-427d-128d-08d5ec23e003 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(48565401081)(2017052603328)(7153060)(7193020); SRVR:MWHPR04MB0401; X-Microsoft-Exchange-Diagnostics: 1; MWHPR04MB0401; 3:4sT6zMtssSCduH7eu9VwXYrd69BFgXYFfVu2qS6h/jAOGI3W6rO1405ZOtOES3JOdkGWEQSTrl1Yjd4YEOlkWoTa73zOugdgHQ0YABsLRBnYOoYKMevllMlS7zLaKprSDl2Se7iWP8da1mzBgvtlLDWV3QMh4Q1YQdYaYvSZL31Da7Laomni6SCozmqBHhdAnMX4U2v4mD/84eM/d7piL9x/E+tHbybIM2RV37QMUZujmUHS2dxor5J7YcRM1SUI; 25:EHJvDF7tLTqHsulYwC3geAvbSG+Q9Bj2pzbdea/mms9ujZX3q33VKiw7hDaVjIa3KXeYBWtahcCIKvOrwnYvbbDglyoPjPAT93tdqJWCewXgCw4ijT4OC5/+PXVNnE4H3FIABAFIGMC82MNMcVFfwyzaRBGn/zXUIutKSGjzdyfCDTS6Kb+U1DpkHKquqSTlK9nF8Z8wiBYT+D7eM6rh4RpuugSZygmZl2xRSsKw0Lgn8cT581L8R8FqtzMWIbZtPxcH+wP6kMpVE3ZnWcgKX3H3G2wgRI8h7DoIRNLxFX4RZimtWX661a6rXI61jAN9yJjQzpNY1wzbJzh3xP33cg==; 31:OZQGsCY1YXfyzeZWVVXsWT9HKtdbvQ7p7uw5WjYetEJdEJunMsEkxFTRWZywK8RUMw3ycdBNRj808jYDjebVgGEC5skrntaGvDv/W7V0cxMnxpgCs8/mU7pwF6qnrH2MAPDHKT8CjLUEuovoLEvESjnV/QlkT+OBi32meUVJ3og6YR39kHlYcB2lOQAItY0RVVlxzXxwjuBfUbZkteSpVjH077crwHhsDS4Y7qLtVXc= X-MS-TrafficTypeDiagnostic: MWHPR04MB0401: WDCIPOUTBOUND: EOP-TRUE X-Microsoft-Exchange-Diagnostics: 1; MWHPR04MB0401; 20:pvvHheGw3a75Kb2y/LdL53MuVBeuB15D1fHQLaMJxBhHb6OMzGpBmXj6JSJoUtZdHeGs273V3t1ub9cX+eq74S0wAvBRKDvjd7uEohxjfiz+iq696/WkjDISxYdnca1rqo/DwrowfRO4GetvQ6q6BPWI1G/Yj4zw8dOB0mN/aCgpQF/b/QSDMUUg744CfrXqEy1z/aDc6Uw2c+oyELGCfedHMxWdIcbkLqdIDCIRUklEzSMgMEY9UobF7imnhr1ghDsV8VIHc0qC6RVafyTVJrFaeH3ISlUC4pizOTQS1XSk4fuOLrzBrFvSGTkOrRgs8YbHxicgTJ4pTdmk9/gCayS34FIC7H89k04g42HHqTCv4y0nHV/Qnhd+uEVwX4ymMbMOZq5iZjBEsD6VurXOiHEfnlrVxY2mQFtPs31PAAU7yPsi/2VGinXoDmQjnDSY1TW74h+yS2DS/KKh4K76NSmKJyBji8onxJKCDsJW6uHRvYG3B0UYnNDnTxhwiF31; 4:0g8L2YDGmSYbcsWmKCVkgTKUJlIco1vUN/AzZ9cxGMUyrYpUE/pnUY1MoFLoafR+slXrdhj8G1AwSEsIAFtcVGY5iz1l3xT1A6bdHp00lx+TcKjghMIaVKa4+X+W7i2YiFRqUrujTuTyXkkB6jf9JWIoqHOEVL+6cmgR+v8NpMVqhHGt7plj5HtOWeRtf8Y5pQWROKdDm+FXSQYI2mOTLxS+HiGRbI0KiLo3qk7KQnXyVFfVCRRklwj80ZBHMKmImO6Ji0XqdTUiitAHx83N4A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(3231311)(944501410)(52105095)(10201501046)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:MWHPR04MB0401; BCL:0; PCL:0; RULEID:; SRVR:MWHPR04MB0401; X-Forefront-PRVS: 073631BD3D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(136003)(346002)(376002)(39860400002)(396003)(366004)(189003)(199004)(118296001)(47776003)(2906002)(76176011)(3846002)(53936002)(26005)(6116002)(575784001)(97736004)(86362001)(16586007)(2351001)(316002)(8676002)(72206003)(476003)(2616005)(956004)(51416003)(305945005)(48376002)(16526019)(2361001)(6666003)(6916009)(4326008)(68736007)(66066001)(478600001)(50226002)(7736002)(186003)(25786009)(6506007)(386003)(36756003)(106356001)(44832011)(446003)(52116002)(5660300001)(6486002)(8936002)(81156014)(11346002)(105586002)(50466002)(6512007)(81166006)(486006); DIR:OUT; SFP:1102; SCL:1; SRVR:MWHPR04MB0401; H:risc6-mainframe.int.fusionio.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR04MB0401; 23:7uXmB4iG0vjVqjo+hu+QCtPfCGgs8rwgrBBh7e6Y0?= =?us-ascii?Q?wfwTyVCVEsisHgpndduyq3V6Xgb+WDKLKHPg2XodHr65cSQg0OO/uphljKk1?= =?us-ascii?Q?/PHoDtX5Bn7EeyrQeO9s5EtqFc/qOmWl66fV9GdbGOZtZPyc/okHX9vyK/1n?= =?us-ascii?Q?dPSZMAl79B7/eKJb1srjxmlBCZWXU8XUK8xddwExM1ryRs+IMIDSQQYpqbB0?= =?us-ascii?Q?Vhdwyx7o1luNSujna/HFZUqUxF/rZwm77IOaNmF01fxnJmD8VEfqdJRtgub/?= =?us-ascii?Q?AAC68s30uUfzHdcpUeFiLKBUgRFixdYqB0/yloI4bfxDl6D43abv14ko/SYb?= =?us-ascii?Q?BHhdpbeppmY7c4NvKBW2ND6MY/sOPpNwZm/Zh0b8BfWziDggNFHnwywljDv1?= =?us-ascii?Q?VG3SHtgBwSaJo8uPd+cQYfe7SRfMgmGu+QW87qjaK1Qd0vwBHnyprroEud9x?= =?us-ascii?Q?jcTbdtL1l3SQsvChjbAwOXNn4vH3SG/Ftw6BtknWic1X7HSX1oGxfUTwiUx5?= =?us-ascii?Q?qxrtBGG4cOttDkd8jo6FVKRXAsa2xzn4/RjO7hGH81J1Y4XWVwYKAkyqF/hK?= =?us-ascii?Q?98IZZCZy3ajPWOLWzKinRmB0TQ25rSFebNF0DI9sVTIfrk89v8lX6Ros3d2S?= =?us-ascii?Q?E/HdcOex7u/FbBhKAjhceCtIa7aMDdZc1P0bNL80qZAiVLa1mYFMvk3q8qBe?= =?us-ascii?Q?HUpc0ei82N9lM1Q3lXvG2gjPF09yfr0t8M/gpT5gHmpM5jhO1TZ8MT+80qB4?= =?us-ascii?Q?q4H8MvlM8WTly1Jj5DM70sIG3Sl+nd0NitAsDn2oXrUAtqFadl/1KwpinWA8?= =?us-ascii?Q?XoVRizNIk+aERmmeJLD84qg4PdzFP2A6DgM/KYwfvuY5aWW6VRkTHij+K1RD?= =?us-ascii?Q?OIg85Y4PenIKsQAZkZM6VT65HHNzH6wcDjRELX1elIciSe+pTxL8frZFwk0y?= =?us-ascii?Q?vnVIVdQvnf75N4qApBUwV7Hh5yeiB59E+WBpI7gt2fxeXipXbzRKueBKJFrw?= =?us-ascii?Q?NXdHgdurIyBxwJW0uRJ0h5m003fYWlbeIpuqJC/1SzRD9z+oJJgMQ8rSBNWW?= =?us-ascii?Q?4V3UwW1eHILodsaJl4oAoOLW5LydK1/dr/BNLMdt8D/ywUsl4fhy5xm7Dbvu?= =?us-ascii?Q?FisNw803Hh/ZaGPnoHzgBiEUSk8UYBXxE4bzcGxK27nUb4tVfX14Vgv46kQ4?= =?us-ascii?Q?uBSaCJcZd+uKuhW8AfCTvWMBdTm4O+rN5/gRm8aOBYOm6nF50rNvLE0a9Jt/?= =?us-ascii?Q?ATl1i7Lp2+qOIEm19bkU/7WjtvVh6KgAHlmLB9zoyteNqqAKtT1D6oeac7FS?= =?us-ascii?B?UT09?= X-Microsoft-Antispam-Message-Info: GkzIpYqxXxalNb7cTH/blaMmOA0oUbbfoKfiwpxpFOvMAHv23XaTEdl9NUxz4+wYfdQdXVpd+P8X7GkNwWJypHbw58C8zGxXII1hLt6GN54h3Zsu4U7TOMUg65TC4HImVhSYTVQBsmEhwKdl7jG1bEywjCv8MQGYwt+1pOH8u7Fp2dpgnMneugSuFMgQTy/fIAFy8EV97zMA4yauQtrX1Q5sXt95uzOp7IYMBlrptw+qplw2PVsyIhkd15jEAMY+KIkXVuwlx4odye9s3f78ZcP7MA9X2sCS0mz0UWnt5DIuq/ttkGRIcM1bDSlT1RsL+SFgvS5Us60P22HPNKyJG71cnREw5ZU7DkzOK8Tj1ko= X-Microsoft-Exchange-Diagnostics: 1; MWHPR04MB0401; 6:47C5jYFam7YkPxsmAxYHexifFWZI7IHM62bRRvRPJBMkMbrm1usocHI2Ml3m1pPqnJep2aFTXtcF06HNmOdVYpkxv71T0kRHkSZiPiDefby+CUHRpI3ICT2qti28YEqxf7YqI1qfjeirZ8Guyx9xbQvUaNeorpmNUDT/PPTKGQaGXrhxnoMYED7SSkaAtZxr1uuWCapV/QDL5Xn5LdaP6FgsEu3lxHOfHxrPFCMe1STw024VjwLQpkqDNg158I5f5eFhI5SlIEZOBIwjXhB27t2ObiRsG4faUoXEylPCnjtfG4GAfoMz4T32n5ewElOVgeNi/EoiAr7dhtPjXGkc7iGyoZZKflcbnORtGqPYgHXZEyUMRtzZjztC1m1fJmfW1VDQHWz28Y0pRpDdfE5HcAheoXY57663ljcvuJdx0INQV+VeVBiTh12Y3Tu/d/5a2GO4SChNNADICdRut2iB0w==; 5:hpal2q4XC8mbwcGRxyizdxABd1CThUIziUdYIesOPoBuGc2g9UcDUHdZbxfWBphuS5t0amRPq1LLvBR88bVwvk5kTX/UzhrYJDnfEtCtE8p7FetA4JIeK7Mu6VCmimIbVwwp1/gXGqXWeLTBaFBTMh6ztDN4nvV/9qd9HU9JSZE=; 24:V1Bv7d+48w3myeMHxuWWiXFHzuBiiS6kP6l06pBPWX4o0w+U2vjW+UXTSNsDwZ2EoHMv7SigsuwVLuwLelkMmTM+StGp4uNXslL5E2zy7mw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; MWHPR04MB0401; 7:m3nnGXcExBJTgALfqds73isLYOPgGS2gx1kRAlAOQ4MNFnXBMMejbc5vlWBtjP+L9eSCCD4g8HKMR5viGsA2PY/EZmS/McShcR4hO/Qz6NXu9+F+BYszjaVtDlHzwWLDh+1uR0Jp/WOjOwlS9CQjGdJrDD5PJkzuQyrZHyQOK6wqNp12WHXtqpcNU1BSghFV+KzN73noDfmqU35WrvJSylL6Zj5oOilZHqKiC3h75Wby16m35mcaGc7r5+6Ed9Ze; 20:LCfwItv5e/Ik20ZTJH+3kogHW1p438TuhDbCiejk3lXpUTCohnzj5JgQw98zMXsgRz44rPsDoBb405JrF7FNiiF9hyGWxfxP3V9k8GCkziaZSIUaNcENNAvdpqiIlMklipLBv41VRAJjNpuCtDaVrM06Um1E5/SqeAtEwtY51MI= X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2018 20:28:36.7339 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ff0b3a86-4832-427d-128d-08d5ec23e003 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR04MB0401 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 68.232.141.245 Subject: [Qemu-devel] [PATCH v1 4/5] riscv_hart: Fix crash when introspecting the device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, mjc@sifive.com, alistair.francis@wdc.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the new object_initialize_child() and sysbus_init_child_obj() to fix the issue. Signed-off-by: Alistair Francis Reviewed-by: Michael Clark Reviewed-by: Thomas Huth --- hw/riscv/riscv_hart.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/riscv/riscv_hart.c b/hw/riscv/riscv_hart.c index 75ba7ed579..e34a26a0ef 100644 --- a/hw/riscv/riscv_hart.c +++ b/hw/riscv/riscv_hart.c @@ -45,11 +45,10 @@ static void riscv_harts_realize(DeviceState *dev, Error= **errp) s->harts =3D g_new0(RISCVCPU, s->num_harts); =20 for (n =3D 0; n < s->num_harts; n++) { - - object_initialize(&s->harts[n], sizeof(RISCVCPU), s->cpu_type); + object_initialize_child(OBJECT(s), "harts[*]", &s->harts[n], + sizeof(RISCVCPU), s->cpu_type, + &error_abort, NULL); s->harts[n].env.mhartid =3D n; - object_property_add_child(OBJECT(s), "harts[*]", OBJECT(&s->harts[= n]), - &error_abort); qemu_register_reset(riscv_harts_cpu_reset, &s->harts[n]); object_property_set_bool(OBJECT(&s->harts[n]), true, "realized", &err); --=20 2.17.1 From nobody Wed Nov 5 00:11:33 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail header.i=@wdc.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1531859712065484.1182063381558; Tue, 17 Jul 2018 13:35:12 -0700 (PDT) Received: from localhost ([::1]:33177 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffWgg-0004hx-So for importer@patchew.org; Tue, 17 Jul 2018 16:35:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffWac-0000LB-Ve for qemu-devel@nongnu.org; Tue, 17 Jul 2018 16:28:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffWaZ-0005pP-OH for qemu-devel@nongnu.org; Tue, 17 Jul 2018 16:28:55 -0400 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:52367) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1ffWaZ-0005on-B9 for qemu-devel@nongnu.org; Tue, 17 Jul 2018 16:28:51 -0400 Received: from mail-bn3nam04lp0118.outbound.protection.outlook.com (HELO NAM04-BN3-obe.outbound.protection.outlook.com) ([216.32.180.118]) by ob1.hgst.iphmx.com with ESMTP; 18 Jul 2018 04:28:50 +0800 Received: from risc6-mainframe.int.fusionio.com (199.255.44.250) by CY4PR04MB0391.namprd04.prod.outlook.com (2603:10b6:903:b1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.16; Tue, 17 Jul 2018 20:28:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1531859332; x=1563395332; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=W9bRzEGMy+Jky9nnCS0ilVuC88ZyPsCNeeD+GeO4ygA=; b=BdEch6ekDVSxV3Tvcu788H4oG9dyPlLbaa26Q04oT3Hdyt2jO0JIm1AS RScDImqvFhhq+s51MKM6jwz8EUA+8iClTmoA8Tr/3dLjH0Y9pe2NBivv2 X29A6fqyKG9H5CbzSfgbXzodqyaL6CN+er3kNPJ7Isv95uxLKoZw8sbm8 WD8ZStBu+Un5jFsTlomtkcRiAFfMJRAL0buBqIPPkM9i1+gEn9XLw8iPp taMwKpgGAPV9tJJQLtnwlNQJkwY+OacE2HQZO6UjxJGYTmMUfiSLsdoS7 a2je6fz4i9IR1zDnWaum/N2zy3SjgytZeXr3KPudvThOrDo/OIM7e24FZ w==; X-IronPort-AV: E=Sophos;i="5.51,366,1526313600"; d="scan'208";a="85582321" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O04ttyAvflY7xNRuN1XMygf9ikVkKzXYM6fRCF9TB1A=; b=LhZBi3ebDy20xsy64ZR3y4d9n2kkHS6sPvmrpus2xE1RlrwaKSokqtTjW4LHJQeeVq9znU2ZreBN0t8G9uFymHBh0bV93I9S1SC/wEjaopXVogx6h1IncuIZmKOw5E6AAF8sft8qwJYzj0xvbgGMjpoVdhp32qXcVCBVXR7BDTM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alistair.Francis@wdc.com; From: Alistair Francis To: qemu-devel@nongnu.org Date: Tue, 17 Jul 2018 13:28:39 -0700 Message-Id: <9495ff8a469ffcdeeaeaf3f0b59f999d20df8285.1531859179.git.alistair.francis@wdc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [199.255.44.250] X-ClientProxiedBy: BYAPR04CA0035.namprd04.prod.outlook.com (2603:10b6:a03:40::48) To CY4PR04MB0391.namprd04.prod.outlook.com (2603:10b6:903:b1::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 322ad8a2-9700-4625-2cbe-08d5ec23e6a2 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(48565401081)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:CY4PR04MB0391; X-Microsoft-Exchange-Diagnostics: 1; CY4PR04MB0391; 3:eYVPsSMXrlFXTqnVTpogLH09y8Jc8/JZ9jMUzVA4Fex14Kalrg9FXw98cuTM/p3V0o+YKBnGNVLH4QoOUT5tIPN/TaSWCFl4lYq4sp4VS/p9J/sV8cTJQTwSBVs6zeOD8F7aPQiNnMOEB3STtsKgiNods3Dj41LPN7wuIXeuiG8QkoLk2TccT8Xc7rHs/dxcQ8TtOvhbboRupLJuIAAe20oOdSORITubNnT0yJnFnIRpnlzykXGn/88eFAdjmlIR; 25:0dHHkSVgI8G+N3skXYOedCT4Lw3fEddvGeSW0+gRqpAILpEEtUiVdayqRnQ1b00B7hirNESFMcAt+uu7K0BF+2rv8wdoyXxIm8i9gui+es24nRqQcjn4zuH7jU4lcwInq+v6IYAw1iKucLgMUseGKl7OF9aAr9wM4RN5ImKhHaXOSXtOl6Xdpg+I+S1FEO2BvFbwnxFioQEFa5dEwyllfT6P21o2lOTBuIgpjn9ng1Ir67A/oFyc7jF7iwmZzUydcR6x2LCNelgmQCoHa8EaETkPRZvqbcHkSedYuKMKEkWFVzEh6+B236Vbgv2JqdknynMFyIjCUKX/tCt+9lBwXA==; 31:s4Yn3Bve8ymZraX+zlDv4ltQ4gGWMswGBfIKQByH5Xo8fB/ZheQKb1yCXLocos2SV2Wq0LImH0MlMtdBdMt40K8AnwnOZKPHTfSvyEmftmd9O2ri+b+2AYcDFkb3ygIIkcWoPcZCit4EyJsNkbofqH9JwTTmuy6ACs7669oPcg+pVs2Bay01uzX9519lkB+3BdrR19hJpQvexsy6y9J7+upnqoAbH/ujehNpimjY93s= X-MS-TrafficTypeDiagnostic: CY4PR04MB0391: WDCIPOUTBOUND: EOP-TRUE X-Microsoft-Exchange-Diagnostics: 1; CY4PR04MB0391; 20:Wq3UwePe6ndBO+QlCi6HVvkyo1tyU/wKuzCZ+Dbg6r3nQI92L+zXhdnts7TJ36dSxqIuBerTD4WkgQbDLWK1M6+iHaHfsarqiC6DkbRilFrTWjohmxIGTjqKJiPb9JroGAFaf5qgY2qiY4/HUi3I/3/yFei5ChaQORkPBBp4rzQsQWJg0DmqLTgpMk1sy4uu+HMCU2RUbcNbRW9+WuVQJ6DUk3OEkcrz+APqXNd9uFYH2BjAAeKmHaKjguGSMb+8D3q9Z9SsFYGgVO/pC/D6JkX5tsoaExug9GYK2HV73pvhWvL1DYYs/W4UsSrcC8+9naZ4Wygct2dmVN3hFXM/UF4xuFXkEwKFB/nnoUaKcam7CjTA1Ly8wBfN5IyOeqkKhl8Lw7IWRRvbZU7Pr0sij92sUK67CYUmxE4wvcdl8bbMTRLTwVknwFxDI3NH5Jb2k0M1l1d/6NIkN9/XP3AtKX7z4mSMCvecVN58935JUKLczjzYL55YtHputzrhFGy5; 4:JBMH4Nc2Gmdt3QxhEMSDkmiML8ZcLVEL1v6Xlbi7862iWhNmGpvqDHvhVhxWx9WoUyyDxD5G6R7I0dU1bPkP5I4qfegicijmttypynPESYlQZLp9OPY1xox9DZ8HgIzSomK9Xh7v65wQLl/QRSOJ1jlAvbh81rKmRqSvdM9IwNEmoHwsPB/DiGp1DDtclLNYEmWUd4oPQIWF3OLSGCilE1MSuL+9/Dk/2CV3aU+o3ddQTIRiRQC4KN1KhYXkzGrzNx7p6erDVDLQoaHRrJ2C0w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(3231311)(944501410)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:CY4PR04MB0391; BCL:0; PCL:0; RULEID:; SRVR:CY4PR04MB0391; X-Forefront-PRVS: 073631BD3D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(346002)(136003)(396003)(376002)(366004)(39860400002)(189003)(199004)(16586007)(478600001)(316002)(2351001)(50226002)(105586002)(106356001)(36756003)(72206003)(50466002)(6666003)(5660300001)(2906002)(6916009)(68736007)(2361001)(118296001)(26005)(386003)(6506007)(48376002)(52116002)(446003)(47776003)(11346002)(51416003)(81156014)(81166006)(8676002)(3846002)(76176011)(6116002)(66066001)(44832011)(2616005)(476003)(956004)(7736002)(486006)(97736004)(8936002)(305945005)(6486002)(86362001)(6512007)(25786009)(53936002)(4326008)(16526019)(186003); DIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR04MB0391; H:risc6-mainframe.int.fusionio.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR04MB0391; 23:6z9WxjpjAcd4gH5jUTlltFJKvPZHmw4n9GdkvNowi?= =?us-ascii?Q?mKjbcD9cupQFtQYAqQNo6C9AXkiaNai1Ro5yG04VX214Pue9xiRj77nw0+9L?= =?us-ascii?Q?FFPclZ0Je4EHgWYuP5ckgyc5QbNsN5C6qmAJsKMLhk8QNx7jGDo8mziMmQaD?= =?us-ascii?Q?YK6mE0jnUrzimf2exTWCxwqc7pOWiXnp/PLmv0v3sMvvLx3tnvuGZL5Ntfco?= =?us-ascii?Q?19KzFJ2ss2ceUCoceDyMjzdMvQe73Cac/fqz3a1qlfpefDFyRqmtMBZduQa4?= =?us-ascii?Q?vh6swfgkGZ5J8v/p3rOk2LHqdPumQSbnQy1WOIk26smRC9SxLYpzY9oUni2C?= =?us-ascii?Q?IlKWURCGk8YPrxQLCq+gc384Fwa71+Ch9tZ4XAhBsmReqBvkJPu25joEF9jT?= =?us-ascii?Q?9aFukdTl25Z8Op2y9g8N0zRxs9irB1yNmIa8l13IU86T3wlO6K/8h1vKsYwG?= =?us-ascii?Q?kkZwUY7pq/wxHSeaZUxEVgBCSHdf1KDqklO7qO+A5nWOUZZbvxgAzV5wkhEa?= =?us-ascii?Q?42XbtRS7d6XHBgt70vKEsS8E1rdqQzRZ75TpBcOOgx1o2FvlC77xO51dLGEu?= =?us-ascii?Q?p0YqZ0Q3FqWQEwrwtfxQhtXBvngrdmjoAODiNEaqDR16mKyhJ4uXkDWbKYLq?= =?us-ascii?Q?/djt9kXTIFyoLvuDLHw3ocQKHVHd3DemZyUT9qZdwLIQ+gRRFyD7sCGkvY16?= =?us-ascii?Q?EE6wMaoA4PBoLNDnxi4O5R5h9nafl8jwTRbfl+NqpfFKh6bkOu1fHUTwpjHr?= =?us-ascii?Q?SCLZg0JD0cCEcVyxcte2BVbPkm1A+y6hU5avy1SB+EB1tzwmIH4g+S8G0iBO?= =?us-ascii?Q?nzgyDp6jYD7/Q+qRGHCkfakN1+kZ2dBXr1EbOts0F6iaRsjrHGHYh6s3Z/t9?= =?us-ascii?Q?MDrNbFbK0FYJIJyLzKNMjxMuPE3sD8WVVKNUVKNxqirCPEktKP8wL+eFGYXU?= =?us-ascii?Q?f45TINNPe2wmQf1NnI7FKyImbeQEq8UwvQwK4YImvJsLVBgOZ7fJuOMpVa8V?= =?us-ascii?Q?jsH5wzQ8PBPwwhbevZzIWU8X/fmzAugtobq9MAgQVJtS4cbbRo4n5ghTCpqm?= =?us-ascii?Q?STlVmgC6EEE70HCNRVfcHzm3BDnD08TP7ZPuaPzBkqJAZ+2AsDIo4oXYxzp7?= =?us-ascii?Q?vUGhMSKxO0VxMD2yqsRYVtlQmjHD2fj4NJFJPBBxKklZpWj/4mbbjADHrz3U?= =?us-ascii?Q?ehuMIoGPXe38ntw3aHrPx19D5mtuMo1ZTbQ5btqY7A7ELPXkUcJdnOXHsL+s?= =?us-ascii?Q?czxKaLfMzfxLMYXBTIr/XmvEMwdv3k1uiV5T5hy?= X-Microsoft-Antispam-Message-Info: MDv9gemHD9y3WrJ9ev8GPZciS46DUPyf3Ua2haZ0g78+/MTz+k+3Q2x97QI6cWsUhFcs7mDpZJRKd2Q/l9jW5m0oJ1/olrRBnYxPOt+5gLxvyfZqWHCtafPUcVajjEO08lh/DmZHsoVj46dXCtBaRJb3bymuLP6/0Vxdlh+YnGUyW0ov5EWQn/XB4rQzzhMFxtDZHqFt6S4jceWlgPSRqSjZBagbF4EBu6LczEhovz7xD/mEYvSJVjdoB3ZA3CYyNQpt3J+dnSEamJ8zGx1azY4naU37w30RAeDBLOP2tPt8Qi28NTlKdikA4lgKTdTcdreDphxp7uRdFbRl9v3QtazoXHbW2aJxY72UWh0lOfY= X-Microsoft-Exchange-Diagnostics: 1; CY4PR04MB0391; 6:zlZsnwiminjvRssod/mmo9TLMfcmvXhx7j5BxZJYFAZXqStTRgZ1CZAIWtEYmrosoLNx2jbDyqcUp1RG3jWh62Hsr+z5lOheMUfFn4kk10JsIHg3VboFPRMT8uIQKJKyF7WcHIwdAiIvjk5uoqxuabd3CKqN+UoxEHJpJkFRrUGobVKq0i2wzco6lLVNZUVA0Y7MkCFXygcADQdl3Yf8PSWJJ9B0sqMEazmmVAx1qG+duaMDWji7hltcuqiQLDqkB22V0odZXvSidREXsyUXnH3iVRrjUvggiD8TRlPkSMSblSTBA/ijWKYmIHqmRDzTwwyfokoxJ/mYr3jw+lRBegUbd/Wh5B/qBdzvwbzd7NE2mdQ+MFkD4clcVQ6rNwEkrI03CnIxHf8H77PS62UGOlGQosed7pSThUS2DJfgMrCHxT4oO5dOr4GgiSwyCyMV6yGZhSmR8bniP9zH0bfb8g==; 5:HYr0dkqe8ALySDgJhB8sWwNEO2fd+dXHxg/rkpbfYX4Tiq0BY0Dw1xgawjiDvvKn1MegCZ+ME95KpS+T8rAyBCPcWhkxMf+s7Xvwrm55YyNk68mX2vgUCcBe7v2JrjCDAtvEDKjcHVCBDIR6kDMeoeO3l2qEmIoO9TwFe9KhcfI=; 7:oBGVAom/+p9EURnJk5vgqS8iSDapQ9A47b/LmoraOffe9sJRolIsXUVy19OSgBcEPTFWszA5onabCzDDA/IogXHh7TlB3xdp05UwoNXwiMnu9M7QOYDjPZ2sgp8UOaqvHHNV9EkwJYBUsIHW+RHkQnp0JOEJIF9qQVH8ihbWF91a3Oe56Yvg514dVUM7yPnZBMbvj/ZQdRDO99xXGJsFGQc+Blx5BxiWmAcPAQ4Zs9Rb/RXw10THKiTV4bxR/8Ft SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR04MB0391; 20:BafYX8r0e8wN6W1I9K2RQtLx/FUJ5Yl5r0NUGb0Pc75Kufq390q6lAL+o1hwO/VfN2HASNDnnxCNSrqWyWiHjQailhTTRmVSOPl0bbOo68eSge41ob0YKiTnXb9r3rxy/lX1NpVykDpP0faEjUuYW8AO/tZM85t93T/DF1fR/sI= X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2018 20:28:47.8160 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 322ad8a2-9700-4625-2cbe-08d5ec23e6a2 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR04MB0391 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 216.71.154.45 Subject: [Qemu-devel] [PATCH v1 5/5] spike: Fix crash when introspecting the device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, mjc@sifive.com, alistair.francis@wdc.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the new object_initialize_child() and sysbus_init_child_obj() to fix the issue. Signed-off-by: Alistair Francis Reviewed-by: Michael Clark Reviewed-by: Thomas Huth --- hw/riscv/spike.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/riscv/spike.c b/hw/riscv/spike.c index f94e2b6707..c8c056c50b 100644 --- a/hw/riscv/spike.c +++ b/hw/riscv/spike.c @@ -171,9 +171,8 @@ static void spike_v1_10_0_board_init(MachineState *mach= ine) int i; =20 /* Initialize SOC */ - object_initialize(&s->soc, sizeof(s->soc), TYPE_RISCV_HART_ARRAY); - object_property_add_child(OBJECT(machine), "soc", OBJECT(&s->soc), - &error_abort); + object_initialize_child(OBJECT(machine), "soc", &s->soc, sizeof(s->soc= ), + TYPE_RISCV_HART_ARRAY, &error_abort, NULL); object_property_set_str(OBJECT(&s->soc), SPIKE_V1_10_0_CPU, "cpu-type", &error_abort); object_property_set_int(OBJECT(&s->soc), smp_cpus, "num-harts", @@ -254,9 +253,8 @@ static void spike_v1_09_1_board_init(MachineState *mach= ine) int i; =20 /* Initialize SOC */ - object_initialize(&s->soc, sizeof(s->soc), TYPE_RISCV_HART_ARRAY); - object_property_add_child(OBJECT(machine), "soc", OBJECT(&s->soc), - &error_abort); + object_initialize_child(OBJECT(machine), "soc", &s->soc, sizeof(s->soc= ), + TYPE_RISCV_HART_ARRAY, &error_abort, NULL); object_property_set_str(OBJECT(&s->soc), SPIKE_V1_09_1_CPU, "cpu-type", &error_abort); object_property_set_int(OBJECT(&s->soc), smp_cpus, "num-harts", --=20 2.17.1