[Qemu-devel] [PATCH v5 0/3] watchdog.h: Drop local redefinition of actions enum

Michal Privoznik posted 3 patches 6 years, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/cover.1504771369.git.mprivozn@redhat.com
Test checkpatch failed
Test docker passed
Test s390x passed
hw/watchdog/watchdog.c    | 65 ++++++++++++++++++++++++-----------------------
hw/watchdog/wdt_diag288.c |  6 ++---
include/sysemu/watchdog.h | 12 ++-------
monitor.c                 |  4 +--
qapi-schema.json          |  9 +++++++
qapi/run-state.json       |  6 ++---
6 files changed, 52 insertions(+), 50 deletions(-)
[Qemu-devel] [PATCH v5 0/3] watchdog.h: Drop local redefinition of actions enum
Posted by Michal Privoznik 6 years, 6 months ago
diff to v4:
- in 3/3 compare passed action string case insensitively to the qapi enum

Michal Privoznik (3):
  qapi: Rename WatchdogExpirationAction enum
  watchdog.h: Drop local redefinition of actions enum
  watchdog: Allow setting action on the fly

 hw/watchdog/watchdog.c    | 65 ++++++++++++++++++++++++-----------------------
 hw/watchdog/wdt_diag288.c |  6 ++---
 include/sysemu/watchdog.h | 12 ++-------
 monitor.c                 |  4 +--
 qapi-schema.json          |  9 +++++++
 qapi/run-state.json       |  6 ++---
 6 files changed, 52 insertions(+), 50 deletions(-)

-- 
2.13.5


Re: [Qemu-devel] [PATCH v5 0/3] watchdog.h: Drop local redefinition of actions enum
Posted by Eric Blake 6 years, 6 months ago
On 09/07/2017 03:05 AM, Michal Privoznik wrote:
> diff to v4:
> - in 3/3 compare passed action string case insensitively to the qapi enum
> 
> Michal Privoznik (3):
>   qapi: Rename WatchdogExpirationAction enum
>   watchdog.h: Drop local redefinition of actions enum
>   watchdog: Allow setting action on the fly

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
>  hw/watchdog/watchdog.c    | 65 ++++++++++++++++++++++++-----------------------
>  hw/watchdog/wdt_diag288.c |  6 ++---
>  include/sysemu/watchdog.h | 12 ++-------
>  monitor.c                 |  4 +--
>  qapi-schema.json          |  9 +++++++
>  qapi/run-state.json       |  6 ++---
>  6 files changed, 52 insertions(+), 50 deletions(-)
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH v5 0/3] watchdog.h: Drop local redefinition of actions enum
Posted by Markus Armbruster 6 years, 6 months ago
Michal Privoznik <mprivozn@redhat.com> writes:

> diff to v4:
> - in 3/3 compare passed action string case insensitively to the qapi enum

In 2/3, actually.

Series
Reviewed-by: Markus Armbruster <armbru@redhat.com>

Re: [Qemu-devel] [PATCH v5 0/3] watchdog.h: Drop local redefinition of actions enum
Posted by Michal Privoznik 6 years, 6 months ago
On 09/07/2017 10:05 AM, Michal Privoznik wrote:
> diff to v4:
> - in 3/3 compare passed action string case insensitively to the qapi enum
> 
> Michal Privoznik (3):
>   qapi: Rename WatchdogExpirationAction enum
>   watchdog.h: Drop local redefinition of actions enum
>   watchdog: Allow setting action on the fly
> 
>  hw/watchdog/watchdog.c    | 65 ++++++++++++++++++++++++-----------------------
>  hw/watchdog/wdt_diag288.c |  6 ++---
>  include/sysemu/watchdog.h | 12 ++-------
>  monitor.c                 |  4 +--
>  qapi-schema.json          |  9 +++++++
>  qapi/run-state.json       |  6 ++---
>  6 files changed, 52 insertions(+), 50 deletions(-)
> 

Thanks for all the reviews. What do I need to get it pushed ;-)

Michal

Re: [Qemu-devel] [PATCH v5 0/3] watchdog.h: Drop local redefinition of actions enum
Posted by Markus Armbruster 6 years, 5 months ago
Michal Privoznik <mprivozn@redhat.com> writes:

> On 09/07/2017 10:05 AM, Michal Privoznik wrote:
>> diff to v4:
>> - in 3/3 compare passed action string case insensitively to the qapi enum
>> 
>> Michal Privoznik (3):
>>   qapi: Rename WatchdogExpirationAction enum
>>   watchdog.h: Drop local redefinition of actions enum
>>   watchdog: Allow setting action on the fly
>> 
>>  hw/watchdog/watchdog.c    | 65 ++++++++++++++++++++++++-----------------------
>>  hw/watchdog/wdt_diag288.c |  6 ++---
>>  include/sysemu/watchdog.h | 12 ++-------
>>  monitor.c                 |  4 +--
>>  qapi-schema.json          |  9 +++++++
>>  qapi/run-state.json       |  6 ++---
>>  6 files changed, 52 insertions(+), 50 deletions(-)
>> 
>
> Thanks for all the reviews. What do I need to get it pushed ;-)

Nothing, I'll take it.