From nobody Sun May 19 11:37:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=tencent.com ARC-Seal: i=1; a=rsa-sha256; t=1586142875; cv=none; d=zohomail.com; s=zohoarc; b=j5ZscF2DxmrQpjOHKjXTYwknBQTePUTIE28Yb2f0yUZp79a/JBtjVhFfKxnjIIRikvQ2TJ9rCEJz0ZhDFRKUNhfnl6aBwd0i4vwonUPQ8vXerrFww+uAkGnJaDnmJPyVlaFhKlxteBkbDBw0JDIRF+ZBhvaw56JDbyqscmbFi3A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586142875; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=8fCEIbDk68Acp+vs6mxoEb2prh1aikrPFzroeCeH/eI=; b=dx1z8yyJeAN0sZdmQbEVD/N3liey83q8WGnfYdTsA4MNSNJpDCq73poyEtjR/vXlGDnB/7txj+IAC23KVVxrjZbES7Zxp8TYnVr/BEU1QJ9crAwjWr0d38nVkZWuT8G6QIgALjZkX9UviwMWD5q9hOBLc8Fh0D6H/hUd64UxZAM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1586142874982558.6382020198031; Sun, 5 Apr 2020 20:14:34 -0700 (PDT) Received: from localhost ([::1]:54120 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLIDY-0006Pq-Sh for importer@patchew.org; Sun, 05 Apr 2020 23:14:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34490) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLICq-0005zt-Ud for qemu-devel@nongnu.org; Sun, 05 Apr 2020 23:13:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jLICm-0008Tt-VO for qemu-devel@nongnu.org; Sun, 05 Apr 2020 23:13:45 -0400 Received: from mail6.tencent.com ([220.249.245.26]:35357) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jLICk-0008Ph-LA for qemu-devel@nongnu.org; Sun, 05 Apr 2020 23:13:44 -0400 Received: from EX-SZ021.tencent.com (unknown [10.28.6.73]) by mail6.tencent.com (Postfix) with ESMTP id 69B6FCC0E4; Mon, 6 Apr 2020 11:14:14 +0800 (CST) Received: from EX-SZ008.tencent.com (10.28.6.32) by EX-SZ021.tencent.com (10.28.6.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1847.3; Mon, 6 Apr 2020 11:13:35 +0800 Received: from EX-SZ005.tencent.com (10.28.6.29) by EX-SZ008.tencent.com (10.28.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1847.3; Mon, 6 Apr 2020 11:13:34 +0800 Received: from EX-SZ005.tencent.com ([fe80::5d14:1c60:ce53:dbd6]) by EX-SZ005.tencent.com ([fe80::5d14:1c60:ce53:dbd6%4]) with mapi id 15.01.1847.007; Mon, 6 Apr 2020 11:13:34 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tencent.com; s=s202002; t=1586142854; bh=8fCEIbDk68Acp+vs6mxoEb2prh1aikrPFzroeCeH/eI=; h=From:To:CC:Subject:Date; b=dGdO0xJbydrO67m9J7/+35uuzZGQ6r84uF85cj8kCcxFhWB1QeMMaHqURIa8zZd1I A3G//U1JEgwCiQl7feRU60WpG78gkgJVZaPgvTLI63RwZ66i9PqrvOSZcrQHAzDTuq XV+92GylN6sqXnmcuyIE1oMWZHzEVIipWPYS8078= From: =?utf-8?B?YmF1ZXJjaGVuKOmZiOiSmeiSmSk=?= To: qemu-devel Subject: Requesting review about a bugfix in touch_all_pages Thread-Topic: Requesting review about a bugfix in touch_all_pages Thread-Index: AQHWC8D0kmS2yvN+ZEGzd75W8Q0lkQ== Date: Mon, 6 Apr 2020 03:13:34 +0000 Message-ID: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [9.19.161.78] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 220.249.245.26 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @tencent.com) From faf903f7b8892179e64bd1a37fe3585a6441bc51 Mon Sep 17 00:00:00 2001 From: Bauerchen Date: Mon, 6 Apr 2020 10:36:54 +0800 Subject: [PATCH] Fix: In touch_all_pages, maybe we need a lock to protect =C2=A0qemu_cond_boardcast, or qemu_cond_boardcast may be called before all = touch =C2=A0page threads enter qemu_cond_wait. In this case, =C2=A0main thread wa= its touch =C2=A0page threads return, touch page threads wait main thread waking up, t= hat is a =C2=A0dead lock ,vm will be in pause state forever; Signed-off-by: Bauerchen --- =C2=A0util/oslib-posix.c | 3 +++ =C2=A01 file changed, 3 insertions(+) diff --git a/util/oslib-posix.c b/util/oslib-posix.c index 4dd6d7d..062236a 100644 --- a/util/oslib-posix.c +++ b/util/oslib-posix.c @@ -492,8 +492,11 @@ static bool touch_all_pages(char *area, size_t hpagesi= ze, size_t numpages, =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 QEMU_THREAD_JOINABLE); =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0addr +=3D memset_thread[i].numpages * hpa= gesize; =C2=A0 =C2=A0 =C2=A0} + + =C2=A0 =C2=A0qemu_mutex_lock(&page_mutex); =C2=A0 =C2=A0 =C2=A0threads_created_flag =3D true; =C2=A0 =C2=A0 =C2=A0qemu_cond_broadcast(&page_cond); + =C2=A0 =C2=A0qemu_mutex_unlock(&page_mutex); =C2=A0 =C2=A0 =C2=A0 =C2=A0for (i =3D 0; i < memset_num_threads; i++) { =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0qemu_thread_join(&memset_thread[i].pgthre= ad); --=C2=A0 1.8.3.1