From nobody Mon Feb 9 13:08:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1566779372; cv=none; d=zoho.com; s=zohoarc; b=UjnOYXO9JzDmUu19cF++Xl6WfHjjVVksKmHXfX0360xaTa6ODjY6kxXlBArBuD1DFCl/0qgr1u1N06FfwlwIUA0T6RW41AGw36F7VUE73QXKm9W+SW4gwGJBtTlAnpeN6JH+rejvCOhyOz28Q1jx17Wxolsjx9cRPtGX+1EAItM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566779372; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=wLkXMiZQuJXReldHJyQj4Rgta+ZWvb/ldWsuhQXJSqE=; b=kFXwRMbnkyS/bJI5r338gq7g/SsGDyTuBHgObIwKE9MRcwu6PXMwKGYwnJlH7BUs8QlsDLqs7nlkPjUTVPmRhXRV/Qb6cHF3dCr8KBNAEuFY8L3trYHf05h9gxSGycb4nKIvXT1NwTSlj1yshRPNQZQKP+cDaMNsDra7clhQdOI= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1566779372645942.1756254642587; Sun, 25 Aug 2019 17:29:32 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1220DA28739; Mon, 26 Aug 2019 00:29:30 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B72BE5D6D0; Mon, 26 Aug 2019 00:29:27 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E81182551C; Mon, 26 Aug 2019 00:29:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x7Q0TJ03013968 for ; Sun, 25 Aug 2019 20:29:19 -0400 Received: by smtp.corp.redhat.com (Postfix) id 93A89600CE; Mon, 26 Aug 2019 00:29:19 +0000 (UTC) Received: from mx1.redhat.com (ext-mx21.extmail.prod.ext.phx2.redhat.com [10.5.110.62]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F1D71600C4; Mon, 26 Aug 2019 00:29:14 +0000 (UTC) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CFF0F18C4271; Mon, 26 Aug 2019 00:29:13 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id g67so14123873wme.1; Sun, 25 Aug 2019 17:29:13 -0700 (PDT) Received: from decltype.home.dirty-ice.org (2a01-036c-0113-61b1-0001-0000-0000-00d3.pool6.digikabel.hu. [2a01:36c:113:61b1:1::d3]) by smtp.gmail.com with ESMTPSA id c19sm8662339wml.13.2019.08.25.17.29.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 Aug 2019 17:29:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3SCYdPHixYiDa5hoVT0Tlp9GgfPbk+6aSz1nYbqKJJQ=; b=DP2Ci/pAQ7Upnz+VYcK/zHwMjQfsG67A1t5QEcaVSZvS5jYqG6Vr96367iK0S/Kai0 FKIvTcsngiQb+T0w5GeXxixTqxmTRm4B1/29xgmukkN8rBfqUIa0MLWU58F/8+1KlJTG 1qzFjo5t7IsKLcvW65z6aVyzs7/PYrvxC0K+7Cv+rxVAxDpq/o8H7mY0j3C2MsVlApzs nFpuXeCCU9xr7S9XxclAofPLFNaDLbRGGF8/NPnCqdSryYyvMPpLXfDcPG/c0dmgiFZB xlG18hW6tr1aMIxQ7eJLn5B4qpeyhdqXIOiWjGQA0aHuMtTLe6q0K/HjS/o1JGV9ryy+ Ji6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3SCYdPHixYiDa5hoVT0Tlp9GgfPbk+6aSz1nYbqKJJQ=; b=CxCpLcd01TorKTrut4ItRnXdhstT4oq70CKp2akp3hOav2vENH2RduHCIOmVS5pRbe D9VCfCjSHuhvv8e2yanKmHmPi+uW3lQDdfIgFYECYRnJRHx1QkH6lm9TSs+dBaudbnrB h0v2N46tNKzE/mQmg54iXuuBk+8HAavx7r7Ubq0rJ7WW2pZ7pYBq1c1kZeWsIXRjQHpN gq+7MKR5gf4p91c9Z1k7df+XA3tpw7ag5a9Mjr9eETHWvGyAagaRKWYDxBo7HkMxM52L EEYVbzBLHyBRFXJ8/zav63vImq5Lmu3ZnbF/mcPntex9VIqVNMFBmpaMCRaq0NOyuKmE UQ3Q== X-Gm-Message-State: APjAAAUEDGobNyXkI8vmqKapvgDTSycQ2/72bQVSDJVDCSd9TeH+yspz fGK1lz2I6YGJ+jDUG37y1QcVIo/7vyY= X-Google-Smtp-Source: APXvYqxTcLgcqvx6VaGC/xNB2xDSeEgY6v8IOoiPaGB1cn3+dfcXqi3DAkOaUvmmoSo5eHoddzTO6g== X-Received: by 2002:a05:600c:21ca:: with SMTP id x10mr18458075wmj.112.1566779352510; Sun, 25 Aug 2019 17:29:12 -0700 (PDT) From: "=?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?=" X-Google-Original-From: =?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?= To: qemu-devel@nongnu.org Date: Mon, 26 Aug 2019 02:29:07 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.62]); Mon, 26 Aug 2019 00:29:14 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.62]); Mon, 26 Aug 2019 00:29:14 +0000 (UTC) for IP:'209.85.128.66' DOMAIN:'mail-wm1-f66.google.com' HELO:'mail-wm1-f66.google.com' FROM:'dirty.ice.hu@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.099 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS) 209.85.128.66 mail-wm1-f66.google.com 209.85.128.66 mail-wm1-f66.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.62 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: "reviewer:Incompatible changes" , Gerd Hoffmann , Maxim Levitsky Subject: [libvirt] [PATCH 1/3] audio: omitting audiodev= parameter is only deprecated X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.68]); Mon, 26 Aug 2019 00:29:31 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) Unfortunately, changes introduced in af2041ed2d "audio: audiodev=3D parameters no longer optional when -audiodev present" breaks backward compatibility. This patch changes the error into a deprecation warning. Signed-off-by: K=C5=91v=C3=A1g=C3=B3, Zolt=C3=A1n --- qemu-deprecated.texi | 7 +++++++ audio/audio.c | 8 ++++---- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 00a4b6f350..9d74a1cfc0 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -72,6 +72,13 @@ backend settings instead of environment variables. To e= ase migration to the new format, the ``-audiodev-help'' option can be used to convert the current values of the environment variables to ``-audiodev'' options. =20 +@subsection Creating sound card devices and vnc without audiodev=3D proper= ty (since 4.2) + +When not using the deprecated legacy audio config, each sound card +should specify an @code{audiodev=3D} property. Additionally, when using +vnc, you should specify an @code{audiodev=3D} propery if you plan to +transmit audio through the VNC protocol. + @subsection -mon ...,control=3Dreadline,pretty=3Don|off (since 4.1) =20 The @code{pretty=3Don|off} switch has no effect for HMP monitors, but is diff --git a/audio/audio.c b/audio/audio.c index 7d715332c9..e13addf922 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -1412,8 +1412,9 @@ static AudioState *audio_init(Audiodev *dev, const ch= ar *name) drvname =3D AudiodevDriver_str(dev->driver); } else if (!QTAILQ_EMPTY(&audio_states)) { if (!legacy_config) { - dolog("You must specify an audiodev=3D for the device %s\n", n= ame); - exit(1); + dolog("Device %s: audiodev default parameter is deprecated, pl= ease " + "specify audiodev=3D%s\n", name, + QTAILQ_FIRST(&audio_states)->dev->id); } return QTAILQ_FIRST(&audio_states); } else { @@ -1548,8 +1549,7 @@ CaptureVoiceOut *AUD_add_capture( =20 if (!s) { if (!legacy_config) { - dolog("You must specify audiodev when trying to capture\n"); - return NULL; + dolog("Capturing without setting an audiodev is deprecated\n"); } s =3D audio_init(NULL, NULL); } --=20 2.22.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list