From nobody Tue Dec 16 07:33:19 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1650874991; cv=none; d=zohomail.com; s=zohoarc; b=jOttLRRRDMCn2bqlIWvLFxb3hg0TYAMRXGqQMrc7s8qqK8TjVefDRj0OktpDNBD7LFi5P8dx1p4fdQeAGIJnUXRBOyTMNrXjYZC3D7VTsbdnpILHk66koruO3cf6oHCF85r5blq2kXAVKbpzcd7Mfn5rHsB2kJp5TC9Jc19ChgY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650874991; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uSjZ4QBWRDNWG4JCXGIx/l5GdZP0dmWgbGQwE/eNVLc=; b=aGlXzP48PDBT8KOBPkTmjlRnxEpRjUPvdVaHyOBEvA4hxXF6EsRymHb6Z/Ar8X2C/vx3p2gtoI0gVym6WYYTIOR4nLUvDV43rFib22HVeCi5hTvBcWAO3nSabEHyDkvrDGVfeDvgyNWHmCChK/gIl3kfLIAIUD4QXmtB5gq7H8c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1650874991207449.7503902358653; Mon, 25 Apr 2022 01:23:11 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-584-QnAT0kFmOnmJAUTcAjkk8A-1; Mon, 25 Apr 2022 04:22:25 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E7C3F281182A; Mon, 25 Apr 2022 08:22:18 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id D43EB42B939; Mon, 25 Apr 2022 08:22:18 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 7978A193F6E3; Mon, 25 Apr 2022 08:22:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 117D8193F6EB for ; Mon, 25 Apr 2022 08:22:13 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 015F62167D67; Mon, 25 Apr 2022 08:22:13 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F12B72167D63 for ; Mon, 25 Apr 2022 08:22:09 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C4EE280418C for ; Mon, 25 Apr 2022 08:22:09 +0000 (UTC) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-59-JYNe41-IMMic5WtfuJwlCg-1; Mon, 25 Apr 2022 04:22:08 -0400 Received: by mail-wr1-f69.google.com with SMTP id d28-20020adf9b9c000000b0020ad4a50e14so717473wrc.3 for ; Mon, 25 Apr 2022 01:22:08 -0700 (PDT) Received: from wheatley.localdomain (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id w5-20020a7bc105000000b0038eb9932dacsm7960786wmi.48.2022.04.25.01.22.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 01:22:05 -0700 (PDT) Received: from wheatley.redhat.com (wheatley.k8r.cz [127.0.0.1]) by wheatley.localdomain (Postfix) with ESMTP id 783A667B1B63; Mon, 25 Apr 2022 10:22:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650874990; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=uSjZ4QBWRDNWG4JCXGIx/l5GdZP0dmWgbGQwE/eNVLc=; b=Que2AKObKvUpyTTXwbCCJLdZCKeKiBBnsyKwQyKJRXOd2d2mdcnMCJuTygwFPKGoX5DTrO DnVGgJMVnkg1rrpKaTKDtyZpn240+uEUGVDheG/YtXiqt2d1vsBfsIrzaMPRJ/lZXo5lmK IJTUQHJF2LQ+T6z++GV8gv3iw7MRozE= X-MC-Unique: QnAT0kFmOnmJAUTcAjkk8A-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: JYNe41-IMMic5WtfuJwlCg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uSjZ4QBWRDNWG4JCXGIx/l5GdZP0dmWgbGQwE/eNVLc=; b=tzMOdsr/HCkWkOcdonop27wNSSafHQ3Y1w5rd2W83ORrNvYLFmG/dQrHtJL/gE2lGy wn0hLHUXuT7dGQsX8Dx7XLz/iXhjmHg+0iIzyAh9VY8m3mLHhXPxCKHBSSyQVMra+3kn oibcZ4d6i1FK7mgSAKYI4IxadG1g6mu1+zfWhRe16YOqtCfX8128XWt8K0uZj4LzTkQe gEndqa6Q1hf0QDEBjco5RN8uXivW99OBiQky3YZX02/9JS6vgtKbEzGZrIG9JlLMuq67 bZdhh1q0wuPl+WzYJ3+Nu/8vdJ/yYKIZugp+QR9VGCdVigdivUx52CHUg0Asa6WkGOTp RtJA== X-Gm-Message-State: AOAM532MNzx2tgTKYQJZ8pUfrY8FY8H2c25LCMK2nFCW0e/v1AKWmbUZ 0jqvLyOIGQEo5cTZ1YjQfNwmvzzLI5IPJetSLhgZegkRJGcQ6txrNqmeq11oKwQyqCj/Yfp4xXS 6xq50Eia3vtknx18EUPg= X-Received: by 2002:a5d:414b:0:b0:20a:dc15:bd00 with SMTP id c11-20020a5d414b000000b0020adc15bd00mr2725001wrq.136.1650874926087; Mon, 25 Apr 2022 01:22:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8qC2lx1GQUGbLcuVMC7CuPZAW1FwOhnYZSanHQlE+T8VWSG0vRNi3RnDUInHu9vI2cxEZng== X-Received: by 2002:a5d:414b:0:b0:20a:dc15:bd00 with SMTP id c11-20020a5d414b000000b0020adc15bd00mr2724989wrq.136.1650874925839; Mon, 25 Apr 2022 01:22:05 -0700 (PDT) From: Martin Kletzander To: qemu-devel@nongnu.org Subject: [PATCH 14/18] audio: Require AudioState in AUD_add_capture Date: Mon, 25 Apr 2022 10:21:57 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Stefan Hajnoczi , libvir-list@redhat.com, Christian Schoenebeck , Yanan Wang , Gerd Hoffmann , "Edgar E. Iglesias" , Qiuhao Li , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Marcel Apfelbaum , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Laurent Vivier , Thomas Huth , Alistair Francis , Alexander Bulekov , Bandan Das , qemu-arm@nongnu.org, Jan Kiszka , Pavel Dovgalyuk , Eduardo Habkost , Darren Kenny , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1650874992555100016 Content-Type: text/plain; charset="utf-8"; x-default="true" Since all callers require a valid audiodev this function can now safely abort in case of missing AudioState. Signed-off-by: Martin Kletzander --- audio/audio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index b95aca444382..97eb645764c1 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -1855,10 +1855,8 @@ CaptureVoiceOut *AUD_add_capture( struct capture_callback *cb; =20 if (!s) { - if (!legacy_config) { - dolog("Capturing without setting an audiodev is deprecated\n"); - } - s =3D audio_init(NULL, NULL); + error_setg(&error_abort, + "Capturing without setting an audiodev is not supported= "); } =20 if (!audio_get_pdo_out(s->dev)->mixing_engine) { --=20 2.35.1