From nobody Sat Nov 23 17:38:27 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A9E21DEFC8 for ; Fri, 22 Nov 2024 13:14:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732281264; cv=none; b=HMTBoBYtztNbZWZLP9Ln19nH670dCOQmolqECEsn7YjYmzyftUCcGx/XqXoCRFi7CkGzpv2ToWpBoNA3TgsmVWn4M/FPu018QsrXG4Y0eHwwbtGk2U1o6M++vpXSGiuI1tQCm+KOBzsX2dPZtvyQOw8NFAUjetRANVHHuusOaPk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732281264; c=relaxed/simple; bh=doZIE/N48jfI+gtG9UrfyFhDLPR7ZyHz+PuyPm64C0Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rH43tQ2iVXCuZsfYbzPqLNQTGgvF36Ont1p9dIL6XZKW14DM6KA2o7JUaGMiHkaR/v/3g/Ew3qAumV0xHxiw9wGGvJM52nRe1aeSWmGFZzAid9rS6aqD5Xr8gNUgLU0G7J4Zhn3dZPeqQHeDVfLRvjw6rKZ19mm49IOTeL37et8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FzIRhSZ2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FzIRhSZ2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 131DEC4CECE; Fri, 22 Nov 2024 13:14:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732281264; bh=doZIE/N48jfI+gtG9UrfyFhDLPR7ZyHz+PuyPm64C0Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FzIRhSZ2GD29EOUyT1QbOegmc4UjN5oXmh+UOOL+z3qjMRkPyVwydl5ukf5c4LqtM jCwH7Y9NvUVrtMoSw9IafY+9lQYc2/xYwHAyuCOJxSFuGrmJojM7mLMvFKSob3xvZR K6PuN2rZodulcNDJHmmX+zKX84RC6HXjM4fCSC7UtSzzHkibkXkXdlNnm5ZV2FQpNM rhs7oLi3WC4bnuBxAySAA+t86ZPs7yWEzBA1dzAsw9J0dKyyWvzcZVRnCB2nW/uHW/ f67vKpq53Gy5zqt4AInthKSyZ7EaYbhi42wZfclUL4jbwpzz90De3yMVKjml9UXhoa lplbUKrIIYANg== Received: from mchehab by mail.kernel.org with local (Exim 4.98) (envelope-from ) id 1tETUM-00000006v9l-0Dol; Fri, 22 Nov 2024 14:14:22 +0100 From: Mauro Carvalho Chehab To: Cc: Jonathan Cameron , Shiju Jose , Mauro Carvalho Chehab , "Michael S. Tsirkin" , Ani Sinha , Dongjiu Geng , Igor Mammedov , linux-kernel@vger.kernel.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH v2 2/5] acpi/ghes: add a firmware file with HEST address Date: Fri, 22 Nov 2024 14:14:12 +0100 Message-ID: X-Mailer: git-send-email 2.47.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab Content-Type: text/plain; charset="utf-8" Store HEST table address at GPA, placing its content at hest_addr_le variable. Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Jonathan Cameron --- Change from v8: - hest_addr_lr is now pointing to the error source size and data. Signed-off-by: Mauro Carvalho Chehab --- hw/acpi/ghes.c | 17 ++++++++++++++++- include/hw/acpi/ghes.h | 1 + 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c index 8c7d0d5cdb0c..680cada0e487 100644 --- a/hw/acpi/ghes.c +++ b/hw/acpi/ghes.c @@ -30,6 +30,7 @@ =20 #define ACPI_HW_ERROR_FW_CFG_FILE "etc/hardware_errors" #define ACPI_HW_ERROR_ADDR_FW_CFG_FILE "etc/hardware_errors_addr" +#define ACPI_HEST_ADDR_FW_CFG_FILE "etc/acpi_table_hest_addr" =20 /* The max size in bytes for one error block */ #define ACPI_GHES_MAX_RAW_DATA_LENGTH (1 * KiB) @@ -261,7 +262,7 @@ static void build_ghes_error_table(GArray *hardware_err= ors, BIOSLinker *linker, } =20 /* - * tell firmware to write hardware_errors GPA into + * Tell firmware to write hardware_errors GPA into * hardware_errors_addr fw_cfg, once the former has been initialized. */ bios_linker_loader_write_pointer(linker, ACPI_HW_ERROR_ADDR_FW_CFG_FIL= E, 0, @@ -355,6 +356,8 @@ void acpi_build_hest(GArray *table_data, GArray *hardwa= re_errors, =20 acpi_table_begin(&table, table_data); =20 + int hest_offset =3D table_data->len; + /* Error Source Count */ build_append_int_noprefix(table_data, num_sources, 4); for (i =3D 0; i < num_sources; i++) { @@ -362,6 +365,15 @@ void acpi_build_hest(GArray *table_data, GArray *hardw= are_errors, } =20 acpi_table_end(linker, &table); + + /* + * tell firmware to write into GPA the address of HEST via fw_cfg, + * once initialized. + */ + bios_linker_loader_write_pointer(linker, + ACPI_HEST_ADDR_FW_CFG_FILE, 0, + sizeof(uint64_t), + ACPI_BUILD_TABLE_FILE, hest_offset); } =20 void acpi_ghes_add_fw_cfg(AcpiGhesState *ags, FWCfgState *s, @@ -375,6 +387,9 @@ void acpi_ghes_add_fw_cfg(AcpiGhesState *ags, FWCfgStat= e *s, fw_cfg_add_file_callback(s, ACPI_HW_ERROR_ADDR_FW_CFG_FILE, NULL, NULL, NULL, &(ags->hw_error_le), sizeof(ags->hw_error_le), false); =20 + fw_cfg_add_file_callback(s, ACPI_HEST_ADDR_FW_CFG_FILE, NULL, NULL, + NULL, &(ags->hest_addr_le), sizeof(ags->hest_addr_le), false); + ags->present =3D true; } =20 diff --git a/include/hw/acpi/ghes.h b/include/hw/acpi/ghes.h index 9f0120d0d596..237721fec0a2 100644 --- a/include/hw/acpi/ghes.h +++ b/include/hw/acpi/ghes.h @@ -58,6 +58,7 @@ enum AcpiGhesNotifyType { }; =20 typedef struct AcpiGhesState { + uint64_t hest_addr_le; uint64_t hw_error_le; bool present; /* True if GHES is present at all on this board */ } AcpiGhesState; --=20 2.47.0