From nobody Sat Apr 11 23:04:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1772954467; cv=none; d=zohomail.com; s=zohoarc; b=KKZ9m49NV/+6mLS554SkN5Kv8Rc37+w78eptncFK5Oo2x69Gtpeo8uzRoowhKwiECBnDq9AFN1fI6ECGpnN4tPDw4KTR8E5wXe7hmgs+/JuO6OkrN8IR/TYwGNPH/yeGzTfsSOfz4eNTM02AnGfKPKzCA09mWooCsGVVVXRcSmI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772954467; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Arw5DkHnIHFmXLFPr7igt+8kKLdzDCKYx1CXG3qK2V4=; b=nzXkeE9qoM2CmfC5tCL0dNB+JujZNROLR1YZdPrUKIQWT+nIzKIFHUF4i02mCg3LUK4fKvhxQKmejMOo/sZPSLkEYDsIXYJ+OAnyfHyCdJxrdSUfPcSb/x+ObTKWjrGADuE9e/qPqm40VUvk/YriPD/a8DRQNA+iRFAStBfjy8A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772954467680712.9177371732603; Sat, 7 Mar 2026 23:21:07 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vz8Qc-0008ND-TZ; Sun, 08 Mar 2026 03:19:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vz8QW-00088m-QG for qemu-devel@nongnu.org; Sun, 08 Mar 2026 03:19:48 -0400 Received: from mail-dy1-x1341.google.com ([2607:f8b0:4864:20::1341]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vz8QV-0001yi-5F for qemu-devel@nongnu.org; Sun, 08 Mar 2026 03:19:48 -0400 Received: by mail-dy1-x1341.google.com with SMTP id 5a478bee46e88-2ba895adfeaso9005191eec.0 for ; Sat, 07 Mar 2026 23:19:46 -0800 (PST) Received: from ZEVORN-PC.bbrouter ([38.95.120.198]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2be4f984ceasm6014081eec.32.2026.03.07.23.19.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2026 23:19:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772954386; x=1773559186; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Arw5DkHnIHFmXLFPr7igt+8kKLdzDCKYx1CXG3qK2V4=; b=f2GmZQ02Zqr1TF1/aNmX1CrUJam928cPiHcmy1JZrgJcrJzOLpmgMArtGwwYfTYea/ ARYep9549hUqxAQ6Ptw7Gb6UKCnNsY9283T38gsPApBj69I9uRJ1Z3QrMleoDiac7Msh qooNAbjp1rMrX6xIfYvJUeMWUshmOJAiWm+m9oEDjJIKOos5uUFE0cR8UVADd98E56EI xU5x/A5Ai1q+UzXUBmQCBCb/M7NxqOi90G0fADjzVInXgZ/QfzJ8YDbUVbIktr9kTLh1 mAFc53Mro41Aig83o4NHGLGrCCKSy/9x9LmbhWzQyxGiIag41d1KTonkEw6PIAkJyiQg B/+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772954386; x=1773559186; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Arw5DkHnIHFmXLFPr7igt+8kKLdzDCKYx1CXG3qK2V4=; b=EjUf572lG2tyd/GFO4AN0swY13EDK7qyXhWvyPyNm2H9WXsDMfEhPGI0xeT98FaTSV j1e4yWM9/pRYlC493F5yioH0ACw6S8yaBI5sIjvHB4SOvKtYO5YXtvLS1BQRPgdM6thf Pduf6bDHwrKImMxdti7xUJ8LuvZwnGfLdvCiBv95CiK+XvaIDAeLoshxBtpCJOSmdPlK oYgvpcCDSzP95/WjOmKeUftZhzsoaIumIXC4gWBUVHC9uu0urgtovRt5hp4W+hVOOXGU weAOk2RQkLXBkyeyq8viwSL8oZaRjxg67Np3OSd1wvR8bgILOC754S2ZP2pNlFxmAJmR kx4Q== X-Forwarded-Encrypted: i=1; AJvYcCWZBdQmruqRPovFLL+0rPEuEAaijnZxoJcE35hEMgDSafrkXpkbS0c+MuP2qaRg0jXA7ZDufcvybMZ8@nongnu.org X-Gm-Message-State: AOJu0YwX8ZL7fCFRtr1GL6miTaA1ULkthPNitpij2O7GMGH/tqMo0SdZ s4jPs/khnVknG1hFjpAEJrgbCDo+hP6wwVUjb2zv+r5JIVfPijGzb1qM X-Gm-Gg: ATEYQzxpPwf8T/lwQJTu8wdlnDYriqG+jHoapDiQuSnhtMU7Seyi5RND/oADDBxaYTM K/XgBY71J2k2EA5+TSvc9YUu2ze3xIszn+Lw8sncobeREMQWolD6UOZ6TeUYPVdpaHIyY9zvdk7 zI+rTeYJmPdnsIA1fhdnTob2Caz3KGE7g2uweJO0ydZLvCVZiu21j5nB/cXofZEA5jEoMElpby8 1iKNNW7lE5tSDizOh737RNeMIfkbIOR82MhilXN4qiDe09xXyzhO6+Kd0+1A3BGpL18kOR3n11S Q9CFideMM7hJUUybnGYGJjsNWfmL8g6U6ij0ogxjfdo6LhNBxdWE2K+XYSRP3a56n3b/5l5nZNd ajZLsusLjd2eDTLwoVI4JxUQmRDxMO249Lark/s0x2qe4O+xgT+oA69n+nnEHxc9yk/PHimwivS 7SwzIB7wHp9zET8F6vddGwsIwjscWxD9mmtWyg2Bj2tEH9tZjOsLdi6ZkhBVe7vQEoSTmtPbMBV EfvkY0IawTEIeu94vvQEqd1wWM= X-Received: by 2002:a05:7300:6c28:b0:2be:e4b:60c3 with SMTP id 5a478bee46e88-2be4e027173mr2822376eec.19.1772954385681; Sat, 07 Mar 2026 23:19:45 -0800 (PST) From: Chao Liu To: Paolo Bonzini , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Chao Liu , Fabiano Rosas , Laurent Vivier Cc: tangtao1634@phytium.com.cn, qemu-devel@nongnu.org, qemu-riscv@nongnu.org Subject: [PATCH v1 13/28] target/riscv: allow debug-mode actions for itrigger Date: Sun, 8 Mar 2026 15:17:16 +0800 Message-ID: X-Mailer: git-send-email 2.53.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1341; envelope-from=chao.liu.zevorn@gmail.com; helo=mail-dy1-x1341.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1772954469842154100 Content-Type: text/plain; charset="utf-8" Accept action=3Ddebug-mode in itrigger tdata1 when Sdext is enabled and reject unsupported action encodings explicitly. This extends the instruction-count trigger path to the same debug-entry mode used by other trigger types and keeps invalid encodings from being silently accepted. Signed-off-by: Chao Liu --- target/riscv/debug.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/target/riscv/debug.c b/target/riscv/debug.c index f3d6eaeb1e..4dbcf289f2 100644 --- a/target/riscv/debug.c +++ b/target/riscv/debug.c @@ -916,15 +916,27 @@ static target_ulong itrigger_validate(CPURISCVState *= env, target_ulong ctrl) { target_ulong val; + uint32_t action; =20 /* validate the generic part first */ val =3D tdata1_validate(env, ctrl, TRIGGER_TYPE_INST_CNT); =20 - /* validate unimplemented (always zero) bits */ - warn_always_zero_bit(ctrl, ITRIGGER_ACTION, "action"); warn_always_zero_bit(ctrl, ITRIGGER_HIT, "hit"); warn_always_zero_bit(ctrl, ITRIGGER_PENDING, "pending"); =20 + action =3D ctrl & ITRIGGER_ACTION; + if (action =3D=3D DBG_ACTION_DBG_MODE) { + if (env_archcpu(env)->cfg.ext_sdext) { + val |=3D action; + } else { + qemu_log_mask(LOG_GUEST_ERROR, + "trigger action=3Ddebug mode requires Sdext\n"); + } + } else if (action !=3D DBG_ACTION_BP) { + qemu_log_mask(LOG_UNIMP, "trigger action: %u is not supported\n", + action); + } + /* keep the mode and attribute bits */ val |=3D ctrl & (ITRIGGER_VU | ITRIGGER_VS | ITRIGGER_U | ITRIGGER_S | ITRIGGER_M | ITRIGGER_COUNT); --=20 2.53.0