From nobody Sat Apr 27 23:04:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1585325764; cv=none; d=zohomail.com; s=zohoarc; b=JH2YFwtiiw/zz5NA77Rt9BDRls7DCSswtQ17RKlJ/h5ThlTpudldSL6/YQ2IuUYXx80K+YyvfpqkizAVbSnFWrTTGah6BZyhGEuRk8MChBKoYfs68sLMm/KzWesQlUdOLdgpz0+1mt7HSn8HJnP5Zd8gxqsVEW0ASJDESsy6FlE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585325764; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=dPMBhR6UAA/siPZ5yMvnhLaQI2BxOrKdcLWmgCVffQw=; b=J16UuMuF3bPB2jcWh9RmoXI3zFJGhD7/yGrgLcvQycyxXAYktUIA7+ps92dWc6kPMvAX0AAIRuEXwAUmMvfZ+txo7XVyHl91+bykdAs/bJuhMPd3Lnv4XpxB/b2SbeRSpcv6e3xDTIbQQpnGx6ld9ZerF+mM9aUWqcqhhWr5xp4= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585325764585876.8207581948614; Fri, 27 Mar 2020 09:16:04 -0700 (PDT) Received: from localhost ([::1]:43928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHreN-0002rK-0D for importer@patchew.org; Fri, 27 Mar 2020 12:16:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37796) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHrdg-0002Of-FR for qemu-devel@nongnu.org; Fri, 27 Mar 2020 12:15:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jHrdf-0006Qy-3A for qemu-devel@nongnu.org; Fri, 27 Mar 2020 12:15:20 -0400 Received: from cmccmta1.chinamobile.com ([221.176.66.79]:2592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jHrdd-0006Ek-UD for qemu-devel@nongnu.org; Fri, 27 Mar 2020 12:15:19 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.3]) by rmmx-syy-dmz-app03-12003 (RichMail) with SMTP id 2ee35e7e2685fc9-def25; Sat, 28 Mar 2020 00:15:01 +0800 (CST) Received: from maozy-host.localdomain (unknown[117.136.46.213]) by rmsmtp-syy-appsvr02-12002 (RichMail) with SMTP id 2ee25e7e2680fcf-c9487; Sat, 28 Mar 2020 00:15:01 +0800 (CST) X-RM-TRANSID: 2ee35e7e2685fc9-def25 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 X-RM-TRANSID: 2ee25e7e2680fcf-c9487 From: Mao Zhongyi To: qemu-devel@nongnu.org Subject: [PATCH v2] monitor/hmp-cmds: add units for migrate_parameters. Date: Sat, 28 Mar 2020 00:14:54 +0800 Message-Id: X-Mailer: git-send-email 2.17.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 221.176.66.79 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dgilbert@redhat.com, Mao Zhongyi , sgarzare@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When running: (qemu) info migrate_parameters announce-initial: 50 ms announce-max: 550 ms announce-step: 100 ms compress-wait-thread: on ... max-bandwidth: 33554432 bytes/second downtime-limit: 300 milliseconds x-checkpoint-delay: 20000 ... xbzrle-cache-size: 67108864 add units for the parameters 'x-checkpoint-delay' and 'xbzrle-cache-size', it's easier to read, also move milliseconds to ms to keep the same style. Signed-off-by: Mao Zhongyi Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Stefano Garzarella --- monitor/hmp-cmds.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index 2a900a528a..790fad3afe 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -436,11 +436,11 @@ void hmp_info_migrate_parameters(Monitor *mon, const = QDict *qdict) MigrationParameter_str(MIGRATION_PARAMETER_MAX_BANDWIDTH), params->max_bandwidth); assert(params->has_downtime_limit); - monitor_printf(mon, "%s: %" PRIu64 " milliseconds\n", + monitor_printf(mon, "%s: %" PRIu64 " ms\n", MigrationParameter_str(MIGRATION_PARAMETER_DOWNTIME_LIMIT), params->downtime_limit); assert(params->has_x_checkpoint_delay); - monitor_printf(mon, "%s: %u\n", + monitor_printf(mon, "%s: %u ms\n", MigrationParameter_str(MIGRATION_PARAMETER_X_CHECKPOINT_DELAY), params->x_checkpoint_delay); assert(params->has_block_incremental); @@ -453,7 +453,7 @@ void hmp_info_migrate_parameters(Monitor *mon, const QD= ict *qdict) monitor_printf(mon, "%s: %s\n", MigrationParameter_str(MIGRATION_PARAMETER_MULTIFD_COMPRESSION= ), MultiFDCompression_str(params->multifd_compression)); - monitor_printf(mon, "%s: %" PRIu64 "\n", + monitor_printf(mon, "%s: %" PRIu64 " bytes\n", MigrationParameter_str(MIGRATION_PARAMETER_XBZRLE_CACHE_SIZE), params->xbzrle_cache_size); monitor_printf(mon, "%s: %" PRIu64 "\n", --=20 2.17.1