From nobody Sun Jul 26 10:07:51 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1784889031; cv=none; d=zohomail.com; s=zohoarc; b=X4g1zSEwQFGlpjbnkybfnD+7/jzlrezILPU1F0PRlbZAhD4CVejWVTYo+VuMI8RmdoV0910xKfJcVTCJF+Zc50G3rCnehS78okjTBD5adw9RjNeerHDmk/L8yqCMQGiRCCEba+MToW6Q1Wb4v/S6+vLT0vtkFtWzZrs45U5Y+0M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784889031; h=Content-Type:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iSs6CPp552YxV/2AsV+6koEA1wJ+b55ymEdPdU+1CIM=; b=eZgGpD06ZR2huutHh20wtrA7rLYRjMrMzDi/lx60YVtvQUGgxbuDXCLjH3pbOpt9iOOk8NkcXjkFZ0r/C9R9mgQgVA0Zs23KUSZG5S9yqs1nmf/XScNlyB5T44ebTCrew5rx3tOfTPaT4ZUjWYxmBSi2Q3+npxTBY7gOOlgACTk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178488903153534.64707867039124; Fri, 24 Jul 2026 03:30:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wnDAA-0000LC-OX; Fri, 24 Jul 2026 06:29:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wnDA8-0000Kd-JI for qemu-devel@nongnu.org; Fri, 24 Jul 2026 06:29:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wnDA6-0002oy-MQ for qemu-devel@nongnu.org; Fri, 24 Jul 2026 06:29:52 -0400 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-222-t-DhUI8SOIeKWWAHNvRHhg-1; Fri, 24 Jul 2026 06:29:47 -0400 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4955ce558d8so2844595e9.3 for ; Fri, 24 Jul 2026 03:29:47 -0700 (PDT) Received: from redhat.com (IGLD-80-230-37-66.inter.net.il. [80.230.37.66]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4957af16f72sm66489215e9.0.2026.07.24.03.29.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 03:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784888989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=iSs6CPp552YxV/2AsV+6koEA1wJ+b55ymEdPdU+1CIM=; b=e8RAKM9kZTtQKVc6N9b+NB1aNiJzjGQ2aTBLBUilbZJbuoN3peS49MSBgVWJf9tLaASY6+ GvHBHAMrxOseGHBfUxQyZm1pk181LuerIRtclYojn9e9maToHMVVJvobHNNitEbhXyHupF eIsBuWOOezFZafKoIKu3URxCWQRTni8= X-MC-Unique: t-DhUI8SOIeKWWAHNvRHhg-1 X-Mimecast-MFC-AGG-ID: t-DhUI8SOIeKWWAHNvRHhg_1784888986 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784888986; x=1785493786; darn=nongnu.org; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=iSs6CPp552YxV/2AsV+6koEA1wJ+b55ymEdPdU+1CIM=; b=QMWERzTb7jidNAzLGkmVYsERML3XhzaaEZjaap1pmRQwoL9bzfohf2uM2LLzkRfzE9 hbELQRBoD2irh785V7FOJrHtWllEUbctfAdHYMriGfDxfWMPzvpp3wVRn1RStvnjYxj2 f6THzJIXHD6XM56rwpQDv8/jCJwCo0v1zFfXzXCLa4OpyJSR4rL1CArr28wGipJ4eGp2 blA6nAZMwZ3keRpK86ZmOLlTqaCzRrYdGpyShcIhbKd4KeO9nwGVT0iQbTX9Cw6iPGDT 2949cihvemgV+G2DU9rze1GIRdTkBnKFJTHLXgLtAXEXTxVhF7WDpIHkSfwRKOZqtDh6 jfMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784888986; x=1785493786; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iSs6CPp552YxV/2AsV+6koEA1wJ+b55ymEdPdU+1CIM=; b=ZNMXTRw75pg48qZl/cm/95ktI/0GKt4eHunrncCkKRX9H2UM4Xx1OZYbSRzg+7eSdc iEw7KiCiUJ1Xoa8dJLqwpWN0S0O/Iw+jNzHseTENl/c1IsjaaWLOR8ni6CzWtAkxFxxU zQ/bO/vNh5GeRrKu89Y2N5oqQHqW+SiA9/LW01Ie2agRhI54C3gZaoCGIk5UYeM1Jzhk KhmC6L8ifNpq9iQZT1lT8yz0bYBBSnlObi9ARxlPD6hba4NHHFesrt8Wrt0s9CEVS+1X c6sxTFIm6rPTe8f4NnqOLs36WZJBXS89b+vy687pFhQKTaiEBZpDEKDy8LHgES/hrQJb S28w== X-Gm-Message-State: AOJu0Yzmi4qklYR5D2oPFR2tQBPKwJjF0QqkisTAIYX3SuV21PaHunSN oIeiDh1b9Eqk6cwvfZaJMA19EhZzpcb4O85ZJ+qzTolU3rJDUt3KorDM7gotJkNoZoL4KQY7VaH mDvKS+2Mq1vjKRXkeps9YY7zpi+sBVXJ136yZHhCsBfzP/i8ZbJXeda0obeutymRxEh/+IbqQ5C Jv8Qg0wqL1mjzS54NZ0ouJvNJJ9RGfRB64lw== X-Gm-Gg: AR+sD12TAx9a2p7mVGF6jHgS8a0oJ/wVGzHq/2ZLjOxCrDmxcFhzbpAB0le8zwhE3Q8 jh/F6zOxN7H1/+Tiih9xRUEZDnte4mBbyHlz+fnNk8G42NncnbzNsRkLsVshsBcb4UCkMj2fMFt mL6Q2u+b/NkQvitA5g8PGNbNwLvDvenm1GK4qx/BaSvEauIMIhI+Q9S8uNN5nTh7fiVL+wVxFIm Bd2+65nVoxOrsOSTQcSSu4RzzrN/FSY6E90t2JqKSlKx+aZICd+nFRPlIQXhVaTPKOewe0V4LH2 6u/XU3k9DdlswWYY0qqonSb0one7am61VX5DNMbRUOplVobj02NvoSD5ApdtI3qTKGPt4+a4N1N /bG8UtJn2zv613znlL9PCrA== X-Received: by 2002:a05:600c:1914:b0:495:4d00:2fc0 with SMTP id 5b1f17b1804b1-49573ccb598mr81711805e9.12.1784888986176; Fri, 24 Jul 2026 03:29:46 -0700 (PDT) X-Received: by 2002:a05:600c:1914:b0:495:4d00:2fc0 with SMTP id 5b1f17b1804b1-49573ccb598mr81711275e9.12.1784888985536; Fri, 24 Jul 2026 03:29:45 -0700 (PDT) Date: Fri, 24 Jul 2026 06:29:43 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Cc: Jia Jia , Xie Yongji Subject: [PATCH] libvduse: validate vq size Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email 2.51.2.2891.g4157995a80.dirty X-Mutt-Fcc: =sent Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.951, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-Zoho-Virus-Status: 1 X-Zoho-AV-Stamp: zmail-av-0.2.10.1.5.2/284.872.57 X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1784889033559158500 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" libvduse assumes that vq size (aka vq num) is below VIRTQUEUE_MAX_SIZE and maps logs large enough based on this assumption. However, vduse_queue_enable() accepts the vq size returned through VDUSE_VQ_GET_INFO without validation, so a value above VIRTQUEUE_MAX_SIZE (1024) overruns the inflight log and causes out-of-bounds writes in vduse_queue_inflight_get(). According to the virtio spec, vq size can only be reduced, not increased, so vq size must not exceed the previously configured max_size, but the kernel vduse module does not validate this for us, and we should not trust another process to follow the spec. Validate and reject vq size values above VIRTQUEUE_MAX_SIZE. Fixes: CVE-2026-61402 Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3652 Reported-by: Jia Jia Signed-off-by: Michael S. Tsirkin --- subprojects/libvduse/libvduse.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/subprojects/libvduse/libvduse.c b/subprojects/libvduse/libvdus= e.c index df9ca5e56f..712b97b4c3 100644 --- a/subprojects/libvduse/libvduse.c +++ b/subprojects/libvduse/libvduse.c @@ -902,6 +902,11 @@ static void vduse_queue_enable(VduseVirtq *vq) return; } =20 + if (vq_info.num > VIRTQUEUE_MAX_SIZE) { + fprintf(stderr, "vq[%d] vring num %u exceeds max %u\n", + vq->index, vq_info.num, VIRTQUEUE_MAX_SIZE); + return; + } vq->vring.num =3D vq_info.num; vq->vring.desc_addr =3D vq_info.desc_addr; vq->vring.avail_addr =3D vq_info.driver_addr; --=20 MST