From nobody Sat May 18 14:54:16 2024 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1554852620; cv=none; d=zoho.com; s=zohoarc; b=UvYOa0z6OvNwH6JXOxsDH7t7y/Nu7Y9wS6wK7mDd81UnrVyRoD8yvZrJ0jR0h/Ewj4ezzYZpB5q7zt1LTIkR0fY+p5J/WnUzjNdO3Bd/jC4C+fZ8xXWb8vxy8gLv8QOwoQm1rXBh/OjvAq6tJKkXj/7nV7KVvyO3MyDXu2xfCns= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1554852620; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=mdXfsMJmLwzjuU/1Ka/I5bPmnQhtZkF/1VeOYTAcAcY=; b=EZwilGS2+uxAtTo3WDbhwCdQUl39K1flyYWazvQVc6pVPs1qoQmH3Ki/bHiOQA8HhBuWscYr/nReT1cn4zr6+y+1dKUIMokq3ME3R6HdPtBEmfSvsEPuWZPT1aRGr4OHiIDoVbDvjq+VIxYW7ePvlEe1vBc8oB1U3I/AoU+JPJI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1554852620902205.49519132562318; Tue, 9 Apr 2019 16:30:20 -0700 (PDT) Received: from localhost ([127.0.0.1]:50557 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE0Bm-0002lJ-55 for importer@patchew.org; Tue, 09 Apr 2019 19:30:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hE0Az-0002SN-1v for qemu-devel@nongnu.org; Tue, 09 Apr 2019 19:29:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hE0Ay-0008ST-8K for qemu-devel@nongnu.org; Tue, 09 Apr 2019 19:29:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56910) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hE0Ay-0008S2-0U for qemu-devel@nongnu.org; Tue, 09 Apr 2019 19:29:12 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 909D43018ECF for ; Tue, 9 Apr 2019 23:20:09 +0000 (UTC) Received: from worklaptop.redhat.com (ovpn-123-33.rdu2.redhat.com [10.10.123.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id 91B4F64046; Tue, 9 Apr 2019 23:20:01 +0000 (UTC) From: Cole Robinson To: qemu-devel@nongnu.org Date: Tue, 9 Apr 2019 19:19:57 -0400 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 09 Apr 2019 23:20:09 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Cole Robinson , dgilbert@redhat.com, quintela@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" The only caller that checks the error code is looking for !=3D 0, so returning false is incorrect. Fixes: 5aaac467938 "migration: savevm: consult migration blockers" Signed-off-by: Cole Robinson Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela --- migration/savevm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/savevm.c b/migration/savevm.c index 34bcad3807..a3dae4cf02 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -2544,7 +2544,7 @@ int save_snapshot(const char *name, Error **errp) AioContext *aio_context; =20 if (migration_is_blocked(errp)) { - return false; + return ret; } =20 if (!replay_can_snapshot()) { --=20 2.21.0