From nobody Mon Feb 9 03:17:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1591471547; cv=none; d=zohomail.com; s=zohoarc; b=ADPZHkzrRFMtyoupsCfZPr/k2MyHweqDB/H8cfJdcKFHMTm/1MW2xm38oh8lDLGGBBpdyhwHUVG9z+dUgKwyhpmPvHwI0DCPi61l/AAVucayof/eYlGonyCR1Qn3hkNIPb/fS/y+vqGKJ3PqQSIl0idMA/AV3bT4wS1vuxLkuCk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591471547; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=mA5oQQ5RTadjtGGaGp+5NHoYWMhQiAV4Iu5BasKoFV8=; b=ZBIYUzCblmOGTLAAgJLoDAQFGRG7LHtcJ6wIKoT6I8yOs7wPq/ENTUGwOOkSs5/3E/TD487OUIlEGUIts8X2vnKYCmJZwYrldkhwvD/YD4hGJXhGQNIYoqsWoI3y1vbzBtMsm6Fi/JHC65u+8f2/V6WGfKzm/NBHG2rgFQM16GU= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591471546856129.59982080738052; Sat, 6 Jun 2020 12:25:46 -0700 (PDT) Received: from localhost ([::1]:45618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jheRt-0001rH-Kd for importer@patchew.org; Sat, 06 Jun 2020 15:25:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jheP9-0007RL-JF for qemu-devel@nongnu.org; Sat, 06 Jun 2020 15:22:55 -0400 Received: from zero.eik.bme.hu ([152.66.115.2]:30190) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jheP7-0006H0-BP for qemu-devel@nongnu.org; Sat, 06 Jun 2020 15:22:55 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 05464746307; Sat, 6 Jun 2020 21:22:43 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 82CCC7482C8; Sat, 6 Jun 2020 21:22:42 +0200 (CEST) Message-Id: In-Reply-To: References: From: BALATON Zoltan Subject: [PATCH 3/4] sm501: Ignore no-op blits Date: Sat, 06 Jun 2020 21:17:36 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: qemu-devel@nongnu.org X-Spam-Probability: 8% Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=152.66.115.2; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/06 15:22:43 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sebastian Bauer , Magnus Damm , Gerd Hoffmann , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Some guests seem to try source copy blits with same source and dest which are no-op so avoid calling pixman for these. Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- hw/display/sm501.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 85d54b598f..3397ca9fbf 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501.c @@ -788,6 +788,11 @@ static void sm501_2d_operation(SM501State *s) (rop2_source_is_pattern ? " with pattern source" : "")); } + /* Ignore no-op blits, some guests seem to do this */ + if (src_base =3D=3D dst_base && src_pitch =3D=3D dst_pitch && + src_x =3D=3D dst_x && src_y =3D=3D dst_y) { + break; + } /* Check for overlaps, this could be made more exact */ uint32_t sb, se, db, de; sb =3D src_base + src_x + src_y * (width + src_pitch); --=20 2.21.3