From nobody Sun Nov 9 21:37:00 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1551896632406877.9852585674074; Wed, 6 Mar 2019 10:23:52 -0800 (PST) Received: from localhost ([127.0.0.1]:37336 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1bCj-0004b8-B9 for importer@patchew.org; Wed, 06 Mar 2019 13:23:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59690) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1b2A-0004g4-6J for qemu-devel@nongnu.org; Wed, 06 Mar 2019 13:12:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1b1t-00069J-QE for qemu-devel@nongnu.org; Wed, 06 Mar 2019 13:12:38 -0500 Received: from fanzine.igalia.com ([91.117.99.155]:59305) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1b1o-0005fs-Be; Wed, 06 Mar 2019 13:12:31 -0500 Received: from 87-92-21-153.bb.dnainternet.fi ([87.92.21.153] helo=perseus.local) by fanzine.igalia.com with esmtpsa (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim) id 1h1b10-0004qu-Jp; Wed, 06 Mar 2019 19:11:38 +0100 Received: from berto by perseus.local with local (Exim 4.89) (envelope-from ) id 1h1b0m-0005OO-3d; Wed, 06 Mar 2019 20:11:24 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=References:In-Reply-To:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=Q5Y7cvRusZmYGsqO+rjtOfPqU6ww3DCHWSQhPtMUlSQ=; b=bzyritn4FTIvrOpRXyoHAP7XmbQK3KR3w4KBg16g5UTst9i2R0ILwDXcA4km/K1mNySbtQ6knN/99kKiUO9I09/P7P3u6E8LiVhGZ1gCrRESEDdn2VlbyEJopgdTQZzDjUFTWh3KW7haKUEtkctpOojE7vJARPfGt+YreNnmdBWNr4nRtWgLn55TmwM2UwTB1O+mxpyhmRBNlmBvLRuRQOIBd/WmdTlzXlupHLJX0KE1jGgsn7g2mgo2cbYruc84rcLQ/MCqWTSFbIp8FFbUxIjnrEtmVAajMcNAthhrMY8c62XIH4fgKp3krQxiuu3B023D2tX3mvQ4Pm3iFE2wow==; From: Alberto Garcia To: qemu-devel@nongnu.org Date: Wed, 6 Mar 2019 20:11:03 +0200 Message-Id: X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 91.117.99.155 Subject: [Qemu-devel] [PATCH v2 03/13] block: Freeze the backing chain for the duration of the mirror job X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Alberto Garcia , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Alberto Garcia --- block/mirror.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/block/mirror.c b/block/mirror.c index 726d3c27fb..010fdafd79 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -630,6 +630,10 @@ static int mirror_exit_common(Job *job) } s->prepared =3D true; =20 + if (bdrv_chain_contains(src, target_bs)) { + bdrv_unfreeze_backing_chain(mirror_top_bs, target_bs); + } + bdrv_release_dirty_bitmap(src, s->dirty_bitmap); =20 /* Make sure that the source BDS doesn't go away during bdrv_replace_n= ode, @@ -1639,6 +1643,10 @@ static void mirror_start_job(const char *job_id, Blo= ckDriverState *bs, goto fail; } } + + if (bdrv_freeze_backing_chain(mirror_top_bs, target, errp) < 0) { + goto fail; + } } =20 QTAILQ_INIT(&s->ops_in_flight); --=20 2.11.0