From nobody Mon Feb 9 19:37:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@gnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 15067316888571006.7735892265611; Fri, 29 Sep 2017 17:34:48 -0700 (PDT) Received: from localhost ([::1]:37549 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dy5jx-0008Jh-2V for importer@patchew.org; Fri, 29 Sep 2017 20:34:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dy5Vc-0004HY-Ht for qemu-devel@nongnu.org; Fri, 29 Sep 2017 20:19:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dy5Vb-0005JM-98 for qemu-devel@nongnu.org; Fri, 29 Sep 2017 20:19:56 -0400 Received: from mail-sn1nam02on0051.outbound.protection.outlook.com ([104.47.36.51]:16022 helo=NAM02-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dy5VW-00055r-GG; Fri, 29 Sep 2017 20:19:50 -0400 Received: from MWHPR02CA0023.namprd02.prod.outlook.com (10.168.209.161) by BLUPR02MB1122.namprd02.prod.outlook.com (10.163.79.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Sat, 30 Sep 2017 00:19:47 +0000 Received: from SN1NAM02FT029.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e44::208) by MWHPR02CA0023.outlook.office365.com (2603:10b6:300:4b::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.8 via Frontend Transport; Sat, 30 Sep 2017 00:19:46 +0000 Received: from xsj-pvapsmtpgw02 (149.199.60.100) by SN1NAM02FT029.mail.protection.outlook.com (10.152.72.110) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.56.11 via Frontend Transport; Sat, 30 Sep 2017 00:19:46 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:41291 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1dy5VR-0000E5-Vv; Fri, 29 Sep 2017 17:19:45 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1dy5VR-00079M-T0; Fri, 29 Sep 2017 17:19:45 -0700 Received: from xsj-pvapsmtp01 (xsj-smtp.xilinx.com [149.199.38.66]) by xsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id v8U0JaXg030676; Fri, 29 Sep 2017 17:19:36 -0700 Received: from [172.19.2.220] (helo=localhost.localdomain) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1dy5VI-00071d-3F; Fri, 29 Sep 2017 17:19:36 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Fm2gVa9rCj2sRRORDcrGJc2eNwvrJqXUR8YaPLZYRiQ=; b=Esoxc3r48rbtyhgBqETyss0RoMH6H2T3K3UMMpvsKvli36yiRahPHvMUP8r/S4ipaajEh2YFInh3+0TvfKE/HCNP5aD92P6LZKFA918F4+c2AHVr676xot3aSNaVOEw+f4GFPc/UFjNJYtSXGuK6kp1LzW/H48kNcO0IcT1uumQ= Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@gnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; From: Alistair Francis To: Date: Fri, 29 Sep 2017 17:15:49 -0700 Message-ID: X-Mailer: git-send-email 2.11.0 In-Reply-To: References: X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23358.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(39860400002)(2980300002)(438002)(199003)(189002)(33646002)(356003)(63266004)(8676002)(106466001)(81156014)(118296001)(305945005)(81166006)(39060400002)(4326008)(189998001)(8936002)(16586007)(478600001)(54906003)(36756003)(316002)(77096006)(48376002)(36386004)(2950100002)(50466002)(6666003)(9786002)(2351001)(6916009)(50986999)(76176999)(5660300001)(47776003)(50226002)(2906002)(5003940100001)(106002)(107986001)(5001870100001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR02MB1122; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; SN1NAM02FT029; 1:/6AronS2Qa90mjVIOBPnee3x76cZ9vMaoDu7mZUwmzNTL44a6/6K+JGfKis6Jwo9GiUDk1x0kbhnSTVBwgIxz+Mp3uwlcJjF7WUFE1MEcrdT2o3q0VsA+yvtbyrgP9cC MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5dac4316-caa4-436a-6f9d-08d50798f4ec X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(8251501002)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:BLUPR02MB1122; X-Microsoft-Exchange-Diagnostics: 1; BLUPR02MB1122; 3:9TAp6jQkanGjy+hOp3WYoOa9JpFr6cGt44/iQ2jBwZkmDrECHSDle2xlcXYmGIogTPfyz/gEWGiLWJ8RiK92D2DvzeLm2P9v72ZslYRh+yR01XRR5ZzHrhcj5PG3s+xV4wsNe7300oMTiVCD8fzaXco9R0CQSMCHxEGqlgScCu51nmJoeHJ2rTBw675xj9uH9bA0DdXHC/gWO+OpeJ02JGfV6UMjM9scYr2ri6Ms2mD4Kvs1frKZRd+EUPc2253w75cqXJZ7qFVZaJWFOf8AWGTw1pWyIdCRFmE7AVWawhsTpmwod7k3WgW+E4HQj2gbXQrQpEyTmTVJ1wLorXpyBIfmRDo9S3UdsR6H+vHC7Zo=; 25:7dm4kZDOf1dDhbehVOJLhdgKC+WVMRuRPseu010z3FPFm0j/OehtBygbHZEj5erAwk0J24cnm9rDPejPVhW6hc3yikpmTTvMMjZ9h+bU1T0/yeBAHYRx7uDD4IyqmtJfHPaKyrYM2P/CmnHw9uv9oq+l+MStGUir+SgWb76KqCeQb3Ro4OMkq13Rqup4EMV9b/BoS/FlGoDBA4iAzIJ/slmIaP5rs50GJC+QfIhkNZeAPU3K2mHtmNK+OqCYdNpfp6gALryZ85ruAJJ44Kmsupup1EDil44YXQlghSAbiyyhlepkG/yuF1Ph8A2kG3B/fL4PNslFssoLnfE4YO9Pvg== X-MS-TrafficTypeDiagnostic: BLUPR02MB1122: X-Microsoft-Exchange-Diagnostics: 1; BLUPR02MB1122; 31:LcOaWGGbCISLS96LOuIpcx2i46vFe+lQr4Hq3F8Zn6EmQWZjlDawm6/t2anROUuyhxdKoTG4L23egm77O0TtOnNrBBejy/GbtI7WcnYM5GXKuDJF39rVqe9Pi9+CrvvNIq98OpFg8JkCrX6gSeTW9sjp7d39Ykox/63bt/s5/P3DskrtCQv4AALcynwya9/3zh/ScHyeHWaAyzKD6KjrGY2Zhw8bNZd1kTOm1FVdvDQ=; 20:fDC8RvIQ7JtzjEDwqtwemtsncJRkNqmgZ6J34xyvXLjIYf3jnImFu2Qz1PWYVfznxClgx+qTy6VNa+5fJV4QdGOvbY5WQJdeEHbIRmlGVsscuwvhi2k1LzUlhgCbW7FXGV22lpWIib+/E8uT8v5GcxMTUvJV7CSAqJ9HdeVse7V5/KlsBo1JY3sDAZmCiaMoHckN+cJqHkMSDv1vikwfXFNj8HhLFfe2aCId7rHMDIWs7aJkNFEuLsySTsIQPuW1T0XIOiA0Sd5619iMQlB3rYkLyI/Sy/0PigovtjKXM8Spqzya+eEedLbI+ncW+hQhc3nTr5ect0hO5U17fNL2TcRL8qVk821j9VXIfMlrVYYdsg6zmuOtbh9xJUckbhdq8Yb/2fQDF4KLUcW/T8OPYznZ9ql92XxUGR7/6jgY2hJXNd30N6stPrz2mgG13Fs4fpF9i30/uCWqMEs7J/v9BABezBc+K7fp6cVgryf2HjuWuSQxBMME16egNPCVsHZ9 X-Exchange-Antispam-Report-Test: UriScan:(788757137089)(192813158149592); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93004095)(3002001)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BLUPR02MB1122; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BLUPR02MB1122; X-Microsoft-Exchange-Diagnostics: 1; BLUPR02MB1122; 4:iu989BQDQ9+hBku/XHD960POEINdPhVyXmimlJObroaCy9uUNdBs7vqcQEeM28rKApF7FBZvWldAj4qLHBR5hFWVajRtpS3P8Mcfa25x9LuO/s795PW/iKLDyfs8KFNnByz5dDhC4b7fBojUJtoNnbXRoXAw4wzqwHW646t22GVztKk/mx6XcJqTpHNrCYYmsEawtEL3UoKaFBHY3NrjDwoCJo+477mWjxG9v/LkjwwppzoG5f8rU2ilN9z9PH1Fxl3NSndRYvgf+u6OC9w7rmKKIfgnITTpH72Rcly8GvDn/7yCQoHu9UszNn32bfITtG6PyMVlZj6PbOSR0oqruQ== X-Forefront-PRVS: 0446F0FCE1 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR02MB1122; 23:0xBPI2MgMuHu7PP28NMUNUO6Ri1VfzOn5pbWHjjPh?= =?us-ascii?Q?WM7++zh2aHNlL9rcPSGyfKuSJTss2B535Lxmh9r3p9F2n8n/rXzx6ixTSsJF?= =?us-ascii?Q?gPF907G+4l/1Roi7bq5Lz/APT9yA/jWYWYyJ8mgVK83sagwSiIm+MjDQUhej?= =?us-ascii?Q?bc0aeLRLz7YIafcP0gazcXSmgj4eyR5S4AF8Z4y+YkZ6gIAoaa4X/sTRPKmW?= =?us-ascii?Q?tDvy0WZHGAvk2sK2jNh82+cTyLg3pt+rDi1fy7V7CmTvgqK4Cg7rs7lIWvql?= =?us-ascii?Q?0fFeZDHoNeC+wTwZs3xQ10L3iQTgCDiXAcOYTq2A/YWIgJ8ZbNO+g1O5vhC3?= =?us-ascii?Q?TASASVv9rW9cpZ4Tfc2QrdRNiNf7640lqDIHhfPCaFDKXgzyBy8H0FbfYi9b?= =?us-ascii?Q?pQ1Lj/lcLajBLHY260bq/Tu6mVvgkfLdDgaKhE9ke1dK9frVWivKimxy8d2f?= =?us-ascii?Q?eLGlcOxguvua9NpY8PucPyRSNDXeY6fPrc+wm/F0VRDOrgaEMIeayj0XuSXX?= =?us-ascii?Q?NFXidqjiiRSZaaZ4QLofpBI24/5M2MhwPh1lI3WsvcrTuuP9+mCt6PbDC4mm?= =?us-ascii?Q?5s5ZfZYewcFV+Lwgy9kGHFGJ+4W6D7oDS+FPcfJwoIhOlbVK5uPEtDVu/99h?= =?us-ascii?Q?vCeskWuucrfG/hiS7PUVQhikLP7/NkBQqVdIBKqTlEVpyhB8u0yAXWQGyr1g?= =?us-ascii?Q?Shjbp71tylfTaM3GELe8Mr0BUVGv5opOEDVdleFoX1JzKsXBGY6nD2uEuqRw?= =?us-ascii?Q?8mVjos5oJdklp/k8BGtTR4fH2VTh5UyPz0ab313E8FqAzK+zkgkBJ6NLB2C0?= =?us-ascii?Q?iOc9ktTF7NVBZzOqFdT0rX8ryjXvkuqseCVRxbaDg7EtGKspydStRWQau6Kn?= =?us-ascii?Q?UVCRbmFfSQvs0azE+0fCjsM8MYbjWbQVT3WBGby7EGMUt9wwywCONpXInzXp?= =?us-ascii?Q?Om42y1ujdpABFtCRH/PpFHPeuc3F5opdfT04NbhKhsYh7uZNeGwxHAPvCUKt?= =?us-ascii?Q?WeWQadYg5Ik3TABhcPhz0ygERZV7KhQJyvH/CiTRhbc3NGtvF5xNIoGDdA5r?= =?us-ascii?Q?GcHA2aTtV1GIrvKDJr9wsmMwXyG?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR02MB1122; 6:4/2PYwRlopoTwvrCOfR5NzsrJ1g5O9tL8xqS62gVtDqZSwifMA+kaekGcvOmy9WOX855MnrzLvrbYP6w/3IOMNIXmvTYdkh5RRN1OxvuguTsSlE5gAgDdQgeKx9ljGBy0iI7nIQS6XDXPSa1btUk4lPF5xSdfhF8CwA/AFdIS3KfLaxXR3UdZjBKtQrOueX0Zar6S4Mdq64MBbRej9EaOoFDr7ePO01VBndD/QxMwMOueVxuPKDE0LCi79vhgXAlOnWP7Hx7tmRezSZ7c9dl4LtjR4Z35fGLtyilDyDRlGEQV4a5LKzsY7iaq6C4lv9KW4MzqM5EaL0te+UOqrKRfg==; 5:2X/RKjmCUJOebI3a7RgdrxgRzv8P6WC2aPpY5w2qcY2UlYTgF2oAUpk3Edja1rJ27PAM7cYTG95POQV7wjeZvw7/LGU7baNc/2u5gTzQ1M/Le6R7Mcc70V/aSUdWTBBcalF8+Cl7IZIwJzdNtgPpOQuM9REFk0V+JnJkrRDgMqE=; 24:Hr2Hlo5D8+Cl2S3bH385ePp5mGzc6fOXjB9BjQVE4d/KDVXcpeRt/N6turl202E/kHsaUFlMjHrbzF4osn99cEzVfJPKSIXVuCFf9K45xN0=; 7:EWFSAhQyZA4eP2FiC96dTV2mkqW+SF7Cw37pbom2psVJeZ6yG090h3vhcb3rIYKk+K6WuLy/A+pyTm82rtCEnT4M/j9ooCeb29lWa5JrBfXx5PWbK6G47nuIs4Ra5t3e8V7j5JnWH3yP6P/eqdazwHWDbHwQnzmV5N3WeKy0v3zVyUxGSMeHOXk0KIA22VgxmRDTkSCZRR4RAX9clJbnwDS2B5eQqYVmaAD/05MvNzs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2017 00:19:46.6164 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR02MB1122 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.36.51 Subject: [Qemu-devel] [PATCH v2 16/47] hw/ide: Replace fprintf(stderr, "*\n" with error_report() X-BeenThere: qemu-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair23@gmail.com, armbru@redhat.com, qemu-block@nongnu.org, alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+importer=patchew.org@gnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_= report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_re= port("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report= ("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("= \1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1= "\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\= 2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2)= ;|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|= Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig= }' \ {} + find ./* -type f -exec sed -i \ 'N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}'= \ {} + find ./* -type f -exec sed -i \ 'N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + Some lines where then manually tweaked to pass checkpatch. Signed-off-by: Alistair Francis Cc: qemu-block@nongnu.org --- V2: - Split hw patch into individual directories hw/ide/ahci.c | 6 +++--- hw/ide/core.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index c25e293d88..2ed015285a 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -410,8 +410,8 @@ static void ahci_mem_write(void *opaque, hwaddr addr, =20 /* Only aligned reads are allowed on AHCI */ if (addr & 3) { - fprintf(stderr, "ahci: Mis-aligned write to addr 0x" - TARGET_FMT_plx "\n", addr); + error_report("ahci: Mis-aligned write to addr 0x" + TARGET_FMT_plx "", addr); return; } =20 @@ -1053,7 +1053,7 @@ static void process_ncq_command(AHCIState *s, int por= t, uint8_t *cmd_fis, g_assert(is_ncq(ncq_fis->command)); if (ncq_tfs->used) { /* error - already in use */ - fprintf(stderr, "%s: tag %d already used\n", __func__, tag); + error_report("%s: tag %d already used", __func__, tag); return; } =20 diff --git a/hw/ide/core.c b/hw/ide/core.c index 5f1cd3b91f..0ea34f62ba 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -2762,7 +2762,7 @@ static int ide_drive_pio_pre_save(void *opaque) =20 idx =3D transfer_end_table_idx(s->end_transfer_func); if (idx =3D=3D -1) { - fprintf(stderr, "%s: invalid end_transfer_func for DRQ_STAT\n", + error_report("%s: invalid end_transfer_func for DRQ_STAT", __func__); s->end_transfer_fn_idx =3D 2; } else { --=20 2.11.0