From nobody Mon Nov 10 14:25:01 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail header.i=@wdc.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=wdc.com ARC-Seal: i=1; a=rsa-sha256; t=1556667544; cv=none; d=zoho.com; s=zohoarc; b=msH8dWN50kMvurI1Owqg8UH01aunn5SAV4CX3lp32mylTzWiRa/RKxjVf3xScDTkzct4DcsdtWdTM3jhsruQLznM4vcfUcoDgTW+NJuQxp4GQGn/GnGZuK4I/OiOJ3UGRCTyZy0FGinkMZzuwI8pCi0k55aOkclq6/TViBmnkmg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556667544; h=Content-ID:Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=1SQQMt5THO5pV6WlYA8KAW7IDcB7IjPg+8ezER5gZSg=; b=n7YlUhNjeO7tUcgNPR9WUAWPg6woTf6TkF73e2Bys/peVPpgvRzSeMtHNqlbblvLiy78VDIoJJzbg+/u8IwQK6hd69ZTE7azV2HY3X/1gaVCBVFxcqTUL7eYKiP6wIVeSUnbZ0qL+zUKhwFnfjogcU8ElSeGoP7WD8kA7+2Xt+k= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail header.i=@wdc.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556667544337673.9881243040982; Tue, 30 Apr 2019 16:39:04 -0700 (PDT) Received: from localhost ([127.0.0.1]:55176 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLcKz-0003DS-8X for importer@patchew.org; Tue, 30 Apr 2019 19:39:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLcGK-0007aV-Q8 for qemu-devel@nongnu.org; Tue, 30 Apr 2019 19:34:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLcGJ-0000IX-QC for qemu-devel@nongnu.org; Tue, 30 Apr 2019 19:34:12 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:16222) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hLcB3-00064c-61; Tue, 30 Apr 2019 19:28:45 -0400 Received: from mail-bn3nam01lp2055.outbound.protection.outlook.com (HELO NAM01-BN3-obe.outbound.protection.outlook.com) ([104.47.33.55]) by ob1.hgst.iphmx.com with ESMTP; 01 May 2019 07:28:43 +0800 Received: from DM6PR04MB4908.namprd04.prod.outlook.com (20.176.109.81) by DM6PR04MB6217.namprd04.prod.outlook.com (20.178.224.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.10; Tue, 30 Apr 2019 23:28:41 +0000 Received: from DM6PR04MB4908.namprd04.prod.outlook.com ([fe80::9ba:6028:ae27:7d2]) by DM6PR04MB4908.namprd04.prod.outlook.com ([fe80::9ba:6028:ae27:7d2%2]) with mapi id 15.20.1835.015; Tue, 30 Apr 2019 23:28:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1556666926; x=1588202926; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=1SQQMt5THO5pV6WlYA8KAW7IDcB7IjPg+8ezER5gZSg=; b=doPq3HH2HCRsCkWVDrsbYQRtNI0ipiDk8NfKdgCDiTdiq3JBCcWbV6ty i0OrfXso6GYXZ6UcyHB/fyHBaKzJpMu/n1oD+wcVqpjFyFuMV9aeZxQrW G3HTdTsNf4d/o+kICa7IAFSgMt3MFiPbvbqZQwpcyhkXNh3y8Qji2UzUf fDcPyXzjvat3EV4cpwBOTmbAEKSFKO6NZbm5A/27kXEDcNea5S0hbEpvw k+avM4dxUqzAza7CJd+XulmUsVorinz0PUtaboO3BbRiHuFfk9KXr0wn+ RTubT60V0ptP6Q4Ck8yBEhqdYbKwOuupCVf/eST7W5n9CiZWyKCMEuPWJ A==; X-IronPort-AV: E=Sophos;i="5.60,415,1549900800"; d="scan'208";a="107219018" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1SQQMt5THO5pV6WlYA8KAW7IDcB7IjPg+8ezER5gZSg=; b=PCnnGVkgfsVVfLNJfgKomcYnO7NUh6/VLhITyuBjQADhsInhdC9QT7MJUpnoxQDifrD2gOXyLyu7X0qwiKoM2jHqG+NgKF7H8/zEsUlz/RB0Ny56IeZKKrZSD8/9nenXZYh6s4EuTY8W6t4y1r39TKE9WFotwuIhAkdLj4CQlTk= From: Alistair Francis To: "qemu-devel@nongnu.org" Thread-Topic: [PATCH v2 3/5] hw/usb/dev-mtp: Fix GCC 9 build warning Thread-Index: AQHU/6xy4BPLUqZ6DUSUqz4nuwVSww== Date: Tue, 30 Apr 2019 23:28:41 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.21.0 x-clientproxiedby: BYAPR07CA0013.namprd07.prod.outlook.com (2603:10b6:a02:bc::26) To DM6PR04MB4908.namprd04.prod.outlook.com (2603:10b6:5:19::17) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alistair.Francis@wdc.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [199.255.44.172] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eb962b1a-19e7-4f29-da9b-08d6cdc3947f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:DM6PR04MB6217; x-ms-traffictypediagnostic: DM6PR04MB6217: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:669; x-forefront-prvs: 00235A1EEF x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(39860400002)(136003)(346002)(376002)(396003)(199004)(189003)(5640700003)(8936002)(6436002)(53936002)(73956011)(316002)(54906003)(14454004)(81156014)(6486002)(6916009)(81166006)(68736007)(8676002)(186003)(26005)(3846002)(66446008)(6116002)(66476007)(64756008)(7736002)(6512007)(66946007)(305945005)(102836004)(2906002)(66556008)(5660300002)(386003)(446003)(6506007)(66066001)(44832011)(2501003)(2351001)(11346002)(50226002)(478600001)(36756003)(486006)(476003)(2616005)(76176011)(4326008)(52116002)(14444005)(99286004)(71190400001)(71200400001)(256004)(118296001)(72206003)(86362001)(25786009); DIR:OUT; SFP:1102; SCL:1; SRVR:DM6PR04MB6217; H:DM6PR04MB4908.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: q7I/epXAdgLWL5cSHcH231z0IYnTSy/YMBN88ZJYLYTTTuli7zv5Sd29xEQcNyj75XsIyChxJE4OV6LVVOEDGn5Wou7hLP2tqEcTmP4B0h4Fw7/sFUG+E7H4YSGqbHAqke7O9r4l3S/3MIEAsWbQflytnxzkr7FlPS45oN+l05SF6m3JlzyzELTeInSgzy8+pflzc3A3WWOHGi+WweSzCdb1A7M9ShxyZYioo+dousimFDQuHlTgkmJXzsyH5pxJJnzJG5QInSCiwuaIY9f96eT6qaQCrXVJs9b4EREPuh1TtsYBArsMhdTMM+o693n0rXtSQg86xWAr3GcWknnBeRM8A/iJdYiCuxnb1GQtn0R3fOK6hN3lKhLy4I96OH6JrR1wZvg/34m0KAicO7mkmwkUzTeaRGsGE6rbpOdVcew= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb962b1a-19e7-4f29-da9b-08d6cdc3947f X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2019 23:28:41.5489 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6217 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 216.71.154.42 Subject: [Qemu-devel] [PATCH v2 3/5] hw/usb/dev-mtp: Fix GCC 9 build warning X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "qemu-trivial@nongnu.org" , "riku.voipio@iki.fi" , "laurent@vivier.eu" , Alistair Francis , "kraxel@redhat.com" , "alistair23@gmail.com" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (found 2 invalid signatures) Fix this warning with GCC 9 on Fedora 30: hw/usb/dev-mtp.c:1715:36: error: taking address of packed member of =E2=80= =98struct =E2=80=99 may result in an unaligned pointer value [-W= error=3Daddress-of-packed-member] 1715 | dataset->filename); | ~~~~~~~^~~~~~~~~~ Signed-off-by: Alistair Francis --- hw/usb/dev-mtp.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 99548b012d..8233beacab 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -1711,9 +1711,22 @@ static void usb_mtp_write_metadata(MTPState *s, uint= 64_t dlen) assert(!s->write_pending); assert(p !=3D NULL); =20 +/* + * We are about to access a packed struct. We are confident that the point= er + * address won't be unaligned, so we ignore GCC warnings. + */ +#if defined(CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE) && QEMU_GNUC_PREREQ(9, 0) +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Waddress-of-packed-member" +#endif + filename =3D utf16_to_str(MIN(dataset->length, filename_chars), dataset->filename); =20 +#if defined(CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE) && QEMU_GNUC_PREREQ(9, 0) +#pragma GCC diagnostic pop +#endif + if (strchr(filename, '/')) { usb_mtp_queue_result(s, RES_PARAMETER_NOT_SUPPORTED, d->trans, 0, 0, 0, 0); --=20 2.21.0