From nobody Thu Nov 13 21:53:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582894014; cv=none; d=zohomail.com; s=zohoarc; b=DDEURbslS13gorBPSf3bvIpXhzQxRGmxdR2Ly0EHUf92ky1MhzTi+t1LsdXypLl2cSfpht0Y3KlEx2wFICoWl3VH4t3FjnfWeuF5F8bntswivPuz8j5GT8fY8QTwLOZ//pEEjI0535zMsQP07m5gW91dUJQd6XP3dBol++Am+Bs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582894014; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3pIhUqnxSTMPajmTRJpfkDS850N2DxKwC5hbVFY3rqk=; b=U2QzCrfKLDeTzbLk1d3T2/QPLTxWoGeJzViMJR0bWWYw6pyc+zVL3mRRmEhXJ1t7Dkz2axvyoeTHE/z/L7gO5ZPq0SByGRg4Mnm+taBuUwAMCAxpFxF1M4VCGi2pxpv6fzREwsbw+R5jYENXeUoeQWrVtpO1wYKoLoMtlQKPMXU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582894014930262.89368938577695; Fri, 28 Feb 2020 04:46:54 -0800 (PST) Received: from localhost ([::1]:46400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7f2b-0000Zt-KO for importer@patchew.org; Fri, 28 Feb 2020 07:46:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49069) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7f0x-0007Xm-7X for qemu-devel@nongnu.org; Fri, 28 Feb 2020 07:45:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7f0w-0008Un-6I for qemu-devel@nongnu.org; Fri, 28 Feb 2020 07:45:11 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:33605 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7f0w-0008Ug-2Y for qemu-devel@nongnu.org; Fri, 28 Feb 2020 07:45:10 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-76-896eUneIPheZSqaxtcV_3A-1; Fri, 28 Feb 2020 07:45:08 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 188AF1005512; Fri, 28 Feb 2020 12:45:07 +0000 (UTC) Received: from angien.redhat.com (unknown [10.43.2.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4645BCFDC; Fri, 28 Feb 2020 12:45:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582893909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3pIhUqnxSTMPajmTRJpfkDS850N2DxKwC5hbVFY3rqk=; b=OSMsf7V8KIk4TWe4OThumHIuol/fhR+z5+WRioIBew05vFA+iFuNhWnYgtn5MNgOp/cUXt bQKWHEyXwqU4z457owDSDn1CkGRozu9mFqbvDlM8KgRxNHeA/S7wjbsHw3P0v+o7dQTuRU ss8SBr6Q2661Hai74mxHIL0g1++y9JM= X-MC-Unique: 896eUneIPheZSqaxtcV_3A-1 From: Peter Krempa To: qemu-devel@nongnu.org Subject: [PATCH 1/2] block: Introduce 'bdrv_reopen_commit_post' step Date: Fri, 28 Feb 2020 13:44:46 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Krempa , John Snow , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Add another step in the reopen process where driver can execute code after permission changes are comitted. Signed-off-by: Peter Krempa --- block.c | 9 +++++++++ include/block/block_int.h | 1 + 2 files changed, 10 insertions(+) diff --git a/block.c b/block.c index 1bdb9c679d..a82e53d4cc 100644 --- a/block.c +++ b/block.c @@ -3694,6 +3694,15 @@ cleanup_perm: } } } + + if (ret =3D=3D 0) { + QTAILQ_FOREACH_REVERSE(bs_entry, bs_queue, entry) { + BlockDriverState *bs =3D bs_entry->state.bs; + + if (bs->drv->bdrv_reopen_commit_post) + bs->drv->bdrv_reopen_commit_post(&bs_entry->state); + } + } cleanup: QTAILQ_FOREACH_SAFE(bs_entry, bs_queue, entry, next) { if (ret) { diff --git a/include/block/block_int.h b/include/block/block_int.h index 6f9fd5e20e..f422c0bff0 100644 --- a/include/block/block_int.h +++ b/include/block/block_int.h @@ -122,6 +122,7 @@ struct BlockDriver { int (*bdrv_reopen_prepare)(BDRVReopenState *reopen_state, BlockReopenQueue *queue, Error **errp); void (*bdrv_reopen_commit)(BDRVReopenState *reopen_state); + void (*bdrv_reopen_commit_post)(BDRVReopenState *reopen_state); void (*bdrv_reopen_abort)(BDRVReopenState *reopen_state); void (*bdrv_join_options)(QDict *options, QDict *old_options); --=20 2.24.1