From nobody Mon Feb 9 16:21:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=crudebyte.com ARC-Seal: i=1; a=rsa-sha256; t=1666610150; cv=none; d=zohomail.com; s=zohoarc; b=EfVrEZU//mtOZWs040De2lSndhEfnp+mhKkmwBpd4Yv2UNmrGnWoaXPq96dyL0JFmclGRJ8lMC+6Q1/YGG9nmjXzkzs9HdGk3mihRLWLxPhpA3fo6Lh1p48jBnUJpVEb82gxnWCUwvxY9PNms/tOFZSQpYfO2SJKH8qkaauAftI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666610150; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=4v5VrMMNwy2ZaFxlnEyXkHc8E3xWz+kmzNWy7gqyTgY=; b=YEk7ldCet0oDgOSUTeQTwLobVeilPdeI6YJ8h171QTRVOguWPmBS7Rdj2PdjxGt8agZPtjE33wTlRQa8x81ylctY8UI371TOPqaa93Apix7kndUQ5NZOwHD0Zg70Qeu/7U8duG/yV30xmMoehdZh1laDCiVb8iOvHLuEiXaTDkE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1666610150263774.4416458140654; Mon, 24 Oct 2022 04:15:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1omvMy-0000pC-Jw; Mon, 24 Oct 2022 07:11:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omvMm-0000j5-5A for qemu-devel@nongnu.org; Mon, 24 Oct 2022 07:11:36 -0400 Received: from lizzy.crudebyte.com ([91.194.90.13]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omvMj-0007JI-Sl for qemu-devel@nongnu.org; Mon, 24 Oct 2022 07:11:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=crudebyte.com; s=lizzy; h=Cc:To:Subject:Date:From:References:In-Reply-To: Message-Id:Content-Type:Content-Transfer-Encoding:MIME-Version:Content-ID: Content-Description; bh=4v5VrMMNwy2ZaFxlnEyXkHc8E3xWz+kmzNWy7gqyTgY=; b=BhWfm RuyP6HbJ1kLFt4KHaEFkd7k+WNZ3rsLxlyYZd6x0NWLQBCBbcd2axXuBhZYeR+dF2txudHXoTJ05+ uKuo5j3IlfADCItRWrdoGhmsk20hBosSR2lozV0uynfT/qBg5lVuBrRzJrUzXzrBtyQ7XBZwqKwds FS1pX+iLDkG1MkCAMa5d+lskVKXlMBbY7HkZ3X4ZFQ5itSI70c+lc0AQpj+M4S/lsyvQg9pIt6Bi/ 9qKufxvsOH6oYrCPSGMA+gD+TQdLc3rpdqsvaYdNVIhCp2flQ69lrcxgzMR4XbGCATSxzCU+NaKnt CiyQIx9poswx2hon/4IcY7gP/34qA==; Message-Id: In-Reply-To: References: From: Christian Schoenebeck Date: Mon, 24 Oct 2022 12:54:23 +0200 Subject: [PULL 15/23] tests/9p: convert v9fs_twrite() to declarative arguments To: qemu-devel@nongnu.org, Stefan Hajnoczi Cc: Greg Kurz Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=91.194.90.13; envelope-from=ac9e4e6185f0f5090d18dce2dd3f60d9660be496@lizzy.crudebyte.com; helo=lizzy.crudebyte.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Qemu-devel" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @crudebyte.com) X-ZM-MESSAGEID: 1666610151410100001 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Use declarative function arguments for function v9fs_twrite(). Signed-off-by: Christian Schoenebeck Message-Id: --- tests/qtest/libqos/virtio-9p-client.c | 38 ++++++++++++++++++++------- tests/qtest/libqos/virtio-9p-client.h | 31 ++++++++++++++++++++-- tests/qtest/virtio-9p-test.c | 18 ++++++++++--- 3 files changed, 72 insertions(+), 15 deletions(-) diff --git a/tests/qtest/libqos/virtio-9p-client.c b/tests/qtest/libqos/vir= tio-9p-client.c index 15fde54d63..9ae347fad5 100644 --- a/tests/qtest/libqos/virtio-9p-client.c +++ b/tests/qtest/libqos/virtio-9p-client.c @@ -687,21 +687,39 @@ void v9fs_rlopen(P9Req *req, v9fs_qid *qid, uint32_t = *iounit) } =20 /* size[4] Twrite tag[2] fid[4] offset[8] count[4] data[count] */ -P9Req *v9fs_twrite(QVirtio9P *v9p, uint32_t fid, uint64_t offset, - uint32_t count, const void *data, uint16_t tag) +TWriteRes v9fs_twrite(TWriteOpt opt) { P9Req *req; + uint32_t err; uint32_t body_size =3D 4 + 8 + 4; + uint32_t written =3D 0; =20 - g_assert_cmpint(body_size, <=3D, UINT32_MAX - count); - body_size +=3D count; - req =3D v9fs_req_init(v9p, body_size, P9_TWRITE, tag); - v9fs_uint32_write(req, fid); - v9fs_uint64_write(req, offset); - v9fs_uint32_write(req, count); - v9fs_memwrite(req, data, count); + g_assert(opt.client); + + g_assert_cmpint(body_size, <=3D, UINT32_MAX - opt.count); + body_size +=3D opt.count; + req =3D v9fs_req_init(opt.client, body_size, P9_TWRITE, opt.tag); + v9fs_uint32_write(req, opt.fid); + v9fs_uint64_write(req, opt.offset); + v9fs_uint32_write(req, opt.count); + v9fs_memwrite(req, opt.data, opt.count); v9fs_req_send(req); - return req; + + if (!opt.requestOnly) { + v9fs_req_wait_for_reply(req, NULL); + if (opt.expectErr) { + v9fs_rlerror(req, &err); + g_assert_cmpint(err, =3D=3D, opt.expectErr); + } else { + v9fs_rwrite(req, &written); + } + req =3D NULL; /* request was freed */ + } + + return (TWriteRes) { + .req =3D req, + .count =3D written + }; } =20 /* size[4] Rwrite tag[2] count[4] */ diff --git a/tests/qtest/libqos/virtio-9p-client.h b/tests/qtest/libqos/vir= tio-9p-client.h index 3b70aef51e..dda371c054 100644 --- a/tests/qtest/libqos/virtio-9p-client.h +++ b/tests/qtest/libqos/virtio-9p-client.h @@ -239,6 +239,34 @@ typedef struct TLOpenRes { P9Req *req; } TLOpenRes; =20 +/* options for 'Twrite' 9p request */ +typedef struct TWriteOpt { + /* 9P client being used (mandatory) */ + QVirtio9P *client; + /* user supplied tag number being returned with response (optional) */ + uint16_t tag; + /* file ID of file to write to (required) */ + uint32_t fid; + /* start position of write from beginning of file (optional) */ + uint64_t offset; + /* how many bytes to write */ + uint32_t count; + /* data to be written */ + const void *data; + /* only send Twrite request but not wait for a reply? (optional) */ + bool requestOnly; + /* do we expect an Rlerror response, if yes which error code? (optiona= l) */ + uint32_t expectErr; +} TWriteOpt; + +/* result of 'Twrite' 9p request */ +typedef struct TWriteRes { + /* if requestOnly was set: request object for further processing */ + P9Req *req; + /* amount of bytes written */ + uint32_t count; +} TWriteRes; + void v9fs_set_allocator(QGuestAllocator *t_alloc); void v9fs_memwrite(P9Req *req, const void *addr, size_t len); void v9fs_memskip(P9Req *req, size_t len); @@ -274,8 +302,7 @@ void v9fs_rreaddir(P9Req *req, uint32_t *count, uint32_= t *nentries, void v9fs_free_dirents(struct V9fsDirent *e); TLOpenRes v9fs_tlopen(TLOpenOpt); void v9fs_rlopen(P9Req *req, v9fs_qid *qid, uint32_t *iounit); -P9Req *v9fs_twrite(QVirtio9P *v9p, uint32_t fid, uint64_t offset, - uint32_t count, const void *data, uint16_t tag); +TWriteRes v9fs_twrite(TWriteOpt); void v9fs_rwrite(P9Req *req, uint32_t *count); P9Req *v9fs_tflush(QVirtio9P *v9p, uint16_t oldtag, uint16_t tag); void v9fs_rflush(P9Req *req); diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p-test.c index 60a030b877..a5b9284acb 100644 --- a/tests/qtest/virtio-9p-test.c +++ b/tests/qtest/virtio-9p-test.c @@ -22,6 +22,7 @@ #define tgetattr(...) v9fs_tgetattr((TGetAttrOpt) __VA_ARGS__) #define treaddir(...) v9fs_treaddir((TReadDirOpt) __VA_ARGS__) #define tlopen(...) v9fs_tlopen((TLOpenOpt) __VA_ARGS__) +#define twrite(...) v9fs_twrite((TWriteOpt) __VA_ARGS__) =20 static void pci_config(void *obj, void *data, QGuestAllocator *t_alloc) { @@ -385,7 +386,10 @@ static void fs_write(void *obj, void *data, QGuestAllo= cator *t_alloc) =20 tlopen({ .client =3D v9p, .fid =3D 1, .flags =3D O_WRONLY }); =20 - req =3D v9fs_twrite(v9p, 1, 0, write_count, buf, 0); + req =3D twrite({ + .client =3D v9p, .fid =3D 1, .offset =3D 0, .count =3D write_count, + .data =3D buf, .requestOnly =3D true + }).req; v9fs_req_wait_for_reply(req, NULL); v9fs_rwrite(req, &count); g_assert_cmpint(count, =3D=3D, write_count); @@ -413,7 +417,11 @@ static void fs_flush_success(void *obj, void *data, QG= uestAllocator *t_alloc) * until the write request gets cancelled. */ should_block =3D 1; - req =3D v9fs_twrite(v9p, 1, 0, sizeof(should_block), &should_block, 0); + req =3D twrite({ + .client =3D v9p, .fid =3D 1, .offset =3D 0, + .count =3D sizeof(should_block), .data =3D &should_block, + .requestOnly =3D true + }).req; =20 flush_req =3D v9fs_tflush(v9p, req->tag, 1); =20 @@ -448,7 +456,11 @@ static void fs_flush_ignored(void *obj, void *data, QG= uestAllocator *t_alloc) * could be actually cancelled. */ should_block =3D 0; - req =3D v9fs_twrite(v9p, 1, 0, sizeof(should_block), &should_block, 0); + req =3D twrite({ + .client =3D v9p, .fid =3D 1, .offset =3D 0, + .count =3D sizeof(should_block), .data =3D &should_block, + .requestOnly =3D true + }).req; =20 flush_req =3D v9fs_tflush(v9p, req->tag, 1); =20 --=20 2.30.2