From nobody Tue Feb 10 04:15:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1566170393; cv=none; d=zoho.com; s=zohoarc; b=bqHfuSYIL22BEZQH0YxlOSx+AR6SzhJXwp3k57EkJcmswlAtsyaU1pri7OlSXkbhskF+iLsf/+IpDWzA2zaWWtsfxONrVqSIlE4Fol5CuNB73zWTz+F3GWVlvTuD0Rt0f/SMFzrt82gAudl838YZNgqPXMXsJow5El9GWh3a+hs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566170393; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=KkJvtrc3QrV2I7WYyibxflgUNfu3hfn3RhzurnFS0ws=; b=B4HFRDcGY4cTapsRdpHgg0fpACUYZ5Vi4TrWPDvomiqDDiPxia/PXkg0XdcbfXJCpDR0/MDl9xW6hjNGvfGtatxV+qo5LRYADsbbc1D2bmE+c9zTpgDkCs7djU7PIZUMrGCW5BY/5eb2C8+D2GFTYY1njcvg8iDOXvbOHirkVlA= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1566170393446327.1164415615856; Sun, 18 Aug 2019 16:19:53 -0700 (PDT) Received: from localhost ([::1]:43638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzUSj-0003K5-P4 for importer@patchew.org; Sun, 18 Aug 2019 19:19:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49757) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzUGV-0006YV-9E for qemu-devel@nongnu.org; Sun, 18 Aug 2019 19:07:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzUGU-0005KR-Bo for qemu-devel@nongnu.org; Sun, 18 Aug 2019 19:07:11 -0400 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:52756) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hzUGU-0005Jn-5m for qemu-devel@nongnu.org; Sun, 18 Aug 2019 19:07:10 -0400 Received: by mail-wm1-x344.google.com with SMTP id o4so9534wmh.2 for ; Sun, 18 Aug 2019 16:07:10 -0700 (PDT) Received: from nullptr.home.dirty-ice.org (2a01-036c-0113-49c9-0000-0000-0000-0005.pool6.digikabel.hu. [2a01:36c:113:49c9::5]) by smtp.gmail.com with ESMTPSA id c15sm33657152wrb.80.2019.08.18.16.07.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Aug 2019 16:07:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KkJvtrc3QrV2I7WYyibxflgUNfu3hfn3RhzurnFS0ws=; b=aWd9oHb04kGXvRv0eC4j08jUkl3cS6T1vdY8J0+fuwXtGChWBgkua53TJJZtE9EET0 gh6joL6CGg9zEq2ZROo0pb5F2TbVtgl9v9ndUaYqM4qwRcWvtfVCxgLXPYpyFTU3P2Qt j3LMuePYHOjMhl2rWn2s869qH2gETGonCJTTFiExGr7VMvFGVajYeRrwwZqQlrxy8V3Q jYZaNPUboYHW4p8J++4TUaNSUiiMbeXcuXFFmnR4f9r1IcmQGOQI0Bz+rL7ZRh9MiiVk 3i5vIp5AX7oYlTbbk3D0bvcaEwTSYML5U4HXesthFw3edCho652qQ75gtQLgoBGC0Z9J jUZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KkJvtrc3QrV2I7WYyibxflgUNfu3hfn3RhzurnFS0ws=; b=EpEF1/ZBH0Qf57C7KBdxN4nFivuoeDZcUGgNiTBH4iu6WRoCk4IDw1UJSN5LjS8I6+ NFE4jdL/k0NdL/EZ83d/vcHjExInl8uSRguLJHoHIw3upMCuEf/GLC//VDHwVNZWPiJ9 wcO7yEHAenrw54k5CWnV0dPdjWJlkts/WfwMMXgMFw6HCXs80Dt0ljn3sFG/l8Gk1XKW gPiziw/bJ3s162sfQ1n2D24E2BFx6D11uYzqRyY6HDndDYh3PpGuN3qOGdzxtkcJ4IlP RWIJu6W39iLVlAr1hmKorbijUVrL30z34rWs+7ILPcGuYScyr3kLszQGDLPoAKYL8JMo Z5sQ== X-Gm-Message-State: APjAAAV9e9s3HNW7nqMRf6n6d+yHDbCVYzM1PYBW29tuXf9GVbkWQbdL kCgDAVNYp6AU10NJfJB73Rhl+Wny X-Google-Smtp-Source: APXvYqzpAOWQga7jlikjWTMZupVMJGq5vHtRuRwHl/dpb+FzyxTO3WZEywT408LIKgX+Eoms4iP4Mw== X-Received: by 2002:a1c:200a:: with SMTP id g10mr16099005wmg.160.1566169629108; Sun, 18 Aug 2019 16:07:09 -0700 (PDT) From: "=?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?=" X-Google-Original-From: =?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?= To: qemu-devel@nongnu.org Date: Mon, 19 Aug 2019 01:06:56 +0200 Message-Id: X-Mailer: git-send-email 2.22.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 Subject: [Qemu-devel] [PATCH v4 11/14] paaudio: fix playback glitches X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Pulseaudio normally assumes that when the server wants it, the client can generate the audio samples and send it right away. Unfortunately this is not the case with QEMU -- it's up to the emulated system when does it generate the samples. Buffering the samples and sending them from a background thread is just a workaround, that doesn't work too well. Instead enable pa's compatibility support and let pa worry about the details. Signed-off-by: K=C5=91v=C3=A1g=C3=B3, Zolt=C3=A1n --- audio/paaudio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index f3864e1d50..c8ae1a6eca 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -512,10 +512,8 @@ static pa_stream *qpa_simple_new ( =20 flags =3D PA_STREAM_INTERPOLATE_TIMING -#ifdef PA_STREAM_ADJUST_LATENCY - | PA_STREAM_ADJUST_LATENCY -#endif - | PA_STREAM_AUTO_TIMING_UPDATE; + | PA_STREAM_AUTO_TIMING_UPDATE + | PA_STREAM_EARLY_REQUESTS; =20 if (dev) { /* don't move the stream if the user specified a sink/source */ --=20 2.22.0