From nobody Thu May 16 12:05:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; t=1559475907; cv=none; d=zoho.com; s=zohoarc; b=WDkRMgtMA4YMvUQZagzw3MEOk1V7BvJOnfl08LHj0dJsmeLdeUaY7DiseoGYqHgruIyUD8IZvQNcT3qAGUkG7bshS8Bee6jZWIuxPGIRwXnY/Pt0qnwAdFL3y+EjYFDfqV15REJ0IfFfPN1QRMAqh6l7IDGFu4hzNUlfXmnIH6I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559475907; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=LPRohFcCy2LgqGhFtiPJptAGDIRlCROEJgb3PGHTDPg=; b=WGCutkvyV4RZ3yeJEnq87pdvRcdGunroxiXrlCZBLyAoVGy9zOmoflKvNtBKNG4oHO0myJlZpjefAHd/JmbUJ1ul/vIblDjXsUMaAOxT+xjaV3AOhJlG/Mt+KRYprW3yCQM5W5oSEQ+IgaoazK3FkAQmjk7k7Zk0+lK1zHNhMDs= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1559475907859516.1920799382925; Sun, 2 Jun 2019 04:45:07 -0700 (PDT) Received: from localhost ([127.0.0.1]:47967 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hXOv3-0006AD-G9 for importer@patchew.org; Sun, 02 Jun 2019 07:44:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hXOt6-0004pJ-Ox for qemu-devel@nongnu.org; Sun, 02 Jun 2019 07:42:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hXOsW-00067M-9y for qemu-devel@nongnu.org; Sun, 02 Jun 2019 07:42:21 -0400 Received: from thoth.sbs.de ([192.35.17.2]:33127) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hXOsW-00063m-0X for qemu-devel@nongnu.org; Sun, 02 Jun 2019 07:42:20 -0400 Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id x52BgFlF027537 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 2 Jun 2019 13:42:16 +0200 Received: from [139.22.33.164] ([139.22.33.164]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x52BgD2t017469; Sun, 2 Jun 2019 13:42:13 +0200 X-Mozilla-News-Host: news://news.gmane.org:119 To: qemu-devel From: Jan Kiszka Message-ID: Date: Sun, 2 Jun 2019 13:42:13 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 192.35.17.2 Subject: [Qemu-devel] [PATCH] ioapic: kvm: Skip route updates for masked pins X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Peter Xu , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Jan Kiszka Masked entries will not generate interrupt messages, thus do no need to be routed by KVM. This is a cosmetic cleanup, just avoiding warnings of the kind qemu-system-x86_64: vtd_irte_get: detected non-present IRTE (index=3D0, hig= h=3D0xff00, low=3D0x100) if the masked entry happens to reference a non-present IRTE. Signed-off-by: Jan Kiszka Reviewed-by: Michael S. Tsirkin Reviewed-by: Peter Xu --- hw/intc/ioapic.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c index 7074489fdf..2fb288a22d 100644 --- a/hw/intc/ioapic.c +++ b/hw/intc/ioapic.c @@ -197,9 +197,11 @@ static void ioapic_update_kvm_routes(IOAPICCommonState= *s) MSIMessage msg; struct ioapic_entry_info info; ioapic_entry_parse(s->ioredtbl[i], &info); - msg.address =3D info.addr; - msg.data =3D info.data; - kvm_irqchip_update_msi_route(kvm_state, i, msg, NULL); + if (!info.masked) { + msg.address =3D info.addr; + msg.data =3D info.data; + kvm_irqchip_update_msi_route(kvm_state, i, msg, NULL); + } } kvm_irqchip_commit_routes(kvm_state); } --=20 2.16.4