From nobody Sun Apr 12 02:49:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1771770606; cv=none; d=zohomail.com; s=zohoarc; b=nyTjkbChPzUpYk6h8iHiJC+QqddCjQ0wHb+8QTShPLCB9Xlka/jOqh30lcbVD943lIAeYRgBt4YSnMUeGeRl4QMwpXXSCMfE9RTjAylF7mPNckxnBtB9HQYziuf2AMW9iOVwLA7NUCb3tn6MOa2keNdUvAdzVPZyB9e8dNv6uaY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771770606; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=shJs6+uDrl1OnFwGXeXwGM3eD68HLZ/4D3ywa0biSus=; b=CiOUUeiNZaczmn5/63DqgQv3/STIk4MJlsPAqKgwQnydapA1lWd52G0ZaaWsMZD35U1LUpOoOMfhzc0ITOV+buVPQfe/rc2MNtK0AomV87egnB7q4U4R6aIP1ldTNwozz1Pbt2lC8iraP3K/DUcOVy1QpLusqhHRty3m7+fKfbM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1771770606759310.53283556021256; Sun, 22 Feb 2026 06:30:06 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vuASk-00005k-M7; Sun, 22 Feb 2026 09:29:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vuASU-0008EJ-DD for qemu-devel@nongnu.org; Sun, 22 Feb 2026 09:29:19 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vuASS-0006ql-AD for qemu-devel@nongnu.org; Sun, 22 Feb 2026 09:29:17 -0500 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-680-85liheLGMoKVZiY0yWq5Tw-1; Sun, 22 Feb 2026 09:29:13 -0500 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4837907ec88so44656285e9.0 for ; Sun, 22 Feb 2026 06:29:13 -0800 (PST) Received: from redhat.com (IGLD-80-230-79-166.inter.net.il. [80.230.79.166]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970d54a73sm13140195f8f.37.2026.02.22.06.29.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Feb 2026 06:29:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771770555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=shJs6+uDrl1OnFwGXeXwGM3eD68HLZ/4D3ywa0biSus=; b=LPr7prZaagWd/dstOgdYxrbkxQ9iIt6WDjEcHfTPt3H350a65/vdCmvFXkFl/GUfy22Wmp OQL8g2mU08LpchE8zgjWGy2JF/d73WJ0Wqh1zIFvlxu08clQZBmVvbQCN9AdPpm1q2SD6D Tj0OFgHwlsw39q44lloJDQCcHo3G+1k= X-MC-Unique: 85liheLGMoKVZiY0yWq5Tw-1 X-Mimecast-MFC-AGG-ID: 85liheLGMoKVZiY0yWq5Tw_1771770553 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1771770552; x=1772375352; darn=nongnu.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=shJs6+uDrl1OnFwGXeXwGM3eD68HLZ/4D3ywa0biSus=; b=jDaDdapq+1V9tAAvHP3fnJqjWnYYHcbmQ3NofP3yWAS8WKG1hyojdT0hAOjTFuVovF yqXSiGUCUrIMdlVG7U0N7E+a7p+N/h/ez8SqJD6ZdXsSP4OKCkgL9cBA+qTtvnGDFlRL aZEH9f0E7pnhk6q5nBk5DhC4RPgI+tiUAATtY6S8VKaLBaWt+KQygBK8d5AJOfmMqlkS rmOu9sRznWfynWIezBB1FeDr3NcLA5NSkbObtmJqpbZdC4OpofSBOIxHnggYM4yaueez 6aALUzG62Ys9W2TnLrCKVkYYrFR+ct7KMZEo5bzazp8uiq/n8AjmfC2EYzMJQz+/TQ2U cHIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771770552; x=1772375352; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=shJs6+uDrl1OnFwGXeXwGM3eD68HLZ/4D3ywa0biSus=; b=TWr+gEV5TvkqobUp7PAqiXzqYyPQymSqE2AkvZEpwgWREELIT+t6afHwbOAG3mjU9e xI/kQFhsfUoOtHM7Hwsr0ra+XJl6onWQoENUd0zhFHbpJ4+gxMVyaPWgd0yqaT3bAfn+ 0u/pjXruccC52corWs/lHLDC1C/3wE5T31fvG2FSNGGUGO9iCNk9KtiGZw7wmfAFbtbU SAPcdWWY8IvbsIXipYx4dv97OqB83nKU/eJ/c1AIkb0U3X4ekA73+wS+DoNwc46mgEff KzpQgD0P33TUkHcBOex4TB82UCJ3x8OWXW84j4WsZ3aQeNLAHbDqyMXp1OaKXfWmQb2F Hzcg== X-Gm-Message-State: AOJu0YzjwConszmcknUaPvqbEYfNSf+Y1D4HnQDhizvu6WXa8j/P84f4 DtkownnTFQL+fdswvzc5ib5s7cOI9dYnDmCtsCCmSetX+b/so9EqXjZbvAwOxf3lEaRdFJQN6vz vHEBayqBNiJ5E4llqza4gaeqMPLgvLJI8OAazcyK+rY4NEEGssuMPZ9WjK+FwZG2/htrrcBTsgb JgB/8Hcn4m38X8341ra8pKSwRIyVGKVHzFLA== X-Gm-Gg: AZuq6aKDccNDh7+zKWmJu5Q0yYAXLX5a3xUQzQhbIcxJvG9d6Xhg6G7fofnsGPA6BqD 4RnM/api9drbrffq9ADfADgrIS5VP9yexbV/93jVGUqSBSoFFyrA6BC7wKwZ89uWJIJxP5IRk2a g78CxzXlQEjmFzFPzpJvuCD1eGCk0CJzQsew5gpkI8bYetExnNTRo8CxA9thFmuoA/hnkEUKP9d m5tjviftsdHKOHBrkO+pABWgtZOVNswNwt02Y+0Zozjyg68U6daB2c268xVEr8JofOEFJKXNDLf kBlar4mWpb2+TGwwm0sZgzF4SnSypHRLuw3315nXyQNJFEp3SfFTEIqQe3qlKinyQhTCWXFFXx+ t1CMeOUbEuEwgnn6VNBoeJZnbAjfqwYGVDIjzcnhLvUJtnw== X-Received: by 2002:a05:600c:4f8a:b0:480:1d0b:2d32 with SMTP id 5b1f17b1804b1-483a95beb5bmr103361425e9.12.1771770552413; Sun, 22 Feb 2026 06:29:12 -0800 (PST) X-Received: by 2002:a05:600c:4f8a:b0:480:1d0b:2d32 with SMTP id 5b1f17b1804b1-483a95beb5bmr103360835e9.12.1771770551794; Sun, 22 Feb 2026 06:29:11 -0800 (PST) Date: Sun, 22 Feb 2026 09:29:09 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Cc: Peter Maydell , Clement Mathieu--Drif , Zhenzhong Duan , Jason Wang , Yi Liu , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost Subject: [PULL 23/33] intel_iommu: Do not report recoverable faults to host Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.798, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.79, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1771770609231154100 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Clement Mathieu--Drif Signed-off-by: Clement Mathieu--Drif Reviewed-by: Zhenzhong Duan Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Message-Id: <20260208082252.288-1-clement.mathieu--drif@eviden.com> --- hw/i386/intel_iommu.c | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 92a367d657..4924aa4375 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -1857,6 +1857,21 @@ static const bool vtd_qualified_faults[] =3D { [VTD_FR_MAX] =3D false, }; =20 +static const bool vtd_recoverable_faults[] =3D { + [VTD_FR_WRITE] =3D true, + [VTD_FR_READ] =3D true, + [VTD_FR_PASID_DIR_ENTRY_P] =3D true, + [VTD_FR_PASID_ENTRY_P] =3D true, + [VTD_FR_FS_PAGING_ENTRY_INV] =3D true, + [VTD_FR_FS_PAGING_ENTRY_P] =3D true, + [VTD_FR_FS_PAGING_ENTRY_RSVD] =3D true, + [VTD_FR_PASID_ENTRY_FSPTPTR_INV] =3D true, + [VTD_FR_FS_NON_CANONICAL] =3D true, + [VTD_FR_FS_PAGING_ENTRY_US] =3D true, + [VTD_FR_SM_WRITE] =3D true, + [VTD_FR_MAX] =3D false, +}; + /* To see if a fault condition is "qualified", which is reported to softwa= re * only if the FPD field in the context-entry used to process the faulting * request is 0. @@ -1866,6 +1881,11 @@ static inline bool vtd_is_qualified_fault(VTDFaultRe= ason fault) return vtd_qualified_faults[fault]; } =20 +static inline bool vtd_is_recoverable_fault(VTDFaultReason fault, int iomm= u_idx) +{ + return iommu_idx =3D=3D VTD_IDX_ATS && vtd_recoverable_faults[fault]; +} + static inline bool vtd_is_interrupt_addr(hwaddr addr) { return VTD_INTERRUPT_ADDR_FIRST <=3D addr && addr <=3D VTD_INTERRUPT_A= DDR_LAST; @@ -2237,8 +2257,10 @@ static bool vtd_do_iommu_translate(VTDAddressSpace *= vtd_as, PCIBus *bus, } =20 if (ret_fr) { - vtd_report_fault(s, -ret_fr, is_fpd_set, source_id, - addr, is_write, pasid !=3D PCI_NO_PASID, pasid); + if (!vtd_is_recoverable_fault(-ret_fr, iommu_idx)) { + vtd_report_fault(s, -ret_fr, is_fpd_set, source_id, + addr, is_write, pasid !=3D PCI_NO_PASID, pasid= ); + } goto error; } =20 --=20 MST