From nobody Sat Nov 15 10:52:11 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1752532582; cv=none; d=zohomail.com; s=zohoarc; b=Haq0GGq2yir1lx/vhTVe/2nE5rIHU+hXfCdNIwR3IB2EyJ4GQZm0T9vAjjfir1Iw2pECI9SrtVyqG9Vlq9vJxoHlsf4pHkutvXI+VdT6pd9SskQGjP/FNkJZAVYb2bNP6tbduFyyfhcpWolPh3NOFyYG6F1mROR2T4kw1IdHb6k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752532582; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=6uSxElZbJWChayxu0fEwTPCqzfIl4gnOrF+O5vbwmp8=; b=Zb04zFr06QqC56S6bUd5JUi+ANCPAIbLdY03OzHy8Z7WzqPAiGSIpGW7/NTNzhrUJxKaCpWymZg9Qjh111PMcmIAlwVwda757uIoQ5r+fX/GtlfXm4ghtVwO1MyJkiZgMisT8Hks4p9H9dUdl198G3XNpBFomuw1arbBwJTjLW0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752532582246337.77306729433246; Mon, 14 Jul 2025 15:36:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ubRlw-0005Hb-IW; Mon, 14 Jul 2025 18:35:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ubRMb-0000y2-OW for qemu-devel@nongnu.org; Mon, 14 Jul 2025 18:09:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ubRMY-0000JS-Gr for qemu-devel@nongnu.org; Mon, 14 Jul 2025 18:09:33 -0400 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-451-FptxuxldMGSg5swGH0NJaA-1; Mon, 14 Jul 2025 18:09:27 -0400 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-455f79a2a16so25420485e9.2 for ; Mon, 14 Jul 2025 15:09:26 -0700 (PDT) Received: from redhat.com ([2a0d:6fc0:150d:fc00:de3:4725:47c6:6809]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-456111574adsm65899375e9.11.2025.07.14.15.09.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jul 2025 15:09:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752530968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6uSxElZbJWChayxu0fEwTPCqzfIl4gnOrF+O5vbwmp8=; b=culgOi/Vtjx1xcsSBKPHHqePDsx5fPAgjdUoSSWvSbJWyz6ViKIPm+QV+j8RHlY97Hn0R/ i6ITlTnIgydWgCIuMQOLjK2jSFztN/IHvBNxxib8snVlAuyWDbZdCmL8Id5UbYhbslt9zX U9UgcjYUztC/G2ClHulkMdA8el4P9DA= X-MC-Unique: FptxuxldMGSg5swGH0NJaA-1 X-Mimecast-MFC-AGG-ID: FptxuxldMGSg5swGH0NJaA_1752530966 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752530965; x=1753135765; h=content-transfer-encoding:content-disposition:mime-version :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6uSxElZbJWChayxu0fEwTPCqzfIl4gnOrF+O5vbwmp8=; b=BK+cTwXv9sNP8SnGKvzYA2jlDTrK0XaHeEKeuQUCwl6iJP8VO+/rU6UyIXq1LmQtWZ Jlrx3uBJVZtFL+zPxtK+s6EvJ08o6Wtx/AF8jP7jeFnlPYZ3cEHgbzv3Butaxzsc22NS eWOqzqcY00RsgAaxK3kiLw4ke7pau2wcp1bRWijjt97lP9TH362gdQR8ziOjaFzFkyr0 S+gsEP3Ilkl4bwXnYHIG7ewQ9PkPQOR2AsPrz7rWEsOwkM5BglESHfRPmbjlDJycGYNr HeqUkmkbhdYorAVyunly25WR8+oY6GMVwNjCqnwIKrsMJiSdligxUUwwU1eT6jc2RuOq 9RiQ== X-Gm-Message-State: AOJu0YxN07Nr4puw5U5FFfIGOZlMpYCf1mm46Ye70pV0vNBfKti9/Bpp FKcDJwP28dW1dB/KAIZIIhE9m3d+NZxxe+e9/IZt6Ky72+4D1P4RMCqBF4/yaguWehfJAluOLJR L6OEhGkfOh+LdQOHOcXvYkQ9TPFT2BocJ5+KrTBFjrZKbg1lL38Z2pZnSpQMZPTQ5C/8+E0FFLP PkWd93tZ9z1seJBE8WsoFYFGYnRQp/2PZgZw== X-Gm-Gg: ASbGnctkVEY2P0NqQdSFmeZ8tYJN6HTyvDXqLkoCfrP6S7wTWiW2m/MNFvBzwvNf+pJ WFDpbc9Io4kwUzTBbPtc9dogkAIbwpc8nxYnnYOEvbizwV5Pj6v5VPKsL4T8WuECf3bXAwsIoQt B/WBHPMkdmbAAc8/WnPIoEslOOYBCNQhpiWZPTvzbWWihGUv4SLr8dE2mZsm8MeHrTjqNucXqO9 oGT24ZtMzy987svgYhOsAUAeZuDnLLtZfHzr3tgF14m5aiB0pNf3/oCdfOKAjGMG1r1As/sxxHj FutnrmNPGZPVjqKlOeyarN3P2xBkqrd0 X-Received: by 2002:a05:600c:1c21:b0:456:eab:633e with SMTP id 5b1f17b1804b1-45627416ddfmr3029155e9.17.1752530965547; Mon, 14 Jul 2025 15:09:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHf4fUbqEuq7yOUTIGbCjHVThQbgZ5s7mi9Y2FZrPByntykGQVt8LYIvN9oBmCSjrdleYkXrw== X-Received: by 2002:a05:600c:1c21:b0:456:eab:633e with SMTP id 5b1f17b1804b1-45627416ddfmr3029025e9.17.1752530965065; Mon, 14 Jul 2025 15:09:25 -0700 (PDT) Date: Mon, 14 Jul 2025 18:09:23 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , qemu-rust@nongnu.org Subject: [PATCH] rust: bindings: allow any number of params Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1752532584274116600 We are going to be adding more parameters, and this makes rust unhappy: Functions with lots of parameters are considered bad style and reduce readability (=E2=80=9Cwhat does the 5th parameter mean?=E2=80=9D). Cons= ider grouping some parameters into a new type. Specifically: error: this function has too many arguments (8/7) --> /builds/mstredhat/qemu/build/rust/qemu-api/rust-qemu-api-tests.p/st= ructured/bindings.inc.rs:3840:5 | 3840 | / pub fn new_bitfield_1( 3841 | | secure: std::os::raw::c_uint, 3842 | | space: std::os::raw::c_uint, 3843 | | user: std::os::raw::c_uint, ... | 3848 | | address_type: std::os::raw::c_uint, 3849 | | ) -> __BindgenBitfieldUnit<[u8; 4usize]> { | |____________________________________________^ | =3D help: for further information visit https://rust-lang.github.io/ru= st-clippy/master/index.html#too_many_arguments =3D note: `-D clippy::too-many-arguments` implied by `-D warnings` =3D help: to override `-D warnings` add `#[allow(clippy::too_many_argu= ments)]` I didn't want to disable this globally, so I just shut it off for this file. Signed-off-by: Michael S. Tsirkin --- rust/qemu-api/src/bindings.rs | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/rust/qemu-api/src/bindings.rs b/rust/qemu-api/src/bindings.rs index 057de4b646..b4692f9b4b 100644 --- a/rust/qemu-api/src/bindings.rs +++ b/rust/qemu-api/src/bindings.rs @@ -18,11 +18,15 @@ =20 //! `bindgen`-generated declarations. =20 -#[cfg(MESON)] -include!("bindings.inc.rs"); +#[allow(clippy::too_many_arguments)] +mod gen { + #[cfg(MESON)] + include!("bindings.inc.rs"); =20 -#[cfg(not(MESON))] -include!(concat!(env!("OUT_DIR"), "/bindings.inc.rs")); + #[cfg(not(MESON))] + include!(concat!(env!("OUT_DIR"), "/bindings.inc.rs")); +} +pub use gen::*; =20 // SAFETY: these are implemented in C; the bindings need to assert that the // BQL is taken, either directly or via `BqlCell` and `BqlRefCell`. --=20 MST