From nobody Tue Dec 16 07:33:19 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1650875043; cv=none; d=zohomail.com; s=zohoarc; b=MexA4C6cfhDi4wfkDQAvvFVSuAKtxkQJ744RPCsKc/tPrLtOnAIGQe7vU5hL9OLGGV7BlBWwUM2IthQvIHbnUpMDnsHBItCo4h0YL6FS3Y+bOf/nAWCfPyGlWzea3PiPeeKEMtnB2BvZDKChL/0auiTG3KIpJV4sptia1FeHED4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1650875043; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/07G+KOnjwzPWs5gbVSF2lCzR4/Df0FQ6EC3Xytgne8=; b=PuSsaOZ0SvIVpjzP0rZhImG1hN2KlnKTVSmB2C/sCox3zFuRt+XqATo/VQAu36ojQKbkLIOaKhLJ//x9BlNu5b0BH474/IAKsHugpQmuCxLk1ElPVvI4Uv9ovb2iN+Mcuxavd+V6NE4+snkFesfKQJj64VYcKutkhyeYJah7uXk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1650875043066604.9947022839386; Mon, 25 Apr 2022 01:24:03 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-576-RTqDxIsMMxWtAs5HoiUgIg-1; Mon, 25 Apr 2022 04:22:23 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DB9C0833976; Mon, 25 Apr 2022 08:22:13 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id C608640D017A; Mon, 25 Apr 2022 08:22:13 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 36714194036D; Mon, 25 Apr 2022 08:22:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id B0CD41947BBE for ; Mon, 25 Apr 2022 08:22:10 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 90C032024CD0; Mon, 25 Apr 2022 08:22:10 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8C5972026609 for ; Mon, 25 Apr 2022 08:22:07 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3A31580352D for ; Mon, 25 Apr 2022 08:22:07 +0000 (UTC) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-300-2IwPohYBNgCLaT7iQd0Pdg-1; Mon, 25 Apr 2022 04:22:05 -0400 Received: by mail-wm1-f69.google.com with SMTP id k66-20020a1ca145000000b003928959f8efso5509975wme.1 for ; Mon, 25 Apr 2022 01:22:05 -0700 (PDT) Received: from wheatley.localdomain (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id az20-20020a05600c601400b0038ffb253bb3sm12904265wmb.36.2022.04.25.01.22.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 01:22:04 -0700 (PDT) Received: from wheatley.redhat.com (wheatley.k8r.cz [127.0.0.1]) by wheatley.localdomain (Postfix) with ESMTP id 31F3C67B1B5B; Mon, 25 Apr 2022 10:22:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650875041; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/07G+KOnjwzPWs5gbVSF2lCzR4/Df0FQ6EC3Xytgne8=; b=OqiPVIDUwOM4fSllA2+df3RtlP7P04ZjTsWgnus7gnGpB+6kK8ZgQJ6KTs0IGRS2y6SQ/M x/PpPxvGVshZZp5Kfqi4bF0T+jiHbhhANZLBMYqOxki0hcsG2KW07v7ex4/wq0dHZ8HAES LQQIU+35rAY7kIvZwiV2AY5Sx8BB9A0= X-MC-Unique: RTqDxIsMMxWtAs5HoiUgIg-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: 2IwPohYBNgCLaT7iQd0Pdg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/07G+KOnjwzPWs5gbVSF2lCzR4/Df0FQ6EC3Xytgne8=; b=pFNhE7u14LvNG31ekcx1272mFJi6NgxnOFPb9MJuLNWn+4ymFfnJiLboWJCT4xx7O9 VQ3LFnmKdyMDsH/EpfJb3jS4ITdv2DFYhoN5JzJ3TVeN4rJIyLLPN5+V41le2pfGs17n ZP2FIdnDyTS8Y/jHwGcyKzIVNwI3SaswlHvkTLl14tnR8LJQPrGfZdweLk+VXXflaLjM DpSK4KITLitJTvOx9BtqgeqR+ZHX7w6ICfyxvgatevPJu4qfHrqKGB/4tZUQ/xfcINii JEHYYfl8ag9UgeuFIme6qZ02ap/Kx/t3AyOOus6e+k8zZeJK/IKc0FnJc9WQ0KuUpM5u 7d9Q== X-Gm-Message-State: AOAM530EYlP2x2Xly+x/BSfQLwAqtLj9AMtjemkhYnAmOzJ3if8/ZygF 6kq4/PuxKPlIVRJKzA05VvEBZAPIDnW5H1vbVy4C95DstgW1IMlkgA2cCWCGVbfPbV8p3KRR5so 8qzBg/Nme0O07ztg/4lQ= X-Received: by 2002:a05:600c:3b97:b0:393:ea66:77ef with SMTP id n23-20020a05600c3b9700b00393ea6677efmr5295103wms.120.1650874924774; Mon, 25 Apr 2022 01:22:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwVF3dK0i9vOzAY/PYvnp5i5lQER5yvkUNth9GcfEFLwk+oH+Lrsa2v9IyXQkqINxFUFcY9g== X-Received: by 2002:a05:600c:3b97:b0:393:ea66:77ef with SMTP id n23-20020a05600c3b9700b00393ea6677efmr5295078wms.120.1650874924601; Mon, 25 Apr 2022 01:22:04 -0700 (PDT) From: Martin Kletzander To: qemu-devel@nongnu.org Subject: [PATCH 06/18] ui/vnc: Require audiodev= Date: Mon, 25 Apr 2022 10:21:49 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Stefan Hajnoczi , libvir-list@redhat.com, Christian Schoenebeck , Yanan Wang , Gerd Hoffmann , "Edgar E. Iglesias" , Qiuhao Li , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Marcel Apfelbaum , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Laurent Vivier , Thomas Huth , Alistair Francis , Alexander Bulekov , Bandan Das , qemu-arm@nongnu.org, Jan Kiszka , Pavel Dovgalyuk , Eduardo Habkost , Darren Kenny , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1650875044894100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Signed-off-by: Martin Kletzander --- ui/vnc.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index badf1d7664fe..2e7af139b030 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -4188,12 +4188,15 @@ void vnc_display_open(const char *id, Error **errp) vd->ledstate =3D 0; =20 audiodev =3D qemu_opt_get(opts, "audiodev"); - if (audiodev) { - vd->audio_state =3D audio_state_by_name(audiodev); - if (!vd->audio_state) { - error_setg(errp, "Audiodev '%s' not found", audiodev); - goto fail; - } + if (!audiodev) { + error_setg(errp, "Audiodev parameter for vnc required"); + goto fail; + } + + vd->audio_state =3D audio_state_by_name(audiodev); + if (!vd->audio_state) { + error_setg(errp, "Audiodev '%s' not found", audiodev); + goto fail; } =20 device_id =3D qemu_opt_get(opts, "display"); --=20 2.35.1